[PR] Move Jens Scheffler to committer role [airflow]

2023-11-07 Thread via GitHub
jscheffl opened a new pull request, #35522: URL: https://github.com/apache/airflow/pull/35522 This PR adds the meta data for jscheffl as new committer tu use the self-hosted runners as well makes a small nit on documentation update. -- This is an automated message from the Apache Git

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-07 Thread via GitHub
utkarsharma2 commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1801212593 @Eric-Mendes We already have a provider for Apprise, and Apprise support sending notifications to Opsgenie --

(airflow) branch main updated: Use None instead of empty data structures when no ElasticSearch logs (#34793)

2023-11-07 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b3be18b36f Use None instead of empty data

Re: [PR] Use None instead of empty data structures when no ElasticSearch logs [airflow]

2023-11-07 Thread via GitHub
eladkal merged PR #34793: URL: https://github.com/apache/airflow/pull/34793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Pass extra configs to `ClientSecretCredential` and `SparkClient` in `AzureSynapseHook` [airflow]

2023-11-07 Thread via GitHub
eladkal commented on PR #35024: URL: https://github.com/apache/airflow/pull/35024#issuecomment-1801174944 Needs rebase and reaolve conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Add Pankaj Koti to the list of committers in project.rst [airflow]

2023-11-07 Thread via GitHub
pankajkoti opened a new pull request, #35521: URL: https://github.com/apache/airflow/pull/35521 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Remove explicit annotaion for Mypy to infer type [airflow]

2023-11-07 Thread via GitHub
eladkal commented on PR #32670: URL: https://github.com/apache/airflow/pull/32670#issuecomment-1801171330 @uranusjr needs another rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Airflow Triggerer facing frequent restarts [airflow]

2023-11-07 Thread via GitHub
shubhransh-eb commented on issue #33647: URL: https://github.com/apache/airflow/issues/33647#issuecomment-1801095909 Hello, Just wanted to know if we have any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] enhance druid connection parameters [airflow]

2023-11-07 Thread via GitHub
eladkal commented on code in PR #35244: URL: https://github.com/apache/airflow/pull/35244#discussion_r1385975088 ## airflow/providers/apache/druid/hooks/druid.py: ## @@ -163,8 +167,8 @@ class DruidDbApiHook(DbApiHook): conn_name_attr = "druid_broker_conn_id"

Re: [PR] Avoid too many conflicts when generating breeze images [airflow]

2023-11-07 Thread via GitHub
amoghrajesh commented on PR #35508: URL: https://github.com/apache/airflow/pull/35508#issuecomment-1801059852 Really good! Very relatable issue with a nice elegant fix :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Adding amoghrajesh as committer [airflow]

2023-11-07 Thread via GitHub
amoghrajesh opened a new pull request, #35520: URL: https://github.com/apache/airflow/pull/35520 As part of new committer onboarding, adding amoghrajesh as a committer in project.rst --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Allow override of navbar text color [airflow]

2023-11-07 Thread via GitHub
jedcunningham merged PR #35505: URL: https://github.com/apache/airflow/pull/35505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Allow override of navbar text color (#35505)

2023-11-07 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9990f87bc1 Allow override of navbar text

Re: [PR] Allow override of navbar text color [airflow]

2023-11-07 Thread via GitHub
vchiapaikeo commented on code in PR #35505: URL: https://github.com/apache/airflow/pull/35505#discussion_r1385854222 ## airflow/www/templates/appbuilder/navbar.html: ## @@ -21,6 +21,13 @@ {% set languages = appbuilder.languages %} + {% if navbar_text_color %} Review

Re: [PR] Allow override of navbar text color [airflow]

2023-11-07 Thread via GitHub
jedcunningham commented on code in PR #35505: URL: https://github.com/apache/airflow/pull/35505#discussion_r1385837798 ## airflow/www/templates/appbuilder/navbar.html: ## @@ -21,6 +21,13 @@ {% set languages = appbuilder.languages %} + {% if navbar_text_color %} Review

Re: [PR] Make raw HTML descriptions configurable [airflow]

2023-11-07 Thread via GitHub
jedcunningham commented on code in PR #35460: URL: https://github.com/apache/airflow/pull/35460#discussion_r1385810730 ## docs/apache-airflow/core-concepts/params.rst: ## @@ -324,9 +325,18 @@ For examples also please take a look to two example DAGs provided: ``example_par ..

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-07 Thread via GitHub
Eric-Mendes commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1800816758 And how do I run it, @Taragolis? Sorry if it's a dumb question, I'm sort of new at this. I've been trying to do `pytest test_opsgenie.py` and been getting ```bash

Re: [PR] Add custom metadata to Tasks in Graph View [airflow]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #32133: URL: https://github.com/apache/airflow/pull/32133#issuecomment-1800649709 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [PR] Reduce round trips to db when evaluating setup tasks [airflow]

2023-11-07 Thread via GitHub
github-actions[bot] commented on PR #34578: URL: https://github.com/apache/airflow/pull/34578#issuecomment-1800648729 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

(airflow) branch constraints-main updated: Updating constraints. Github run id:6790733276

2023-11-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new f022c958b4 Updating

Re: [PR] Improve error handling in AWS Links [airflow]

2023-11-07 Thread via GitHub
Taragolis commented on code in PR #35518: URL: https://github.com/apache/airflow/pull/35518#discussion_r1385723729 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -209,6 +225,16 @@ def test_empty_xcom(self): deserialized_task.get_extra_links(ti,

Re: [PR] Improve error handling in AWS Links [airflow]

2023-11-07 Thread via GitHub
o-nikolas commented on code in PR #35518: URL: https://github.com/apache/airflow/pull/35518#discussion_r1385721527 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -209,6 +225,16 @@ def test_empty_xcom(self): deserialized_task.get_extra_links(ti,

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-07 Thread via GitHub
Taragolis commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1800347007 Me personal approach would be: 1. Copy test from one of the existed notifier 2. Make changes: e.g. some other mocks required, but I assume that mocks would be almost the

Re: [PR] Add Jira Notifier implementation [airflow]

2023-11-07 Thread via GitHub
Taragolis commented on code in PR #35397: URL: https://github.com/apache/airflow/pull/35397#discussion_r1385706929 ## docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst: ## @@ -0,0 +1,65 @@ + + .. Licensed to the Apache Software Foundation

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-07 Thread via GitHub
Eric-Mendes commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1800312462 @Taragolis I have the PR ready, I'm just struggling to write tests and test it. Do you have any tips? -- This is an automated message from the Apache Git Service. To respond

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-07 Thread via GitHub
Taragolis commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1800302578 @Eric-Mendes I've assigned this to you, since you marked that you will want to submit a PR. If you don't wan't to work on this issue, just let me know. -- This is an automated

[PR] Improve error handling in AWS Links [airflow]

2023-11-07 Thread via GitHub
Taragolis opened a new pull request, #35518: URL: https://github.com/apache/airflow/pull/35518 Follow-up: #35484 Do not fail on call `BaseAwsLink.get_link` and `BaseAwsLink.persist ` methods, if something going wrong then it won't affect Operators/Sensors execution

(airflow) branch main updated (71e0e6e76b -> 637ec90dfc)

2023-11-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 71e0e6e76b Helm chart should set AIRFLOW_HOME from airflowHome (#34839) add 637ec90dfc Remove outdated parts from

Re: [PR] Remove outdated parts from docker-compose sample [airflow]

2023-11-07 Thread via GitHub
potiuk merged PR #35513: URL: https://github.com/apache/airflow/pull/35513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Create an `OpsgenieNotifier` [airflow]

2023-11-07 Thread via GitHub
boring-cyborg[bot] commented on issue #35516: URL: https://github.com/apache/airflow/issues/35516#issuecomment-1800233380 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[I] Create an `OpsgenieNotifier` [airflow]

2023-11-07 Thread via GitHub
Eric-Mendes opened a new issue, #35516: URL: https://github.com/apache/airflow/issues/35516 ### Description Create a notifier for provider opsgenie. It should be the same as `OpsgenieCreateAlertOperator`. ### Use case/motivation Given that now notifiers exist I believe

Re: [I] Numeric values in DAG details are incorrectly rendered as timestamps [airflow]

2023-11-07 Thread via GitHub
ivan-afonichkin commented on issue #35500: URL: https://github.com/apache/airflow/issues/35500#issuecomment-1800197989 @Taragolis could you please assign this one to me? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Long custom operator name overflows in graph view [airflow]

2023-11-07 Thread via GitHub
ivan-afonichkin commented on PR #35382: URL: https://github.com/apache/airflow/pull/35382#issuecomment-1800192491 @potiuk or @bbovenzi just a ping here, please take a look whenever you have time, thanks! -- This is an automated message from the Apache Git Service. To respond to the

[PR] Remove FAB related auth methods from security manager to auth manager [airflow]

2023-11-07 Thread via GitHub
vincbeck opened a new pull request, #35515: URL: https://github.com/apache/airflow/pull/35515 Move all FAB related methods/properties from `airflow.www.security_manager.AirflowSecurityManagerV2` to `airflow.auth.managers.fab.security_manager.override.FabAirflowSecurityManagerOverride`.

Re: [PR] Avoid too many conflicts when generating breeze images [airflow]

2023-11-07 Thread via GitHub
utkarsharma2 commented on PR #35508: URL: https://github.com/apache/airflow/pull/35508#issuecomment-1800135885 This is nice and much required change. :) In our recent attempt to add an LLM provider, we had to get the PRs merged sequentially which was very time-consuming. Going forward

(airflow) branch main updated: Helm chart should set AIRFLOW_HOME from airflowHome (#34839)

2023-11-07 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 71e0e6e76b Helm chart should set AIRFLOW_HOME

Re: [PR] Helm chart should set AIRFLOW_HOME from airflowHome [airflow]

2023-11-07 Thread via GitHub
dstandish merged PR #34839: URL: https://github.com/apache/airflow/pull/34839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on PR #34840: URL: https://github.com/apache/airflow/pull/34840#issuecomment-1800116172 > I think you still need to fix [Static Checks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#static-code-checks), most of them fixed by run `pre-commit`

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385583643 ## docs/apache-airflow-providers-papermill/connections/jupyter_kernel.rst: ## @@ -0,0 +1,78 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

(airflow) branch main updated: Update ECS executor healthcheck with a catchall except (#35512)

2023-11-07 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b67a4f78e5 Update ECS executor healthcheck with

Re: [PR] Update ECS executor healthcheck with a catchall except [airflow]

2023-11-07 Thread via GitHub
o-nikolas merged PR #35512: URL: https://github.com/apache/airflow/pull/35512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] execution_timeout not enforced, task hangs up [airflow]

2023-11-07 Thread via GitHub
potiuk commented on issue #35474: URL: https://github.com/apache/airflow/issues/35474#issuecomment-1800106090 This is ilikely something we cannot do anything about you need to raise it to Kafka developers. The problem is that if you have C library that hangs and does not periodically check

Re: [PR] Implement login and logout in AWS auth manager [airflow]

2023-11-07 Thread via GitHub
vincbeck commented on PR #35488: URL: https://github.com/apache/airflow/pull/35488#issuecomment-1800022626 [Providers Airflow 2.5 compatibility check](https://github.com/apache/airflow/actions/runs/6788678339/job/18455385993?pr=35488#logs) is failing because some of the features (e.g.

(airflow) branch main updated: Update new contributors Slack channel address (#35514)

2023-11-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 26969b280e Update new contributors Slack channel

Re: [PR] Update new contributors Slack channel address [airflow]

2023-11-07 Thread via GitHub
boring-cyborg[bot] commented on PR #35514: URL: https://github.com/apache/airflow/pull/35514#issuecomment-1799988094 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Update new contributors Slack channel address [airflow]

2023-11-07 Thread via GitHub
potiuk merged PR #35514: URL: https://github.com/apache/airflow/pull/35514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Avoid too many conflicts when generating breeze images [airflow]

2023-11-07 Thread via GitHub
potiuk commented on PR #35508: URL: https://github.com/apache/airflow/pull/35508#issuecomment-1799984172 Should be ready :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(airflow) branch main updated: Refresh dependencies for Breeze to latest ones (#35510)

2023-11-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8895a8a728 Refresh dependencies for Breeze to

Re: [PR] Refresh dependencies for Breeze to latest ones [airflow]

2023-11-07 Thread via GitHub
potiuk merged PR #35510: URL: https://github.com/apache/airflow/pull/35510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Allow override of navbar text color [airflow]

2023-11-07 Thread via GitHub
kaxil commented on code in PR #35505: URL: https://github.com/apache/airflow/pull/35505#discussion_r1385517230 ## airflow/config_templates/config.yml: ## @@ -1614,6 +1614,13 @@ webserver: type: string example: ~ default: "#fff" +navbar_text_color: +

Re: [PR] Update new contributors Slack channel address [airflow]

2023-11-07 Thread via GitHub
boring-cyborg[bot] commented on PR #35514: URL: https://github.com/apache/airflow/pull/35514#issuecomment-1799904675 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Update new contributors Slack channel address [airflow]

2023-11-07 Thread via GitHub
sgromme opened a new pull request, #35514: URL: https://github.com/apache/airflow/pull/35514 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Infinite UI redirection loop after deactivating an active user [airflow]

2023-11-07 Thread via GitHub
potiuk merged PR #35486: URL: https://github.com/apache/airflow/pull/35486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (3fbd9d6b18 -> e512a72c33)

2023-11-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 3fbd9d6b18 Add missing examples into Slack Provider (#35495) add e512a72c33 Infinite UI redirection loop after

Re: [I] Infinite UI redirection loop when user is changed to "inactive" while having a session opened [airflow]

2023-11-07 Thread via GitHub
potiuk closed issue #35335: Infinite UI redirection loop when user is changed to "inactive" while having a session opened URL: https://github.com/apache/airflow/issues/35335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Remove outdated parts from docker-compose sample [airflow]

2023-11-07 Thread via GitHub
Taragolis commented on code in PR #35513: URL: https://github.com/apache/airflow/pull/35513#discussion_r1385481430 ## docs/apache-airflow/howto/docker-compose/docker-compose.yaml: ## @@ -189,20 +187,6 @@ services: command: - -c - | -function ver() { -

[PR] Remove outdated parts from docker-compose sample [airflow]

2023-11-07 Thread via GitHub
Taragolis opened a new pull request, #35513: URL: https://github.com/apache/airflow/pull/35513 Some of the parameter in docker-compose will work only in Airflow 2.7+ So that is a time to remove parts related to Airflow < 2.3 . --- **^ Add meaningful

Re: [PR] Add missing examples into Slack Provider [airflow]

2023-11-07 Thread via GitHub
hussein-awala merged PR #35495: URL: https://github.com/apache/airflow/pull/35495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Commit failed: Local: No offset stored while using AwaitMessageTriggerFunctionSensor [airflow]

2023-11-07 Thread via GitHub
ikholodkov commented on issue #32585: URL: https://github.com/apache/airflow/issues/32585#issuecomment-1799797237 Airflow 2.7.2, apache-airflow-providers-apache-kafka==1.2.0. Unfortunately the problem is still relevant. -- This is an automated message from the Apache Git Service. To

(airflow) branch main updated (653ff1c5ff -> 3fbd9d6b18)

2023-11-07 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 653ff1c5ff Increase timeout for flaky Test_BranchPythonDecoratedOperator test (#35511) add 3fbd9d6b18 Add

Re: [PR] Add support for catchup="ignore_first" to disable catchup for the first DagRun [airflow]

2023-11-07 Thread via GitHub
dstandish commented on PR #35392: URL: https://github.com/apache/airflow/pull/35392#issuecomment-1799797170 @hussein-awala can you explain what `ignore_first` means, perhaps with some examples? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
Taragolis commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385465404 ## docs/apache-airflow-providers-papermill/connections/jupyter_kernel.rst: ## @@ -0,0 +1,78 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Add support for catchup="ignore_first" to disable catchup for the first DagRun [airflow]

2023-11-07 Thread via GitHub
hussein-awala commented on code in PR #35392: URL: https://github.com/apache/airflow/pull/35392#discussion_r1385448769 ## airflow/api_connexion/openapi/v1.yaml: ## @@ -3579,7 +3579,7 @@ components: timezone: $ref: '#/components/schemas/Timezone'

[PR] Update ECS executor healthcheck with a catchall except [airflow]

2023-11-07 Thread via GitHub
o-nikolas opened a new pull request, #35512: URL: https://github.com/apache/airflow/pull/35512 Previously only ClientError was being caught. However, there are cases where Botocore (or perhaps other) exceptions can be thrown. Add a catchall except Exception to catch these cases.

Re: [PR] Add system test Dashboard link for LLM providers [airflow-site]

2023-11-07 Thread via GitHub
potiuk commented on PR #890: URL: https://github.com/apache/airflow-site/pull/890#issuecomment-1799627592 Indeed ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add system test Dashboard link for LLM providers [airflow-site]

2023-11-07 Thread via GitHub
o-nikolas commented on PR #890: URL: https://github.com/apache/airflow-site/pull/890#issuecomment-1799607181 This is awesome to see, great work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Allow override of navbar text color [airflow]

2023-11-07 Thread via GitHub
vchiapaikeo commented on PR #35505: URL: https://github.com/apache/airflow/pull/35505#issuecomment-1799591674 Hmm I think [these tests](https://github.com/apache/airflow/actions/runs/6788890669/job/18455004294?pr=35505) are failing due to OOM? Doesn't seem like it's due to the code change

Re: [PR] Avoid too many conflicts when generating breeze images [airflow]

2023-11-07 Thread via GitHub
potiuk commented on PR #35508: URL: https://github.com/apache/airflow/pull/35508#issuecomment-1799535806 OK. Needed to also sort the parameters (otherwise their sequence was depending on the sequence of filed checked out by git :exploding_head: -- This is an automated message from the

(airflow) branch main updated: Increase timeout for flaky Test_BranchPythonDecoratedOperator test (#35511)

2023-11-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 653ff1c5ff Increase timeout for flaky

Re: [PR] Refresh dependencies for Breeze to latest ones [airflow]

2023-11-07 Thread via GitHub
potiuk commented on PR #35510: URL: https://github.com/apache/airflow/pull/35510#issuecomment-1799527483 > oups: > > !? /opt/airflow/=1.2.1 Good tests, nice tests :) ... -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Increase timeout for flaky Test_BranchPythonDecoratedOperator test [airflow]

2023-11-07 Thread via GitHub
potiuk merged PR #35511: URL: https://github.com/apache/airflow/pull/35511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Remove tenacity on KPO logs inner func consume_logs [airflow]

2023-11-07 Thread via GitHub
dstandish merged PR #35504: URL: https://github.com/apache/airflow/pull/35504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Remove tenancity on KPO logs inner func consume_logs (#35504)

2023-11-07 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d6c79ce340 Remove tenancity on KPO logs inner

Re: [PR] Refresh dependencies for Breeze to latest ones [airflow]

2023-11-07 Thread via GitHub
potiuk commented on PR #35510: URL: https://github.com/apache/airflow/pull/35510#issuecomment-1799522949 oups: !? /opt/airflow/=1.2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(airflow) branch main updated: Simplify KPO multi container log reconciliation logic (#35450)

2023-11-07 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 68b3b7b468 Simplify KPO multi container log

Re: [PR] Simplify KPO multi container log reconciliation logic [airflow]

2023-11-07 Thread via GitHub
dstandish merged PR #35450: URL: https://github.com/apache/airflow/pull/35450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on PR #34840: URL: https://github.com/apache/airflow/pull/34840#issuecomment-1799399454 @Taragolis Thanks for your comments and suggestions. I have updated by PR to address your feedback. Please take a look. -- This is an automated message from the Apache Git

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385350060 ## airflow/providers/papermill/operators/papermill.py: ## @@ -17,17 +17,102 @@ # under the License. from __future__ import annotations +from functools

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385350796 ## airflow/providers/papermill/operators/papermill.py: ## @@ -17,17 +17,102 @@ # under the License. from __future__ import annotations +from functools

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385350302 ## airflow/providers/papermill/operators/papermill.py: ## @@ -17,17 +17,102 @@ # under the License. from __future__ import annotations +from functools

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385348078 ## airflow/providers/papermill/hooks/kernel.py: ## @@ -0,0 +1,48 @@ +from airflow.hooks.base import BaseHook + +JUPYTER_KERNEL_SHELL_PORT = 60316

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385347383 ## airflow/providers/papermill/hooks/kernel.py: ## @@ -0,0 +1,48 @@ +from airflow.hooks.base import BaseHook + +JUPYTER_KERNEL_SHELL_PORT = 60316

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385347118 ## airflow/providers/papermill/operators/papermill.py: ## @@ -17,17 +17,102 @@ # under the License. from __future__ import annotations +from functools

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385345845 ## airflow/providers/papermill/provider.yaml: ## @@ -44,6 +44,7 @@ dependencies: - apache-airflow>=2.5.0 - papermill[all]>=1.2.1 - scrapbook[all] +

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1385345068 ## airflow/providers/papermill/hooks/kernel.py: ## @@ -0,0 +1,48 @@ +from airflow.hooks.base import BaseHook + +JUPYTER_KERNEL_SHELL_PORT = 60316

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-11-07 Thread via GitHub
akshaychitneni commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r138535 ## airflow/providers/papermill/hooks/kernel.py: ## @@ -0,0 +1,48 @@ +from airflow.hooks.base import BaseHook + +JUPYTER_KERNEL_SHELL_PORT = 60316

Re: [PR] Avoid too many conflicts when generating breeze images [airflow]

2023-11-07 Thread via GitHub
potiuk commented on PR #35508: URL: https://github.com/apache/airflow/pull/35508#issuecomment-1799356648 > Really nice, this is something that I frequently encountered, and got used to just not solve conflicts add everything and rerun the command manually to get the latest image and hash

Re: [I] AIP-51 - Executor Specific CLI Commands [airflow]

2023-11-07 Thread via GitHub
o-nikolas closed issue #27932: AIP-51 - Executor Specific CLI Commands URL: https://github.com/apache/airflow/issues/27932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Avoid too many conflicts when generating breeze images [airflow]

2023-11-07 Thread via GitHub
potiuk commented on PR #35508: URL: https://github.com/apache/airflow/pull/35508#issuecomment-1799344985 > Really nice, this is something that I frequently encountered, and got used to just not solve conflicts add everything and rerun the command manually to get the latest image and hash

Re: [PR] Increase timeout for flaky Test_BranchPythonDecoratedOperator test [airflow]

2023-11-07 Thread via GitHub
potiuk commented on PR #35511: URL: https://github.com/apache/airflow/pull/35511#issuecomment-1799340758 Very similar case as #35473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Increase timeout for flaky Test_BranchPythonDecoratedOperator test [airflow]

2023-11-07 Thread via GitHub
potiuk opened a new pull request, #35511: URL: https://github.com/apache/airflow/pull/35511 Similar to #35473 - this test sometimes (very rarely) exceeds the default 60 seconds timeout when run in Paralllel test environment where we have multiple containers and multiple databases and

Re: [PR] Refresh dependencies for Breeze to latest ones [airflow]

2023-11-07 Thread via GitHub
potiuk commented on code in PR #35510: URL: https://github.com/apache/airflow/pull/35510#discussion_r1385288780 ## scripts/ci/install_breeze.sh: ## @@ -19,6 +19,6 @@ set -euxo pipefail cd "$( dirname "${BASH_SOURCE[0]}" )/../../" -python -m pip install pipx packaging==23.1

Re: [PR] Refresh dependencies for Breeze to latest ones [airflow]

2023-11-07 Thread via GitHub
potiuk commented on code in PR #35510: URL: https://github.com/apache/airflow/pull/35510#discussion_r1385281233 ## scripts/ci/install_breeze.sh: ## @@ -19,6 +19,6 @@ set -euxo pipefail cd "$( dirname "${BASH_SOURCE[0]}" )/../../" -python -m pip install pipx packaging==23.1

(airflow) branch main updated: Add information about Qubole removal and make it possible to release it (#35492)

2023-11-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3b8db612ff Add information about Qubole removal

Re: [PR] More code coverage for the REST API [airflow]

2023-11-07 Thread via GitHub
potiuk commented on code in PR #35421: URL: https://github.com/apache/airflow/pull/35421#discussion_r1385277883 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -28,6 +30,7 @@ from airflow.api_connexion.types import APIResponse +pytestmark =

Re: [PR] Add information about Qubole removal and make it possible to release it [airflow]

2023-11-07 Thread via GitHub
potiuk merged PR #35492: URL: https://github.com/apache/airflow/pull/35492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Refresh dependencies for Breeze to latest ones [airflow]

2023-11-07 Thread via GitHub
potiuk opened a new pull request, #35510: URL: https://github.com/apache/airflow/pull/35510 Seems that if you have some older dependencies they might have problems with newer configurations (for example pre-commit). Since Breeze has it's own, isolated virtualenv managed by pipx, we can

Re: [I] Document precendence of `full_pod_spec` on `KubernetesPodOperator` [airflow]

2023-11-07 Thread via GitHub
ketozhang commented on issue #35509: URL: https://github.com/apache/airflow/issues/35509#issuecomment-1799263719 From https://github.com/apache/airflow/discussions/35425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Document precendence of `full_pod_spec` on `KubernetesPodOperator` [airflow]

2023-11-07 Thread via GitHub
ketozhang commented on issue #35509: URL: https://github.com/apache/airflow/issues/35509#issuecomment-1799263319 Related discussion https://github.com/apache/airflow/discussions/35425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[I] Document precendence of `full_pod_spec` on `KubernetesPodOperator` [airflow]

2023-11-07 Thread via GitHub
ketozhang opened a new issue, #35509: URL: https://github.com/apache/airflow/issues/35509 ### What do you see as an issue? `full_pod_spec` (see [this answer](https://github.com/apache/airflow/discussions/35425#discussioncomment-7496939)) overrides `pod_template` but it itself is a

  1   2   >