Re: [I] Issue with slim image: ModuleNotFoundError: No module named 'psycopg2' [airflow]

2023-11-11 Thread via GitHub
potiuk commented on issue #35255: URL: https://github.com/apache/airflow/issues/35255#issuecomment-1806743084 Well, it's not obvious - that's why we are having that discussion in the first place. Since you are asking, I will provide you very detailed answer, from which you understand WHY it

Re: [PR] Fix K8S executor override config using pod_override_object [airflow]

2023-11-11 Thread via GitHub
potiuk commented on PR #35185: URL: https://github.com/apache/airflow/pull/35185#issuecomment-1806752378 > Thanks @potiuk! I will check why I don't have the same issue in local. > > I will update the breeze command to create this serviceaccount > > > error looking up service acc

[PR] Add documentation about "providers.jdbc" in provider.yaml [airflow]

2023-11-11 Thread via GitHub
pankajkoti opened a new pull request, #35580: URL: https://github.com/apache/airflow/pull/35580 Version 4.0.0 of the JDBC provider added configuration options in airflow.cfg to be configured so that based on its value the driver_path and driver_class values set in the connection's ext

Re: [PR] Add documentation about "providers.jdbc" in provider.yaml [airflow]

2023-11-11 Thread via GitHub
pankajkoti commented on PR #35580: URL: https://github.com/apache/airflow/pull/35580#issuecomment-1806755410 This was referred to and asked for in the Slack conversation: https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1699335869425019 cc: @sarenmarka -- This is an automated m

Re: [PR] Add documentation about "providers.jdbc" in provider.yaml [airflow]

2023-11-11 Thread via GitHub
pankajkoti commented on PR #35580: URL: https://github.com/apache/airflow/pull/35580#issuecomment-180672 ![screencapture-localhost-63342-airflow-docs-build-docs-apache-airflow-providers-jdbc-stable-configurations-ref-html-2023-11-11-14_19_48](https://github.com/apache/airflow/assets/1020

[PR] Feature/fixed templated storage class [airflow]

2023-11-11 Thread via GitHub
romsharon98 opened a new pull request, #35581: URL: https://github.com/apache/airflow/pull/35581 Add templating for storageClassName in persistent volume claim -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] draft: Add templates for PVC storageClassName [airflow]

2023-11-11 Thread via GitHub
romsharon98 commented on PR #35544: URL: https://github.com/apache/airflow/pull/35544#issuecomment-1806758083 I opened a new branch for this PR: https://github.com/apache/airflow/pull/35581 So I close this PR. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] draft: Add templates for PVC storageClassName [airflow]

2023-11-11 Thread via GitHub
romsharon98 closed pull request #35544: draft: Add templates for PVC storageClassName URL: https://github.com/apache/airflow/pull/35544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add documentation about "providers.jdbc" in provider.yaml [airflow]

2023-11-11 Thread via GitHub
pankajkoti closed pull request #35580: Add documentation about "providers.jdbc" in provider.yaml URL: https://github.com/apache/airflow/pull/35580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix K8S executor override config using pod_override_object [airflow]

2023-11-11 Thread via GitHub
potiuk commented on PR #35185: URL: https://github.com/apache/airflow/pull/35185#issuecomment-1806765381 And BTW. My wild guess - without looking at the changes/code is that this is some kind of race condition - where the service account is either not created yet or maybe while being deleti

Re: [I] Unintentional type conversions with render_template_as_native_object = True [airflow]

2023-11-11 Thread via GitHub
potiuk commented on issue #35577: URL: https://github.com/apache/airflow/issues/35577#issuecomment-1806776912 Feel free to take a stab at that issue. There are about 3.500 operators so reviewing all of them and applying the rules you think of might be a bit tricky though. -- This is an a

Re: [PR] Bump axios from 0.26.0 to 1.6.0 in /airflow/www [airflow]

2023-11-11 Thread via GitHub
potiuk commented on PR #35578: URL: https://github.com/apache/airflow/pull/35578#issuecomment-1806777525 Would be great to get it in @bbovenzi @pierrejeambrun :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] kubernetes executor a few crtical and time consuming functions timing… [airflow]

2023-11-11 Thread via GitHub
potiuk commented on PR #35579: URL: https://github.com/apache/airflow/pull/35579#issuecomment-1806778154 can you also - however add the metrics to the documentation https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/logging-monitoring/metrics.html#metric-desc

Re: [I] Add documentation about "providers.jdbc" "allow_driver_path_in_extra" configuration to jdbc provider.yaml [airflow]

2023-11-11 Thread via GitHub
potiuk closed issue #35499: Add documentation about "providers.jdbc" "allow_driver_path_in_extra" configuration to jdbc provider.yaml URL: https://github.com/apache/airflow/issues/35499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Add documentation about "providers.jdbc" in provider.yaml [airflow]

2023-11-11 Thread via GitHub
potiuk merged PR #35580: URL: https://github.com/apache/airflow/pull/35580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Add documentation about "providers.jdbc" in provider.yaml (#35580)

2023-11-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9cfb1a82f3 Add documentation about "providers.jdbc"

Re: [PR] kubernetes executor a few crtical and time consuming functions timing… [airflow]

2023-11-11 Thread via GitHub
dirrao commented on PR #35579: URL: https://github.com/apache/airflow/pull/35579#issuecomment-1806790802 > Change is good but needs documentation update. Metrics documentation updated -- This is an automated message from the Apache Git Service. To respond to the message, please log

(airflow) branch constraints-main updated: Updating constraints. Github run id:6833911128

2023-11-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 054e429490 Updating con

Re: [PR] docs: Enhance documentation for providers.jdbc configuration in provi… [airflow]

2023-11-11 Thread via GitHub
eladkal commented on PR #35573: URL: https://github.com/apache/airflow/pull/35573#issuecomment-1806811440 Closed in favor of https://github.com/apache/airflow/pull/35580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] docs: Enhance documentation for providers.jdbc configuration in provi… [airflow]

2023-11-11 Thread via GitHub
eladkal closed pull request #35573: docs: Enhance documentation for providers.jdbc configuration in provi… URL: https://github.com/apache/airflow/pull/35573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Unintentional type conversions with render_template_as_native_object = True [airflow]

2023-11-11 Thread via GitHub
kaxil commented on issue #35577: URL: https://github.com/apache/airflow/issues/35577#issuecomment-1806819333 I'd classify that as a bug. The change should be to only change anything where it is a) template_field b) contains any jinja template string -- This is an automated message from th

Re: [I] Status of testing Providers that were prepared on November 08, 2023 [airflow]

2023-11-11 Thread via GitHub
dirrao commented on issue #35540: URL: https://github.com/apache/airflow/issues/35540#issuecomment-1806825702 Tested #34985 locally- it is working as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Unintentional type conversions with render_template_as_native_object = True [airflow]

2023-11-11 Thread via GitHub
Taragolis commented on issue #35577: URL: https://github.com/apache/airflow/issues/35577#issuecomment-1806826006 Duplicate of: - https://github.com/apache/airflow/issues/34641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Unintentional type conversions with render_template_as_native_object = True [airflow]

2023-11-11 Thread via GitHub
Taragolis closed issue #35577: Unintentional type conversions with render_template_as_native_object = True URL: https://github.com/apache/airflow/issues/35577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Adding "job_id" to templated fields in the DatabricksRunNowOperator [airflow]

2023-11-11 Thread via GitHub
Taragolis commented on code in PR #35576: URL: https://github.com/apache/airflow/pull/35576#discussion_r1390234527 ## airflow/providers/databricks/operators/databricks.py: ## @@ -720,7 +720,7 @@ class DatabricksRunNowOperator(BaseOperator): """ # Used in airflow.mode

Re: [I] When updating to 1.11.0, webserver ingress create/upgrade fails. [airflow]

2023-11-11 Thread via GitHub
mg-aik commented on issue #34196: URL: https://github.com/apache/airflow/issues/34196#issuecomment-1806846181 I have the same problem as @phil-park: Error: UPGRADE FAILED: failed to create resource: admission webhook "validate.nginx.ingress.kubernetes.io" denied the request: host "xxx

[PR] Enhancements in IMAGE.rst [airflow]

2023-11-11 Thread via GitHub
KesharwaniArpita opened a new pull request, #35582: URL: https://github.com/apache/airflow/pull/35582 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-gu

Re: [PR] Prevent assignment of non JSON serializable values to DagRun.conf dict [airflow]

2023-11-11 Thread via GitHub
jscheffl commented on PR #35096: URL: https://github.com/apache/airflow/pull/35096#issuecomment-1806932769 Still no luck with static checks, can you take a look here? Actually it just seems you need to run it once and commit the changed applied from ruff: https://github.com/apache/airflow/b

Re: [I] tasks are marked fail even when the api call is in progress with no error logs [airflow]

2023-11-11 Thread via GitHub
github-actions[bot] closed issue #35056: tasks are marked fail even when the api call is in progress with no error logs URL: https://github.com/apache/airflow/issues/35056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Using settings from connection [airflow]

2023-11-11 Thread via GitHub
github-actions[bot] closed pull request #34556: Using settings from connection URL: https://github.com/apache/airflow/pull/34556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Improve precision of the remove_task_decorator function [airflow]

2023-11-11 Thread via GitHub
github-actions[bot] commented on PR #34509: URL: https://github.com/apache/airflow/pull/34509#issuecomment-1806951689 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [I] tasks are marked fail even when the api call is in progress with no error logs [airflow]

2023-11-11 Thread via GitHub
github-actions[bot] commented on issue #35056: URL: https://github.com/apache/airflow/issues/35056#issuecomment-1806951669 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Consolidate ExternalTaskSensor deferrable and non deferrable logic [airflow]

2023-11-11 Thread via GitHub
github-actions[bot] closed pull request #34464: Consolidate ExternalTaskSensor deferrable and non deferrable logic URL: https://github.com/apache/airflow/pull/34464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Refactor os.makedirs/os.mkdir to Path.mkdir [airflow]

2023-11-11 Thread via GitHub
github-actions[bot] commented on PR #34385: URL: https://github.com/apache/airflow/pull/34385#issuecomment-1806951701 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [I] Status of testing Providers that were prepared on November 08, 2023 [airflow]

2023-11-11 Thread via GitHub
phi-friday commented on issue #35540: URL: https://github.com/apache/airflow/issues/35540#issuecomment-1807034724 tested #35293 locally. it works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo