Re: [I] Trigger die with DB deadlock between scheduler [airflow]

2023-11-24 Thread via GitHub
github-actions[bot] commented on issue #27000: URL: https://github.com/apache/airflow/issues/27000#issuecomment-1826235081 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Trigger die with DB deadlock between scheduler [airflow]

2023-11-24 Thread via GitHub
github-actions[bot] closed issue #27000: Trigger die with DB deadlock between scheduler URL: https://github.com/apache/airflow/issues/27000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Status of testing Providers that were prepared on November 24, 2023 [airflow]

2023-11-24 Thread via GitHub
bolleyboll commented on issue #35845: URL: https://github.com/apache/airflow/issues/35845#issuecomment-1826229970 #35799 work ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Enhance DynamoDBValueSensor to support any attribute value in list [airflow]

2023-11-24 Thread via GitHub
flolas commented on PR #35831: URL: https://github.com/apache/airflow/pull/35831#issuecomment-1826194900 > LGTM. Unless there is a valid reason, you can put your PR "in review" Done. also, tests are ok and commits have been squashed. -- This is an automated message from the Apache

Re: [I] Status of testing Providers that were prepared on November 24, 2023 [airflow]

2023-11-24 Thread via GitHub
sseung00921 commented on issue #35845: URL: https://github.com/apache/airflow/issues/35845#issuecomment-1826192246 https://github.com/apache/airflow/pull/35648 work ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(airflow-ci-infra) branch main updated: Bump versions of docker and docker-compose

2023-11-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git The following commit(s) were added to refs/heads/main by this push: new 394a482 Bump versions of docker and

(airflow) branch main updated: allow multiple elements in impersonation chain (#35694)

2023-11-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e2a5dbf8b4 allow multiple elements in

Re: [PR] allow multiple elements in impersonation chain [airflow]

2023-11-24 Thread via GitHub
potiuk merged PR #35694: URL: https://github.com/apache/airflow/pull/35694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]

2023-11-24 Thread via GitHub
potiuk commented on PR #34716: URL: https://github.com/apache/airflow/pull/34716#issuecomment-1826176241 > No worries, I can try to keep this PR up to date. One thing that I haven't thought about is that `HealthCheckPolicy` is GKE specific, so we may not want merge this in :/ Not sure how

Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]

2023-11-24 Thread via GitHub
potiuk closed pull request #34716: feat: enable HTTPRoute for Gateway API URL: https://github.com/apache/airflow/pull/34716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add support for service account impersonation with computeEngineSSHHook (google provider) and IAP tunnel [airflow]

2023-11-24 Thread via GitHub
potiuk commented on PR #35136: URL: https://github.com/apache/airflow/pull/35136#issuecomment-1826173929 > What are the next steps ? I'm not familiar with the PR process. Are there additional steps from you ? Or shall i do something in addition ? Just wait until PR gets green and

(airflow) branch main updated (c905fe88de -> 770f16425c)

2023-11-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c905fe88de Update information about links into the provider.yaml files (#35837) add 770f16425c Add support for

Re: [PR] Add support for service account impersonation with computeEngineSSHHook (google provider) and IAP tunnel [airflow]

2023-11-24 Thread via GitHub
boring-cyborg[bot] commented on PR #35136: URL: https://github.com/apache/airflow/pull/35136#issuecomment-1826173774 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Add support for service account impersonation with computeEngineSSHHook (google provider) and IAP tunnel [airflow]

2023-11-24 Thread via GitHub
potiuk merged PR #35136: URL: https://github.com/apache/airflow/pull/35136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (39107dfeb4 -> c905fe88de)

2023-11-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 39107dfeb4 change indent to 4 (#35824) add c905fe88de Update information about links into the provider.yaml files

Re: [PR] Update information about links into the `provider.yaml` files [airflow]

2023-11-24 Thread via GitHub
potiuk merged PR #35837: URL: https://github.com/apache/airflow/pull/35837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update information about links into the `provider.yaml` files [airflow]

2023-11-24 Thread via GitHub
potiuk commented on code in PR #35837: URL: https://github.com/apache/airflow/pull/35837#discussion_r1404696183 ## airflow/providers/opsgenie/provider.yaml: ## @@ -19,7 +19,7 @@ package-name: apache-airflow-providers-opsgenie name: Opsgenie description: | -`Opsgenie

Re: [PR] Introduce @task.bash TaskFlow decorator [airflow]

2023-11-24 Thread via GitHub
github-actions[bot] commented on PR #30176: URL: https://github.com/apache/airflow/pull/30176#issuecomment-1826152395 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

(airflow) branch main updated: change indent to 4 (#35824)

2023-11-24 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 39107dfeb4 change indent to 4 (#35824)

Re: [I] git-sync-init resources is too indented [airflow]

2023-11-24 Thread via GitHub
hussein-awala closed issue #35815: git-sync-init resources is too indented URL: https://github.com/apache/airflow/issues/35815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix git-sync-init resources indent [airflow]

2023-11-24 Thread via GitHub
hussein-awala merged PR #35824: URL: https://github.com/apache/airflow/pull/35824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix git-sync-init resources indent [airflow]

2023-11-24 Thread via GitHub
hussein-awala commented on PR #35824: URL: https://github.com/apache/airflow/pull/35824#issuecomment-1826118289 > I agree with @jscheffl > > Wrong indent can be on every line its not so simple to cover. > > > > WDYT @hussein-awala ? Okay, I will try to add a

Re: [PR] Update example_ec2 to Create Instance Which Supports Hibernation (#35790) [airflow]

2023-11-24 Thread via GitHub
dashton90 commented on PR #35839: URL: https://github.com/apache/airflow/pull/35839#issuecomment-1826082872 Huh, it looks like boto [fails the terminate waiter if the instance is in the stopping

(airflow) branch main updated: Update README_RELEASE_PROVIDER_PACKAGES.md (#35846)

2023-11-24 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c068089c65 Update

Re: [PR] Update README_RELEASE_PROVIDER_PACKAGES.md [airflow]

2023-11-24 Thread via GitHub
eladkal merged PR #35846: URL: https://github.com/apache/airflow/pull/35846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update example_ec2 to Create Instance Which Supports Hibernation (#35790) [airflow]

2023-11-24 Thread via GitHub
ferruzzi commented on PR #35839: URL: https://github.com/apache/airflow/pull/35839#issuecomment-1826050859 Alright. progress! I ran the proposed changes and it failed, but it's getting much further. Here's the current state: ``` INFO

Re: [PR] feat: SQLExecuteQueryOperator sql_callable [airflow]

2023-11-24 Thread via GitHub
raphaelauv commented on PR #35844: URL: https://github.com/apache/airflow/pull/35844#issuecomment-1826044862 @Taragolis thanks for the advise , it work but it mean 2 operators and it's "less friendly" ```python def build_sql(date): return "select *

Re: [PR] feat: SQLExecuteQueryOperator sql_callable [airflow]

2023-11-24 Thread via GitHub
raphaelauv commented on PR #35844: URL: https://github.com/apache/airflow/pull/35844#issuecomment-1826019503 the limitation with the current implementation is that the full templated query is not available in airflow UI or logs -> ```python import os from airflow

Re: [PR] Update example_ec2 to Create Instance Which Supports Hibernation (#35790) [airflow]

2023-11-24 Thread via GitHub
ferruzzi commented on PR #35839: URL: https://github.com/apache/airflow/pull/35839#issuecomment-1826009643 >Amazon will default to using an Amazon managed key to encrypt the volume if you don't specify one. AH! I misunderstood, I thought you meant "Amazon" meaning my team

Re: [I] Status of testing Providers that were prepared on November 24, 2023 [airflow]

2023-11-24 Thread via GitHub
raphaelauv commented on issue #35845: URL: https://github.com/apache/airflow/issues/35845#issuecomment-1825998540 https://github.com/apache/airflow/pull/35600 work :white_check_mark: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Update example_ec2 to Create Instance Which Supports Hibernation (#35790) [airflow]

2023-11-24 Thread via GitHub
dashton90 commented on PR #35839: URL: https://github.com/apache/airflow/pull/35839#issuecomment-1825998596 I added you as a collaborator to my fork so you should be free to push any changes you need. But I can make the changes myself tonight or tomorrow if you don't get around to it.

[PR] Update README_RELEASE_PROVIDER_PACKAGES.md [airflow]

2023-11-24 Thread via GitHub
eladkal opened a new pull request, #35846: URL: https://github.com/apache/airflow/pull/35846 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] feat: SQLExecuteQueryOperator sql_callable [airflow]

2023-11-24 Thread via GitHub
Taragolis commented on PR #35844: URL: https://github.com/apache/airflow/pull/35844#issuecomment-1825987456 I don't think this required. There is good builtin replacement for exactly the same things already exists for the every operator parameter which supports templated fields:

[I] Status of testing Providers that were prepared on November 24, 2023 [airflow]

2023-11-24 Thread via GitHub
eladkal opened a new issue, #35845: URL: https://github.com/apache/airflow/issues/35845 ### Body I have a kind request for all the contributors to the latest provider packages release. Could you please help us to test the RC versions of the providers? The guidelines on how

[PR] feat: SQLExecuteQueryOperator sql_callable [airflow]

2023-11-24 Thread via GitHub
raphaelauv opened a new pull request, #35844: URL: https://github.com/apache/airflow/pull/35844 how should I manage typing , since mypy fail with ``` error: Argument "sql" to "generate_openlineage_metadata_from_sql" of "SQLParser" has incompatible type "Union[str, List[str],

(airflow-site) branch add-documentation-2023-11-24 created (now 0f8efbc12e)

2023-11-24 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch add-documentation-2023-11-24 in repository https://gitbox.apache.org/repos/asf/airflow-site.git at 0f8efbc12e Add documentation for packages - 2023-11-24 This branch includes the

[PR] Add documentation for packages - 2023-11-24 [airflow-site]

2023-11-24 Thread via GitHub
eladkal opened a new pull request, #899: URL: https://github.com/apache/airflow-site/pull/899 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add support for service account impersonation with computeEngineSSHHook (google provider) and IAP tunnel [airflow]

2023-11-24 Thread via GitHub
ginolegigot commented on PR #35136: URL: https://github.com/apache/airflow/pull/35136#issuecomment-1825976483 Hello thanks for your review! What are the next steps ? I'm not familiar with the PR process. Are there additional steps from you ? Or shall i do something in addition ? I'm

Re: [PR] Create directories based on `AIRFLOW_CONFIG` path [airflow]

2023-11-24 Thread via GitHub
potiuk commented on PR #35818: URL: https://github.com/apache/airflow/pull/35818#issuecomment-1825973689 Nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Update example_ec2 to Create Instance Which Supports Hibernation (#35790) [airflow]

2023-11-24 Thread via GitHub
ferruzzi commented on PR #35839: URL: https://github.com/apache/airflow/pull/35839#issuecomment-1825971688 At a glance, it looks right. As mentioned, we'll need to adjust it to accept a KMS key to encrypt the EBS volume. Github makes it a bit of a pain to collaborate on a PR like this;

Re: [PR] Add EC2HibernateInstanceOperator and EC2RebootInstanceOperator [airflow]

2023-11-24 Thread via GitHub
ferruzzi commented on PR #35790: URL: https://github.com/apache/airflow/pull/35790#issuecomment-1825956441 Amazing, thanks! I'll have a look later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

svn commit: r65525 - /dev/airflow/providers/provider_packages.asc

2023-11-24 Thread eladkal
Author: eladkal Date: Fri Nov 24 17:43:34 2023 New Revision: 65525 Log: remove provider_packages.asc Removed: dev/airflow/providers/provider_packages.asc

svn commit: r65524 - /dev/airflow/providers/

2023-11-24 Thread eladkal
Author: eladkal Date: Fri Nov 24 17:43:02 2023 New Revision: 65524 Log: Add artifacts for Airflow Providers 2023-11-24 Added: dev/airflow/providers/apache_airflow_providers_amazon-8.12.0-py3-none-any.whl (with props)

Re: [PR] Add missing default for version suffix [airflow]

2023-11-24 Thread via GitHub
potiuk merged PR #35842: URL: https://github.com/apache/airflow/pull/35842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Add missing default for version suffix (#35842)

2023-11-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4298c433bc Add missing default for version suffix

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2023-11-24 Thread via GitHub
baruch-shteken commented on PR #34927: URL: https://github.com/apache/airflow/pull/34927#issuecomment-1825922057 I tested my changes locally (I didn't manage to pull my changes from GitHub. However, we use an Airflow docker so I changed the file `airflow/providers/tableau/hooks/tableau.py`

Re: [I] Airflow Kubernetes Connection Not Accepting JSON Kubeconfig [airflow]

2023-11-24 Thread via GitHub
RuizChristianJ closed issue #35690: Airflow Kubernetes Connection Not Accepting JSON Kubeconfig URL: https://github.com/apache/airflow/issues/35690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] Celery tasks stuck queued. Clearing task fails rescheduling [airflow]

2023-11-24 Thread via GitHub
hterik opened a new issue, #35843: URL: https://github.com/apache/airflow/issues/35843 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened Task set to run in celery queue was queued but never started on the worker. Stuck in

[PR] Add missing default for version suffix [airflow]

2023-11-24 Thread via GitHub
potiuk opened a new pull request, #35842: URL: https://github.com/apache/airflow/pull/35842 The missing default was causing the suffix to be None when not specified and crashing package building. --- **^ Add meaningful description above** Read the

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-11-24 Thread via GitHub
JCoder01 commented on code in PR #35800: URL: https://github.com/apache/airflow/pull/35800#discussion_r1404509646 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -642,39 +641,6 @@ def adopt_launched_task( del tis_to_flush_by_key[ti_key]

[I] Task retried after scheduler crashes whilst retries=0 [airflow]

2023-11-24 Thread via GitHub
cesar-vermeulen opened a new issue, #35841: URL: https://github.com/apache/airflow/issues/35841 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened We have a task with a hard restriction that it should not run more than once.

Re: [PR] Add EC2HibernateInstanceOperator and EC2RebootInstanceOperator [airflow]

2023-11-24 Thread via GitHub
dashton90 commented on PR #35790: URL: https://github.com/apache/airflow/pull/35790#issuecomment-1825805238 Created https://github.com/apache/airflow/pull/35839. I've tested the changes independently, but can I leave it to you to do the end-to-end tests? -- This is an automated message

[PR] Update example_ec2 to Create Instance Which Supports Hibernation (#35790) [airflow]

2023-11-24 Thread via GitHub
dashton90 opened a new pull request, #35839: URL: https://github.com/apache/airflow/pull/35839 A bug was introduced in the ec2_example DAG when adding the `EC2HibernateInstanceOperator`. This PR updates the configuration of the example to create an instance which supports hibernation.

Re: [PR] Update example_ec2 to Create Instance Which Supports Hibernation (#35790) [airflow]

2023-11-24 Thread via GitHub
dashton90 commented on PR #35839: URL: https://github.com/apache/airflow/pull/35839#issuecomment-1825802104 @ferruzzi tagging you since you flagged the bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(airflow) branch main updated (0b23d5601c -> cc042a2b7e)

2023-11-24 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 0b23d5601c Prepare docs 2nd wave of Providers November 2023 (#35836) add cc042a2b7e Create directories based on

Re: [PR] Create directories based on `AIRFLOW_CONFIG` path [airflow]

2023-11-24 Thread via GitHub
vincbeck merged PR #35818: URL: https://github.com/apache/airflow/pull/35818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Unable to create a WinRM Connection with apache-airflow-providers-microsoft-winrm installed [airflow]

2023-11-24 Thread via GitHub
sksirajbasha commented on issue #19739: URL: https://github.com/apache/airflow/issues/19739#issuecomment-1825680243 is there a tutorial or a know errata for winrm connections via airflow ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Prepare docs 2nd wave of Providers November 2023 [airflow]

2023-11-24 Thread via GitHub
eladkal merged PR #35836: URL: https://github.com/apache/airflow/pull/35836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Airflow scheduler stopped working [airflow]

2023-11-24 Thread via GitHub
nclaeys commented on issue #35272: URL: https://github.com/apache/airflow/issues/35272#issuecomment-1825680026 Yes you are right, but the crashing pipelines use a cron expression like "0 9,10 * * *", my first comment was more like what I expect when using timezones and cron expression.

Re: [I] Unable to create a WinRM Connection with apache-airflow-providers-microsoft-winrm installed [airflow]

2023-11-24 Thread via GitHub
sksirajbasha commented on issue #19739: URL: https://github.com/apache/airflow/issues/19739#issuecomment-1825679735 > The host should be simply "" – the rest is added automatically. Yep.. I put just the host name in the connection. The one I pasted above is the error log with

Re: [I] Airflow StatsD Configuration Error: XML 'ResourceNotFound' Message for statsd_host Environment Variable [airflow]

2023-11-24 Thread via GitHub
jordi-crespo commented on issue #35817: URL: https://github.com/apache/airflow/issues/35817#issuecomment-1825630340 > Reading this I can confirm that statsd is working in our setup in K8s with the standard helm chart very stable sine ~1 year at least. Am I correct to assume that your

[PR] Add OpenLineage support to GCS operators [airflow]

2023-11-24 Thread via GitHub
kacpermuda opened a new pull request, #35838: URL: https://github.com/apache/airflow/pull/35838 Adding OpenLineage support for the following operators: - GCSDeleteObjectsOperator - GCSFileTransformOperator - GCSTimeSpanFileTransformOperator --- **^

Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]

2023-11-24 Thread via GitHub
Kyrremann commented on PR #34716: URL: https://github.com/apache/airflow/pull/34716#issuecomment-1825521152 No worries, I can try to keep this PR up to date. One thing that I haven't thought about is that `HealthCheckPolicy` is GKE specific, so we may not want merge this in :/ Not sure

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
pankajkoti commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404227678 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
pankajkoti commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404227678 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die

Re: [I] ComputeEngineSSHHook unintentionally deletes instance metadata [airflow]

2023-11-24 Thread via GitHub
VladaZakharova commented on issue #35171: URL: https://github.com/apache/airflow/issues/35171#issuecomment-1825504527 @teslur Sorry for the late response Thank you for the explanation, i think we can merge this :) -- This is an automated message from the Apache Git Service. To

Re: [PR] Update information about links into the `provider.yaml` files [airflow]

2023-11-24 Thread via GitHub
Taragolis commented on code in PR #35837: URL: https://github.com/apache/airflow/pull/35837#discussion_r1404225502 ## airflow/providers/opsgenie/provider.yaml: ## @@ -19,7 +19,7 @@ package-name: apache-airflow-providers-opsgenie name: Opsgenie description: | -`Opsgenie

Re: [I] BigQueryInsertJobOperator doesn't include BigQuery region/location in deferrable mode [airflow]

2023-11-24 Thread via GitHub
eladkal commented on issue #35833: URL: https://github.com/apache/airflow/issues/35833#issuecomment-1825500785 feel free to open PR to address the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Update information about links into the `provider.yaml` files [airflow]

2023-11-24 Thread via GitHub
Taragolis opened a new pull request, #35837: URL: https://github.com/apache/airflow/pull/35837 Update service/integration links in `provider.yaml` files. 1. `http` -> `https` 2. Localised version -> EN or common link 3. URI which redirect to the new domain 4.

Re: [PR] allow multiple elements in impersonation chain [airflow]

2023-11-24 Thread via GitHub
VladaZakharova commented on PR #35694: URL: https://github.com/apache/airflow/pull/35694#issuecomment-1825498530 Thank you for explanation, i think we can merge the changes @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
pankajkoti commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404218105 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die

[PR] Prepare docs 2nd wave of Providers November 2023 [airflow]

2023-11-24 Thread via GitHub
eladkal opened a new pull request, #35836: URL: https://github.com/apache/airflow/pull/35836 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Unable to create a WinRM Connection with apache-airflow-providers-microsoft-winrm installed [airflow]

2023-11-24 Thread via GitHub
malthe commented on issue #19739: URL: https://github.com/apache/airflow/issues/19739#issuecomment-1825457159 The host should be simply "" – the rest is added automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Unable to create a WinRM Connection with apache-airflow-providers-microsoft-winrm installed [airflow]

2023-11-24 Thread via GitHub
sksirajbasha commented on issue #19739: URL: https://github.com/apache/airflow/issues/19739#issuecomment-1825452120 > @sksirajbasha "401 Client Error: for url: http://:5985/wsman; looks suspicious. > > Do you have the host set alright? You need to go through the error log carefully

Re: [I] Unable to create a WinRM Connection with apache-airflow-providers-microsoft-winrm installed [airflow]

2023-11-24 Thread via GitHub
sksirajbasha commented on issue #19739: URL: https://github.com/apache/airflow/issues/19739#issuecomment-1825448653 > @sksirajbasha "401 Client Error: for url: http://:5985/wsman; looks suspicious. > > Do you have the host set alright? You need to go through the error log carefully

Re: [I] Unable to create a WinRM Connection with apache-airflow-providers-microsoft-winrm installed [airflow]

2023-11-24 Thread via GitHub
sksirajbasha commented on issue #19739: URL: https://github.com/apache/airflow/issues/19739#issuecomment-1825447334 the connection looks like this https://github.com/apache/airflow/assets/23027743/54d2f8f8-ddf3-404c-9443-7043ec36f30c;> -- This is an automated message from the

Re: [I] Unable to create a WinRM Connection with apache-airflow-providers-microsoft-winrm installed [airflow]

2023-11-24 Thread via GitHub
malthe commented on issue #19739: URL: https://github.com/apache/airflow/issues/19739#issuecomment-1825441406 @sksirajbasha "401 Client Error: for url: http://:5985/wsman; looks suspicious. Do you have the host set alright? You need to go through the error log carefully to see what

Re: [I] Unable to create a WinRM Connection with apache-airflow-providers-microsoft-winrm installed [airflow]

2023-11-24 Thread via GitHub
sksirajbasha commented on issue #19739: URL: https://github.com/apache/airflow/issues/19739#issuecomment-1825437401 Not sure if this is the right thread. The winrm connection with this provider always fails. IT works via Rundeck when used with same credentials. Errs out with airflow for

Re: [PR] add guideline for missing image when running breeze [airflow]

2023-11-24 Thread via GitHub
Lee-W commented on PR #35813: URL: https://github.com/apache/airflow/pull/35813#issuecomment-1825425883 Sounds good. Let me check where i can add it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
Lee-W commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404163077 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die once

Re: [I] Incorrect queued duration for deferred tasks in gantt view [airflow]

2023-11-24 Thread via GitHub
tirkarthi commented on issue #35288: URL: https://github.com/apache/airflow/issues/35288#issuecomment-1825413513 We are testing a patch for this internally and hopefully upstream it as a pull request in coming week. Please assign this to me. -- This is an automated message from the

Re: [PR] Add multiselect to run state in grid view [airflow]

2023-11-24 Thread via GitHub
eladkal commented on PR #35403: URL: https://github.com/apache/airflow/pull/35403#issuecomment-1825413403 cc @bbovenzi can we merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Displaying "actual" try number in TaskInstance view [airflow]

2023-11-24 Thread via GitHub
eladkal commented on PR #34635: URL: https://github.com/apache/airflow/pull/34635#issuecomment-1825407449 > How do you feel about the approach in general? It feels kinda hacky to me, but it technically works so @bbovenzi approved so I guess it's OK :) -- This is an automated

Re: [PR] enhance druid connection parameters [airflow]

2023-11-24 Thread via GitHub
eladkal commented on code in PR #35244: URL: https://github.com/apache/airflow/pull/35244#discussion_r1404152273 ## airflow/providers/apache/druid/hooks/druid.py: ## @@ -163,8 +167,8 @@ class DruidDbApiHook(DbApiHook): conn_name_attr = "druid_broker_conn_id"

(airflow) branch main updated: Add DagModel attributes before dumping DagDetailSchema for get_dag_details API endpoint (#34947)

2023-11-24 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e8f62e8ee5 Add DagModel attributes before dumping

Re: [PR] Add DagModel attributes before dumping DagDetailSchema for get_dag_details API endpoint [airflow]

2023-11-24 Thread via GitHub
eladkal merged PR #34947: URL: https://github.com/apache/airflow/pull/34947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(bigquery.py): pass correct project_id to triggerer [airflow]

2023-11-24 Thread via GitHub
eladkal commented on PR #35200: URL: https://github.com/apache/airflow/pull/35200#issuecomment-1825395914 Tests are failing ``` FAILED

Re: [PR] Add support for service account impersonation with computeEngineSSHHook (google provider) and IAP tunnel [airflow]

2023-11-24 Thread via GitHub
eladkal commented on PR #35136: URL: https://github.com/apache/airflow/pull/35136#issuecomment-1825394266 @shahar1 can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
potiuk commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404115850 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die once

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
potiuk commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404113452 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die once

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
potiuk commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404111057 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die once

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
potiuk commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404111057 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die once

Re: [PR] Enhance docs for zombie tasks [airflow]

2023-11-24 Thread via GitHub
pankajkoti commented on code in PR #35825: URL: https://github.com/apache/airflow/pull/35825#discussion_r1404086190 ## docs/apache-airflow/core-concepts/tasks.rst: ## @@ -243,9 +243,103 @@ Zombie/Undead Tasks No system runs perfectly, and task instances are expected to die

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-11-24 Thread via GitHub
droppoint commented on code in PR #35800: URL: https://github.com/apache/airflow/pull/35800#discussion_r1404083513 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -642,39 +641,6 @@ def adopt_launched_task( del tis_to_flush_by_key[ti_key]

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-11-24 Thread via GitHub
ephraimbuddy commented on code in PR #35800: URL: https://github.com/apache/airflow/pull/35800#discussion_r1404052934 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -642,39 +641,6 @@ def adopt_launched_task( del tis_to_flush_by_key[ti_key]

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-11-24 Thread via GitHub
ephraimbuddy commented on code in PR #35800: URL: https://github.com/apache/airflow/pull/35800#discussion_r1404052934 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -642,39 +641,6 @@ def adopt_launched_task( del tis_to_flush_by_key[ti_key]