pankajkoti closed pull request #36014: Bump up openai version to >=1.0 & use
get_conn
URL: https://github.com/apache/airflow/pull/36014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Lee-W commented on code in PR #36014:
URL: https://github.com/apache/airflow/pull/36014#discussion_r1413027499
##
airflow/providers/openai/hooks/openai.py:
##
@@ -41,13 +42,9 @@ class OpenAIHook(BaseHook):
def __init__(self, conn_id: str = default_conn_name, *args: Any, **k
potiuk commented on issue #35998:
URL: https://github.com/apache/airflow/issues/35998#issuecomment-1837425016
What you see is likely effect of serialization how it was implemented 2.5
years ago - with thousands of bug fixes released since - including tens of them
released in the 2.1 line yo
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1837427512
You also need to actually use the pre-commit to generate the content :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1837427568
And remove the one added by hand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
potiuk commented on PR #897:
URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1837427718
https://github.com/apache/airflow-site/actions/runs/7075369981/job/19258840711?pr=897
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
bolkedebruin opened a new pull request, #36031:
URL: https://github.com/apache/airflow/pull/36031
s3fs has significantly relaxed its dependency requirements, so we can now
safely remove the upper bound constraint and lower the the minimum required.
bolkedebruin commented on PR #35820:
URL: https://github.com/apache/airflow/pull/35820#issuecomment-1837431695
Note: something went wrong with rebasing, fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1413040413
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1413040413
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on PR #36031:
URL: https://github.com/apache/airflow/pull/36031#issuecomment-1837433974
Looks like it works - but let's see if `pypi` constraints generation works
as well.
Small nit: I think >=2.7.0 would also be fine. we will see if `pip` will do
the job now. The `
potiuk commented on PR #36031:
URL: https://github.com/apache/airflow/pull/36031#issuecomment-1837434795
Interesting thing thoug is that it seems that s3fs had not been bumped here
automatically (see outout of "source constraints") - so I am afraid there will
be something else. We still hav
potiuk merged PR #36023:
URL: https://github.com/apache/airflow/pull/36023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 618fbae2c6 Improve readability and content of the s
potiuk commented on PR #36031:
URL: https://github.com/apache/airflow/pull/36031#issuecomment-1837436717
Hmm. It looks very good now.
But Interesting thing. Seems that source constraints have not been updated
... But the constraints from PyPI were:
https://github.com/apache/air
potiuk merged PR #36031:
URL: https://github.com/apache/airflow/pull/36031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 9bd192eb0a Remove upper bound constraint on aioboto
bolkedebruin commented on PR #36031:
URL: https://github.com/apache/airflow/pull/36031#issuecomment-1837453555
> Looks like it works - but let's see if `pypi` constraints generation works
as well.
>
> Small nit: I think >=2.7.0 would also be fine. we will see if `pip` will
do the job
potiuk commented on PR #36031:
URL: https://github.com/apache/airflow/pull/36031#issuecomment-1837461546
> Gotcha. I thought to limit it to the lower bound that the new s3fs
supports would make sense.
Seems it works and resolution is pretty fast, so no problem :). Maybe even
we coul
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 74de68f84c Updating con
pateash commented on issue #35911:
URL: https://github.com/apache/airflow/issues/35911#issuecomment-1837467087
@eladkal,
I am thinking of adding it as an argument in SparkSubmitOperator if user
wants to override it from connection extras.
let me know what you think.
--
This is a
mpgreg commented on issue #34206:
URL: https://github.com/apache/airflow/issues/34206#issuecomment-1837468294
This is something that will be necessary for MLops use cases.
@jscheffl if I'm understanding your suggestion correctly couldn't we just
use extras to store dynamic content?
boushphong opened a new pull request, #36032:
URL: https://github.com/apache/airflow/pull/36032
…triggered dag runs - DRAFT
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CON
boushphong commented on issue #35870:
URL: https://github.com/apache/airflow/issues/35870#issuecomment-1837489928
@nathadfield Just submitted a pull request. It's a DRAFT PR for now.
https://github.com/apache/airflow/pull/36032/files#diff-4253adbb36bfb93cb75ab00c7d509518134e5bf1ad16473b64
eladkal commented on issue #35911:
URL: https://github.com/apache/airflow/issues/35911#issuecomment-1837516253
We normally allow to override connection extra from the operator level. For
example with Snowflake you can set different warehouse than the default one set
in the connection.
--
Joffreybvn commented on code in PR #36015:
URL: https://github.com/apache/airflow/pull/36015#discussion_r1413141467
##
airflow/providers/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md:
##
@@ -0,0 +1,139 @@
+
+
+# 2. Return common data struct
Joffreybvn commented on code in PR #36015:
URL: https://github.com/apache/airflow/pull/36015#discussion_r1413141467
##
airflow/providers/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md:
##
@@ -0,0 +1,139 @@
+
+
+# 2. Return common data struct
Taragolis opened a new pull request, #36034:
URL: https://github.com/apache/airflow/pull/36034
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideline
potiuk opened a new pull request, #36035:
URL: https://github.com/apache/airflow/pull/36035
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*
ephraimbuddy commented on code in PR #35934:
URL: https://github.com/apache/airflow/pull/35934#discussion_r1413182172
##
airflow/providers/weaviate/hooks/weaviate.py:
##
@@ -193,3 +195,88 @@ def query_without_vector(
.do()
)
return results
+
+d
BasPH commented on code in PR #36035:
URL: https://github.com/apache/airflow/pull/36035#discussion_r1413194319
##
dev/diagrams/pyproject.toml:
##
@@ -0,0 +1,25 @@
+[build-system]
+requires = [
+ "setuptools",
+ "wheel",
+]
+
+[project]
+name = "generate-airflow-architecture"
+
potiuk commented on PR #36035:
URL: https://github.com/apache/airflow/pull/36035#issuecomment-1837585007
> Few minor comments + for a basic diagram I'd show only one user in the
diagram, with an arrow to both the DAG files & webserver.
I thought about it, and I think It's good to ment
potiuk commented on code in PR #36035:
URL: https://github.com/apache/airflow/pull/36035#discussion_r1413197799
##
dev/diagrams/README.md:
##
@@ -0,0 +1,26 @@
+
+
+In order to regenerate the diagrams you need to:
+
+* Have [Graphviz](https://graphviz.org/) installed on your syst
potiuk commented on code in PR #36035:
URL: https://github.com/apache/airflow/pull/36035#discussion_r1413197864
##
dev/diagrams/pyproject.toml:
##
@@ -0,0 +1,25 @@
+[build-system]
+requires = [
+ "setuptools",
+ "wheel",
+]
+
+[project]
+name = "generate-airflow-architecture"
stavdav143 commented on PR #35677:
URL: https://github.com/apache/airflow/pull/35677#issuecomment-1837588155
Hi @eladkal
I committed a unit test for logging.
There were small changes I needed to carry in the test file in order to
comply with the logging algorithm we use.
These were
BinalModi opened a new pull request, #36036:
URL: https://github.com/apache/airflow/pull/36036
^dags
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-requ
boring-cyborg[bot] commented on PR #36036:
URL: https://github.com/apache/airflow/pull/36036#issuecomment-1837592883
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
BinalModi closed pull request #36036: WIP: Update .airflowignore tests
URL: https://github.com/apache/airflow/pull/36036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
potiuk commented on code in PR #36035:
URL: https://github.com/apache/airflow/pull/36035#discussion_r1413208446
##
dev/diagrams/generate_airflow_architecture_diagram.py:
##
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lice
potiuk commented on PR #36035:
URL: https://github.com/apache/airflow/pull/36035#issuecomment-1837604071
I introduced two diagrams now - one basic, and one with standalond DAG file
processor. While it is not yet fullly - mutlitenant, this already gives some
good properties (like scheduler n
potiuk commented on code in PR #36015:
URL: https://github.com/apache/airflow/pull/36015#discussion_r1413210068
##
airflow/providers/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md:
##
@@ -0,0 +1,139 @@
+
+
+# 2. Return common data structure
stavdav143 commented on PR #35677:
URL: https://github.com/apache/airflow/pull/35677#issuecomment-1837605145
Unfortunately @eladkal I had to revert my test case as the GitHub actions do
not run it in a swarm node mode as expected in the local test environment with
breeze. This test case hig
stavdav143 commented on PR #35677:
URL: https://github.com/apache/airflow/pull/35677#issuecomment-1837605592
This below explains how this PR fixes the Docker Swarm Operator issues:
Bug
Below the task never ends and the logs are not being streamed (before this
fix):
![output_bug
potiuk merged PR #36034:
URL: https://github.com/apache/airflow/pull/36034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 3f354c0c92 Do not catch too broad exception in
`Wa
potiuk commented on PR #36017:
URL: https://github.com/apache/airflow/pull/36017#issuecomment-1837621620
Seems like we are havin issue with just released 0.23.1 of Pytest-asyncio,
which was supposed to fix bugs in (also just released but 10 hours earlier). I
opened an issue https://github.c
potiuk opened a new pull request, #36037:
URL: https://github.com/apache/airflow/pull/36037
Seems that pytest-asyncio 0.23.1 break our asyncio tests. We are temporarily
limiting it until
https://github.com/pytest-dev/pytest-asyncio/issues/703 is solved or
answered.
potiuk commented on PR #36017:
URL: https://github.com/apache/airflow/pull/36017#issuecomment-1837622444
And PR here to temporarily limit asyncio until we know whats going on
https://github.com/apache/airflow/pull/36037
--
This is an automated message from the Apache Git Service.
To respo
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 9845b40a75 Limit Pytest-asyncio to < 0.23.1 (#3603
eladkal merged PR #36037:
URL: https://github.com/apache/airflow/pull/36037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
potiuk opened a new pull request, #36038:
URL: https://github.com/apache/airflow/pull/36038
When Mypy runs its check it uses breeze image to do so, and by default on CI
the images are built using `main` version of scripts/ci and workflow files.
This basically means that running static check
potiuk commented on PR #36038:
URL: https://github.com/apache/airflow/pull/36038#issuecomment-1837631634
This is the reason why static-checks failed in
https://github.com/apache/airflow/actions/runs/7079666979/job/19266644846
--
This is an automated message from the Apache Git Service.
To
potiuk commented on code in PR #36022:
URL: https://github.com/apache/airflow/pull/36022#discussion_r1413236122
##
docs/apache-airflow/security/security_model.rst:
##
@@ -97,10 +97,74 @@ capabilities authenticated users may have:
For more information on the capabilities of au
github-actions[bot] commented on PR #35045:
URL: https://github.com/apache/airflow/pull/35045#issuecomment-1837652809
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
Raul824 opened a new issue, #36039:
URL: https://github.com/apache/airflow/issues/36039
### Apache Airflow version
Other Airflow 2 version (please specify below)
### What happened
We have setup retry in case of failures and disconnects on individual task.
Some tasks ar
potiuk opened a new pull request, #36040:
URL: https://github.com/apache/airflow/pull/36040
Seems that the pytest-asyncio problem was already introduced by 0.23.0. In
order to allow tests passing now, we should limit it to below that version
(follow up after #36037)
potiuk commented on PR #36040:
URL: https://github.com/apache/airflow/pull/36040#issuecomment-1837710866
Yes. Confirmed that <0.23.0 solves the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhangw commented on issue #35998:
URL: https://github.com/apache/airflow/issues/35998#issuecomment-1837725670
> What you see is likely effect of serialization how it was implemented 2.5
years ago - with thousands of bug fixes released since - including tens of them
released in the 2.1 line
josh-fell commented on issue #29267:
URL: https://github.com/apache/airflow/issues/29267#issuecomment-1837734706
I was hoping for exactly this functionality when writing docs for something
else, but alas. Thanks for logging this @BasPH!
After digging into this, `sphinx-tabs` unfortuna
Raul824 commented on issue #36039:
URL: https://github.com/apache/airflow/issues/36039#issuecomment-1837787630
Below is the snippet of another such instance.
All tasks in a task group are sequential with trigger rule all_success.
max active run of dag is 1 and depends on past is true.
josh-fell opened a new pull request, #36041:
URL: https://github.com/apache/airflow/pull/36041
This PR introduces the
[`sphinx-design`](https://sphinx-design.readthedocs.io/en/alabaster-theme/index.html)
extension which provides numerous UX components such as tabs, cards, and
dropdowns for
josh-fell commented on code in PR #36041:
URL: https://github.com/apache/airflow/pull/36041#discussion_r1413336125
##
docs/apache-airflow/howto/operator/python.rst:
##
Review Comment:
Happy to yank this from the PR, but I wanted to show a core example of what
this new exte
josh-fell commented on PR #36041:
URL: https://github.com/apache/airflow/pull/36041#issuecomment-1837798322
An example of using tabs to display both the TaskFlow API and operator-style
in the Python how-to doc:
https://github.com/apache/airflow/assets/48934154/a70726b9-f693-4d6b-b4e0
josh-fell commented on code in PR #36041:
URL: https://github.com/apache/airflow/pull/36041#discussion_r1413336125
##
docs/apache-airflow/howto/operator/python.rst:
##
Review Comment:
Happy to yank this from the PR, but I wanted to show a core example of what
this new exte
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new cc2521cf6c Limit pytest-asyncio even more - to <0.
eladkal merged PR #36040:
URL: https://github.com/apache/airflow/pull/36040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
eladkal closed issue #36039: Retry even after task was success
URL: https://github.com/apache/airflow/issues/36039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
pankajkoti commented on code in PR #36022:
URL: https://github.com/apache/airflow/pull/36022#discussion_r1413427589
##
docs/apache-airflow/security/security_model.rst:
##
@@ -67,40 +81,134 @@ scoped as tightly as a single DAG, for example, or as
broad as Admin.
Below are four
ephraimbuddy commented on code in PR #36014:
URL: https://github.com/apache/airflow/pull/36014#discussion_r1413457151
##
airflow/providers/openai/hooks/openai.py:
##
@@ -41,13 +42,9 @@ class OpenAIHook(BaseHook):
def __init__(self, conn_id: str = default_conn_name, *args: A
ephraimbuddy commented on code in PR #36014:
URL: https://github.com/apache/airflow/pull/36014#discussion_r1413467526
##
airflow/providers/openai/hooks/openai.py:
##
@@ -57,21 +54,25 @@ def get_ui_field_behaviour() -> dict[str, Any]:
def test_connection(self) -> tuple[boo
70 matches
Mail list logo
