Re: [PR] Minor fix to DataprocCreateClusterOperator operator docs. [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36322: URL: https://github.com/apache/airflow/pull/36322#discussion_r1432376369 ## airflow/providers/google/cloud/operators/dataproc.py: ## @@ -425,9 +425,8 @@ class DataprocCreateClusterOperator(GoogleCloudBaseOperator): The operator will w

Re: [PR] Remove notifiers compatibility note [airflow]

2023-12-20 Thread via GitHub
uranusjr commented on PR #36323: URL: https://github.com/apache/airflow/pull/36323#issuecomment-1864035714 Maybe they can be reformatted to be not important, but I think we should still keep a note. Most software documentation does keep this kind of notes since it is very easy for users to

[PR] Remove remaining Airflow 2.6 backcompat code from Amazon Provider [airflow]

2023-12-20 Thread via GitHub
Taragolis opened a new pull request, #36324: URL: https://github.com/apache/airflow/pull/36324 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideline

Re: [PR] Remove notifiers compatibility note [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36323: URL: https://github.com/apache/airflow/pull/36323#issuecomment-1864060954 > Maybe they can be reformatted to be not important, but I think we should still keep a note. Most software documentation does keep this kind of notes since it is very easy for users

(airflow) branch constraints-main updated: Updating constraints. Github run id:7272325231

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 90f59d0fd5 Updating con

Re: [PR] Remove notifiers compatibility note [airflow]

2023-12-20 Thread via GitHub
Taragolis commented on PR #36323: URL: https://github.com/apache/airflow/pull/36323#issuecomment-1864095959 I think it better to remove for consistency between providers - Not in all providers we have this importance note, only in this 4 providers, all other listed [here](https://airflow

Re: [PR] DOC multiple vault mount points [airflow]

2023-12-20 Thread via GitHub
Taragolis commented on code in PR #36313: URL: https://github.com/apache/airflow/pull/36313#discussion_r1432444159 ## docs/apache-airflow-providers-hashicorp/secrets-backends/hashicorp-vault.rst: ## @@ -214,3 +214,31 @@ Add "verify": "absolute path to ca-certificate file" [

Re: [PR] Remove notifiers compatibility note [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36323: URL: https://github.com/apache/airflow/pull/36323#issuecomment-1864118856 > It is good point to improve our Core documentation for Notifiers, e.g. there is only this [page](https://airflow.apache.org/docs/apache-airflow/stable/howto/notifications.html) in How

Re: [I] DAG Run Grid View: Run Id not updated consistently [airflow]

2023-12-20 Thread via GitHub
Taragolis closed issue #36320: DAG Run Grid View: Run Id not updated consistently URL: https://github.com/apache/airflow/issues/36320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [I] DAG Run Grid View: Run Id not updated consistently [airflow]

2023-12-20 Thread via GitHub
Taragolis commented on issue #36320: URL: https://github.com/apache/airflow/issues/36320#issuecomment-1864121005 Duplicate of: - https://github.com/apache/airflow/issues/34846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Task ID copy button copying wrong ID [airflow]

2023-12-20 Thread via GitHub
AchimGaedkeLynker commented on issue #34846: URL: https://github.com/apache/airflow/issues/34846#issuecomment-1864123222 Any chance resolving this soon? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] DOC multiple vault mount points [airflow]

2023-12-20 Thread via GitHub
Taragolis commented on code in PR #36313: URL: https://github.com/apache/airflow/pull/36313#discussion_r1432462853 ## docs/apache-airflow-providers-hashicorp/secrets-backends/hashicorp-vault.rst: ## @@ -214,3 +214,31 @@ Add "verify": "absolute path to ca-certificate file" [

Re: [I] In cli "airflow roles export / import" : add the permissions to the json file processed. [airflow]

2023-12-20 Thread via GitHub
dominikhei commented on issue #36128: URL: https://github.com/apache/airflow/issues/36128#issuecomment-1864158574 Hey @gbonazzoli @potiuk I have thought about a possible structure for the exported and imported json. We could maybe follow a structure similar to the ``airflow roles lis

Re: [PR] [WIP] Mapping tasks from ObjectStoragePath [airflow]

2023-12-20 Thread via GitHub
uranusjr commented on PR #36319: URL: https://github.com/apache/airflow/pull/36319#issuecomment-1864169783 Doing this on a path feels a bit wrong since a path doesn’t inheritly hold any information on the thing it points to. Bolke and I were discussing we need something on top of path that

(airflow) branch main updated: Remove remaining Airflow 2.6 backcompat code from Amazon Provider (#36324)

2023-12-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2b31f373ef Remove remaining Airflow 2.6 backcompat

Re: [PR] Remove remaining Airflow 2.5 backcompat code from Amazon Provider [airflow]

2023-12-20 Thread via GitHub
potiuk merged PR #36324: URL: https://github.com/apache/airflow/pull/36324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Remove remaining Airflow 2.5 backcompat code from Docker Provider [airflow]

2023-12-20 Thread via GitHub
Taragolis opened a new pull request, #36325: URL: https://github.com/apache/airflow/pull/36325 We could remove backompat code with previous version of Airflow since Docker provider has minimum Airflow 2.6 requirement --- **^ Add meaningful description above**

[I] Task hostname does not reflect pod name when it's too long [airflow]

2023-12-20 Thread via GitHub
csp33 opened a new issue, #36326: URL: https://github.com/apache/airflow/issues/36326 ### Apache Airflow version 2.8.0 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When a task has a long name (or it's inside one or m

Re: [PR] Add openlineage docs ext with list of supported operators and hooks [airflow]

2023-12-20 Thread via GitHub
uranusjr commented on code in PR #36311: URL: https://github.com/apache/airflow/pull/36311#discussion_r1432521695 ## docs/exts/operators_and_hooks_ref.py: ## @@ -215,6 +215,136 @@ def _render_deferrable_operator_content(*, header_separator: str): return _render_template("d

Re: [PR] Fix broken regex for allowed_deserialization_classes [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36147: URL: https://github.com/apache/airflow/pull/36147#issuecomment-1864240921 I rebased your PR. There were some changes to auth-manager docs structure recently and it works in the way that if you have not rebased, such changes in document structure might cause d

Re: [PR] Fix broken regex for allowed_deserialization_classes [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36147: URL: https://github.com/apache/airflow/pull/36147#issuecomment-1864241872 Generally - as a rule - if you see unrelated error, rebase to see if this is not a result of being behind `main` -- This is an automated message from the Apache Git Service. To respond

[I] Airflow db Migrate does not work [airflow]

2023-12-20 Thread via GitHub
aipatr opened a new issue, #36327: URL: https://github.com/apache/airflow/issues/36327 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.7.3 ### What happened? I try to run airfl

(airflow) branch constraints-main updated: Updating constraints. Github run id:7273850443

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new bf5d3400d4 Updating con

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
sunank200 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432565232 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -396,10 +400,25 @@ def batch_data( .. seealso:: `batch_config_params options

Re: [I] Airflow db Migrate does not work [airflow]

2023-12-20 Thread via GitHub
Taragolis closed issue #36327: Airflow db Migrate does not work URL: https://github.com/apache/airflow/issues/36327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
sunank200 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432587544 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -606,3 +627,220 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool: """ client

Re: [PR] DOC multiple vault mount points [airflow]

2023-12-20 Thread via GitHub
Taragolis merged PR #36313: URL: https://github.com/apache/airflow/pull/36313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: DOC multiple vault mount points (#36313)

2023-12-20 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b9c38c6b18 DOC multiple vault mount points (#363

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
utkarsharma2 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432600126 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -606,3 +636,303 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool: """ cli

[PR] Document the missing website permission [airflow]

2023-12-20 Thread via GitHub
pankajastro opened a new pull request, #36329: URL: https://github.com/apache/airflow/pull/36329 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideli

Re: [PR] Suppress false warning when TI state is QUEUED and TI doesn't have a start_date [airflow]

2023-12-20 Thread via GitHub
kzosabe commented on code in PR #34771: URL: https://github.com/apache/airflow/pull/34771#discussion_r1432601056 ## airflow/jobs/scheduler_job_runner.py: ## @@ -614,6 +614,11 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session) - )

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
utkarsharma2 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432602242 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -606,3 +636,303 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool: """ cli

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
utkarsharma2 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432604634 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -606,3 +636,303 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool: """ cli

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
utkarsharma2 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432604190 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -606,3 +636,303 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool: """ cli

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
utkarsharma2 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432606758 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -606,3 +636,303 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool: """ cli

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
utkarsharma2 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432609855 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -606,3 +627,220 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool: """ cli

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-20 Thread via GitHub
utkarsharma2 commented on code in PR #36177: URL: https://github.com/apache/airflow/pull/36177#discussion_r1432609855 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -606,3 +627,220 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool: """ cli

[PR] minor Amazon provider improvements [airflow]

2023-12-20 Thread via GitHub
Lee-W opened a new pull request, #36330: URL: https://github.com/apache/airflow/pull/36330 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**

Re: [I] [google-cloud-transfers] Object of type MappedArgument is not JSON serializable [airflow]

2023-12-20 Thread via GitHub
arsunny commented on issue #31481: URL: https://github.com/apache/airflow/issues/31481#issuecomment-1864346406 Do we have any update on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [google-cloud-transfers] Object of type MappedArgument is not JSON serializable [airflow]

2023-12-20 Thread via GitHub
potiuk commented on issue #31481: URL: https://github.com/apache/airflow/issues/31481#issuecomment-1864370830 @arsunny -> evidently not and it waits for someone to pick it up. Would you llke to take on the task ? -- This is an automated message from the Apache Git Service. To respond to

(airflow) branch constraints-main updated: Updating constraints. Github run id:7274642101

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 0208770521 Updating con

Re: [PR] Remove remaining Airflow 2.5 backcompat code from Docker Provider [airflow]

2023-12-20 Thread via GitHub
potiuk merged PR #36325: URL: https://github.com/apache/airflow/pull/36325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Remove remaining Airflow 2.5 backcompat code from Docker Provider (#36325)

2023-12-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1fa18cb974 Remove remaining Airflow 2.5 backcompat

[PR] Add docs about extending the Airflow helm chart [airflow]

2023-12-20 Thread via GitHub
shohamy7 opened a new pull request, #36331: URL: https://github.com/apache/airflow/pull/36331 --- This PR add docs about how users can extend the Airflow chart easily. Writing this doc was suggested by @potiuk in the following (closed) PR: #36294 This

Re: [PR] Add docs about extending the Airflow helm chart [airflow]

2023-12-20 Thread via GitHub
shohamy7 commented on PR #36331: URL: https://github.com/apache/airflow/pull/36331#issuecomment-1864398756 @potiuk please review, would like to here what you think :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Make databricks sql hook return a namedtuple [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1864404466 @bolkedebruin - would love to get this one out :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Add docs about extending the Airflow helm chart [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36331: URL: https://github.com/apache/airflow/pull/36331#issuecomment-1864407941 I am all for merging it as-is and then adding incrementally some examples later :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] MYSQL fails to install due to incorrect GPG Key [airflow]

2023-12-20 Thread via GitHub
thewriteway commented on issue #36231: URL: https://github.com/apache/airflow/issues/36231#issuecomment-1864418498 > gpg --keyserver pgp.mit.edu --recv-keys B7B3B788A8D3785C \ > && gpg --export B7B3B788A8D3785C > "/etc/apt/trusted.gpg.d/mysql.gpg" pgp.mit.edu has been deco

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
dirrao commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864449351 Hi @llamageddon83, @droppoint, We are facing this similar issue more often. Here is the another ticket for the same #35675. I have created the MR for avoiding the executor open s

Re: [I] MYSQL fails to install due to incorrect GPG Key [airflow]

2023-12-20 Thread via GitHub
potiuk commented on issue #36231: URL: https://github.com/apache/airflow/issues/36231#issuecomment-1864452812 Any - look it up in comments. I think most people in the discussions above (including Airlfow image) use `keyserver.ubuntu.com` and fallback to `pgp.surf.nl` - but look it up in gen

(airflow) branch constraints-main updated: Updating constraints. Github run id:7275375623

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 156e47944d Updating con

Re: [PR] openlineage, aws: add OpenLineage support for Redshift SQL. [airflow]

2023-12-20 Thread via GitHub
JDarDagran commented on PR #35794: URL: https://github.com/apache/airflow/pull/35794#issuecomment-1864483777 Pinging @o-nikolas then :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Draft: Enable setting up pool for dynamic tasks [airflow]

2023-12-20 Thread via GitHub
AVMusorin closed pull request #35611: Draft: Enable setting up pool for dynamic tasks URL: https://github.com/apache/airflow/pull/35611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Make pod_name length equal to HOST_NAME_MAX [airflow]

2023-12-20 Thread via GitHub
csp33 opened a new pull request, #36332: URL: https://github.com/apache/airflow/pull/36332 Closes #36326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
droppoint commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864543583 @dirrao This is cool, but I already submitted PR #35800 almost a month ago. I think we are fixing different problems. Your PR addresses the issue when adoption is performed on a

[PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk opened a new pull request, #36333: URL: https://github.com/apache/airflow/pull/36333 Since we are getting more diagrams generated in Airflow using the "diagram as a code" approach, this PR improves the pre-commit to be more suitable to support generation of more of the images coming

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36333: URL: https://github.com/apache/airflow/pull/36333#issuecomment-1864555117 This one should set us on a path where we should be able to convert pretty much all our architecture-like-diagrams to diagrams as a code approach easily. It also allows to iterate

Re: [I] MYSQL fails to install due to incorrect GPG Key [airflow]

2023-12-20 Thread via GitHub
Taragolis commented on issue #36231: URL: https://github.com/apache/airflow/issues/36231#issuecomment-1864585666 https://github.com/apache/airflow/blob/43acc4ffbd97bcdaf7c4c0b47921beea72aa5bf1/scripts/docker/common.sh#L92-L100 -- This is an automated message from the Apache Git Service. T

Re: [PR] Fix `sentinel_kwargs` load from ENV [airflow]

2023-12-20 Thread via GitHub
vaaalik commented on PR #36318: URL: https://github.com/apache/airflow/pull/36318#issuecomment-1864594783 Added test to check that config is loaded from a string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-12-20 Thread via GitHub
droppoint commented on code in PR #35800: URL: https://github.com/apache/airflow/pull/35800#discussion_r1432808345 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -642,39 +641,6 @@ def adopt_launched_task( del tis_to_flush_by_key[ti_key]

Re: [I] Commit failed: Local: No offset stored while using AwaitMessageTriggerFunctionSensor [airflow]

2023-12-20 Thread via GitHub
timonviola commented on issue #32585: URL: https://github.com/apache/airflow/issues/32585#issuecomment-1864614787 Hello, I can confirm that it fixes the issue. Thanks @hussein-awala . I can also trigger the error again by: 1. reverting your fix 2. adding `"enable.auto.offset.stor

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
josh-fell commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432833345 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFL

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
potiuk commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864638111 > P.S. Can you share the secret of how you managed to get a review from the maintainer so fast? I can share a secret. Be kind, be considerate, but also ... be persistent. The

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
potiuk commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864638561 I will ping in `development` again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Kubernetes executor running slots leak fix [airflow]

2023-12-20 Thread via GitHub
potiuk merged PR #36240: URL: https://github.com/apache/airflow/pull/36240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
potiuk closed issue #32928: Airflow progressive slowness URL: https://github.com/apache/airflow/issues/32928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

(airflow) branch main updated: Kubernetes executor running slots leak fix (#36240)

2023-12-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 49108e15eb Kubernetes executor running slots leak f

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #35800: URL: https://github.com/apache/airflow/pull/35800#issuecomment-1864650545 Hey @hussein-awala @dstandish -> would love to get that one merged, maybe you two can take a look. I will **just** be relasing also cncf.k8s provider I think, and I think together with #

[I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
llamageddon83 opened a new issue, #32928: URL: https://github.com/apache/airflow/issues/32928 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened We are running Airflow on EKS with version 2.5.3. Airflow has been experiencing progr

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
potiuk commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864652858 Reopening as the #35800 seems to also address part of the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
ephraimbuddy commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864656976 Did the PR actually fixed this issue? I think we need to benchmark it before closing. We have seen this issue with celery and the PR was on kubernetes -- This is an automat

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
dirrao commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864668705 I see multiple issues are reported in the same issue. We might need to create separate issue for Celery executor. -- This is an automated message from the Apache Git Service. To r

Re: [I] In cli "airflow roles export / import" : add the permissions to the json file processed. [airflow]

2023-12-20 Thread via GitHub
gbonazzoli commented on issue #36128: URL: https://github.com/apache/airflow/issues/36128#issuecomment-1864676396 @dominikhei I'm not a developer but it seems to me that if you can export and produce a file with that syntax and re-import it without having any trouble and reproduce th

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432870706 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFLOW_

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432872570 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFLOW_

(airflow) branch constraints-main updated: Updating constraints. Github run id:7277276962

2023-12-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 47b73c5c31 Updating con

Re: [PR] Minor fix to DataprocCreateClusterOperator operator docs. [airflow]

2023-12-20 Thread via GitHub
potiuk merged PR #36322: URL: https://github.com/apache/airflow/pull/36322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (10c4c352f9 -> e718395714)

2023-12-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 10c4c352f9 Minor fix to DataprocCreateClusterOperator operator docs. (#36322) add e718395714 Remove notifiers com

(airflow) branch main updated: Minor fix to DataprocCreateClusterOperator operator docs. (#36322)

2023-12-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 10c4c352f9 Minor fix to DataprocCreateClusterOperat

Re: [PR] Remove notifiers compatibility note [airflow]

2023-12-20 Thread via GitHub
potiuk merged PR #36323: URL: https://github.com/apache/airflow/pull/36323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] In cli "airflow roles export / import" : add the permissions to the json file processed. [airflow]

2023-12-20 Thread via GitHub
potiuk commented on issue #36128: URL: https://github.com/apache/airflow/issues/36128#issuecomment-1864788438 This looks good. And re "existing" role - we want to make it simple, any complex merging should be avoided. Generally speaking deleting a role when it exists an is being imported is

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
vincbeck commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432938003 ## docs/apache-airflow-providers-fab/img/diagram_fab_auth_manager_airflow_architecture.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) un

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
potiuk commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864794389 Yeah. I think there could be many similar behaviours for various reasons. I think we should keep on getting info from people reporting similar issues after upgrading to latest versi

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432946851 ## docs/apache-airflow-providers-fab/img/diagram_fab_auth_manager_airflow_architecture.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432950398 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFLOW_

Re: [I] Airflow progressive slowness [airflow]

2023-12-20 Thread via GitHub
dirrao commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1864809538 I have created a new issue #36335 for celery executor. Let's keep this for Kubernetes executor. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Move config related to FAB auth manager to FAB provider [airflow]

2023-12-20 Thread via GitHub
vincbeck commented on PR #36232: URL: https://github.com/apache/airflow/pull/36232#issuecomment-1864820024 > check_spelling I dont see a `build_errors` in `check_spelling` 👀 . I am now away until next year so I'll continue playing around then unless someone else solves it -- This

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
vincbeck commented on PR #36333: URL: https://github.com/apache/airflow/pull/36333#issuecomment-1864823858 Feel free to merge without my approval (I am now away until next year) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add docs about extending the Airflow helm chart [airflow]

2023-12-20 Thread via GitHub
pankajkoti commented on code in PR #36331: URL: https://github.com/apache/airflow/pull/36331#discussion_r1432964560 ## docs/helm-chart/extending-the-chart.rst: ## @@ -0,0 +1,124 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license a

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432996058 ## CONTRIBUTING.rst: ## @@ -981,6 +981,58 @@ Documentation for ``apache-airflow`` package and other packages that are closely providers packages are in ``/docs/`` di

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432996475 ## docs/apache-airflow-providers-fab/img/diagram_fab_auth_manager_airflow_architecture.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on code in PR #36333: URL: https://github.com/apache/airflow/pull/36333#discussion_r1432996303 ## scripts/ci/pre_commit/pre_commit_generate_airflow_diagrams.py: ## @@ -34,201 +30,28 @@ AIRFLOW_SOURCES_ROOT = Path(__file__).parents[3] DOCS_IMAGES_DIR = AIRFLOW_

Re: [PR] Improve pre-commit to generate Airflow diagrams as a code [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36333: URL: https://github.com/apache/airflow/pull/36333#issuecomment-1864867072 > Feel free to merge without my approval (I am now away until next year) Have good holidays :) -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Make node color more visible in UI and increase font size [airflow]

2023-12-20 Thread via GitHub
bbovenzi commented on PR #36316: URL: https://github.com/apache/airflow/pull/36316#issuecomment-1864868644 Could you a screenshot of how this looks with a dag run selected with task states? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] In cli "airflow roles export / import" : add the permissions to the json file processed. [airflow]

2023-12-20 Thread via GitHub
dominikhei commented on issue #36128: URL: https://github.com/apache/airflow/issues/36128#issuecomment-1864877183 > This looks good. And re "existing" role - we want to make it simple, any complex merging should be avoided. Generally speaking deleting a role when it exists an is being impor

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-12-20 Thread via GitHub
dirrao commented on code in PR #35800: URL: https://github.com/apache/airflow/pull/35800#discussion_r1432987474 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -642,38 +642,37 @@ def adopt_launched_task( del tis_to_flush_by_key[ti_key]

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-12-20 Thread via GitHub
dirrao commented on code in PR #35800: URL: https://github.com/apache/airflow/pull/35800#discussion_r1432987474 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -642,38 +642,37 @@ def adopt_launched_task( del tis_to_flush_by_key[ti_key]

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-12-20 Thread via GitHub
dirrao commented on PR #35800: URL: https://github.com/apache/airflow/pull/35800#issuecomment-1864888787 > Nice findings. Looks promising. Thanks for that. > > Ok here's another scenario. > > The task OOMs and therefore cannot report its state by itself. I believe in this

Re: [PR] Limit pod_name length to HOST_NAME_MAX [airflow]

2023-12-20 Thread via GitHub
potiuk commented on PR #36332: URL: https://github.com/apache/airflow/pull/36332#issuecomment-1864902100 How do you plan to tackle backwards compatibilty. Imagine you are upgrading Airflow and thera are long running Pods still running being adopted by the new Airflow with limited length/ Wh

Re: [PR] Attempt to update Connexion library to version 3 [airflow]

2023-12-20 Thread via GitHub
VladaZakharova commented on PR #36052: URL: https://github.com/apache/airflow/pull/36052#issuecomment-1864958699 Thank you everyone who is involved! :) I have updated the code and Gunicorn command as it was suggested by @RobbeSneyders in his PR (thank you, great job!) I have also adde

  1   2   >