bolkedebruin commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1435997508
##
airflow/io/path.py:
##
@@ -173,10 +176,14 @@ def bucket(self) -> str:
@property
def key(self) -> str:
if self._url:
-return sel
shohamy7 commented on code in PR #36413:
URL: https://github.com/apache/airflow/pull/36413#discussion_r1435990659
##
airflow/providers/apache/kylin/hooks/kylin.py:
##
@@ -32,6 +32,11 @@ class KylinHook(BaseHook):
:param dsn: dsn
"""
+conn_name_attr = "kylin_conn_
eladkal commented on PR #36374:
URL: https://github.com/apache/airflow/pull/36374#issuecomment-1868770241
> The mentioned issue mentions #30264 as a potential use case, but this PR
will not close it
That was my edit to the description.
If you are OK with it I think we can keep
uranusjr commented on PR #36410:
URL: https://github.com/apache/airflow/pull/36410#issuecomment-1868760665
cc @mobuchowski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
eladkal commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1868760316
Lets wait for a fix in upstream first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uranusjr commented on code in PR #36374:
URL: https://github.com/apache/airflow/pull/36374#discussion_r1435960507
##
airflow/models/taskinstance.py:
##
@@ -2361,6 +2361,8 @@ def _run_raw_task(
self.log.info(e)
if not test_mode:
uranusjr commented on code in PR #34168:
URL: https://github.com/apache/airflow/pull/34168#discussion_r1435959772
##
airflow/utils/dag_parameters_overflow.py:
##
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
dirrao commented on issue #36188:
URL: https://github.com/apache/airflow/issues/36188#issuecomment-1868745845
I think we can publish the current number of running parsing processors as a
gauge. I see it being updated if there is a new processor added or
stopped/terminated.
--
This is an
dirrao commented on code in PR #36413:
URL: https://github.com/apache/airflow/pull/36413#discussion_r1435945869
##
airflow/providers/apache/kylin/hooks/kylin.py:
##
@@ -32,6 +32,11 @@ class KylinHook(BaseHook):
:param dsn: dsn
"""
+conn_name_attr = "kylin_conn_id
dirrao commented on code in PR #36413:
URL: https://github.com/apache/airflow/pull/36413#discussion_r1435946213
##
airflow/providers/apache/kylin/hooks/kylin.py:
##
@@ -32,6 +32,11 @@ class KylinHook(BaseHook):
:param dsn: dsn
"""
+conn_name_attr = "kylin_conn_id
dirrao commented on code in PR #36413:
URL: https://github.com/apache/airflow/pull/36413#discussion_r1435945869
##
airflow/providers/apache/kylin/hooks/kylin.py:
##
@@ -32,6 +32,11 @@ class KylinHook(BaseHook):
:param dsn: dsn
"""
+conn_name_attr = "kylin_conn_id
This is an automated email from the ASF dual-hosted git repository.
joshfell pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 22654fa2f6 Use cards when describing priority wei
josh-fell merged PR #36411:
URL: https://github.com/apache/airflow/pull/36411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
github-actions[bot] closed pull request #34071: Databricks ClusteState &
Clsuter GET API
URL: https://github.com/apache/airflow/pull/34071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
github-actions[bot] commented on PR #34168:
URL: https://github.com/apache/airflow/pull/34168#issuecomment-1868619379
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] closed pull request #32786: Add TabularVttsSensor
URL: https://github.com/apache/airflow/pull/32786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
hussein-awala commented on PR #36374:
URL: https://github.com/apache/airflow/pull/36374#issuecomment-1868617680
The mentioned issue mentions #30264 as a potential use case, but this PR
will not close it, because the running tasks are marked as skipped without
raising any skip exception:
o-nikolas commented on PR #36236:
URL: https://github.com/apache/airflow/pull/36236#issuecomment-1868615116
> ah this will involve setting up the third party system config to run the
test right.. I completely forgot about that part and I don't have an account
personally to up and run these
yo1956 commented on code in PR #36401:
URL: https://github.com/apache/airflow/pull/36401#discussion_r1435892468
##
airflow/www/app.py:
##
@@ -75,6 +75,9 @@ def create_app(config=None, testing=False):
flask_app.config["PERMANENT_SESSION_LIFETIME"] =
timedelta(minutes=sett
hussein-awala commented on code in PR #36401:
URL: https://github.com/apache/airflow/pull/36401#discussion_r1435891375
##
airflow/www/app.py:
##
@@ -75,6 +75,9 @@ def create_app(config=None, testing=False):
flask_app.config["PERMANENT_SESSION_LIFETIME"] =
timedelta(minut
This is an automated email from the ASF dual-hosted git repository.
husseinawala pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from a3b3a6e0c8 Remove redundant `docker` decorator parameters in
documentation (#36407)
add 8af6368364 Make `ku
hussein-awala merged PR #36405:
URL: https://github.com/apache/airflow/pull/36405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ai
This is an automated email from the ASF dual-hosted git repository.
husseinawala pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new a3b3a6e0c8 Remove redundant `docker` decorato
hussein-awala merged PR #36407:
URL: https://github.com/apache/airflow/pull/36407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ai
This is an automated email from the ASF dual-hosted git repository.
husseinawala pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new e3fd0d1a98 Remove redundant `docker` decorato
hussein-awala merged PR #36406:
URL: https://github.com/apache/airflow/pull/36406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ai
hussein-awala commented on code in PR #36410:
URL: https://github.com/apache/airflow/pull/36410#discussion_r1435889890
##
airflow/io/path.py:
##
@@ -52,6 +52,9 @@ def __init__(
conn_id: str | None = None,
**kwargs: typing.Any,
) -> None:
+# warning
shohamy7 commented on issue #28790:
URL: https://github.com/apache/airflow/issues/28790#issuecomment-1868604302
Hi @Taragolis
Looks like WebHDFSHook has been resolved in #36145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
shohamy7 opened a new pull request, #36413:
URL: https://github.com/apache/airflow/pull/36413
---
Related: #28790
This PR adds connection type of Apache Kylin and add docs about the
connection
**^ Add meaningful description above**
Read the **[Pull
uranusjr commented on code in PR #36281:
URL: https://github.com/apache/airflow/pull/36281#discussion_r1435885636
##
airflow/providers/cncf/kubernetes/pod_launcher_deprecated.py:
##
@@ -148,13 +148,13 @@ def monitor_pod(self, pod: V1Pod, get_logs: bool) ->
tuple[State, str | No
uranusjr commented on code in PR #36281:
URL: https://github.com/apache/airflow/pull/36281#discussion_r1435885656
##
airflow/serialization/serialized_objects.py:
##
@@ -167,9 +168,9 @@ def encode_timezone(var: Timezone) -> str | int:
)
-def decode_timezone(var: str | in
shohamy7 opened a new pull request, #36412:
URL: https://github.com/apache/airflow/pull/36412
Related: #28790
This PR adds documentation about the `LivyHook`.
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://g
josh-fell commented on PR #36411:
URL: https://github.com/apache/airflow/pull/36411#issuecomment-1868587907
**Before**
https://github.com/apache/airflow/assets/48934154/fdc062ef-cf05-4ee8-a5f8-d9562ee65b82";>
**After**
https://github.com/apache/airflow/assets/48934154/b07c5db5-2e
josh-fell opened a new pull request, #36411:
URL: https://github.com/apache/airflow/pull/36411
This PR is a a small facelift to improve the readability of the Priority
Weights doc. Instead of using a bulleted list to outline and describe the
different weighting methods, let's use a cards vi
josh-fell commented on issue #36384:
URL: https://github.com/apache/airflow/issues/36384#issuecomment-1868584576
#36198 and #36262 verified in packaged files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
bolkedebruin commented on PR #36410:
URL: https://github.com/apache/airflow/pull/36410#issuecomment-1868580098
should I just add openlineage to the list to 'always' test @potiuk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
bolkedebruin commented on PR #35972:
URL: https://github.com/apache/airflow/pull/35972#issuecomment-1868579179
We *did* mark AFS as experimental right? So, in theory we could be a bit
more daring in not doing backwards compatibility?
--
This is an automated message from the Apache Git Ser
bolkedebruin opened a new pull request, #36410:
URL: https://github.com/apache/airflow/pull/36410
This adds low level support for open lineage to ObjectStorage and integrates
it into common.io.
---
**^ Add meaningful description above**
Read the **[Pu
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 6199f1ffc8 Update metrics.rst for param dagrun.sche
potiuk closed issue #33426: Statsd metrics dagrun.schedule_delay sends time in
different format against the seconds specified in docs
URL: https://github.com/apache/airflow/issues/33426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
potiuk merged PR #36404:
URL: https://github.com/apache/airflow/pull/36404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on issue #36384:
URL: https://github.com/apache/airflow/issues/36384#issuecomment-1868552590
BTW. Happy Holidays everyone ! - this one will continue after 26th of
December 🎄
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
potiuk commented on issue #36384:
URL: https://github.com/apache/airflow/issues/36384#issuecomment-1868552426
I think there are some main changes that influence that - I already saw one
change while I was testing Python Client
https://github.com/apache/airflow/issues/36377 - but it works fi
dirrao commented on PR #36401:
URL: https://github.com/apache/airflow/pull/36401#issuecomment-1868548193
> Thank you for your comment.
>
> > How about triggering a DAG with input configuration?
>
> Sorry, what does this mean?
>
> > Does it require more than 1MB?
>
yo1956 commented on PR #36401:
URL: https://github.com/apache/airflow/pull/36401#issuecomment-1868539949
Thank you for your comment.
> How about triggering a DAG with input configuration?
Sorry, what does this mean?
> Does it require more than 1MB?
I'm not really
vchiapaikeo commented on issue #36384:
URL: https://github.com/apache/airflow/issues/36384#issuecomment-1868524593
Has anyone noticed unusual behavior with the DagFileProcessor lately? I've
observed some unusual behavior where a relatively simple dag is continually
getting removed and added
jayceslesar commented on PR #36393:
URL: https://github.com/apache/airflow/pull/36393#issuecomment-1868524094
Thank you for the example!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 3f60482974 Don't get pod status in KubernetesPodOpe
potiuk merged PR #36355:
URL: https://github.com/apache/airflow/pull/36355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on issue #36408:
URL: https://github.com/apache/airflow/issues/36408#issuecomment-1868503517
We could for example use `stubgen` from mypy and compare the generated .pyi
files AST (whil we remove the things we want to remove from .pyI). That would
force whoever addss stuff t
Taragolis commented on issue #36408:
URL: https://github.com/apache/airflow/issues/36408#issuecomment-1868502294
For provider's decorators it might be a good point to make it as part of
some release management commands rather than pre-commit, because such of
decorators is a part of provider
potiuk commented on PR #36405:
URL: https://github.com/apache/airflow/pull/36405#issuecomment-1868500278
Added https://github.com/apache/airflow/issues/36408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
potiuk commented on issue #36408:
URL: https://github.com/apache/airflow/issues/36408#issuecomment-1868500231
cc: @Taragolis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Taragolis commented on PR #36281:
URL: https://github.com/apache/airflow/pull/36281#issuecomment-1868499023
Seems like all major stuff are resolved, so this PR could be reviewed.
The only things are required is add is newsfragment file
--
This is an automated message from the Apache Git
Taragolis opened a new pull request, #36407:
URL: https://github.com/apache/airflow/pull/36407
Similar to #36406, but changes in docker provider documentation
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/a
Taragolis opened a new pull request, #36406:
URL: https://github.com/apache/airflow/pull/36406
This parameters are filled by `_DockerDecoratedOperator` so there is no way
to overwrite it/
---
**^ Add meaningful description above**
Read the **[Pull Request
Gu
Taragolis opened a new pull request, #36405:
URL: https://github.com/apache/airflow/pull/36405
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideline
Bowrna opened a new pull request, #36404:
URL: https://github.com/apache/airflow/pull/36404
The timer in statsd client if passed the timedelta, converts into
milliseconds rather than seconds.
---
**^ Add meaningful description above**
Read the **[Pull
potiuk commented on code in PR #36281:
URL: https://github.com/apache/airflow/pull/36281#discussion_r1435801808
##
.github/workflows/ci.yml:
##
@@ -1123,11 +1123,61 @@ jobs:
breeze testing db-tests
--parallel-test-types
"${{needs.build-info.outputs.paralle
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 97d2266b2d Add WeaviateDocumentIngestOperator (#364
potiuk merged PR #36402:
URL: https://github.com/apache/airflow/pull/36402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
romsharon98 commented on PR #36355:
URL: https://github.com/apache/airflow/pull/36355#issuecomment-1868482652
Looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on PR #36399:
URL: https://github.com/apache/airflow/pull/36399#issuecomment-1868481973
How about backwards compatibility ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 63544e184d Allow changing of `config_file` in
`Kub
potiuk closed pull request #34819: allow changing of config file from default
for the KubernetesResourceBaseOperator
URL: https://github.com/apache/airflow/pull/34819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
potiuk merged PR #36397:
URL: https://github.com/apache/airflow/pull/36397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
Taragolis closed issue #36386: AWS Provder Operators and Sensors Duplicate Code
URL: https://github.com/apache/airflow/issues/36386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
Taragolis commented on issue #36386:
URL: https://github.com/apache/airflow/issues/36386#issuecomment-1868480794
Ok, let's then close this one in favor or
https://github.com/apache/airflow/issues/35278.
If required something more than described in
https://github.com/apache/airflow/issue
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch pendulum-3
in repository https://gitbox.apache.org/repos/asf/airflow.git
discard 59e997338f Fix _run_test_command input
discard ccb2e4e76e Add backcompat to pendulum 2
discard 86cf110954 Ad
potiuk commented on PR #35337:
URL: https://github.com/apache/airflow/pull/35337#issuecomment-1868472273
Also - ther are quite a few comments on that PR already and generailly
author's task is to respond to them - either by confirming they agree with the
comments and applying them or discus
potiuk commented on PR #35337:
URL: https://github.com/apache/airflow/pull/35337#issuecomment-1868472037
But - as usual - it's totally and entirely on the author to take "care"
about their PR. rebase it when there are conflicts, fix tes cases, remind the
reviewers that it still needs review
Taragolis commented on PR #36393:
URL: https://github.com/apache/airflow/pull/36393#issuecomment-1868471926
And after that you could remove `test_hook_and_client` because it not
required anymore after that
--
This is an automated message from the Apache Git Service.
To respond to the mess
potiuk commented on PR #35337:
URL: https://github.com/apache/airflow/pull/35337#issuecomment-1868471282
> @potiuk @uranusjr as far as I understand, the Airflow team is not
interested in this feature?
Well. If someone was to write a PR which will be good, sound, passess all
the tests
Taragolis commented on PR #36393:
URL: https://github.com/apache/airflow/pull/36393#issuecomment-1868470176
It could be something like that.
```python
with mock.patch.object(EcsBaseOperator, "hook",
new_callable=mock.PropertyMock) as m:
mocked_hook = mock.Mag
Lee-W commented on PR #36341:
URL: https://github.com/apache/airflow/pull/36341#issuecomment-1868466527
> FYI We might get better impersonation support in gcloud-aio soon. :)
[talkiq/gcloud-aio#665](https://github.com/talkiq/gcloud-aio/pull/665)
This looks great! Should we use the cur
75 matches
Mail list logo
