Re: [PR] Fix assignment of template field in `__init__` in `container_instances.py` [airflow]

2024-01-03 Thread via GitHub
dirrao commented on code in PR #36529: URL: https://github.com/apache/airflow/pull/36529#discussion_r1440167500 ## airflow/providers/microsoft/azure/operators/container_instances.py: ## @@ -151,7 +151,7 @@ def __init__( self.ci_conn_id = ci_conn_id self.resou

Re: [PR] Fix assignment of template field in `__init__` in `container_instances.py` [airflow]

2024-01-03 Thread via GitHub
dirrao commented on code in PR #36529: URL: https://github.com/apache/airflow/pull/36529#discussion_r1440167500 ## airflow/providers/microsoft/azure/operators/container_instances.py: ## @@ -151,7 +151,7 @@ def __init__( self.ci_conn_id = ci_conn_id self.resou

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
gbonazzoli commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1874987058 @dominikhei I've just tested on my installation and it works ! There is only a little aesthetic inaccuracy as you can see form the `airflow roles export `output:

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1874989352 > I looked at the code and I think we have the same problem also in the import phase. Good chance to make a PR and fix it @gbonazzoli -- This is an automated message from the A

Re: [I] Unable to provide Kubernetes proxy information in the Kubernetes pod operator. [airflow]

2024-01-03 Thread via GitHub
amoghrajesh closed issue #14904: Unable to provide Kubernetes proxy information in the Kubernetes pod operator. URL: https://github.com/apache/airflow/issues/14904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] Unable to provide Kubernetes proxy information in the Kubernetes pod operator. [airflow]

2024-01-03 Thread via GitHub
amoghrajesh commented on issue #14904: URL: https://github.com/apache/airflow/issues/14904#issuecomment-1874991470 Looks like @doughepi was able to get a workaround working here. I would not be fixing this at the moment. We can reopen if any other users come to ask for it. cc @eladka

[I] Airflow Python 3.12 support [airflow]

2024-01-03 Thread via GitHub
dirrao opened a new issue, #36546: URL: https://github.com/apache/airflow/issues/36546 ### Description Right now, airflow is not officially supporting the Python 3.12 version ### Use case/motivation Python software stack update. ### Related issues _No respon

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
gbonazzoli commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875002765 @potiuk @dominikhei Unfortunately I'm not a developer and I'm not able to make the PR (git commands and count distinct "name" attribute in the Python list are among the thing

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875006072 > Unfortunately I'm not a developer and I'm not able to make the PR (git commands and count distinct "name" attribute in the Python list are among the things that I do not know how to wr

Re: [I] Document precedence of `full_pod_spec` on `KubernetesPodOperator` [airflow]

2024-01-03 Thread via GitHub
amoghrajesh commented on issue #35509: URL: https://github.com/apache/airflow/issues/35509#issuecomment-1875008089 @ketozhang do you want to work on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] Changing wording in docstring for CNCF provider [airflow]

2024-01-03 Thread via GitHub
amoghrajesh opened a new pull request, #36547: URL: https://github.com/apache/airflow/pull/36547 Changing some small wordings in CNCF provider which I came across recently while searching for some code --- **^ Add meaningful description above** Read the **[Pu

Re: [I] Airflow REST API: Add generic capability to retrieve required information for the specified entity.. [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #29893: URL: https://github.com/apache/airflow/issues/29893#issuecomment-1875024049 I assigned you - but part of the task is to propose how to do it. Generally speaking, generic retrieval/update of partial information is somethingh that GraphQL attempted to do as t

[PR] Optimise getting changelogs in airflow-github [airflow]

2024-01-03 Thread via GitHub
amoghrajesh opened a new pull request, #36548: URL: https://github.com/apache/airflow/pull/36548 Fix the logic for getting changelog in minor versions so that we get only the changelog that is not present in the RELEASE_NOTES.rst instead of getting everything which is a heav

[I] Project/User specific dags [airflow]

2024-01-03 Thread via GitHub
tanisha41 opened a new issue, #36549: URL: https://github.com/apache/airflow/issues/36549 ### Description There is already one option but that is for permissions that what kind of user can view what dags, for example- admin can view all/edit and can do anything, op/public has got onl

Re: [I] Project/User specific dags [airflow]

2024-01-03 Thread via GitHub
boring-cyborg[bot] commented on issue #36549: URL: https://github.com/apache/airflow/issues/36549#issuecomment-1875093202 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2024-01-03 Thread via GitHub
claneys commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1875108037 Hi @hussein-awala, Happy new year :) Is the changes fine to you ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Optimise getting changelogs in airflow-github [airflow]

2024-01-03 Thread via GitHub
ephraimbuddy commented on PR #36548: URL: https://github.com/apache/airflow/pull/36548#issuecomment-1875112236 Can you test by running it between v2-7-stable and v2-8-stable. Problem was between minors -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] add deferrable mode to RedshiftClusterSensor [airflow]

2024-01-03 Thread via GitHub
Lee-W opened a new pull request, #36550: URL: https://github.com/apache/airflow/pull/36550 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**

Re: [I] Airflow Python 3.12 support [airflow]

2024-01-03 Thread via GitHub
Taragolis commented on issue #36546: URL: https://github.com/apache/airflow/issues/36546#issuecomment-1875141571 This kind of task not a straight forward, required to someone check what kind of core / providers dependencies not ready for 3.12 yet, or we use outdated dependencies or some dep

Re: [PR] Optimise getting changelogs in airflow-github [airflow]

2024-01-03 Thread via GitHub
amoghrajesh commented on PR #36548: URL: https://github.com/apache/airflow/pull/36548#issuecomment-1875149852 Sure @ephraimbuddy, let me check that out and I will post the results here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Audit logs entry as clear event even if we click on the tasks. [airflow]

2024-01-03 Thread via GitHub
jscheffl commented on issue #36119: URL: https://github.com/apache/airflow/issues/36119#issuecomment-1875211536 Thanks @Rafnel and @sktemkar16 to respond back. Apache Airflow is an open source project, most work consist out of volunteers and only a few "full paid" developers are maintaining

Re: [I] Audit logs entry as clear event even if we click on the tasks. [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #36119: URL: https://github.com/apache/airflow/issues/36119#issuecomment-1875218033 Yep. Would be great if someone could take that issue and fix it - seems it should be rather simple but to fix one someone debugs and finds the root cause. -- This is an automated

Re: [I] Audit logs entry as clear event even if we click on the tasks. [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #36119: URL: https://github.com/apache/airflow/issues/36119#issuecomment-1875218394 So ... volunteers are welcome :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add SparkKubernetesOperator crd implementation [airflow]

2024-01-03 Thread via GitHub
hamedhsn commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1875219366 @bolkedebruin I added a related doc for the operator to [operators.rst](https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-cncf-kubernetes/operators.rst) let m

Re: [PR] Remove MSSQL support form Airflow core [airflow]

2024-01-03 Thread via GitHub
jscheffl commented on PR #36514: URL: https://github.com/apache/airflow/pull/36514#issuecomment-1875219650 > I think we should also remove some hacks or mssql conditions from the `alembic` migrations scripts, but it could be done as follow up if we think that might bring a bit more pain if

[I] Unexpected zombie task in Cloud Composer Environment [airflow]

2024-01-03 Thread via GitHub
RESArnau opened a new issue, #36551: URL: https://github.com/apache/airflow/issues/36551 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.5.3 ### What happened? In our Google Cl

Re: [I] Unexpected zombie task in Cloud Composer Environment [airflow]

2024-01-03 Thread via GitHub
boring-cyborg[bot] commented on issue #36551: URL: https://github.com/apache/airflow/issues/36551#issuecomment-1875225492 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Redis hook with ssl fails instantiate Redis client [airflow]

2024-01-03 Thread via GitHub
shohamy7 opened a new issue, #36552: URL: https://github.com/apache/airflow/issues/36552 ### Apache Airflow Provider(s) redis ### Versions of Apache Airflow Providers apache-airflow-providers-redis==3.5.0 (latest) ### Apache Airflow version 2.8.0 ###

Re: [I] Airflow Python 3.12 support [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #36546: URL: https://github.com/apache/airflow/issues/36546#issuecomment-1875304673 > At current moment we know at lest incompatible with that pendulum 2 doesn't support of python 3.12, but this one could be solved by https://github.com/apache/airflow/pull/36281

(airflow) branch constraints-main updated: Updating constraints. Github run id:7394757374

2024-01-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new cc320281e6 Updating con

Re: [PR] Remove MSSQL support form Airflow core [airflow]

2024-01-03 Thread via GitHub
jscheffl merged PR #36514: URL: https://github.com/apache/airflow/pull/36514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

(airflow) branch main updated (ef9e8b0e7a -> dec78ab3f1)

2024-01-03 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ef9e8b0e7a Update dags.rst with information on DAG pausing (#36540) add dec78ab3f1 Remove MSSQL support form Air

Re: [PR] Remove MSSQL support from breeze [airflow]

2024-01-03 Thread via GitHub
jscheffl merged PR #36515: URL: https://github.com/apache/airflow/pull/36515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] Project/User specific dags [airflow]

2024-01-03 Thread via GitHub
potiuk closed issue #36549: Project/User specific dags URL: https://github.com/apache/airflow/issues/36549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [I] Unexpected zombie task in Cloud Composer Environment [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #36551: URL: https://github.com/apache/airflow/issues/36551#issuecomment-1875353714 Without more details - there is no way this can be acted on. If you can provide more details, logs and finding - then ther is a higher chance (no guarantees though) that someone mig

Re: [I] Unexpected zombie task in Cloud Composer Environment [airflow]

2024-01-03 Thread via GitHub
potiuk closed issue #36551: Unexpected zombie task in Cloud Composer Environment URL: https://github.com/apache/airflow/issues/36551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Remove MSSQL support from breeze [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36515: URL: https://github.com/apache/airflow/pull/36515#issuecomment-1875354485 WH ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Remove MSSQL support from breeze [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36515: URL: https://github.com/apache/airflow/pull/36515#issuecomment-1875355417 (That should even solve the failing MSSQL issue we had in main for a few days ) :tada: -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] Airflow schedules tasks in wrong timezone with an MSSQL Metadata DB on a non-UTC server [airflow]

2024-01-03 Thread via GitHub
potiuk closed issue #21171: Airflow schedules tasks in wrong timezone with an MSSQL Metadata DB on a non-UTC server URL: https://github.com/apache/airflow/issues/21171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [I] Airflow schedules tasks in wrong timezone with an MSSQL Metadata DB on a non-UTC server [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #21171: URL: https://github.com/apache/airflow/issues/21171#issuecomment-1875356933 Closing. MSSQL has just been removed from main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Flaky tests with `run_processor_manager_one_loop` [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #31575: URL: https://github.com/apache/airflow/issues/31575#issuecomment-1875359468 Closing. That one was MSSQL-related and we just removed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Flaky tests with `run_processor_manager_one_loop` [airflow]

2024-01-03 Thread via GitHub
potiuk closed issue #31575: Flaky tests with `run_processor_manager_one_loop` URL: https://github.com/apache/airflow/issues/31575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[I] Bold and increase font-size of graph task headers [airflow]

2024-01-03 Thread via GitHub
NilsJPWerner opened a new issue, #36557: URL: https://github.com/apache/airflow/issues/36557 ### Description I think bolding and increasing the fontsize of task headers would improve legibility. Here is a comparison: Before: https://github.com/apache/airflow/assets/10968348

Re: [PR] Implement Google Analytics Admin (GA4) operators [airflow]

2024-01-03 Thread via GitHub
moiseenkov closed pull request #36276: Implement Google Analytics Admin (GA4) operators URL: https://github.com/apache/airflow/pull/36276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Changing wording in docstring for CNCF provider [airflow]

2024-01-03 Thread via GitHub
amoghrajesh commented on PR #36547: URL: https://github.com/apache/airflow/pull/36547#issuecomment-1875370246 Thanks for the reviews @potiuk @pankajkoti. Merging the PR since it is a simple fix -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Changing wording in docstring for CNCF provider [airflow]

2024-01-03 Thread via GitHub
amoghrajesh merged PR #36547: URL: https://github.com/apache/airflow/pull/36547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airf

(airflow) branch main updated (eab75fac95 -> 2f15c95a28)

2024-01-03 Thread amoghdesai
This is an automated email from the ASF dual-hosted git repository. amoghdesai pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from eab75fac95 Remove MSSQL support from breeze (#36515) add 2f15c95a28 Changing wording in docstring for CNCF pro

Re: [I] Bold and increase font-size of graph task headers [airflow]

2024-01-03 Thread via GitHub
jscheffl commented on issue #36557: URL: https://github.com/apache/airflow/issues/36557#issuecomment-1875380969 Thanks for the proposal. Peronally I'd prefer to keep a consistent font size (meaning not too many different font sizes on the UI) but making bold text and other proposals looks g

Re: [I] Airflow REST API: Add generic capability to retrieve required information for the specified entity.. [airflow]

2024-01-03 Thread via GitHub
HarryWu-CHN commented on issue #29893: URL: https://github.com/apache/airflow/issues/29893#issuecomment-1875382856 What is the meaning of `POC`, please? As you mention `implement a POC`. @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] Airflow REST API: Add generic capability to retrieve required information for the specified entity.. [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #29893: URL: https://github.com/apache/airflow/issues/29893#issuecomment-1875390569 Proof Of Concept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Add openlineage docs ext with list of supported operators and hooks [airflow]

2024-01-03 Thread via GitHub
potiuk merged PR #36311: URL: https://github.com/apache/airflow/pull/36311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: feat: Add openlineage docs ext with list of supported operators and hooks. (#36311)

2024-01-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f0e3e612ba feat: Add openlineage docs ext with list

Re: [PR] Add openlineage docs ext with list of supported operators and hooks [airflow]

2024-01-03 Thread via GitHub
potiuk commented on code in PR #36311: URL: https://github.com/apache/airflow/pull/36311#discussion_r1440484931 ## docs/exts/operators_and_hooks_ref.py: ## @@ -215,6 +215,136 @@ def _render_deferrable_operator_content(*, header_separator: str): return _render_template("def

Re: [I] Redis hook with ssl fails instantiate Redis client [airflow]

2024-01-03 Thread via GitHub
shohamy7 commented on issue #36552: URL: https://github.com/apache/airflow/issues/36552#issuecomment-1875449264 @jscheffl @potiuk Should we support both `ssl_cert_file` and `ssl_certfile` with deprecation warning for the `ssl_cert_file` extra? This will fix the problem for already cre

Re: [I] Redis hook with ssl fails instantiate Redis client [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #36552: URL: https://github.com/apache/airflow/issues/36552#issuecomment-1875452072 Ideally both with deprecation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875458389 And BTW, if you don't want to - then I suggest you create an issue - then we can mark it as good-first-issue and make it ready for someone to pick it up. Comment in PR is not really acti

(airflow) branch main updated: Rewording text in CONTRIBUTING guide (#36534)

2024-01-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new bd1d2f4448 Rewording text in CONTRIBUTING guide (#3

Re: [PR] Rewording text in CONTRIBUTING guide [airflow]

2024-01-03 Thread via GitHub
potiuk merged PR #36534: URL: https://github.com/apache/airflow/pull/36534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Updated import path for the variable sql_alchemy_connect_args [airflow]

2024-01-03 Thread via GitHub
potiuk closed pull request #36525: Updated import path for the variable sql_alchemy_connect_args URL: https://github.com/apache/airflow/pull/36525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Updated import path for the variable sql_alchemy_connect_args [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36525: URL: https://github.com/apache/airflow/pull/36525#issuecomment-1875465725 This is bad fix. You shoud copy airflow_local_setings available in airflow code as template and use it from there. See https://airflow.apache.org/docs/apache-airflow/stable/ad

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

2024-01-03 Thread via GitHub
vincbeck commented on PR #36523: URL: https://github.com/apache/airflow/pull/36523#issuecomment-1875470814 > > If the condition is already met and the task is deferred, what happens? My understanding is the task gets executed successfully. So the gain here is just time? Instead of deferring

Re: [PR] check job_status before BatchOperator execute in deferrable mode [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36523: URL: https://github.com/apache/airflow/pull/36523#issuecomment-1875481928 > I see, I dont necessarily agree but I'll wait others to comment, I might be the only grumpy one here :) Just a little grumpy, I think :) > Yes, I think that's something we

Re: [PR] Add usage withing jinja template [airflow]

2024-01-03 Thread via GitHub
romanzdk commented on PR #35479: URL: https://github.com/apache/airflow/pull/35479#issuecomment-1875498412 Could someone merge this, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] Bold and increase font-size of graph task headers [airflow]

2024-01-03 Thread via GitHub
NilsJPWerner commented on issue #36557: URL: https://github.com/apache/airflow/issues/36557#issuecomment-1875502332 @bbovenzi do you have thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add usage withing jinja template [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #35479: URL: https://github.com/apache/airflow/pull/35479#issuecomment-1875511246 First -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] Add usage withing jinja template [airflow]

2024-01-03 Thread via GitHub
romanzdk opened a new pull request, #35479: URL: https://github.com/apache/airflow/pull/35479 Add an example how to reference AWS connection in jinja template --- -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] Airflow REST API: Add generic capability to retrieve required information for the specified entity.. [airflow]

2024-01-03 Thread via GitHub
HarryWu-CHN commented on issue #29893: URL: https://github.com/apache/airflow/issues/29893#issuecomment-1875515968 @potiuk Thank you for telling me about the task in detail!🌸 But just for `dags` or `dagRuns`, isn't it OK to just add 'only' parameter when the Schema() is created. ```

Re: [PR] Add usage withing jinja template [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #35479: URL: https://github.com/apache/airflow/pull/35479#issuecomment-1875516020 BTW. It's up to author to remind and follow up if you see your PR is not merged (and especially when bot marks it as stalled) - it's far easier to do it for. you than for reviewers to mo

Re: [I] Airflow REST API: Add generic capability to retrieve required information for the specified entity.. [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #29893: URL: https://github.com/apache/airflow/issues/29893#issuecomment-1875521578 This issue is about `generic` funcrtionality. If you want to do only dags or dagRuns limited version - feel free to open PRs with fixes - but they would not close that issue. --

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
vincbeck commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875529189 By looking at this PR again, the json format changes, is not it a breaking change? If some users use the CI command `airflow roles export` or `airflow roles import` in their CI, it wil

Re: [PR] Move config related to FAB auth manager to FAB provider [airflow]

2024-01-03 Thread via GitHub
vincbeck closed pull request #36232: Move config related to FAB auth manager to FAB provider URL: https://github.com/apache/airflow/pull/36232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Fix test `test_cli_import_roles` [airflow]

2024-01-03 Thread via GitHub
vincbeck opened a new pull request, #36558: URL: https://github.com/apache/airflow/pull/36558 The import and export CI command has been modified in #36347. As part of this change, the order of the roles is not sorted, thus we should not assume in tests they are.

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
vincbeck commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875550552 To fix the test: #36558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Fix security manager inheritance in fab provider [airflow]

2024-01-03 Thread via GitHub
vincbeck commented on PR #36538: URL: https://github.com/apache/airflow/pull/36538#issuecomment-1875550943 The failures are not related to this PR, fix: #36558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875558733 > By looking at this PR again, the json format changes, is not it a breaking change? The observation we had is that we should treat it as bugfix. Roles export/import without permi

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2024-01-03 Thread via GitHub
PApostol commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1875561872 Hello, I have updated the PR, tests seem to pass now. Perhaps it can be reviewed? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Cli export / import roles including permissions [airflow]

2024-01-03 Thread via GitHub
vincbeck commented on PR #36347: URL: https://github.com/apache/airflow/pull/36347#issuecomment-1875563625 Sounds good :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2024-01-03 Thread via GitHub
potiuk merged PR #33328: URL: https://github.com/apache/airflow/pull/33328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] Sanitize filename of the MySQLHook bulk_load parameter [airflow]

2024-01-03 Thread via GitHub
potiuk closed issue #33283: Sanitize filename of the MySQLHook bulk_load parameter URL: https://github.com/apache/airflow/issues/33283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

(airflow) branch main updated: Sanitize filenames in MySQLHook (#33328)

2024-01-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3598a52a2d Sanitize filenames in MySQLHook (#33328)

Re: [PR] Sanitize filenames in MySQLHook [airflow]

2024-01-03 Thread via GitHub
potiuk commented on PR #33328: URL: https://github.com/apache/airflow/pull/33328#issuecomment-1875577456 Cool. Thanks for fixing it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Error when opening Airflow - Something bad has happened. [airflow]

2024-01-03 Thread via GitHub
boring-cyborg[bot] commented on issue #36560: URL: https://github.com/apache/airflow/issues/36560#issuecomment-1875578101 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Error when opening Airflow - Something bad has happened. [airflow]

2024-01-03 Thread via GitHub
nareshkumarailaveni opened a new issue, #36560: URL: https://github.com/apache/airflow/issues/36560 ### Apache Airflow version 2.8.0 ### If "Other Airflow 2 version" selected, which one? 2.3.3 ### What happened? "Something bad has happened. Air

Re: [PR] Update community elements [airflow-site]

2024-01-03 Thread via GitHub
bbovenzi commented on code in PR #914: URL: https://github.com/apache/airflow-site/pull/914#discussion_r1440618379 ## landing-pages/site/data/videos.json: ## @@ -1,32 +1,32 @@ [ { "name": "video", -"date": "2019-07-22", -"title": "Running Apache Airflow Reliably

Re: [PR] Update community elements [airflow-site]

2024-01-03 Thread via GitHub
bbovenzi commented on code in PR #914: URL: https://github.com/apache/airflow-site/pull/914#discussion_r1440620451 ## landing-pages/site/layouts/community/list.html: ## @@ -21,7 +21,7 @@ Community -Apache Airflowâ„¢ was started at Airbnb as open source from th

Re: [PR] Update community elements [airflow-site]

2024-01-03 Thread via GitHub
bbovenzi commented on code in PR #914: URL: https://github.com/apache/airflow-site/pull/914#discussion_r1440621042 ## landing-pages/site/layouts/meetups/list.html: ## @@ -1,79 +1,75 @@ {{/* - Licensed to the Apache Software Foundation (ASF) under one - or more contributor licen

Re: [PR] Fix test `test_cli_import_roles` [airflow]

2024-01-03 Thread via GitHub
vincbeck merged PR #36558: URL: https://github.com/apache/airflow/pull/36558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] Airflow Python 3.12 support [airflow]

2024-01-03 Thread via GitHub
dirrao commented on issue #36546: URL: https://github.com/apache/airflow/issues/36546#issuecomment-1875651103 > > At current moment we know at lest incompatible with that pendulum 2 doesn't support of python 3.12, but this one could be solved by #36281 > > Yeah. I believe this is the

(airflow) branch main updated: Fix test `test_cli_import_roles` (#36558)

2024-01-03 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dc228f9233 Fix test `test_cli_import_roles` (#365

Re: [I] Airflow Python 3.12 support [airflow]

2024-01-03 Thread via GitHub
dirrao commented on issue #36546: URL: https://github.com/apache/airflow/issues/36546#issuecomment-1875663778 I have updated the breeze. However when I run this test with 3.12. The base image is missing. How to publish this image? `Error response from daemon: No such image: ghcr.io/

Re: [I] Airflow progressive slowness [airflow]

2024-01-03 Thread via GitHub
ephraimbuddy commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1875673643 FYI, I updated `[scheduler]max_tis_per_dag` to 512 in 2.8.0 and saw good improvement in the number of tasks ran per minute -- This is an automated message from the Apache Gi

[PR] Fix misconfiguration of redis client with ssl [airflow]

2024-01-03 Thread via GitHub
shohamy7 opened a new pull request, #36561: URL: https://github.com/apache/airflow/pull/36561 --- Closes: #36552 Fix the instantiation of the Redis client when connection via SSL. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Explicitly passing `raise_on_deleted_version=True` to `read_secret_version` in Hashicorp operator [airflow]

2024-01-03 Thread via GitHub
romsharon98 commented on PR #36532: URL: https://github.com/apache/airflow/pull/36532#issuecomment-1875703396 > Could you check [#31349 (review)](https://github.com/apache/airflow/pull/31349#pullrequestreview-1430519806)? Thanks for notice it @hussein-awala ! I didn't notice this t

Re: [I] Airflow Python 3.12 support [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #36546: URL: https://github.com/apache/airflow/issues/36546#issuecomment-1875706242 You should be able to build it locally with `breeze ci-image build` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Airflow Python 3.12 support [airflow]

2024-01-03 Thread via GitHub
potiuk commented on issue #36546: URL: https://github.com/apache/airflow/issues/36546#issuecomment-1875708269 You might see some missing cache etc. but they should be just warnings - and you can always disable cache with `build` command flags (use --help to see the flags) -- This is an a

[PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
shohamy7 opened a new pull request, #36562: URL: https://github.com/apache/airflow/pull/36562 --- Redis 6 and above introduced an option to authenticate with username in addition to password. This PR aims to add support for this kind of authentication.

[PR] Fix configuration of mypy plugins to point to paths not modules [airflow]

2024-01-03 Thread via GitHub
potiuk opened a new pull request, #36563: URL: https://github.com/apache/airflow/pull/36563 The configuration of our MyPy plugins was wrongly pointing to modules rather than paths. This caused problems in the environment where you had no PYTHONPATH set pointing to the root of your Airflow s

(airflow) branch constraints-main updated: Updating constraints. Github run id:7399908663

2024-01-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new c0a40bd17f Updating con

[PR] Update collaborators for Airflow [airflow]

2024-01-03 Thread via GitHub
potiuk opened a new pull request, #36564: URL: https://github.com/apache/airflow/pull/36564 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*

Re: [PR] Add username authenticating to the Redis hook [airflow]

2024-01-03 Thread via GitHub
eladkal commented on PR #36562: URL: https://github.com/apache/airflow/pull/36562#issuecomment-1875728540 > Redis 6 and above introduced an option to authenticate with username in addition to password. We currently don't support redis 6 due to https://github.com/apache/airflo

  1   2   3   >