Re: [PR] Fix assignment of template field in `__init__` in `CloudDataTransferServiceCreateJobOperator` [airflow]

2024-01-21 Thread via GitHub
romsharon98 commented on code in PR #36909: URL: https://github.com/apache/airflow/pull/36909#discussion_r1461458749 ## tests/providers/google/cloud/operators/test_cloud_storage_transfer_service.py: ## @@ -324,21 +324,33 @@ def test_job_create_multiple(self, aws_hook, gcp_hook):

Re: [PR] Fix assignment of template field in `__init__` in `CloudDataTransferServiceCreateJobOperator` [airflow]

2024-01-21 Thread via GitHub
romsharon98 commented on code in PR #36909: URL: https://github.com/apache/airflow/pull/36909#discussion_r1461458749 ## tests/providers/google/cloud/operators/test_cloud_storage_transfer_service.py: ## @@ -324,21 +324,33 @@ def test_job_create_multiple(self, aws_hook, gcp_hook):

Re: [PR] Fix assignment of template field in `__init__` in `CloudDataTransferServiceCreateJobOperator` [airflow]

2024-01-21 Thread via GitHub
romsharon98 commented on code in PR #36909: URL: https://github.com/apache/airflow/pull/36909#discussion_r1461458749 ## tests/providers/google/cloud/operators/test_cloud_storage_transfer_service.py: ## @@ -324,21 +324,33 @@ def test_job_create_multiple(self, aws_hook, gcp_hook):

Re: [PR] Update INTHEWILD.md [airflow]

2024-01-21 Thread via GitHub
pankajkoti commented on code in PR #36942: URL: https://github.com/apache/airflow/pull/36942#discussion_r1461453451 ## INTHEWILD.md: ## @@ -256,6 +256,7 @@ Currently, **officially** using Airflow: 1. [imgix](https://www.imgix.com/) [[@dclubb](https://github.com/dclubb)] 1. [In

Re: [PR] add WasbPrefixSensorTrigger params breaking change to azure provider changelog [airflow]

2024-01-21 Thread via GitHub
Lee-W commented on code in PR #36940: URL: https://github.com/apache/airflow/pull/36940#discussion_r1461442605 ## airflow/providers/microsoft/azure/CHANGELOG.rst: ## @@ -27,6 +27,18 @@ Changelog - +9.0.0 +. + +Breaking changes + + +.. warning:: +

Re: [PR] add WasbPrefixSensorTrigger params breaking change to azure provider changelog [airflow]

2024-01-21 Thread via GitHub
eladkal commented on code in PR #36940: URL: https://github.com/apache/airflow/pull/36940#discussion_r1461441552 ## airflow/providers/microsoft/azure/CHANGELOG.rst: ## @@ -27,6 +27,18 @@ Changelog - +9.0.0 +. + +Breaking changes + + +.. warning::

Re: [I] CRSF bad request error when redirected from another website [airflow]

2024-01-21 Thread via GitHub
Tejalgnrml commented on issue #24051: URL: https://github.com/apache/airflow/issues/24051#issuecomment-1903385706 Similar issue, upon redirecting the webserver ip through a domain i am facing this issue Any solutions? Thanks in advance -- This is an automated message from the Apache

(airflow) branch main updated (e34b253ec2 -> 03682eb28a)

2024-01-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from e34b253ec2 Force install hatch in Test Open API job (#36938) add 03682eb28a Fix small issues with breeze docs move

Re: [PR] Fix small issues with breeze docs moved to new place [airflow]

2024-01-21 Thread via GitHub
potiuk merged PR #36937: URL: https://github.com/apache/airflow/pull/36937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Update INTHEWILD.md [airflow]

2024-01-21 Thread via GitHub
amolsr opened a new pull request, #36942: URL: https://github.com/apache/airflow/pull/36942 added Infoedge company --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING

(airflow) branch main updated: Force install hatch in Test Open API job (#36938)

2024-01-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e34b253ec2 Force install hatch in Test Open API job

Re: [PR] Force install hatch in Test Open API job [airflow]

2024-01-21 Thread via GitHub
potiuk merged PR #36938: URL: https://github.com/apache/airflow/pull/36938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] add WasbPrefixSensorTrigger params breaking change to azure provider changelog [airflow]

2024-01-21 Thread via GitHub
pankajkoti commented on code in PR #36940: URL: https://github.com/apache/airflow/pull/36940#discussion_r1461414401 ## airflow/providers/microsoft/azure/CHANGELOG.rst: ## @@ -27,6 +27,18 @@ Changelog - +9.0.0 +. + +Breaking changes + + +.. warning

(airflow) branch main updated: Check cluster state before defer Dataproc operators to trigger (#36892)

2024-01-21 Thread pankajkoti
This is an automated email from the ASF dual-hosted git repository. pankajkoti pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e07a42e69d Check cluster state before defer Dat

Re: [PR] Check cluster state before defer Dataproc operators to trigger [airflow]

2024-01-21 Thread via GitHub
pankajkoti merged PR #36892: URL: https://github.com/apache/airflow/pull/36892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airfl

Re: [PR] Add deferrable implementation in HTTPSensor [airflow]

2024-01-21 Thread via GitHub
Lee-W commented on code in PR #36904: URL: https://github.com/apache/airflow/pull/36904#discussion_r1461377038 ## tests/providers/http/sensors/test_http.py: ## @@ -330,3 +331,62 @@ def test_sensor(self): dag=self.dag, ) sensor.run(start_date=DEFAUL

Re: [PR] Disable dryrun autofetch for ClearInstance and MarkInstance [airflow]

2024-01-21 Thread via GitHub
im-perativa commented on PR #36941: URL: https://github.com/apache/airflow/pull/36941#issuecomment-190324 @dirrao I'm not sure if we have test cases for these files as these are UI modification without change to the connexion API. cmiiw -- This is an automated message from the Apache

Re: [I] [GkeStartPodOperator] - Kubernetes client request can hand indefinitely [airflow]

2024-01-21 Thread via GitHub
dirrao commented on issue #36802: URL: https://github.com/apache/airflow/issues/36802#issuecomment-1903209260 @IKholopov Thanks for reporting the issue. Looks like its a bug. It requires further investigation. -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] Audit logs entry as clear event even if we click on the tasks. [airflow]

2024-01-21 Thread via GitHub
im-perativa commented on issue #36119: URL: https://github.com/apache/airflow/issues/36119#issuecomment-1902992418 @potiuk submitted a PR that hopefully can fix this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] Disable dryrun autofetch for ClearInstance and MarkInstance [airflow]

2024-01-21 Thread via GitHub
im-perativa opened a new pull request, #36941: URL: https://github.com/apache/airflow/pull/36941 this PR set `useQuery` to be enabled after action button is clicked instead of automatically on render to reduce dry run api calls and prevent unintended audit logs r

Re: [PR] Fix WasbPrefixSensor arg inconsistency between sync and async mode [airflow]

2024-01-21 Thread via GitHub
Lee-W commented on code in PR #36806: URL: https://github.com/apache/airflow/pull/36806#discussion_r1461250647 ## airflow/providers/microsoft/azure/triggers/wasb.py: ## @@ -102,26 +102,28 @@ class WasbPrefixSensorTrigger(BaseTrigger): ``copy``, ``deleted`` :par

[PR] add WasbPrefixSensorTrigger params breaking change to azure provider changelog [airflow]

2024-01-21 Thread via GitHub
Lee-W opened a new pull request, #36940: URL: https://github.com/apache/airflow/pull/36940 address https://github.com/apache/airflow/pull/36806/files#r1460306275 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://g

(airflow) branch constraints-main updated: Updating constraints. Github run id:7604490849

2024-01-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e295bcb67b Updating con

Re: [PR] Add support for catchup="ignore_first" to disable catchup for the first DagRun [airflow]

2024-01-21 Thread via GitHub
github-actions[bot] commented on PR #35392: URL: https://github.com/apache/airflow/pull/35392#issuecomment-1902817203 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Add explanation about cleaning logs with helm [airflow]

2024-01-21 Thread via GitHub
github-actions[bot] closed pull request #35783: Add explanation about cleaning logs with helm URL: https://github.com/apache/airflow/pull/35783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Check cluster state before defer Dataproc operators to trigger [airflow]

2024-01-21 Thread via GitHub
Lee-W commented on code in PR #36892: URL: https://github.com/apache/airflow/pull/36892#discussion_r1461230579 ## airflow/providers/google/cloud/operators/dataproc.py: ## @@ -2480,17 +2499,23 @@ def execute(self, context: Context): if not self.deferrable: h

Re: [PR] Support Personal access token method for Tableau Connection [airflow]

2024-01-21 Thread via GitHub
github-actions[bot] closed pull request #34927: Support Personal access token method for Tableau Connection URL: https://github.com/apache/airflow/pull/34927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Stop logo clashing when pinwheel animates [airflow]

2024-01-21 Thread via GitHub
github-actions[bot] closed pull request #35564: Stop logo clashing when pinwheel animates URL: https://github.com/apache/airflow/pull/35564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Task succeeded but retried --> downstream task fails since upstream task is still running [airflow]

2024-01-21 Thread via GitHub
github-actions[bot] commented on issue #35773: URL: https://github.com/apache/airflow/issues/35773#issuecomment-1902817191 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Task succeeded but retried --> downstream task fails since upstream task is still running [airflow]

2024-01-21 Thread via GitHub
github-actions[bot] closed issue #35773: Task succeeded but retried --> downstream task fails since upstream task is still running URL: https://github.com/apache/airflow/issues/35773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] fix: downstream on list [airflow]

2024-01-21 Thread via GitHub
github-actions[bot] commented on PR #36107: URL: https://github.com/apache/airflow/pull/36107#issuecomment-1902817169 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Fix successful Apache Druid task submissions reported as failed [airflow]

2024-01-21 Thread via GitHub
potiuk commented on PR #36813: URL: https://github.com/apache/airflow/pull/36813#issuecomment-1902804456 > Hey @potiuk, I thought [this unit test](https://github.com/apache/airflow/blob/7a814f1403752d42d309f79010d9214083eda762/tests/providers/apache/druid/hooks/test_druid.py#L81-L95) was al

(airflow) branch main updated: Add deferrable param in FileSensor (#36840)

2024-01-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d48985c8f2 Add deferrable param in FileSensor (#368

Re: [PR] Add deferrable param in FileSensor [airflow]

2024-01-21 Thread via GitHub
potiuk merged PR #36840: URL: https://github.com/apache/airflow/pull/36840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] Generate a mermaid diagram for the database ERD schema [airflow]

2024-01-21 Thread via GitHub
potiuk commented on issue #36842: URL: https://github.com/apache/airflow/issues/36842#issuecomment-1902798819 Looks good. CLI is not a problem. We can run `python -m paracelsus` from pre-commit, no problem with that -- This is an automated message from the Apache Git Service. To respond t

Re: [I] Request for Inclusion of Horizontal Pod Autoscaling (HPA) Option in KubernetesPodOperator [airflow]

2024-01-21 Thread via GitHub
potiuk closed issue #36932: Request for Inclusion of Horizontal Pod Autoscaling (HPA) Option in KubernetesPodOperator URL: https://github.com/apache/airflow/issues/36932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Request for Inclusion of Horizontal Pod Autoscaling (HPA) Option in KubernetesPodOperator [airflow]

2024-01-21 Thread via GitHub
raphaelauv commented on issue #36932: URL: https://github.com/apache/airflow/issues/36932#issuecomment-1902791048 the KPO start a pod , that's all and will always use the `KubernetesCreateResourceOperator` to start something like a `RayJob` or `SparkApplication` -- This is an a

Re: [I] Support for Flask-sesssion 0.6.0+ [airflow]

2024-01-21 Thread via GitHub
potiuk commented on issue #36897: URL: https://github.com/apache/airflow/issues/36897#issuecomment-1902784689 Asked https://github.com/pallets-eco/flask-session/issues/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] Force install hatch in Test Open API job [airflow]

2024-01-21 Thread via GitHub
potiuk opened a new pull request, #36938: URL: https://github.com/apache/airflow/pull/36938 The python hatch package might be installed from cache but fail to be available on commmand line. This PR forces hatch installation, whihc will also make it available as command.

[PR] Fix small issues with breeze docs moved to new place [airflow]

2024-01-21 Thread via GitHub
potiuk opened a new pull request, #36937: URL: https://github.com/apache/airflow/pull/36937 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*

Re: [PR] Move Breeze documentation to inside Breeze and split it. [airflow]

2024-01-21 Thread via GitHub
potiuk merged PR #36936: URL: https://github.com/apache/airflow/pull/36936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Move Breeze documentation to inside Breeze and split it. [airflow]

2024-01-21 Thread via GitHub
potiuk commented on code in PR #36936: URL: https://github.com/apache/airflow/pull/36936#discussion_r1461088218 ## BREEZE.rst: ## @@ -15,2895 +15,4 @@ specific language governing permissions and limitations under the License. -.. raw:: html - - - - - -.

Re: [PR] Move Breeze documentation to inside Breeze and split it. [airflow]

2024-01-21 Thread via GitHub
pankajkoti commented on code in PR #36936: URL: https://github.com/apache/airflow/pull/36936#discussion_r1461073688 ## BREEZE.rst: ## @@ -15,2895 +15,4 @@ specific language governing permissions and limitations under the License. -.. raw:: html - - - -

[PR] Move Breeze documentation to inside Breeze and split it. [airflow]

2024-01-21 Thread via GitHub
potiuk opened a new pull request, #36936: URL: https://github.com/apache/airflow/pull/36936 The BREEZE.rst document became enormous - enough for it to stop being rendered by GitHub. This change splits it into multiple smaller documents - each focusing on a specific aspect of Breeze, making

(airflow) branch constraints-main updated: Updating constraints. Github run id:7602882964

2024-01-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 7d947959d2 Updating con

Re: [PR] Fix assignment of template field in `__init__` in `CloudDataTransferServiceCreateJobOperator` [airflow]

2024-01-21 Thread via GitHub
hussein-awala commented on code in PR #36909: URL: https://github.com/apache/airflow/pull/36909#discussion_r1461039353 ## tests/providers/google/cloud/operators/test_cloud_storage_transfer_service.py: ## @@ -324,21 +324,33 @@ def test_job_create_multiple(self, aws_hook, gcp_hook

Re: [PR] Fix assignment of template field in `__init__` in `auto_ml.py` [airflow]

2024-01-21 Thread via GitHub
eladkal merged PR #36934: URL: https://github.com/apache/airflow/pull/36934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

(airflow) branch main updated: fix templating field to super constructor (#36934)

2024-01-21 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9e4f5ba67a fix templating field to super construct

[PR] 36239 automatically set dag off [airflow]

2024-01-21 Thread via GitHub
pateash opened a new pull request, #36935: URL: https://github.com/apache/airflow/pull/36935 closes: #36239 related: #ISSUE --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONT

[PR] Fix assignment of template field in `__init__` in `auto_ml.py` [airflow]

2024-01-21 Thread via GitHub
romsharon98 opened a new pull request, #36934: URL: https://github.com/apache/airflow/pull/36934 related: https://github.com/apache/airflow/issues/36484 fix: ``` CreateAutoMLForecastingTrainingJobOperator's constructor lacks direct assignments for instance members corresponding

Re: [PR] Fix assignment of template field in `__init__` in `CloudDataTransferServiceCreateJobOperator` [airflow]

2024-01-21 Thread via GitHub
romsharon98 commented on PR #36909: URL: https://github.com/apache/airflow/pull/36909#issuecomment-1902687616 > Is it possible to add a test for str body? Added 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Check cluster state before defer Dataproc operators to trigger [airflow]

2024-01-21 Thread via GitHub
pankajkoti commented on code in PR #36892: URL: https://github.com/apache/airflow/pull/36892#discussion_r1460969866 ## airflow/providers/google/cloud/operators/dataproc.py: ## @@ -2480,17 +2499,23 @@ def execute(self, context: Context): if not self.deferrable:

Re: [I] Copy button on a Dag run's config copies only one run config [airflow]

2024-01-21 Thread via GitHub
anteverse commented on issue #36848: URL: https://github.com/apache/airflow/issues/36848#issuecomment-1902681169 Thanks a lot, looking forward to the next releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Make Helm artifacts reproducible [airflow]

2024-01-21 Thread via GitHub
potiuk commented on PR #36930: URL: https://github.com/apache/airflow/pull/36930#issuecomment-1902679160 I actually managed to get also the helm package reproducible - It turned out to be as easy as repackaging the .tar.gz produced by helm-package in a reproducible way. Signing the packages

Re: [PR] Add dataset delete feature [airflow]

2024-01-21 Thread via GitHub
im-perativa commented on PR #36781: URL: https://github.com/apache/airflow/pull/36781#issuecomment-1902665951 @potiuk re-requesting your review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add dataset delete feature [airflow]

2024-01-21 Thread via GitHub
edumuellerFSL commented on code in PR #36781: URL: https://github.com/apache/airflow/pull/36781#discussion_r1460827252 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -32,14 +34,42 @@ dataset_schema, ) from airflow.models.dataset import DatasetEvent, Dataset

Re: [PR] Add dataset delete feature [airflow]

2024-01-21 Thread via GitHub
edumuellerFSL commented on code in PR #36781: URL: https://github.com/apache/airflow/pull/36781#discussion_r1460827252 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -32,14 +34,42 @@ dataset_schema, ) from airflow.models.dataset import DatasetEvent, Dataset

Re: [PR] Add dataset delete feature [airflow]

2024-01-21 Thread via GitHub
edumuellerFSL commented on code in PR #36781: URL: https://github.com/apache/airflow/pull/36781#discussion_r1460827252 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -32,14 +34,42 @@ dataset_schema, ) from airflow.models.dataset import DatasetEvent, Dataset

Re: [PR] Add dataset delete feature [airflow]

2024-01-21 Thread via GitHub
edumuellerFSL commented on code in PR #36781: URL: https://github.com/apache/airflow/pull/36781#discussion_r1460827252 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -32,14 +34,42 @@ dataset_schema, ) from airflow.models.dataset import DatasetEvent, Dataset

Re: [I] Suggesting to add documentation on how to run Airflow on Windows using WSL [airflow]

2024-01-21 Thread via GitHub
ErandH commented on issue #26274: URL: https://github.com/apache/airflow/issues/26274#issuecomment-1902600928 Thank you so much for the reply. I will probably try it out and report back my experience with using it. Will look into WinRM as well, thanks for the suggestion. -- This is an au

(airflow) branch constraints-main updated: Updating constraints. Github run id:7599705968

2024-01-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 7ba54ed869 Updating con

Re: [PR] Turn Helm chart source tarball into reproducible tarball [airflow]

2024-01-21 Thread via GitHub
potiuk commented on PR #36930: URL: https://github.com/apache/airflow/pull/36930#issuecomment-1902552313 cc: @jedcunningham - I'd love you take a look before preparing the Helm Chart to see if that all looks good for you - I made all the variables and package location quite a bit more consi