(airflow) branch use-uv-for-prod-image updated (402e7983a8 -> 807cfb559f)

2024-03-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch use-uv-for-prod-image in repository https://gitbox.apache.org/repos/asf/airflow.git omit 402e7983a8 Merge branch 'main' into use-uv-for-prod-image omit 8773cb8d8c Switch from --user to ve

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
potiuk commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509903874 ## pyproject.toml: ## @@ -83,7 +83,7 @@ dependencies = [ # The usage was added in #30596, seemingly only to override and improve the default error message.

[I] Status of testing of Apache Airflow Helm Chart 1.13.0rc1 [airflow]

2024-03-01 Thread via GitHub
jedcunningham opened a new issue, #37844: URL: https://github.com/apache/airflow/issues/37844 ### Body We are kindly requesting that contributors to [Apache Airflow Helm Chart 1.13.0rc1](https://dist.apache.org/repos/dist/dev/airflow/helm-chart/1.13.0rc1) help test the RC. Ple

(airflow) annotated tag helm-chart/1.13.0rc1 updated (f7f005f180 -> 748653e718)

2024-03-01 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to annotated tag helm-chart/1.13.0rc1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag helm-chart/1.13.0rc1 was modified! *** from f7f005f180 (commit) to 748

svn commit: r67661 - /dev/airflow/helm-chart/1.12.0rc1/

2024-03-01 Thread jedcunningham
Author: jedcunningham Date: Sat Mar 2 04:20:39 2024 New Revision: 67661 Log: Remove old Helm Chart release: 1.12.0rc1 Removed: dev/airflow/helm-chart/1.12.0rc1/

svn commit: r67660 - /dev/airflow/helm-chart/1.13.0rc1/

2024-03-01 Thread jedcunningham
Author: jedcunningham Date: Sat Mar 2 04:19:59 2024 New Revision: 67660 Log: Add artifacts for Helm Chart 1.13.0rc1 Added: dev/airflow/helm-chart/1.13.0rc1/ dev/airflow/helm-chart/1.13.0rc1/airflow-1.13.0.tgz (with props) dev/airflow/helm-chart/1.13.0rc1/airflow-1.13.0.tgz.asc

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
Satoshi-Sh commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509874151 ## pyproject.toml: ## @@ -83,7 +83,7 @@ dependencies = [ # The usage was added in #30596, seemingly only to override and improve the default error message.

[I] Use a better log context name than `pod_manager.py` for KubernetesPodOperator runtime [airflow]

2024-03-01 Thread via GitHub
ketozhang opened a new issue, #37843: URL: https://github.com/apache/airflow/issues/37843 ### Description KPO's runtime stderr and stdout is printed to the logger `pod_manager.py` module. ### Use case/motivation The context "KubernetesPodOperator" would be more clear.

[I] Scheduler throwing error when schedule is set to @hourly and catchup_by_default is set to False [airflow]

2024-03-01 Thread via GitHub
sudarshan2906 opened a new issue, #37842: URL: https://github.com/apache/airflow/issues/37842 ### Apache Airflow version 2.8.2 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? I am using a very simple dag which has sched

Re: [PR] Add example PSRP DAG [airflow]

2024-03-01 Thread via GitHub
github-actions[bot] commented on PR #34907: URL: https://github.com/apache/airflow/pull/34907#issuecomment-1974116328 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] [WIP] Update test_file_not_new_enough in test_sftp.py with logical_date example [airflow]

2024-03-01 Thread via GitHub
github-actions[bot] commented on PR #36681: URL: https://github.com/apache/airflow/pull/36681#issuecomment-1974116294 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Encrypt all string trigger attributes [airflow]

2024-03-01 Thread via GitHub
github-actions[bot] commented on PR #36801: URL: https://github.com/apache/airflow/pull/36801#issuecomment-1974116275 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

(airflow) branch main updated (2bc5d2decb -> f7f005f180)

2024-03-01 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2bc5d2decb Bump sanitize-html from 2.11.0 to 2.12.1 in /airflow/www (#37833) add f7f005f180 Release notes

Re: [PR] Release notes for helm chart 1.13.0 [airflow]

2024-03-01 Thread via GitHub
jedcunningham merged PR #37806: URL: https://github.com/apache/airflow/pull/37806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
ferruzzi commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509647962 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
ferruzzi commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509647962 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

Re: [PR] Bump sanitize-html from 2.11.0 to 2.12.1 in /airflow/www [airflow]

2024-03-01 Thread via GitHub
hussein-awala merged PR #37833: URL: https://github.com/apache/airflow/pull/37833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

(airflow) branch main updated (e8af807cad -> 2bc5d2decb)

2024-03-01 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from e8af807cad Resolve PT017 in tests (#37837) add 2bc5d2decb Bump sanitize-html from 2.11.0 to 2.12.1 in /airfl

(airflow) branch dependabot/npm_and_yarn/airflow/www/sanitize-html-2.12.1 deleted (was ec58587d95)

2024-03-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/airflow/www/sanitize-html-2.12.1 in repository https://gitbox.apache.org/repos/asf/airflow.git was ec58587d95 Bump sanitize-html from 2.11.0 to 2.12.1 in /airflo

(airflow) branch main updated (2ab60812a0 -> e8af807cad)

2024-03-01 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2ab60812a0 Make `executemany` keyword arguments only in `DbApiHook.insert_rows` (#37840) add e8af807cad Res

Re: [PR] Resolve PT017 in tests [airflow]

2024-03-01 Thread via GitHub
hussein-awala merged PR #37837: URL: https://github.com/apache/airflow/pull/37837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

(airflow) branch main updated: Make `executemany` keyword arguments only in `DbApiHook.insert_rows` (#37840)

2024-03-01 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2ab60812a0 Make `executemany` keyword argumen

Re: [I] Recent change to DbApiHook affects multiple providers [airflow]

2024-03-01 Thread via GitHub
hussein-awala closed issue #37838: Recent change to DbApiHook affects multiple providers URL: https://github.com/apache/airflow/issues/37838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Make `executemany` keyword arguments only in `DbApiHook.insert_rows` [airflow]

2024-03-01 Thread via GitHub
hussein-awala merged PR #37840: URL: https://github.com/apache/airflow/pull/37840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
ferruzzi commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509631372 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

Re: [PR] Add the dataset_expression as part of DAGDetailSchema [airflow]

2024-03-01 Thread via GitHub
dstandish commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1509633634 ## airflow/api_connexion/endpoints/dag_endpoint.py: ## @@ -81,11 +81,13 @@ def get_dag_details( for key, value in dag.__dict__.items(): if not key.sta

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
ferruzzi commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509631372 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

Re: [I] Pgbouncer not set properly upon using data.metadataSecretName [airflow]

2024-03-01 Thread via GitHub
adilblanco commented on issue #33924: URL: https://github.com/apache/airflow/issues/33924#issuecomment-1974012692 Facing the same roadblock. Any progress or updates on this ? Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
ferruzzi commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509631372 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
ferruzzi commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509631372 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

Re: [I] Support `uv` in addition to `pip` when extending the Docker image [airflow]

2024-03-01 Thread via GitHub
potiuk commented on issue #37785: URL: https://github.com/apache/airflow/issues/37785#issuecomment-1974004467 1.`git config --global core.autocrlf` should fix windows 2.3 -> updated default. in the new version now.. Seems `uv` was set as default to build image but still has some teething

(airflow) branch use-uv-for-prod-image updated (8773cb8d8c -> 402e7983a8)

2024-03-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch use-uv-for-prod-image in repository https://gitbox.apache.org/repos/asf/airflow.git from 8773cb8d8c Switch from --user to venv for PROD image and enable uv add 87a249a02f fix: Pass proxi

(airflow) branch main updated (a7691b787b -> e1f60bfb94)

2024-03-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a7691b787b Simplify some docs around airflow_local_settings (#37835) add e1f60bfb94 Update to latest uv version (#

Re: [PR] Update to latest uv version [airflow]

2024-03-01 Thread via GitHub
potiuk merged PR #37841: URL: https://github.com/apache/airflow/pull/37841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
o-nikolas commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509612285 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

[PR] Update to latest uv version [airflow]

2024-03-01 Thread via GitHub
potiuk opened a new pull request, #37841: URL: https://github.com/apache/airflow/pull/37841 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
ferruzzi commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509575621 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

Re: [PR] Use sys.version_info to get the python version [airflow]

2024-03-01 Thread via GitHub
Taragolis commented on PR #37750: URL: https://github.com/apache/airflow/pull/37750#issuecomment-1973957648 I run hook locally and push changes into the branch: https://github.com/apache/airflow/pull/37750/commits/c0d2041aa663ecd169cc999b1e19e6a147ee6931 -- This is an automated message fr

Re: [PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
o-nikolas commented on code in PR #37839: URL: https://github.com/apache/airflow/pull/37839#discussion_r1509567753 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor.py: ## @@ -302,14 +302,15 @@ def __handle_failed_task(self, task_arn: str, reason: str):

(airflow) branch fix-dbapi-hook-signature updated (eb174682df -> 16b6b44cd7)

2024-03-01 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch fix-dbapi-hook-signature in repository https://gitbox.apache.org/repos/asf/airflow.git from eb174682df Make `executemany` keyword arguments only in `DbApiHook.insert_rows` add 16b6b4

[PR] Make `executemany` keyword arguments only in `DbApiHook.insert_rows` [airflow]

2024-03-01 Thread via GitHub
Taragolis opened a new pull request, #37840: URL: https://github.com/apache/airflow/pull/37840 closes: #37838 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull

(airflow) branch fix-dbapi-hook-signature created (now eb174682df)

2024-03-01 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch fix-dbapi-hook-signature in repository https://gitbox.apache.org/repos/asf/airflow.git at eb174682df Make `executemany` keyword arguments only in `DbApiHook.insert_rows` This branch in

(airflow) 01/01: Make `executemany` keyword arguments only in `DbApiHook.insert_rows`

2024-03-01 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch fix-dbapi-hook-signature in repository https://gitbox.apache.org/repos/asf/airflow.git commit eb174682dfd7f25111242bb8899717ef24be6369 Author: Andrey Anshin AuthorDate: Sat Mar 2 00:53:11 2024

Re: [I] Support `uv` in addition to `pip` when extending the Docker image [airflow]

2024-03-01 Thread via GitHub
yehoshuadimarsky commented on issue #37785: URL: https://github.com/apache/airflow/issues/37785#issuecomment-1973840615 Edit #3: Followed instructions here https://docs.docker.com/engine/install/debian/ to setup Docker with BuildKit on GH Codespaces, now I can build the image. It ran for a

Re: [I] Support `uv` in addition to `pip` when extending the Docker image [airflow]

2024-03-01 Thread via GitHub
yehoshuadimarsky commented on issue #37785: URL: https://github.com/apache/airflow/issues/37785#issuecomment-1973819965 Just tried building the image on Windows following these steps: 1. Cloned this repo 2. Checkout the PR branch 3. Ran in Powershell: ```pwsh $env:AIRFLOW_VERSI

[PR] ECS Executor - REMOVED job failure count should not increment [airflow]

2024-03-01 Thread via GitHub
ferruzzi opened a new pull request, #37839: URL: https://github.com/apache/airflow/pull/37839 None of the other executors increment failure count for a REMOVED job. This changes brings ECS Executor in line with the rest. --- **^ Add meaningful descripti

[I] Recent change to DbApiHook affects multiple providers [airflow]

2024-03-01 Thread via GitHub
ferruzzi opened a new issue, #37838: URL: https://github.com/apache/airflow/issues/37838 ### Apache Airflow version 2.8.2 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? It looks like https://github.com/apache/airflow/p

[PR] Resolve PT017 in tests [airflow]

2024-03-01 Thread via GitHub
Taragolis opened a new pull request, #37837: URL: https://github.com/apache/airflow/pull/37837 [`PT017`](https://docs.astral.sh/ruff/rules/pytest-assert-in-except/): raise exception in except block, use pytest.raises() instead --- **^ Add meaningful description

(airflow) branch main updated: Simplify some docs around airflow_local_settings (#37835)

2024-03-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a7691b787b Simplify some docs around airflow_local_

Re: [PR] Simplify some docs around airflow_local_settings [airflow]

2024-03-01 Thread via GitHub
potiuk merged PR #37835: URL: https://github.com/apache/airflow/pull/37835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Use sys.version_info to get the python version [airflow]

2024-03-01 Thread via GitHub
uranusjr commented on PR #37750: URL: https://github.com/apache/airflow/pull/37750#issuecomment-1973762755 IF you really really really want to avoid installing things locally, you could just apply the changes suggested by the CI manually yourself. -- This is an automated message from the

Re: [PR] Raising Exception if dag is not in active state while triggering dag [airflow]

2024-03-01 Thread via GitHub
boring-cyborg[bot] commented on PR #37836: URL: https://github.com/apache/airflow/pull/37836#issuecomment-1973756010 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Raising Exception if dag is not in active state while triggering dag [airflow]

2024-03-01 Thread via GitHub
nj7 opened a new pull request, #37836: URL: https://github.com/apache/airflow/pull/37836 While triggering dag, currently inactive dag created by a templating method (either using variable or static file) gets triggered but there subsequent task never gets triggered, hence remains in ever ru

Re: [PR] Add the dataset_expression as part of get_dag_details [airflow]

2024-03-01 Thread via GitHub
uranusjr commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1509416566 ## airflow/api_connexion/endpoints/dag_endpoint.py: ## @@ -81,11 +82,21 @@ def get_dag_details( for key, value in dag.__dict__.items(): if not key.star

Re: [PR] Add the dataset_expression as part of get_dag_details [airflow]

2024-03-01 Thread via GitHub
uranusjr commented on code in PR #37826: URL: https://github.com/apache/airflow/pull/37826#discussion_r1509416566 ## airflow/api_connexion/endpoints/dag_endpoint.py: ## @@ -81,11 +82,21 @@ def get_dag_details( for key, value in dag.__dict__.items(): if not key.star

Re: [PR] `MappedOperator` setter methods [airflow]

2024-03-01 Thread via GitHub
uranusjr commented on PR #37828: URL: https://github.com/apache/airflow/pull/37828#issuecomment-1973746420 It might be easier to just make these normal instance attributes like `task_id`, `task_group` instead of living one level below. -- This is an automated message from the Apache Git S

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
sudiptob2 commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509401512 ## airflow/www/app.py: ## @@ -70,7 +72,27 @@ def create_app(config=None, testing=False): """Create a new instance of Airflow WWW app.""" -flask_app = Fl

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
Satoshi-Sh commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509407337 ## pyproject.toml: ## @@ -83,7 +83,7 @@ dependencies = [ # The usage was added in #30596, seemingly only to override and improve the default error message.

[PR] Simplify some docs around airflow_local_settings [airflow]

2024-03-01 Thread via GitHub
jedcunningham opened a new pull request, #37835: URL: https://github.com/apache/airflow/pull/37835 This builds on what we did in #37829. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
sudiptob2 commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509401512 ## airflow/www/app.py: ## @@ -70,7 +72,27 @@ def create_app(config=None, testing=False): """Create a new instance of Airflow WWW app.""" -flask_app = Fl

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
potiuk commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509398492 ## airflow/www/app.py: ## @@ -70,7 +72,27 @@ def create_app(config=None, testing=False): """Create a new instance of Airflow WWW app.""" -flask_app = Flask

Re: [I] Airflow UI marks task as failed but the task still running in kubernetes [airflow]

2024-03-01 Thread via GitHub
RNHTTR commented on issue #37800: URL: https://github.com/apache/airflow/issues/37800#issuecomment-1973696566 Can you provide more information? Logs, etc. As is, there's not enough info to be able to reproduce or come up with a solution since the problem is not really clear. -- This is a

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
potiuk commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509377511 ## airflow/cli/commands/internal_api_command.py: ## @@ -73,8 +73,8 @@ def internal_api(args): log.info(f"Starting the Internal API server on port {args.port}

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
potiuk commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509377511 ## airflow/cli/commands/internal_api_command.py: ## @@ -73,8 +73,8 @@ def internal_api(args): log.info(f"Starting the Internal API server on port {args.port}

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
potiuk commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509371886 ## airflow/cli/commands/webserver_command.py: ## @@ -383,7 +383,7 @@ def webserver(args): "--workers", str(num_workers), "--work

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-01 Thread via GitHub
potiuk commented on code in PR #37638: URL: https://github.com/apache/airflow/pull/37638#discussion_r1509367562 ## pyproject.toml: ## @@ -83,7 +83,7 @@ dependencies = [ # The usage was added in #30596, seemingly only to override and improve the default error message.

(airflow) branch main updated (785776a0d7 -> 6ec7386a49)

2024-03-01 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 785776a0d7 Fix images in breeze docs (#37832) add 6ec7386a49 Add section about local settings configuration

Re: [PR] Add section about local settings configuration. [airflow]

2024-03-01 Thread via GitHub
jedcunningham merged PR #37829: URL: https://github.com/apache/airflow/pull/37829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Updated Readme [airflow]

2024-03-01 Thread via GitHub
hamad-tariq commented on PR #37802: URL: https://github.com/apache/airflow/pull/37802#issuecomment-1973608230 > I'm also a bit hesitant to make the readme even longer to cover this case. Yes that's a valid point but it does add some value for the users too. -- This is an automated

[I] ObjectStorage for GCS unable to use GCP connection credential [airflow]

2024-03-01 Thread via GitHub
pankajastro opened a new issue, #37834: URL: https://github.com/apache/airflow/issues/37834 ### Apache Airflow version main (development) ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? Below DAG is unable to use creden

Re: [I] Datasets - trigger DAG run when any dataset is updated [airflow]

2024-03-01 Thread via GitHub
dstandish commented on issue #34534: URL: https://github.com/apache/airflow/issues/34534#issuecomment-1973597174 Yes there's a number of PRs that have been merged for this but this is the one that show you the syntax https://github.com/apache/airflow/pull/37101 -- This is an automated

Re: [I] Grid view tooltip text is truncated if date is too long [airflow]

2024-03-01 Thread via GitHub
simond commented on issue #37782: URL: https://github.com/apache/airflow/issues/37782#issuecomment-1973585299 Fixed by pr #37805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] Grid view tooltip text is truncated if date is too long [airflow]

2024-03-01 Thread via GitHub
simond closed issue #37782: Grid view tooltip text is truncated if date is too long URL: https://github.com/apache/airflow/issues/37782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add section about local settings configuration. [airflow]

2024-03-01 Thread via GitHub
jedcunningham commented on code in PR #37829: URL: https://github.com/apache/airflow/pull/37829#discussion_r1509292335 ## docs/apache-airflow/howto/set-config.rst: ## @@ -167,6 +167,34 @@ the example below. that you run airflow components on is synchronized (for example usi

[PR] Bump sanitize-html from 2.11.0 to 2.12.1 in /airflow/www [airflow]

2024-03-01 Thread via GitHub
dependabot[bot] opened a new pull request, #37833: URL: https://github.com/apache/airflow/pull/37833 Bumps [sanitize-html](https://github.com/apostrophecms/sanitize-html) from 2.11.0 to 2.12.1. Changelog Sourced from https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELO

(airflow) branch dependabot/npm_and_yarn/airflow/www/sanitize-html-2.12.1 created (now ec58587d95)

2024-03-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/airflow/www/sanitize-html-2.12.1 in repository https://gitbox.apache.org/repos/asf/airflow.git at ec58587d95 Bump sanitize-html from 2.11.0 to 2.12.1 in /airflo

Re: [PR] Add section about local settings configuration. [airflow]

2024-03-01 Thread via GitHub
potiuk commented on code in PR #37829: URL: https://github.com/apache/airflow/pull/37829#discussion_r1509287031 ## docs/apache-airflow/howto/set-config.rst: ## @@ -167,6 +167,34 @@ the example below. that you run airflow components on is synchronized (for example using ntp

(airflow) branch main updated (11f732c7d0 -> 785776a0d7)

2024-03-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 11f732c7d0 Add a bit more PT rules (#37827) add 785776a0d7 Fix images in breeze docs (#37832) No new revisions we

Re: [PR] Fix images in breeze docs [airflow]

2024-03-01 Thread via GitHub
potiuk merged PR #37832: URL: https://github.com/apache/airflow/pull/37832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Updated Readme [airflow]

2024-03-01 Thread via GitHub
jedcunningham commented on PR #37802: URL: https://github.com/apache/airflow/pull/37802#issuecomment-1973562551 I'm also a bit hesitant to make the readme even longer to cover this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

(airflow) branch main updated: Add a bit more PT rules (#37827)

2024-03-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 11f732c7d0 Add a bit more PT rules (#37827) 11f732c

Re: [PR] Add a bit more PT rules [airflow]

2024-03-01 Thread via GitHub
potiuk merged PR #37827: URL: https://github.com/apache/airflow/pull/37827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Add section about local settings configuration. [airflow]

2024-03-01 Thread via GitHub
jedcunningham commented on code in PR #37829: URL: https://github.com/apache/airflow/pull/37829#discussion_r1509273244 ## docs/apache-airflow/howto/set-config.rst: ## @@ -167,6 +167,34 @@ the example below. that you run airflow components on is synchronized (for example usi

Re: [PR] Add section about local settings configuration. [airflow]

2024-03-01 Thread via GitHub
jedcunningham commented on code in PR #37829: URL: https://github.com/apache/airflow/pull/37829#discussion_r1509269574 ## docs/apache-airflow/howto/set-config.rst: ## @@ -167,6 +167,34 @@ the example below. that you run airflow components on is synchronized (for example usi

(airflow) branch main updated (4a048161b1 -> 653c8be8a3)

2024-03-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 4a048161b1 Increase tooltip size of dag grid view (#37782) (#37805) add 653c8be8a3 Fix docs of `BranchDayOfWeekOpe

Re: [PR] Fix docs of `BranchDayOfWeekOperator` [airflow]

2024-03-01 Thread via GitHub
potiuk merged PR #37813: URL: https://github.com/apache/airflow/pull/37813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Avoid use of `assert` outside of the tests [airflow]

2024-03-01 Thread via GitHub
uranusjr commented on code in PR #37718: URL: https://github.com/apache/airflow/pull/37718#discussion_r1509268413 ## airflow/cli/commands/task_command.py: ## @@ -212,7 +212,8 @@ def _run_task_by_selected_method( - as raw task - by executor """ -assert not isin

[PR] Fix images in breeze docs [airflow]

2024-03-01 Thread via GitHub
jedcunningham opened a new pull request, #37832: URL: https://github.com/apache/airflow/pull/37832 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [I] 2 webservers active upon upgrade using helm chart and startupprobe keeps failing. [airflow]

2024-03-01 Thread via GitHub
potiuk closed issue #37812: 2 webservers active upon upgrade using helm chart and startupprobe keeps failing. URL: https://github.com/apache/airflow/issues/37812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Datasets - trigger DAG run when any dataset is updated [airflow]

2024-03-01 Thread via GitHub
gabrielrmn commented on issue #34534: URL: https://github.com/apache/airflow/issues/34534#issuecomment-1973496328 any updates here? looking forward for this improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Uploading logs to Google Cloud Storage fails after a task completes [airflow]

2024-03-01 Thread via GitHub
potiuk closed issue #37809: Uploading logs to Google Cloud Storage fails after a task completes URL: https://github.com/apache/airflow/issues/37809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] Uploading logs to Google Cloud Storage fails after a task completes [airflow]

2024-03-01 Thread via GitHub
potiuk commented on issue #37809: URL: https://github.com/apache/airflow/issues/37809#issuecomment-1973475005 Some of your operators are storing some fields whaicah are unpicklable, but it's hard to say which ones. Unfortunately they are set in the way that does not reveal which fields they

Re: [PR] Fix external_executor_id being overwritten [airflow]

2024-03-01 Thread via GitHub
potiuk commented on PR #37784: URL: https://github.com/apache/airflow/pull/37784#issuecomment-1973460948 I might be wrong of course, but that sounds like a case where overriding it would make sense (but it's more of "I am not sure" that "I know"). -- This is an automated message from the

Re: [I] Apply Airflow Reverse Proxy Through the Values.yaml [airflow]

2024-03-01 Thread via GitHub
potiuk commented on issue #37825: URL: https://github.com/apache/airflow/issues/37825#issuecomment-1973441644 Discussion is good for questions - there is no need to open both discussion and issue. Hopefully someone will chime in in the discusssion -- This is an automated message from the

Re: [I] Scheduler fails to schedule DagRuns due to persistent DAG record lock [airflow]

2024-03-01 Thread via GitHub
Schlyterr commented on issue #36920: URL: https://github.com/apache/airflow/issues/36920#issuecomment-1973422572 We ran into this issue today and after following these steps it started working again. 1. Pause all DAGs 2. Going into Browse -> Task Instances and deleting all tasks th

[PR] Add section about local settings configuration. [airflow]

2024-03-01 Thread via GitHub
potiuk opened a new pull request, #37829: URL: https://github.com/apache/airflow/pull/37829 Often people see in our docs or issues/discussions that they should configure local settings, but - surprisingly - there is not a single section that explains it. Some specific configuration capabili

Re: [I] Annotate a Dataset Event in the Source Task [airflow]

2024-03-01 Thread via GitHub
jedcunningham commented on issue #37810: URL: https://github.com/apache/airflow/issues/37810#issuecomment-1973379755 LGTM, looking forward to this 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] fix: adding lots of setter methods [airflow]

2024-03-01 Thread via GitHub
nathadfield opened a new pull request, #37828: URL: https://github.com/apache/airflow/pull/37828 Closes #37013 Addresses this issue referenced that prevents cluster policies from modifying task attributes by adding lots of additional `setter` methods to the `MappedOperator`. -- T

[PR] Add a bit more PT rules [airflow]

2024-03-01 Thread via GitHub
Taragolis opened a new pull request, #37827: URL: https://github.com/apache/airflow/pull/37827 Enable other PT rules which do not required to do a lot of actions. Since we enable more rule than exclude, I've add other rules to exclusion list instead. That not mean that we

[PR] Add the dataset_expression as part of get_dag_details [airflow]

2024-03-01 Thread via GitHub
sunank200 opened a new pull request, #37826: URL: https://github.com/apache/airflow/pull/37826 - Add the dataset_expression as part of get_dag_details For example, the following dataset expression: `(dag1_dataset | (dag2_dataset & dag3_dataset))` is returned as part of dictionary.

  1   2   >