[PR] Add padding to bottom of log block. [airflow]

2024-03-28 Thread via GitHub
tirkarthi opened a new pull request, #38610: URL: https://github.com/apache/airflow/pull/38610 With addition of grouping logs in the UI absence of padding at the bottom can be interfering with the scroll bar. Since pb={0} was already there should be a purpose for that but couldn't find it

Re: [PR] Remove @provide_session from _get_ti [airflow]

2024-03-28 Thread via GitHub
dstandish commented on code in PR #38570: URL: https://github.com/apache/airflow/pull/38570#discussion_r1544066909 ## airflow/cli/commands/task_command.py: ## @@ -149,23 +150,27 @@ def _get_dag_run( execution_date=dag_run_execution_date,

Re: [PR] Edited timetable docs [airflow]

2024-03-28 Thread via GitHub
uranusjr commented on code in PR #38505: URL: https://github.com/apache/airflow/pull/38505#discussion_r1544046401 ## docs/apache-airflow/authoring-and-scheduling/timetable.rst: ## @@ -19,49 +19,49 @@ Timetables == -For DAGs with time-based schedules (as opposed to

Re: [PR] Remove @provide_session from _get_ti [airflow]

2024-03-28 Thread via GitHub
dstandish commented on code in PR #38570: URL: https://github.com/apache/airflow/pull/38570#discussion_r1544014877 ## airflow/cli/commands/task_command.py: ## @@ -149,23 +150,27 @@ def _get_dag_run( execution_date=dag_run_execution_date,

Re: [PR] Remove @provide_session from _get_ti [airflow]

2024-03-28 Thread via GitHub
uranusjr commented on code in PR #38570: URL: https://github.com/apache/airflow/pull/38570#discussion_r1544011206 ## airflow/cli/commands/task_command.py: ## @@ -149,23 +150,27 @@ def _get_dag_run( execution_date=dag_run_execution_date,

[PR] Improve XComObjectStoreBackend implementation [airflow]

2024-03-28 Thread via GitHub
uranusjr opened a new pull request, #38608: URL: https://github.com/apache/airflow/pull/38608 Repeated configuration access is moved to cached functions so the string literals don't need to be written repeatedly. The path configuration is made mandatory since it more or less is; using this

Re: [I] dag run successfully with eventlet.monkey_patch() warning!? [airflow]

2024-03-28 Thread via GitHub
claude89757 commented on issue #38581: URL: https://github.com/apache/airflow/issues/38581#issuecomment-2026508793 > https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#worker-class it is not webserver‘s worker with warnings, it is the worker to run dags!!!

[PR] Rename to XComObjectStorageBackend [airflow]

2024-03-28 Thread via GitHub
uranusjr opened a new pull request, #38607: URL: https://github.com/apache/airflow/pull/38607 The config names all use "object storage", but the class is still using "object store". Let's rename the class for consistency. See #38142 #38415. -- This is an automated message from the

Re: [PR] Rename XCOM_OBJECTSTORAGE to XCOM_OBJECTSTORE [airflow]

2024-03-28 Thread via GitHub
uranusjr closed pull request #38606: Rename XCOM_OBJECTSTORAGE to XCOM_OBJECTSTORE URL: https://github.com/apache/airflow/pull/38606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(airflow) branch main updated: Implement context accessor for DatasetEvent extra (#38481)

2024-03-28 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fce3a58334 Implement context accessor for

Re: [PR] Implement context accessor for DatasetEvent extra [airflow]

2024-03-28 Thread via GitHub
uranusjr merged PR #38481: URL: https://github.com/apache/airflow/pull/38481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use explicit and easier to use runs-on approach for CI workflows [airflow]

2024-03-28 Thread via GitHub
potiuk commented on PR #38605: URL: https://github.com/apache/airflow/pull/38605#issuecomment-2026450838 same as #38601 but run as canary run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Use explicit and easier to use runs-on approach for CI workflows [airflow]

2024-03-28 Thread via GitHub
potiuk closed pull request #38605: Use explicit and easier to use runs-on approach for CI workflows URL: https://github.com/apache/airflow/pull/38605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Use explicit and easier to use runs-on approach for CI workflows [airflow]

2024-03-28 Thread via GitHub
potiuk opened a new pull request, #38605: URL: https://github.com/apache/airflow/pull/38605 Depending on selective checks, but also on the job executed, we choose whether to run job on public runners or self-hosted runners. So far the set of labels to select the runners were passed in a

(airflow) 01/01: Use explicit and easier to use runs-on approach for CI workflows

2024-03-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch consistent-approach-for-runs-on-usage in repository https://gitbox.apache.org/repos/asf/airflow.git commit b8056fa2849ebf40cb990f38cb6c6dc7bfe38614 Author: Jarek Potiuk AuthorDate: Thu Mar 28

(airflow) branch consistent-approach-for-runs-on-usage created (now b8056fa284)

2024-03-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch consistent-approach-for-runs-on-usage in repository https://gitbox.apache.org/repos/asf/airflow.git at b8056fa284 Use explicit and easier to use runs-on approach for CI workflows This

Re: [PR] Hide internals of some groupped workflows [airflow]

2024-03-28 Thread via GitHub
potiuk commented on PR #38604: URL: https://github.com/apache/airflow/pull/38604#issuecomment-2026431281 Avoids this: https://github.com/apache/airflow/assets/595491/07e726a4-6964-4cb8-bbb8-2ced24a4a1b4;> -- This is an automated message from the Apache Git Service. To respond

[PR] Hide internals of some groupped workflows [airflow]

2024-03-28 Thread via GitHub
potiuk opened a new pull request, #38604: URL: https://github.com/apache/airflow/pull/38604 When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as

[PR] pt012 issue fix amazon [airflow]

2024-03-28 Thread via GitHub
Bowrna opened a new pull request, #38603: URL: https://github.com/apache/airflow/pull/38603 related: #38270 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [I] 'utf-8' codec can't decode byte 0x80 in position 0: invalid start byte (after upgrade to 2.8.2) [airflow]

2024-03-28 Thread via GitHub
github-actions[bot] commented on issue #37871: URL: https://github.com/apache/airflow/issues/37871#issuecomment-2026356888 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Wrong order of parameters in WebUI [airflow]

2024-03-28 Thread via GitHub
github-actions[bot] commented on issue #35944: URL: https://github.com/apache/airflow/issues/35944#issuecomment-2026356949 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Support configuring multiple namespace for multiNamespaceMode [airflow]

2024-03-28 Thread via GitHub
github-actions[bot] closed pull request #35639: Support configuring multiple namespace for multiNamespaceMode URL: https://github.com/apache/airflow/pull/35639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Wrong order of parameters in WebUI [airflow]

2024-03-28 Thread via GitHub
github-actions[bot] closed issue #35944: Wrong order of parameters in WebUI URL: https://github.com/apache/airflow/issues/35944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] 404 Pod not found can be seen often [airflow]

2024-03-28 Thread via GitHub
github-actions[bot] commented on issue #37090: URL: https://github.com/apache/airflow/issues/37090#issuecomment-2026356927 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [I] 'utf-8' codec can't decode byte 0x80 in position 0: invalid start byte (after upgrade to 2.8.2) [airflow]

2024-03-28 Thread via GitHub
github-actions[bot] closed issue #37871: 'utf-8' codec can't decode byte 0x80 in position 0: invalid start byte (after upgrade to 2.8.2) URL: https://github.com/apache/airflow/issues/37871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] context["task_instance"] does not pickup correct instance if multiple runs (with almost timestamp) [airflow]

2024-03-28 Thread via GitHub
github-actions[bot] closed issue #37960: context["task_instance"] does not pickup correct instance if multiple runs (with almost timestamp) URL: https://github.com/apache/airflow/issues/37960 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] context["task_instance"] does not pickup correct instance if multiple runs (with almost timestamp) [airflow]

2024-03-28 Thread via GitHub
github-actions[bot] commented on issue #37960: URL: https://github.com/apache/airflow/issues/37960#issuecomment-2026356868 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
ferruzzi commented on PR #38602: URL: https://github.com/apache/airflow/pull/38602#issuecomment-2026320220 @Taragolis - I added you to the review list since you saw the previous attempt at this, don't feel obligated though. -- This is an automated message from the Apache Git Service. To

[PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
ferruzzi opened a new pull request, #38602: URL: https://github.com/apache/airflow/pull/38602 Includes the basic doc page, hook, operator, unit tests, and system test. Currently only supports invoking one of the prebuilt "foundation" models. Custom model support is coming next.

Re: [PR] Implement context accessor for DatasetEvent extra [airflow]

2024-03-28 Thread via GitHub
potiuk commented on code in PR #38481: URL: https://github.com/apache/airflow/pull/38481#discussion_r1543841511 ## scripts/ci/pre_commit/pre_commit_template_context_key_sync.py: ## Review Comment: BTW. `...` -> View file shows that it is definitely not empty. -- This

Re: [PR] Implement context accessor for DatasetEvent extra [airflow]

2024-03-28 Thread via GitHub
potiuk commented on code in PR #38481: URL: https://github.com/apache/airflow/pull/38481#discussion_r1543841206 ## scripts/ci/pre_commit/pre_commit_template_context_key_sync.py: ## Review Comment: Definitely misleading. It does show permission change (100644 -> 100755) but

Re: [PR] Implement context accessor for DatasetEvent extra [airflow]

2024-03-28 Thread via GitHub
uranusjr commented on code in PR #38481: URL: https://github.com/apache/airflow/pull/38481#discussion_r1543836544 ## scripts/ci/pre_commit/pre_commit_template_context_key_sync.py: ## Review Comment: And the file is definitely not empty; I guess by “this file is empty”

Re: [PR] Implement context accessor for DatasetEvent extra [airflow]

2024-03-28 Thread via GitHub
uranusjr commented on code in PR #38481: URL: https://github.com/apache/airflow/pull/38481#discussion_r1543835985 ## docs/apache-airflow/authoring-and-scheduling/datasets.rst: ## @@ -224,6 +224,29 @@ If one dataset is updated multiple times before all consumed datasets have

Re: [PR] Implement context accessor for DatasetEvent extra [airflow]

2024-03-28 Thread via GitHub
uranusjr commented on code in PR #38481: URL: https://github.com/apache/airflow/pull/38481#discussion_r1543834911 ## scripts/ci/pre_commit/pre_commit_template_context_key_sync.py: ## Review Comment: I did a `chmod +x`; it wasn’t executing correctly. -- This is an

[PR] Use explicit and easier to use runs-on approach for CI workflows [airflow]

2024-03-28 Thread via GitHub
potiuk opened a new pull request, #38601: URL: https://github.com/apache/airflow/pull/38601 Depending on selective checks, but also on the job executed, we choose whether to run job on public runners or self-hosted runners. So far the set of labels to select the runners were passed in a

(airflow) branch main updated: Brings back mypy-checks (#38597)

2024-03-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a2f5307fd0 Brings back mypy-checks (#38597)

Re: [PR] Brings back mypy-checks [airflow]

2024-03-28 Thread via GitHub
potiuk merged PR #38597: URL: https://github.com/apache/airflow/pull/38597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]

2024-03-28 Thread via GitHub
potiuk commented on PR #38594: URL: https://github.com/apache/airflow/pull/38594#issuecomment-2026283948 > path = sys.path[0] + "/tests/providers/cncf/kubernetes/pod.yaml" Yeah. Someone took advantage of assuming sys.path will be modified :) -- This is an automated message from the

Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]

2024-03-28 Thread via GitHub
Taragolis commented on PR #38594: URL: https://github.com/apache/airflow/pull/38594#issuecomment-2026281241 樂 樂 樂 ```console # Provide existent file path, # so loaded YAML file content should be used to call deserialize_model_dict(), rather than None.

Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]

2024-03-28 Thread via GitHub
Taragolis commented on PR #38594: URL: https://github.com/apache/airflow/pull/38594#issuecomment-2026275654 > interesting . I had no idea pytest is doing that. I've found myself it about week ago when try to find how to solve one issue. -- This is an automated message from the

Re: [PR] Brings back mypy-checks [airflow]

2024-03-28 Thread via GitHub
potiuk commented on PR #38597: URL: https://github.com/apache/airflow/pull/38597#issuecomment-2026264526 Should be fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]

2024-03-28 Thread via GitHub
potiuk commented on PR #38594: URL: https://github.com/apache/airflow/pull/38594#issuecomment-2026264100 interesting . I had no idea pytest is doing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Brings back mypy-checks [airflow]

2024-03-28 Thread via GitHub
potiuk commented on PR #38597: URL: https://github.com/apache/airflow/pull/38597#issuecomment-2026251541 Just one small issue :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] sql.py imported from sql in postgreshook not writing sql statements in the task logs [airflow]

2024-03-28 Thread via GitHub
potiuk closed issue #38498: sql.py imported from sql in postgreshook not writing sql statements in the task logs URL: https://github.com/apache/airflow/issues/38498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] sql.py imported from sql in postgreshook not writing sql statements in the task logs [airflow]

2024-03-28 Thread via GitHub
potiuk commented on issue #38498: URL: https://github.com/apache/airflow/issues/38498#issuecomment-2026249290 I think someone might take a look if you spend a little time on explaining what exactly is wrog. I spend about a minute looking at your description and have no idea not even what

[I] Possible race condition in triggerer when running multiple instances [airflow]

2024-03-28 Thread via GitHub
Lioscro opened a new issue, #38599: URL: https://github.com/apache/airflow/issues/38599 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.6.3 ### What happened? Our Airflow

Re: [I] Possible race condition in triggerer when running multiple instances [airflow]

2024-03-28 Thread via GitHub
boring-cyborg[bot] commented on issue #38599: URL: https://github.com/apache/airflow/issues/38599#issuecomment-2026240949 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

Re: [PR] Brings back mypy-checks [airflow]

2024-03-28 Thread via GitHub
potiuk commented on PR #38597: URL: https://github.com/apache/airflow/pull/38597#issuecomment-2026232201 It was literally day-and-a-half or so, so I hope there won't be many things to fix  -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Bug when running airflow right after install [airflow]

2024-03-28 Thread via GitHub
boring-cyborg[bot] commented on issue #38598: URL: https://github.com/apache/airflow/issues/38598#issuecomment-2026218754 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[I] Bug when running airflow right after install [airflow]

2024-03-28 Thread via GitHub
kvak opened a new issue, #38598: URL: https://github.com/apache/airflow/issues/38598 ### Apache Airflow version 2.8.4 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? `pip3 install apache-airflow` I get:

(airflow) branch main updated (85f3b46701 -> 8617dc4634)

2024-03-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 85f3b46701 Fix secrets inheriting for docs build (#38596) add 8617dc4634 Move `*_wait_for_done_logging` into the

Re: [PR] Move `*_wait_for_done_logging` into the db tests [airflow]

2024-03-28 Thread via GitHub
potiuk merged PR #38595: URL: https://github.com/apache/airflow/pull/38595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (a9a6976dd2 -> 85f3b46701)

2024-03-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a9a6976dd2 docs: yandex provider grammatical improvements (#38589) add 85f3b46701 Fix secrets inheriting for docs

Re: [PR] Fix secrets inheriting for docs build [airflow]

2024-03-28 Thread via GitHub
potiuk merged PR #38596: URL: https://github.com/apache/airflow/pull/38596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Brings back mypy-checks [airflow]

2024-03-28 Thread via GitHub
potiuk opened a new pull request, #38597: URL: https://github.com/apache/airflow/pull/38597 During the last week refactor input on mypy checks was moved to another workflow and mypy checks were not running for a day. This change brings it back. ---

Re: [PR] Add a migration script for encrypted trigger kwargs [airflow]

2024-03-28 Thread via GitHub
hussein-awala commented on code in PR #38358: URL: https://github.com/apache/airflow/pull/38358#discussion_r1543773967 ## airflow/migrations/versions/0138_2_9_0_encrypt_trigger_kwargs.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[PR] Fix secrets inheriting for docs build [airflow]

2024-03-28 Thread via GitHub
potiuk opened a new pull request, #38596: URL: https://github.com/apache/airflow/pull/38596 The workflow for docs building had been moved to a different sub-workflow and it needs secrets in canary build to upload the docs to AWS. This PR adds the secret inheriting to the docs workflow to

Re: [PR] Support multiple Docker hosts in `docker_url` attribute. [airflow]

2024-03-28 Thread via GitHub
Taragolis commented on code in PR #38466: URL: https://github.com/apache/airflow/pull/38466#discussion_r1543759158 ## airflow/providers/docker/operators/docker.py: ## @@ -343,13 +345,20 @@ def hook(self) -> DockerHook: assert_hostname=self.tls_hostname,

Re: [PR] Support multiple Docker hosts in `docker_url` attribute. [airflow]

2024-03-28 Thread via GitHub
Taragolis commented on code in PR #38466: URL: https://github.com/apache/airflow/pull/38466#discussion_r1543749181 ## airflow/providers/docker/operators/docker.py: ## @@ -283,6 +283,8 @@ def __init__( self.dns = dns self.dns_search = dns_search

Re: [PR] Migrate to connexion v3 [airflow]

2024-03-28 Thread via GitHub
Satoshi-Sh commented on PR #37638: URL: https://github.com/apache/airflow/pull/37638#issuecomment-2026171883 Hi @RobbeSneyders , I'm working on the test_error_handling.py at the moment. You might have some ideas to fix the errors. Could you have a look at this? You can find the

(airflow) branch main updated: docs: yandex provider grammatical improvements (#38589)

2024-03-28 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a9a6976dd2 docs: yandex provider grammatical

Re: [PR] docs: yandex provider grammatical improvements [airflow]

2024-03-28 Thread via GitHub
hussein-awala merged PR #38589: URL: https://github.com/apache/airflow/pull/38589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
ferruzzi commented on code in PR #38575: URL: https://github.com/apache/airflow/pull/38575#discussion_r1543742834 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -0,0 +1,118 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
Taragolis commented on code in PR #38575: URL: https://github.com/apache/airflow/pull/38575#discussion_r1543734669 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -0,0 +1,118 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]

2024-03-28 Thread via GitHub
Taragolis closed pull request #38594: [Experiment] Use `importlib` import mode for `pytest` URL: https://github.com/apache/airflow/pull/38594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Move `*_wait_for_done_logging` into the db tests [airflow]

2024-03-28 Thread via GitHub
Taragolis opened a new pull request, #38595: URL: https://github.com/apache/airflow/pull/38595 Different measures for fix flakey behaviour in this similar tests, both og them test `run_beam_command` from Apache Beam Provider - one test in Apache Beam Provider another in

[PR] [Experiment] Use `importlib` import mode for `pytest` [airflow]

2024-03-28 Thread via GitHub
Taragolis opened a new pull request, #38594: URL: https://github.com/apache/airflow/pull/38594 - [import mode](https://docs.pytest.org/en/latest/explanation/pythonpath.html#import-modes) - [Choosing a test layout / import

(airflow) 01/01: [Experiment] Use `importlib` import mode for `pytest`

2024-03-28 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch pytest-import-mode-importlib in repository https://gitbox.apache.org/repos/asf/airflow.git commit 586451344a8603f10439bf136406f78348212896 Author: Andrey Anshin AuthorDate: Fri Mar 29

(airflow) branch pytest-import-mode-importlib created (now 586451344a)

2024-03-28 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch pytest-import-mode-importlib in repository https://gitbox.apache.org/repos/asf/airflow.git at 586451344a [Experiment] Use `importlib` import mode for `pytest` This branch includes the

Re: [PR] Refactor DAG tabs navigation [airflow]

2024-03-28 Thread via GitHub
jedcunningham commented on PR #38592: URL: https://github.com/apache/airflow/pull/38592#issuecomment-2026057162 I pulled this up and experimented with it for a few minutes. I like it. It's intuitive and easy to use. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Apprise fix [airflow]

2024-03-28 Thread via GitHub
boring-cyborg[bot] commented on PR #38593: URL: https://github.com/apache/airflow/pull/38593#issuecomment-2026030812 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Apprise fix [airflow]

2024-03-28 Thread via GitHub
rrr2rrr opened a new pull request, #38593: URL: https://github.com/apache/airflow/pull/38593 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
ferruzzi commented on code in PR #38575: URL: https://github.com/apache/airflow/pull/38575#discussion_r1543575746 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -0,0 +1,118 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add a migration script for encrypted trigger kwargs [airflow]

2024-03-28 Thread via GitHub
utkarsharma2 commented on code in PR #38358: URL: https://github.com/apache/airflow/pull/38358#discussion_r1543575210 ## airflow/migrations/versions/0138_2_9_0_encrypt_trigger_kwargs.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

Re: [PR] Add a migration script for encrypted trigger kwargs [airflow]

2024-03-28 Thread via GitHub
utkarsharma2 commented on code in PR #38358: URL: https://github.com/apache/airflow/pull/38358#discussion_r1543572691 ## airflow/migrations/versions/0138_2_9_0_encrypt_trigger_kwargs.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

Re: [PR] Add a migration script for encrypted trigger kwargs [airflow]

2024-03-28 Thread via GitHub
utkarsharma2 commented on code in PR #38358: URL: https://github.com/apache/airflow/pull/38358#discussion_r1543573781 ## airflow/migrations/versions/0138_2_9_0_encrypt_trigger_kwargs.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

(airflow) branch main updated (507d516ff8 -> b3af7f07d0)

2024-03-28 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 507d516ff8 Add missing containers to helm chart resources docs (#38534) add b3af7f07d0 Resolve `PT012` in

Re: [PR] pt012 fix for k8s cncf [airflow]

2024-03-28 Thread via GitHub
Taragolis merged PR #38529: URL: https://github.com/apache/airflow/pull/38529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Implement context accessor for DatasetEvent extra [airflow]

2024-03-28 Thread via GitHub
jscheffl commented on code in PR #38481: URL: https://github.com/apache/airflow/pull/38481#discussion_r1543555175 ## scripts/ci/pre_commit/pre_commit_template_context_key_sync.py: ## Review Comment: This file is uuups, empty? I assume this is a mistake? -- This is an

Re: [PR] Implement context accessor for DatasetEvent extra [airflow]

2024-03-28 Thread via GitHub
jscheffl commented on code in PR #38481: URL: https://github.com/apache/airflow/pull/38481#discussion_r1543552790 ## airflow/models/taskinstance.py: ## @@ -761,6 +767,7 @@ def get_triggering_events() -> dict[str, list[DatasetEvent | DatasetEventPydanti "dag_run":

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
Taragolis commented on code in PR #38575: URL: https://github.com/apache/airflow/pull/38575#discussion_r1543548966 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -0,0 +1,118 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[PR] Refactor DAG tabs navigation [airflow]

2024-03-28 Thread via GitHub
bbovenzi opened a new pull request, #38592: URL: https://github.com/apache/airflow/pull/38592 We got rid of all of the old DAG pages and their buttons. But in the grid view, the tabs displayed depended on the task+run selection. It was then confusing as to where views disappeared to.

Re: [PR] Expose AWS IAM missing param in Hashicorp secret [airflow]

2024-03-28 Thread via GitHub
pankajastro commented on code in PR #38536: URL: https://github.com/apache/airflow/pull/38536#discussion_r1543545322 ## airflow/providers/hashicorp/_internal_client/vault_client.py: ## @@ -103,7 +108,11 @@ def __init__( password: str | None = None, key_id: str

Re: [PR] Add missing containers to helm chart resources docs [airflow]

2024-03-28 Thread via GitHub
jedcunningham merged PR #38534: URL: https://github.com/apache/airflow/pull/38534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Add missing containers to helm chart resources docs (#38534)

2024-03-28 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 507d516ff8 Add missing containers to helm

(airflow) branch main updated (32e04a408c -> b9d3f38ceb)

2024-03-28 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 32e04a408c Better fix for constraint generation dependency for PROD build (#38582) add b9d3f38ceb

Re: [PR] Address some minor issues in the release guide [airflow]

2024-03-28 Thread via GitHub
ephraimbuddy merged PR #38588: URL: https://github.com/apache/airflow/pull/38588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated (a64bb40a0f -> 32e04a408c)

2024-03-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a64bb40a0f Don't error when (un)pausing (un)paused dag in the CLI (#38585) add 32e04a408c Better fix for

Re: [PR] Better fix for constraint generation dependency for PROD build [airflow]

2024-03-28 Thread via GitHub
potiuk merged PR #38582: URL: https://github.com/apache/airflow/pull/38582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
ferruzzi closed pull request #38575: Introduce Amazon Bedrock service URL: https://github.com/apache/airflow/pull/38575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] bugfix: properly serialize nested attrs classes [airflow]

2024-03-28 Thread via GitHub
tomrutter opened a new pull request, #38591: URL: https://github.com/apache/airflow/pull/38591 --- closes: #38540 Running attr.asdict with recurse=False allows the serialize function to later serialize the nested attr objects consistently. With

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
ferruzzi commented on PR #38575: URL: https://github.com/apache/airflow/pull/38575#issuecomment-2025783635 Had to fix the operator unit tests. I've run the above dag against the live service several times, so the issue was in my mocked response format, not in the operator.

Re: [PR] Address some minor issues in the release guide [airflow]

2024-03-28 Thread via GitHub
ephraimbuddy commented on code in PR #38588: URL: https://github.com/apache/airflow/pull/38588#discussion_r154329 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -852,7 +857,7 @@ Documentation for providers can be found in the ``/docs/apache-airflow`` directo ```shell

Re: [I] sql.py from the postgreshook not writing sql statements in the task logs [airflow]

2024-03-28 Thread via GitHub
Mrhacktivist commented on issue #38498: URL: https://github.com/apache/airflow/issues/38498#issuecomment-2025630347 Can someone please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-28 Thread via GitHub
ferruzzi commented on PR #38575: URL: https://github.com/apache/airflow/pull/38575#issuecomment-2025576804 One day I'll learn that "one last little tweak" after running static checks is a bad idea. But apparently today is not that day. Fix coming. -- This is an automated message from

[PR] docs: yandex provider grammatical improvements [airflow]

2024-03-28 Thread via GitHub
ImpressionableRaccoon opened a new pull request, #38589: URL: https://github.com/apache/airflow/pull/38589 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Resolve `PT012` in `SFTP` provider tests [airflow]

2024-03-28 Thread via GitHub
eladkal commented on PR #38518: URL: https://github.com/apache/airflow/pull/38518#issuecomment-2025568339 Can you rebase and resolve conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Separate dag/task UI display name from dag / task id [airflow]

2024-03-28 Thread via GitHub
cmarteepants commented on issue #22073: URL: https://github.com/apache/airflow/issues/22073#issuecomment-2025535198 @pnsvk the [PR](https://github.com/apache/airflow/pull/38446) will be included as part of 2.9, which should be released within the next 1.5 weeks -- This is an automated

Re: [PR] Address some minor issues in the release guide [airflow]

2024-03-28 Thread via GitHub
potiuk commented on code in PR #38588: URL: https://github.com/apache/airflow/pull/38588#discussion_r1543186549 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -852,7 +857,7 @@ Documentation for providers can be found in the ``/docs/apache-airflow`` directo ```shell script

Re: [PR] Address some minor issues in the release guide [airflow]

2024-03-28 Thread via GitHub
higrys commented on code in PR #38588: URL: https://github.com/apache/airflow/pull/38588#discussion_r1543185968 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -852,7 +857,7 @@ Documentation for providers can be found in the ``/docs/apache-airflow`` directo ```shell script

  1   2   >