Re: [I] Airflow sending negative values [airflow]

2024-04-07 Thread via GitHub
github-actions[bot] closed issue #29953: Airflow sending negative values URL: https://github.com/apache/airflow/issues/29953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Add a newsfragment for PR 38015 validation [airflow]

2024-04-07 Thread via GitHub
jscheffl opened a new pull request, #38811: URL: https://github.com/apache/airflow/pull/38811 As I was stumbling over this problem in RC2 testing I propose we add a newsfragment in order to inform users about the stronger validation - which in my case rather looked like a breaking change.

[PR] Add MobiKwik as an Airflow user into INTHEWILD.md [airflow]

2024-04-07 Thread via GitHub
ketankkeshri opened a new pull request, #38812: URL: https://github.com/apache/airflow/pull/38812 Add MobiKwik as an Airflow user. MobiKwik- A leading Indian fintech company. --- **^ Add meaningful description above** Read the **[Pull Request Guide

Re: [PR] Add MobiKwik as an Airflow user into INTHEWILD.md [airflow]

2024-04-07 Thread via GitHub
boring-cyborg[bot] commented on PR #38812: URL: https://github.com/apache/airflow/pull/38812#issuecomment-2041345767 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

Re: [PR] Don't allow defaults other than None in context parameters, and improve error message [airflow]

2024-04-07 Thread via GitHub
jscheffl commented on PR #38015: URL: https://github.com/apache/airflow/pull/38015#issuecomment-2041348474 Uh, oh, late to the party. I noticed this change which - after some reading - really looks understandable. But when testing 2.9.0RC2 I had a lot of broken DAGs and it felt to be like a

Re: [PR] Update ACL during job reset [airflow]

2024-04-07 Thread via GitHub
subham611 commented on PR #38741: URL: https://github.com/apache/airflow/pull/38741#issuecomment-2041350618 @Lee-W `Wait for CI images ` step is failing. How should I fix this, or simply rerun would work? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
slycyberguy commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1554839150 ## .github/workflows/ci.yml: ## Review Comment: On my local repo, I added CodeCov to the file and I accidentally committed it. So I removed the update. -

Re: [PR] Added Feature: search dags by task id with suggestions [airflow]

2024-04-07 Thread via GitHub
pruoff commented on PR #37436: URL: https://github.com/apache/airflow/pull/37436#issuecomment-2041368166 @jscheffl > I checked and I have no auto-complete and suggestions when I type as described in the PR descriptions. Tested with Firefox and Chromium. Did I mis-undertstand the PR that

[PR] Add pre-commit script to keep tags sorted in OpenAPI spec [airflow]

2024-04-07 Thread via GitHub
pankajkoti opened a new pull request, #38813: URL: https://github.com/apache/airflow/pull/38813 Following up with PR #38717, this PR adds a pre-commit hook to keep the tags list sorted in the OpenAPI spec yaml. I previously tried to use the pyyaml library, to find the tags and r

Re: [PR] Add pre-commit script to keep tags sorted in OpenAPI spec [airflow]

2024-04-07 Thread via GitHub
pankajkoti commented on PR #38813: URL: https://github.com/apache/airflow/pull/38813#issuecomment-2041378133 **Pre-commit in action:** **The files contents that were manually updated to check the pre-commit:** https://github.com/apache/airflow/assets/10206082/ee4e3b3b-9ef4-48bc-8742

Re: [PR] Add `AirflowInternalRuntimeError` for raise "non catchable" errors [airflow]

2024-04-07 Thread via GitHub
Taragolis merged PR #38778: URL: https://github.com/apache/airflow/pull/38778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Add `AirflowInternalRuntimeError` for raise "non catchable" errors (#38778)

2024-04-07 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4358511fce Add `AirflowInternalRuntimeError` for

Re: [I] KubernetesPodOperator prints empty log lines without respecting the log format [airflow]

2024-04-07 Thread via GitHub
karakanb commented on issue #36571: URL: https://github.com/apache/airflow/issues/36571#issuecomment-2041385244 please reopen this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Add MobiKwik as an Airflow user into INTHEWILD.md [airflow]

2024-04-07 Thread via GitHub
pankajkoti commented on code in PR #38812: URL: https://github.com/apache/airflow/pull/38812#discussion_r1554856680 ## INTHEWILD.md: ## @@ -319,6 +319,7 @@ Currently, **officially** using Airflow: 1. [MFG Labs](https://github.com/MfgLabs) 1. [Ministry of Economy of Brazil](htt

Re: [PR] Add MobiKwik as an Airflow user into INTHEWILD.md [airflow]

2024-04-07 Thread via GitHub
pankajkoti merged PR #38812: URL: https://github.com/apache/airflow/pull/38812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airfl

Re: [PR] Add MobiKwik as an Airflow user into INTHEWILD.md [airflow]

2024-04-07 Thread via GitHub
boring-cyborg[bot] commented on PR #38812: URL: https://github.com/apache/airflow/pull/38812#issuecomment-2041398378 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

(airflow) branch main updated (4358511fce -> 5ab7033272)

2024-04-07 Thread pankajkoti
This is an automated email from the ASF dual-hosted git repository. pankajkoti pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 4358511fce Add `AirflowInternalRuntimeError` for raise "non catchable" errors (#38778) add 5ab7033272 Add Mob

Re: [PR] Add tests to four services in AWS util [airflow]

2024-04-07 Thread via GitHub
hussein-awala commented on code in PR #38809: URL: https://github.com/apache/airflow/pull/38809#discussion_r1554961081 ## .github/workflows/ci.yml: ## Review Comment: Why do you delete this file? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Update ACL during job reset [airflow]

2024-04-07 Thread via GitHub
Lee-W commented on PR #38741: URL: https://github.com/apache/airflow/pull/38741#issuecomment-2041477480 > @Lee-W `Wait for CI images ` step is failing. How should I fix this, or simply rerun would work? Let me trigger rerun and see how it works -- This is an automated message from

[PR] add kerberos sidecar to pod-template-file [airflow]

2024-04-07 Thread via GitHub
romsharon98 opened a new pull request, #38815: URL: https://github.com/apache/airflow/pull/38815 today we have kerberos-init-container and kerberos-sidecar in `worker-deployment.yaml`. we want to apply it also on `pod-template-file.yaml` for KubernetesExecutor. related: https://github.

[I] KubernetesPodOperator prints empty log lines without respecting the log format [airflow]

2024-04-07 Thread via GitHub
karakanb opened a new issue, #36571: URL: https://github.com/apache/airflow/issues/36571 ### Apache Airflow Provider(s) cncf-kubernetes ### Versions of Apache Airflow Providers apache-airflow-providers-amazon==8.14.0 apache-airflow-providers-celery==3.5.1 apache-air

Re: [PR] Don't allow defaults other than None in context parameters, and improve error message [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38015: URL: https://github.com/apache/airflow/pull/38015#issuecomment-2041517914 I think a little bit more context is needed on that one, becuase this is a follow-up and really fix of another problem introdued in 2.8 in https://github.com/apache/airflow/pull/33430 (

Re: [PR] Add a newsfragment for PR 38015 validation [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38811: URL: https://github.com/apache/airflow/pull/38811#issuecomment-2041518494 Yes we can manually add it to the docs when publishing 2.9.0 ones . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Add a newsfragment for PR 38015 validation [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38811: URL: https://github.com/apache/airflow/pull/38811#issuecomment-2041518632 I also provided more context in https://github.com/apache/airflow/pull/38015#issuecomment-2041517914 -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] update edge label image in documentation example with the new graph view [airflow]

2024-04-07 Thread via GitHub
potiuk merged PR #38802: URL: https://github.com/apache/airflow/pull/38802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (5ab7033272 -> 6004175d55)

2024-04-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 5ab7033272 Add MobiKwik as an Airflow user into INTHEWILD.md (#38812) add 6004175d55 (img/edge_label_example.png):

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1555005243 ## .github/workflows/ci.yml: ## Review Comment: So you should bring it back - otherwise no tests are run at all and if we merge it, it will break our CI. --

Re: [I] Connection Extra Field is not encrypted/masked on editing [airflow]

2024-04-07 Thread via GitHub
potiuk commented on issue #11218: URL: https://github.com/apache/airflow/issues/11218#issuecomment-2041521069 I can't remember, really - but just checking/reproducing it might be good enough thing to do here. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] adding callback hook for on/off state of dag [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38683: URL: https://github.com/apache/airflow/pull/38683#discussion_r1555005706 ## airflow/models/dag.py: ## @@ -690,6 +694,7 @@ def __init__( ) self.dagrun_timeout = dagrun_timeout self.sla_miss_callback = sla_m

Re: [I] Automate links to configuration of providers [airflow]

2024-04-07 Thread via GitHub
potiuk commented on issue #34306: URL: https://github.com/apache/airflow/issues/34306#issuecomment-2041522200 @poorvirohidekar - similarly to what has beein implemented for automatically retrieving operators/hooks and other references here https://github.com/apache/airflow/blob/main/docs/ex

Re: [PR] Don't allow defaults other than None in context parameters, and improve error message [airflow]

2024-04-07 Thread via GitHub
jscheffl commented on PR #38015: URL: https://github.com/apache/airflow/pull/38015#issuecomment-2041524410 Thanks @potiuk for the detailled background. Convinced. And believe me, I did not want to revert and call for an RC4 - if we can add the newsfragtment on the docs this woul dbe great

Re: [I] expand_kwargs does not preserve templates [airflow]

2024-04-07 Thread via GitHub
potiuk commented on issue #38745: URL: https://github.com/apache/airflow/issues/38745#issuecomment-2041528618 > in this case data author could include {{ var.value.get('SOME_SECRET') }} template and get access to the variable if the target storage is available for them Yes. But you c

Re: [PR] Don't allow defaults other than None in context parameters, and improve error message [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38015: URL: https://github.com/apache/airflow/pull/38015#issuecomment-2041529236 > If we can add the newsfragtment on the docs this woul dbe great for others potentially stumbling into it. Agree :) -- This is an automated message from the Apache Git

Re: [PR] Suppress jaydebeapi.Error when setAutoCommit or getAutoCommit is unsupported by JDBC driver [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38707: URL: https://github.com/apache/airflow/pull/38707#discussion_r1555010713 ## airflow/providers/jdbc/hooks/jdbc.py: ## @@ -152,7 +153,8 @@ def set_autocommit(self, conn: jaydebeapi.Connection, autocommit: bool) -> None: :param conn:

Re: [PR] Add pre-commit script to keep tags sorted in OpenAPI spec [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38813: URL: https://github.com/apache/airflow/pull/38813#issuecomment-2041531168 Yeah. Sometimes parsers are not the best in preserving thigns and old-good file reading + regexp is best. -- This is an automated message from the Apache Git Service. To respond to the

(airflow) branch constraints-main updated: Updating constraints. Github run id:8590063372

2024-04-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 8d2d4f1036 Updating con

Re: [PR] Add a newsfragment for PR 38015 validation [airflow]

2024-04-07 Thread via GitHub
jscheffl merged PR #38811: URL: https://github.com/apache/airflow/pull/38811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

(airflow) branch main updated: Add a newsfragment for PR 38015 validation (#38811)

2024-04-07 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 395a9ab24d Add a newsfragment for PR 38015 valida

Re: [PR] Add pre-commit script to keep tags sorted in OpenAPI spec [airflow]

2024-04-07 Thread via GitHub
potiuk merged PR #38813: URL: https://github.com/apache/airflow/pull/38813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (395a9ab24d -> 9fcc1e826e)

2024-04-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 395a9ab24d Add a newsfragment for PR 38015 validation (#38811) add 9fcc1e826e Add pre-commit script to keep tags s

Re: [PR] fix: try002 for provider openlineage [airflow]

2024-04-07 Thread via GitHub
mobuchowski merged PR #38806: URL: https://github.com/apache/airflow/pull/38806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airf

(airflow) branch main updated: fix: try002 for provider openlineage (#38806)

2024-04-07 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7d9737154c fix: try002 for provider openlineag

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
slycyberguy commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1555019303 ## .github/workflows/ci.yml: ## Review Comment: That makes sense. I have now added the original file to the PR. Sorry, I'm new to GitHub. At first, I though

Re: [PR] Add tests to four services in AWS util [airflow]

2024-04-07 Thread via GitHub
slycyberguy commented on code in PR #38809: URL: https://github.com/apache/airflow/pull/38809#discussion_r1555019989 ## .github/workflows/ci.yml: ## Review Comment: On my local repo, I had added CodeCov to the file and I accidentally committed it. So I removed the file. Un

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1555021343 ## .github/workflows/ci.yml: ## Review Comment: Still not there -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
slycyberguy commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1555025374 ## .github/workflows/ci.yml: ## Review Comment: I added it to PR #38809. That's where it was deleted. Do I need to add it to this PR as well? Originally, al

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1555025952 ## .github/workflows/ci.yml: ## Review Comment: each PR is separate. You should not remove the .ci.yml in your main. Look at the list of changed files in this PR

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
slycyberguy commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1555028495 ## .github/workflows/ci.yml: ## Review Comment: Yes, I see that this PR says the file is deleted. So what steps should I take? I already pushed the addition

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1555043528 ## .github/workflows/ci.yml: ## Review Comment: Restore the file, the usual way. We generally don't teach git basics, the expectation is that you learn it

Re: [PR] Replace dill package to use cloudpickle [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38531: URL: https://github.com/apache/airflow/pull/38531#discussion_r1555045432 ## hatch_build.py: ## @@ -144,6 +144,12 @@ "virtualenv": [ "virtualenv", ], +"dill": [ +"dill", Review Comment: ```suggestion

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
slycyberguy commented on code in PR #38810: URL: https://github.com/apache/airflow/pull/38810#discussion_r1555045730 ## .github/workflows/ci.yml: ## Review Comment: Thanks for the advice. I'll take care of it. I'm new to unit testing, so I started off with developing

Re: [PR] Replace dill package to use cloudpickle [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38531: URL: https://github.com/apache/airflow/pull/38531#discussion_r1555046517 ## airflow/models/taskinstance.py: ## @@ -1287,7 +1287,7 @@ class TaskInstance(Base, LoggingMixin): queued_dttm = Column(UtcDateTime) queued_by_job_id = Colu

Re: [PR] Give `on_task_instance_failed` access to the error that caused the failure [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38155: URL: https://github.com/apache/airflow/pull/38155#discussion_r1555047282 ## docs/apache-airflow/administration-and-deployment/listeners.rst: ## @@ -34,21 +34,63 @@ Lifecycle events allow you to react to start and stop events for an Airflow

Re: [I] Pgbouncer not set properly upon using data.metadataSecretName [airflow]

2024-04-07 Thread via GitHub
potiuk commented on issue #33924: URL: https://github.com/apache/airflow/issues/33924#issuecomment-2041578066 I think coming with an idea is part of the solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] fix: try002 for provider airbyte [airflow]

2024-04-07 Thread via GitHub
potiuk merged PR #38786: URL: https://github.com/apache/airflow/pull/38786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: fix: try002 for provider airbyte (#38786)

2024-04-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 153370310e fix: try002 for provider airbyte (#38786

Re: [PR] fix: try002 for provider fab [airflow]

2024-04-07 Thread via GitHub
potiuk merged PR #38801: URL: https://github.com/apache/airflow/pull/38801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (153370310e -> 6d3d2075ae)

2024-04-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 153370310e fix: try002 for provider airbyte (#38786) add 6d3d2075ae fix: try002 for provider fab (#38801) No new

Re: [PR] Fix skip Apache Beam pipeline options if value is set to false [airflow]

2024-04-07 Thread via GitHub
potiuk merged PR #38496: URL: https://github.com/apache/airflow/pull/38496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] Apache Beam pipeline option parsed incorrectly if value is False [airflow]

2024-04-07 Thread via GitHub
potiuk closed issue #38457: Apache Beam pipeline option parsed incorrectly if value is False URL: https://github.com/apache/airflow/issues/38457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

(airflow) branch main updated (6d3d2075ae -> 472b646acb)

2024-04-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 6d3d2075ae fix: try002 for provider fab (#38801) add 472b646acb fix: skip apache beam pipeline options if value is

Re: [PR] Improve editable airflow installation by adding preinstalled deps [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38764: URL: https://github.com/apache/airflow/pull/38764#issuecomment-2041586184 Would love to merge it - it gives a better `--editable` experience -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Implement start/end/debug for multiple executors in scheduler job [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38514: URL: https://github.com/apache/airflow/pull/38514#discussion_r1555067360 ## airflow/jobs/job.py: ## @@ -104,12 +105,13 @@ class Job(Base, LoggingMixin): Only makes sense for SchedulerJob and BackfillJob instances. """ -def _

Re: [PR] Make _get_ti compatible with RPC [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38570: URL: https://github.com/apache/airflow/pull/38570#discussion_r1555080840 ## airflow/serialization/serialized_objects.py: ## @@ -538,9 +538,9 @@ def serialize( elif isinstance(var, Resources): return var.to_dict()

Re: [PR] Pass through more parameters to AzureBlobFileSystem to mirror handlin… [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38747: URL: https://github.com/apache/airflow/pull/38747#issuecomment-2041599263 unit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] cohere 5.0.0 support [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38465: URL: https://github.com/apache/airflow/pull/38465#issuecomment-2041603712 Seems that `cohere 5` forces installation of opentelemetry exporter . Can we do something about it ? ``` #58 33.98 opentelemetry-exporter-otlp-proto-common 1.24.0 has requirem

Re: [PR] Clean up the exception handler when run_as_user is the airflow user [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38726: URL: https://github.com/apache/airflow/pull/38726#issuecomment-2041605014 Nice catch. Can you add a test case for that ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add hook_params to template_fields for BaseSQLOperator-related Operators [airflow]

2024-04-07 Thread via GitHub
potiuk merged PR #38724: URL: https://github.com/apache/airflow/pull/38724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Add hook_params to template_fields for BaseSQLOperator-related Operators [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38724: URL: https://github.com/apache/airflow/pull/38724#issuecomment-2041605633 Nice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

(airflow) branch main updated (472b646acb -> ef97ed245b)

2024-04-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 472b646acb fix: skip apache beam pipeline options if value is set to false (#38496) add ef97ed245b Add hook_param

Re: [PR] Add option for ExternalTaskSensor to automatically infer upstream execution dates [airflow]

2024-04-07 Thread via GitHub
potiuk commented on PR #38542: URL: https://github.com/apache/airflow/pull/38542#issuecomment-2041607356 If you tag me - you limit your chances of getting review. I might be busy/not available or simply not have anything to say I suggest you continue asking for review - there are others who

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1555086029 ## airflow/providers/apache/hive/CHANGELOG.rst: ## @@ -27,6 +27,14 @@ Changelog - +7.0.2 Review Comment: I think it's a breaking change it should be 8.

Re: [PR] Deferrable mode for Custom Training Job operators [airflow]

2024-04-07 Thread via GitHub
potiuk commented on code in PR #38584: URL: https://github.com/apache/airflow/pull/38584#discussion_r1555088106 ## airflow/providers/google/cloud/operators/vertex_ai/custom_job.py: ## @@ -539,6 +564,94 @@ def on_kill(self) -> None: if self.hook: self.hook.c

Re: [PR] Add watchdog for immediately processing changes in the DAGs folder [airflow]

2024-04-07 Thread via GitHub
github-actions[bot] commented on PR #34487: URL: https://github.com/apache/airflow/pull/34487#issuecomment-2041658627 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Attempt to update Connexion library to version 3 [airflow]

2024-04-07 Thread via GitHub
github-actions[bot] commented on PR #36052: URL: https://github.com/apache/airflow/pull/36052#issuecomment-2041658611 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [I] Render template for dictionary keys [airflow]

2024-04-07 Thread via GitHub
mightydeveloper commented on issue #16892: URL: https://github.com/apache/airflow/issues/16892#issuecomment-2041686537 Please feel free to re-open it if you like to work on it! I was assuming that the feature is merged. -- This is an automated message from the Apache Git Service. To re

Re: [PR] Add six tests for AWS triggers [airflow]

2024-04-07 Thread via GitHub
slycyberguy closed pull request #38810: Add six tests for AWS triggers URL: https://github.com/apache/airflow/pull/38810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Add tests to four services in AWS util [airflow]

2024-04-07 Thread via GitHub
slycyberguy closed pull request #38809: Add tests to four services in AWS util URL: https://github.com/apache/airflow/pull/38809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add cancel_previous_run to DatabricksRunNowOperator [airflow]

2024-04-07 Thread via GitHub
Lee-W merged PR #38702: URL: https://github.com/apache/airflow/pull/38702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

Re: [I] Provide option to cancel job runs in DatabricksRunNowOperator [airflow]

2024-04-07 Thread via GitHub
Lee-W closed issue #38695: Provide option to cancel job runs in DatabricksRunNowOperator URL: https://github.com/apache/airflow/issues/38695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Add cancel_previous_run to DatabricksRunNowOperator [airflow]

2024-04-07 Thread via GitHub
boring-cyborg[bot] commented on PR #38702: URL: https://github.com/apache/airflow/pull/38702#issuecomment-2041722095 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

(airflow) branch main updated: Add cancel_previous_run to DatabricksRunNowOperator (#38702)

2024-04-07 Thread weilee
This is an automated email from the ASF dual-hosted git repository. weilee pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4e6d3fa4cf Add cancel_previous_run to DatabricksRun

Re: [PR] Simplify dataset serialization [airflow]

2024-04-07 Thread via GitHub
uranusjr merged PR #38694: URL: https://github.com/apache/airflow/pull/38694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

(airflow) branch main updated: Simplify dataset serialization (#38694)

2024-04-07 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f2e2221bb1 Simplify dataset serialization (#38694

Re: [PR] Implement Metadata to emit runtime extra [airflow]

2024-04-07 Thread via GitHub
uranusjr merged PR #38650: URL: https://github.com/apache/airflow/pull/38650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] Annotate a Dataset Event in the Source Task [airflow]

2024-04-07 Thread via GitHub
uranusjr closed issue #37810: Annotate a Dataset Event in the Source Task URL: https://github.com/apache/airflow/issues/37810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(airflow) branch main updated (f2e2221bb1 -> e04af7eb8c)

2024-04-07 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f2e2221bb1 Simplify dataset serialization (#38694) add e04af7eb8c Implement Metadata to emit runtime extra (#386

[I] Error when Adding a new record in Dag Run [airflow]

2024-04-07 Thread via GitHub
MyLong opened a new issue, #38816: URL: https://github.com/apache/airflow/issues/38816 ### Apache Airflow version 2.9.0b2 ### If "Other Airflow 2 version" selected, which one? 2.9.0rc3 ### What happened? When Add a new record in Browse-DAG Runs, if there is

Re: [I] Error when Adding a new record in Dag Run [airflow]

2024-04-07 Thread via GitHub
boring-cyborg[bot] commented on issue #38816: URL: https://github.com/apache/airflow/issues/38816#issuecomment-2041753950 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] [docs] update `DagBag` class docstring to include all params [airflow]

2024-04-07 Thread via GitHub
rawwar commented on PR #38814: URL: https://github.com/apache/airflow/pull/38814#issuecomment-2041756226 > ``` > When ``True`` uses heuristics (files containing ``DAG`` and ``airflow`` strings) to filter > ``` @romsharon98, Sorry, I did not understand what you are trying

Re: [PR] Setting use_beeline by default for hive cli connection [airflow]

2024-04-07 Thread via GitHub
amoghrajesh commented on code in PR #38763: URL: https://github.com/apache/airflow/pull/38763#discussion_r1555197923 ## airflow/providers/apache/hive/CHANGELOG.rst: ## @@ -27,6 +27,14 @@ Changelog - +7.0.2 Review Comment: Sure, made the change for that -- Thi

Re: [I] Automate links to configuration of providers [airflow]

2024-04-07 Thread via GitHub
poorvirohidekar commented on issue #34306: URL: https://github.com/apache/airflow/issues/34306#issuecomment-2041826011 @potiuk - So from the provider.yaml file, I see that we generate https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/configurations-ref.html doc. When yo

[PR] Fix 'use case' spelling [airflow]

2024-04-07 Thread via GitHub
uranusjr opened a new pull request, #38817: URL: https://github.com/apache/airflow/pull/38817 The top-level site uses 'use case' but the documentation uses 'use-case'. The former seems to be the more popular spelling. Home page: https://github.com/apache/airflow/assets/605277/01d02

Re: [PR] [fix] Simplify metrics handling [airflow]

2024-04-07 Thread via GitHub
boring-cyborg[bot] commented on PR #38818: URL: https://github.com/apache/airflow/pull/38818#issuecomment-2041833975 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] [fix] Simplify metrics handling [airflow]

2024-04-07 Thread via GitHub
Jack-R-lantern opened a new pull request, #38818: URL: https://github.com/apache/airflow/pull/38818 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests

Re: [PR] add `kerberos-sidecar` and `kerberos-initcontainer` to pod-template-file [airflow]

2024-04-07 Thread via GitHub
romsharon98 commented on PR #38815: URL: https://github.com/apache/airflow/pull/38815#issuecomment-2041835731 > Thanks for the catch, @romsharon. But can you add some test coverage in test_pod_template_file.py? I duplicate the test from `test_worker.py`. you this more test need to be

[PR] Add six unit tests for aws/triggers [airflow]

2024-04-07 Thread via GitHub
slycyberguy opened a new pull request, #38819: URL: https://github.com/apache/airflow/pull/38819 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rs

[PR] Add four unit tests for aws/utils [airflow]

2024-04-07 Thread via GitHub
slycyberguy opened a new pull request, #38820: URL: https://github.com/apache/airflow/pull/38820 Unit tests for: airflow/provider/amazon/aws/utils/sagemaker.py airflow/provider/amazon/aws/utils/rds.py airflow/provider/amazon/aws/utils/sqs.py airflow/provider/amazon/aws/utils/t

Re: [PR] Add six unit tests for aws/triggers [airflow]

2024-04-07 Thread via GitHub
slycyberguy commented on PR #38819: URL: https://github.com/apache/airflow/pull/38819#issuecomment-2041845961 Unit tests for: airflow/provider/amazon/aws/triggers/athena.py airflow/provider/amazon/aws/triggers/rds.py airflow/provider/amazon/aws/triggers/emr.py airflow/provider

Re: [PR] add Wei Lee to committer list [airflow-site]

2024-04-07 Thread via GitHub
jedcunningham commented on code in PR #996: URL: https://github.com/apache/airflow-site/pull/996#discussion_r1555216087 ## landing-pages/site/data/committers.json: ## @@ -161,6 +161,12 @@ "image": "https://github.com/vincbeck.png";, "nick": "vincbeck" }, + { +"

  1   2   >