qcha41 opened a new issue, #38954:
URL: https://github.com/apache/airflow/issues/38954
### Apache Airflow version
2.9.0
### If "Other Airflow 2 version" selected, which one?
_No response_
### What happened?
When you launch a backfill command with the Airflow
uranusjr commented on PR #38942:
URL: https://github.com/apache/airflow/pull/38942#issuecomment-2051059310
Same about using cast like this. The thing I don’t understand is, why does
the stub not able to correctly identify the return type from `session.execute`
in the first place…?
--
Thi
dabla commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2051052690
I will just add an example for the MSGrapSensor and how we use it with the
PowerBI api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uranusjr commented on code in PR #38950:
URL: https://github.com/apache/airflow/pull/38950#discussion_r1562051157
##
airflow/models/dag.py:
##
@@ -582,7 +582,7 @@ def __init__(
if start_date and start_date.tzinfo:
tzinfo = None if start_date.tzinfo else set
dstandish commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562051588
##
airflow/models/taskinstance.py:
##
@@ -539,7 +539,7 @@ def _refresh_from_db(
task_instance.end_date = ti.end_date
task_instance.duration = ti.d
uranusjr commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562050194
##
airflow/models/taskinstance.py:
##
@@ -539,7 +539,7 @@ def _refresh_from_db(
task_instance.end_date = ti.end_date
task_instance.duration = ti.du
uranusjr commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562050194
##
airflow/models/taskinstance.py:
##
@@ -539,7 +539,7 @@ def _refresh_from_db(
task_instance.end_date = ti.end_date
task_instance.duration = ti.du
uranusjr commented on code in PR #38949:
URL: https://github.com/apache/airflow/pull/38949#discussion_r1562049749
##
dev/perf/scheduler_dag_execution_timing.py:
##
@@ -79,8 +79,7 @@ def change_state(self, key, state, info=None):
if not run:
import airflow.m
dstandish commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562047896
##
airflow/models/dagrun.py:
##
@@ -650,7 +650,6 @@ def get_task_instance(
)
@staticmethod
-@internal_api_call
Review Comment:
Basis for con
dstandish commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562046802
##
airflow/models/taskinstance.py:
##
@@ -539,7 +539,7 @@ def _refresh_from_db(
task_instance.end_date = ti.end_date
task_instance.duration = ti.d
uranusjr commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562045467
##
airflow/models/taskinstance.py:
##
@@ -539,7 +539,7 @@ def _refresh_from_db(
task_instance.end_date = ti.end_date
task_instance.duration = ti.du
uranusjr commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562044901
##
airflow/models/dagrun.py:
##
@@ -650,7 +650,6 @@ def get_task_instance(
)
@staticmethod
-@internal_api_call
Review Comment:
cc @vincbeck
uranusjr commented on PR #38891:
URL: https://github.com/apache/airflow/pull/38891#issuecomment-2050995652
The catchup flag still affects time-based scheduling (and only that). I’ll
call that out explicitly in the fragment.
--
This is an automated message from the Apache Git Service.
To r
aritra24 closed issue #38944: Unable to mock Variable in python unittest
URL: https://github.com/apache/airflow/issues/38944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
scottlimmer opened a new pull request, #38953:
URL: https://github.com/apache/airflow/pull/38953
Remove redirect rule for flower config as per
https://airflow.apache.org/docs/apache-airflow/stable/security/flower.html#flower-url-prefix
---
**^ Add meanin
aritra24 commented on issue #38944:
URL: https://github.com/apache/airflow/issues/38944#issuecomment-2050983951
Closing this issue in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
boring-cyborg[bot] commented on PR #38953:
URL: https://github.com/apache/airflow/pull/38953#issuecomment-2050981803
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
eladkal commented on PR #38891:
URL: https://github.com/apache/airflow/pull/38891#issuecomment-2050975597
> I decided to not consider catchup at all here, and make the behavior
change as simple as possible. A news fragment has been added to note the
breaking change.
What does it mean
dirrao commented on code in PR #38951:
URL: https://github.com/apache/airflow/pull/38951#discussion_r1561968503
##
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##
@@ -42,7 +42,7 @@
from airflow.exceptions import AirflowException,
AirflowProviderDeprecationWarning
Bowrna commented on issue #38304:
URL: https://github.com/apache/airflow/issues/38304#issuecomment-2050826701
> The thing is that task_instance is not created yet because ... the task is
in the queue. So what needs to happen is that the whole logic should happen in
scheduler - becuase it's
github-actions[bot] commented on issue #36838:
URL: https://github.com/apache/airflow/issues/36838#issuecomment-2050747458
This issue has been automatically marked as stale because it has been open
for 14 days with no response from the author. It will be closed in next 7 days
if no further
github-actions[bot] commented on issue #38280:
URL: https://github.com/apache/airflow/issues/38280#issuecomment-2050747410
This issue has been closed because it has not received response from the
issue author.
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] closed issue #38280: EksPodOperator doesn't work with
deferrable=True
URL: https://github.com/apache/airflow/issues/38280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
hussein-awala commented on PR #38942:
URL: https://github.com/apache/airflow/pull/38942#issuecomment-2050693402
> I tried, but I think I overused cast and TYPE_CHEKING.
Personally, I have no issue with that, this casting improves the dev
experience and helps to use the IDE auto-comple
hussein-awala commented on code in PR #38942:
URL: https://github.com/apache/airflow/pull/38942#discussion_r1561837881
##
airflow/cli/commands/task_command.py:
##
@@ -97,7 +97,7 @@ def _get_dag_run(
dag: DAG,
create_if_necessary: CreateIfNecessary,
exec_date_or_ru
Taragolis commented on code in PR #38950:
URL: https://github.com/apache/airflow/pull/38950#discussion_r1561836489
##
airflow/providers/google/cloud/hooks/bigquery.py:
##
@@ -2849,7 +2849,7 @@ def next(self) -> list | None:
return None
query_resul
Taragolis commented on PR #38948:
URL: https://github.com/apache/airflow/pull/38948#issuecomment-2050671774
AFAIK it is exact the opposite, default values assigned exactly once, as
well as module imports exactly once, if do not count manual reload through
importlib or clear sys.modules
jedcunningham commented on code in PR #38951:
URL: https://github.com/apache/airflow/pull/38951#discussion_r1561823263
##
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##
@@ -42,7 +42,7 @@
from airflow.exceptions import AirflowException,
AirflowProviderDeprecationW
jedcunningham opened a new pull request, #38951:
URL: https://github.com/apache/airflow/pull/38951
We should use the same, non deprecated, version of PodDefaults for the xcom
sidecar when creating and reading xcom.
--
This is an automated message from the Apache Git Service.
To respond to
hussein-awala opened a new pull request, #38950:
URL: https://github.com/apache/airflow/pull/38950
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
hussein-awala opened a new pull request, #38947:
URL: https://github.com/apache/airflow/pull/38947
This rule is useful to detect the asyncio tasks which are created without
setting their reference to a variable because this could lead to unexpected
results like removing them by GC.
--
Th
chz8494 commented on PR #38614:
URL: https://github.com/apache/airflow/pull/38614#issuecomment-2050612522
@hussein-awala can someone review and suggest if tests good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dstandish commented on PR #38943:
URL: https://github.com/apache/airflow/pull/38943#issuecomment-2050592083
this, dealing, as it does, with try_number, is a weird one, so i'm gonna let
it go overnight to see if @uranusjr @potiuk @jedcunningham want to give it a
look
--
This is an automat
dstandish closed pull request #38906: Do not log event when using db isolation
URL: https://github.com/apache/airflow/pull/38906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dstandish opened a new pull request, #38946:
URL: https://github.com/apache/airflow/pull/38946
To use RPC, we need to accept a session, which is provided by the RPC call
handler. But, the action log callback system may already be forwarding a
session, so to avoid a collision, I have made th
This is an automated email from the ASF dual-hosted git repository.
vincbeck pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 725c568e73 fix(airbyte/hooks): add schema and port to prevent
InvalidURL error (#38860)
add 4a3caa2e35 Amazon B
vincbeck merged PR #38945:
URL: https://github.com/apache/airflow/pull/38945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
dabla commented on code in PR #38707:
URL: https://github.com/apache/airflow/pull/38707#discussion_r1561754471
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -111,6 +112,15 @@ def fetch_one_handler(cursor) -> list[tuple] | None:
return None
+@contextmanager
+de
dabla commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050548933
> I told you adding local imports is **really** not a good idea - those
imports are needed elsewhere (in unit tests where they are mocked).
Yeah saw it too, moved them at top of fil
dabla commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050548094
> Surely, but we have the same problem with common code. If we add it today,
it's only going to be really usable 10 months from now. because providers are
importing stuff from earlier air
ferruzzi commented on PR #38945:
URL: https://github.com/apache/airflow/pull/38945#issuecomment-2050510573
@vincbeck - Feel free to review and merge at your convenience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ferruzzi opened a new pull request, #38945:
URL: https://github.com/apache/airflow/pull/38945
Hardcoded region names caused an issue since the dashboard pipeline runs in
a different region.
Also tweaked some variable names to try to be a little more clear.
---
**^ Ad
bbovenzi commented on issue #33012:
URL: https://github.com/apache/airflow/issues/33012#issuecomment-2050500574
We also made the filter bar collapsible:
https://github.com/apache/airflow/pull/38296
Im going to improve the UX of it for 2.9.1 but yes, this is done.
--
This is an auto
bbovenzi closed issue #33012: Full screen mode for Logs, Graph, Code etc..
URL: https://github.com/apache/airflow/issues/33012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from f87772f52a Fix dag run selection (#38941)
add 725c568e73 fix(airbyte/hooks): add schema and port to prevent
Inva
boring-cyborg[bot] commented on PR #38860:
URL: https://github.com/apache/airflow/pull/38860#issuecomment-2050497441
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
eladkal closed issue #37449: `AirbyteTriggerSyncOperator` does not work on
deferrable mode
URL: https://github.com/apache/airflow/issues/37449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
eladkal merged PR #38860:
URL: https://github.com/apache/airflow/pull/38860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new f87772f52a Fix dag run selection (#38941)
f87772f5
eladkal closed issue #38939: You cannot see newer DAG runs if you open a link
to a specific DAG run [UI Bug] [New as of 2.9.0?]
URL: https://github.com/apache/airflow/issues/38939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
eladkal merged PR #38941:
URL: https://github.com/apache/airflow/pull/38941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
ivanwakeup commented on issue #38944:
URL: https://github.com/apache/airflow/issues/38944#issuecomment-2050438532
I think i found the issue. lowercase `my_test_var` instead of `MY_TEST_VAR`
in the variable definition causes airflow to not pickup the value. changing
this fixes it.
--
This
Taragolis commented on code in PR #38707:
URL: https://github.com/apache/airflow/pull/38707#discussion_r1561583638
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -111,6 +112,15 @@ def fetch_one_handler(cursor) -> list[tuple] | None:
return None
+@contextmanager
potiuk commented on PR #38747:
URL: https://github.com/apache/airflow/pull/38747#issuecomment-2050400684
Tests failing, I am afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
potiuk commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050393302
I told you adding local imports is **really** not a good idea - those
imports are needed elsewhere (in unit tests where they are mocked).
--
This is an automated message from the Apac
uranusjr commented on code in PR #38715:
URL: https://github.com/apache/airflow/pull/38715#discussion_r1561554648
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -550,47 +557,48 @@ def insert_rows(
:param commit_every: The maximum number of rows to insert in one
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch improve-warning-system
in repository https://gitbox.apache.org/repos/asf/airflow.git
omit f75f498d45 Add group based on where warnings raised
add 0c26326f04 Add group based on where w
potiuk commented on PR #38715:
URL: https://github.com/apache/airflow/pull/38715#issuecomment-2050377843
> Also wondering why these tests are failing as those are unrelated with my
changes (I think):
I'd say it's a side-effect of another test that probably interact with
caplog in a
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch improve-warning-system
in repository https://gitbox.apache.org/repos/asf/airflow.git
omit 35b4fd406b Change capture warnings output format to the JSON
add cdc7f19b57 Add retry logic f
Taragolis merged PR #38926:
URL: https://github.com/apache/airflow/pull/38926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from cd88ddb4f1 Limit redis image to 7.2 in sample docker-compose.yaml
(#38938)
add 05ba268d05 Fix `SAWarning` 'Coe
potiuk commented on PR #38715:
URL: https://github.com/apache/airflow/pull/38715#issuecomment-2050337696
I re-run it. Seems like intermittent error because of broken docker on
GitHub Runner. Happens.
`docker: Error response from daemon: unauthorized: authentication required.`
--
Th
dabla commented on PR #38715:
URL: https://github.com/apache/airflow/pull/38715#issuecomment-2050338045
Also wondering why these tests are failing as those are unrelated with my
changes (I think):
```
___ TestWasbBlobSensorTrigger.test_waiting_for_blob
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new cd88ddb4f1 Limit redis image to 7.2 in sample docke
potiuk merged PR #38938:
URL: https://github.com/apache/airflow/pull/38938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
ivanwakeup opened a new issue, #38944:
URL: https://github.com/apache/airflow/issues/38944
### What do you see as an issue?
The airflow Best Practices documentation page suggests using
`unittest.mock.patch` along with setting `os.environ` values to mock Variables
and Connections. Thi
boring-cyborg[bot] commented on issue #38944:
URL: https://github.com/apache/airflow/issues/38944#issuecomment-2050324177
Thanks for opening your first issue here! Be sure to follow the issue
template! If you are willing to raise PR to address this issue please do so, no
need to wait for ap
tomrutter commented on PR #38747:
URL: https://github.com/apache/airflow/pull/38747#issuecomment-2050318290
Checked tests and linting pass, and rebased to latest main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dstandish commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1561498670
##
airflow/models/dagrun.py:
##
@@ -650,7 +650,6 @@ def get_task_instance(
)
@staticmethod
-@internal_api_call
Review Comment:
this is a dri
dstandish commented on PR #38907:
URL: https://github.com/apache/airflow/pull/38907#issuecomment-2050307736
closing in favor of #38943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dstandish closed pull request #38907: Fix error when setting try_number from
TaskInstancePydantic
URL: https://github.com/apache/airflow/pull/38907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dstandish opened a new pull request, #38943:
URL: https://github.com/apache/airflow/pull/38943
There was an error in the refresh_from_db code, and because of try_number
inconsistency, the same run was going into two different log files. There is
some ugliness here, but some ugliness is una
Rafnel commented on issue #38939:
URL: https://github.com/apache/airflow/issues/38939#issuecomment-2050306084
Awesome, thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
josix commented on PR #38860:
URL: https://github.com/apache/airflow/pull/38860#issuecomment-2050283042
Hi @hussein-awala thanks for the advise, I've added the test for it. PTAL,
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
FFCMSouza commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2050273127
I saw that on version 1.9.0, thats already a different type of exception for
this cases.
I believe that the following change could be made to fix that behavior:
`
dabla commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050266922
@potiuk FYI: I've also deleted the apache-airflow-providers-msgraph package
under pypi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dabla commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050247170
> > But if you confirm this is fine then no problem I will do it like this :)
>
> Yes. We do it in a number of other places - you already looked at it.
>
> > couldn't we adapt
This is an automated email from the ASF dual-hosted git repository.
ferruzzi pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from f3ab31de97 Use `model_dump` instead of `dict` for serialize Pydantic
V2 model (#38933)
add c25d346adf Amazon Be
ferruzzi merged PR #38850:
URL: https://github.com/apache/airflow/pull/38850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
phi-friday opened a new pull request, #38942:
URL: https://github.com/apache/airflow/pull/38942
[Mypy / Pep-484 Support for ORM
Mappings](https://docs.sqlalchemy.org/en/20/orm/extensions/mypy.html)
To support 1.4 and 2.x simultaneously, it seems best to use
sqlalchemy
bbovenzi opened a new pull request, #38941:
URL: https://github.com/apache/airflow/pull/38941
Fixes: https://github.com/apache/airflow/issues/38939
We added logic to change the date filters for the grid data when the
selected run_id was out of range. But that created its own issue tha
aritra24 commented on issue #37030:
URL: https://github.com/apache/airflow/issues/37030#issuecomment-2050205856
@poorvirohidekar I believe it's part of the [Flask app
builder](https://github.com/dpgaspar/Flask-AppBuilder/blob/c65e067f09e741c0031263c8599b8e8811d5/flask_appbuilder/security
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 55b251f849 Replace also "-" in providers compatibility check
specification (#38936)
add f3ab31de97 Use `model_
Taragolis merged PR #38933:
URL: https://github.com/apache/airflow/pull/38933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
eladkal commented on issue #38939:
URL: https://github.com/apache/airflow/issues/38939#issuecomment-2050171659
cc @bbovenzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050167395
> But if you confirm this is fine then no problem I will do it like this :)
Yes. We do it in a number of other places - you already looked at it.
> couldn't we adapt the ver
dabla commented on issue #38904:
URL: https://github.com/apache/airflow/issues/38904#issuecomment-2050164510
Just tested [#38528](https://github.com/apache/airflow/pull/38528) and I
confirm it is working with ODBC as well as JDBC.
--
This is an automated message from the Apache Git Servic
bbovenzi opened a new pull request, #38940:
URL: https://github.com/apache/airflow/pull/38940
The text was getting cut off too many times for graph view nodes. The zoomed
out version was also hard to read.
Before:
https://github.com/apache/airflow/assets/4600967/6c93cb8a-b970-
Rafnel opened a new issue, #38939:
URL: https://github.com/apache/airflow/issues/38939
### Apache Airflow version
2.9.0
### If "Other Airflow 2 version" selected, which one?
_No response_
### What happened?
When I click on a specific DAG run in a DAG, then c
dabla commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050135785
> Some more explanation: This is what compatiblity checks are doing
basically - they try to import the providers in airflow 2.6.0 so if you import
anything that is missing, they should fa
dabla commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050133314
> > Now I'm getting this
[errors](https://github.com/apache/airflow/actions/runs/8648788861/job/23713776144?pr=38111#step:10:2621)
probably something else needs to be changed/excluded so
potiuk commented on PR #38512:
URL: https://github.com/apache/airflow/pull/38512#issuecomment-2050130140
No need to apologise :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
potiuk commented on PR #38936:
URL: https://github.com/apache/airflow/pull/38936#issuecomment-2050129139
5 approvals for 1-line change in < 2 hours. The key is to have as small
changes as possible :)
--
This is an automated message from the Apache Git Service.
To respond to the message, p
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 55b251f849 Replace also "-" in providers compatibil
potiuk merged PR #38936:
URL: https://github.com/apache/airflow/pull/38936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on code in PR #38707:
URL: https://github.com/apache/airflow/pull/38707#discussion_r1561336492
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -111,6 +112,15 @@ def fetch_one_handler(cursor) -> list[tuple] | None:
return None
+@contextmanager
+d
potiuk commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050116244
Some more explanation: This is what compatiblity checks are doing basically
- they try to import the providers in airflow 2.6.0 so if you import anything
that is missing, they should fai
potiuk commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2050112072
> Now I'm getting this
[errors](https://github.com/apache/airflow/actions/runs/8648788861/job/23713776144?pr=38111#step:10:2621)
probably something else needs to be changed/excluded so
gazev commented on PR #38512:
URL: https://github.com/apache/airflow/pull/38512#issuecomment-2050099970
> Does the other PR fixes the same thing? If so - close it. If not - change
yours to add new things. Why do you need to ask me :) ? Seems pretty
straightforward?
I am really sorry
gazev closed pull request #38512: Refactor: Directly pass HttpOperator `data`
and `json` arguments to requests and aiohttp params
URL: https://github.com/apache/airflow/pull/38512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
1 - 100 of 235 matches
Mail list logo