moritzsanne commented on PR #38960:
URL: https://github.com/apache/airflow/pull/38960#issuecomment-2053545092
Hey, thanks for reviewing this so quickly. I've rebased my branch using the
rebase button in github after your reviews. I am unsure if this was the right
thing today in this case. I
paramjeet01 commented on issue #38968:
URL: https://github.com/apache/airflow/issues/38968#issuecomment-2053543932
@ephraimbuddy , The above config has improved the performance in scheduling
the tasks and the gantt view shows the tasks queue time is lesser than before.
Also , please share p
tirkarthi commented on code in PR #38912:
URL: https://github.com/apache/airflow/pull/38912#discussion_r1563729073
##
airflow/providers/google/cloud/triggers/bigquery.py:
##
@@ -113,6 +116,14 @@ async def run(self) -> AsyncIterator[TriggerEvent]: #
type: ignore[override]
Taragolis commented on PR #38978:
URL: https://github.com/apache/airflow/pull/38978#issuecomment-2053478944
Yep, main and in other PRs it pass without any issues now.
There is newly open Issue in mpi4py repo with the same issue:
https://github.com/mpi4py/mpi4py/issues/484
Lets keep
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch improve-warning-system
in repository https://gitbox.apache.org/repos/asf/airflow.git
omit 5c6240c690 Revert some accidental changes
omit df4a571173 Update example in docs
omit 0877
Taragolis commented on PR #38978:
URL: https://github.com/apache/airflow/pull/38978#issuecomment-2053389362
Looks like it was resolved without our involvement 😄🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
discard d676dd8530 Rewritten history to remove past gh-pages deployments
new 2599b6a8e1 Rewritten history to
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch summit
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
was 66723d2950 Add temporary banner for 2024 Airflow Summit
The revisions that were on this branch are still conta
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
The following commit(s) were added to refs/heads/main by this push:
new 9c16bc9be8 Add temporary banner for 2024 Airf
eladkal merged PR #1004:
URL: https://github.com/apache/airflow-site/pull/1004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airfl
github-actions[bot] closed pull request #37381: Feature: Return rowcount from
SQL Operators
URL: https://github.com/apache/airflow/pull/37381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
github-actions[bot] closed pull request #37551: Add secret caching for Airflow
CLI
URL: https://github.com/apache/airflow/pull/37551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
github-actions[bot] commented on PR #37746:
URL: https://github.com/apache/airflow/pull/37746#issuecomment-2052716460
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
anandhimurali opened a new pull request, #38982:
URL: https://github.com/apache/airflow/pull/38982
**Motivation**
Currently, users need to write custom extractor inorder to add custom facets
in the lineage events. Managing the entire extractor will be hard while users
might just want to
boring-cyborg[bot] commented on PR #38982:
URL: https://github.com/apache/airflow/pull/38982#issuecomment-2052695209
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
idantepper opened a new pull request, #38981:
URL: https://github.com/apache/airflow/pull/38981
related: #38642
I removed the initialization of TaskInstance from using execution_date to
using run_id
before changing when running the tests the following warn was given
[https://gi
This is an automated email from the ASF dual-hosted git repository.
dstandish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new d03ba594b3 Use debug level for minischeduler ski
dstandish merged PR #38976:
URL: https://github.com/apache/airflow/pull/38976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
potiuk closed pull request #38980: Fix more integration tests
URL: https://github.com/apache/airflow/pull/38980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
potiuk opened a new pull request, #38980:
URL: https://github.com/apache/airflow/pull/38980
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul
mateuslatrova opened a new pull request, #38979:
URL: https://github.com/apache/airflow/pull/38979
### Explain
There is no issue linked to this PR.
The documentation of the LivyOperator had an error:
`:param polling_interval: time in seconds between polling for job
completion. D
potiuk commented on PR #38531:
URL: https://github.com/apache/airflow/pull/38531#issuecomment-2052632462
> Unlike dill and cloudpickle, serde's serialize() method loses an object's
type information similar to what json.dumps() does:
It shoudl not . @bolkedebruin -> i believe serde sho
potiuk commented on PR #38111:
URL: https://github.com/apache/airflow/pull/38111#issuecomment-2052628759
some main errrs fixed already - you will need to rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Taragolis commented on PR #38978:
URL: https://github.com/apache/airflow/pull/38978#issuecomment-2052605542
I will open task for resolve it in the morning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from c450cbfbf9 Make default_action_log an RPC function (#38946)
add 311f2dd3ff Remove unnecessary logs from test outpu
potiuk merged PR #38974:
URL: https://github.com/apache/airflow/pull/38974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
Taragolis closed pull request #38978: Mark
`extending/add-build-essential-extend/Dockerfile` docker example test as XFAIL
URL: https://github.com/apache/airflow/pull/38978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dstandish merged PR #38946:
URL: https://github.com/apache/airflow/pull/38946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
This is an automated email from the ASF dual-hosted git repository.
dstandish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new c450cbfbf9 Make default_action_log an RPC functi
This is an automated email from the ASF dual-hosted git repository.
vincbeck pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 259bc1c7b8 Fix Mypy error introduced in main (#38975)
add ed99893853 Fix `DbApiHook.insert_rows` when `rows` is
vincbeck merged PR #38972:
URL: https://github.com/apache/airflow/pull/38972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
Taragolis opened a new pull request, #38978:
URL: https://github.com/apache/airflow/pull/38978
This test starts failed during build `mpi4py` package, currently it blocks
to run finalise step for tests, e.g. summarise warnings.
https://github.com/apache/airflow/actions
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 61501796ca Fix `sql_alchemy_engine_args` config example (#38971)
add 259bc1c7b8 Fix Mypy error introduced in main
potiuk merged PR #38975:
URL: https://github.com/apache/airflow/pull/38975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
RNHTTR opened a new issue, #38977:
URL: https://github.com/apache/airflow/issues/38977
### Apache Airflow version
2.9.0
### If "Other Airflow 2 version" selected, which one?
_No response_
### What happened?
The fact that the date in the Run ID (I think `logi
dstandish opened a new pull request, #38976:
URL: https://github.com/apache/airflow/pull/38976
Now that we are using nowait, it will be more common that the minicheduler
skips. Leaving it at info level will cause unnecessary alarm to users.
--
This is an automated message from the Ap
potiuk commented on code in PR #38974:
URL: https://github.com/apache/airflow/pull/38974#discussion_r1563205954
##
tests/conftest.py:
##
@@ -1145,6 +1145,17 @@ def reset_logging_config():
logging.config.dictConfig(logging_config)
+@pytest.fixture(scope="session", autous
cmarteepants commented on issue #30974:
URL: https://github.com/apache/airflow/issues/30974#issuecomment-2052540712
@uranusjr you're closer to this than I am. What is your opinion?
I think there's a lot of value in supporting these scenarios - but there's
something about the approach
potiuk opened a new pull request, #38975:
URL: https://github.com/apache/airflow/pull/38975
Some recent changes in AIP-44 related prs merged together caused mypy error
in main. This PR fixes it
---
**^ Add meaningful description above**
Read the **[Pu
Taragolis commented on code in PR #38974:
URL: https://github.com/apache/airflow/pull/38974#discussion_r1563202905
##
tests/conftest.py:
##
@@ -1145,6 +1145,17 @@ def reset_logging_config():
logging.config.dictConfig(logging_config)
+@pytest.fixture(scope="session", aut
potiuk opened a new pull request, #38974:
URL: https://github.com/apache/airflow/pull/38974
The logs from `fab` and `dag` at info level are useful for PROD but clutter
the output for tests. We should set log level for those two modules to warning
to avoid that.
phi-friday commented on PR #38942:
URL: https://github.com/apache/airflow/pull/38942#issuecomment-2052514771
I used `try_number` instead of `_try_number`, which caused the problem. Will
be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
vincbeck commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563153818
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.lo
vincbeck commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563151718
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.lo
dabla commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563148396
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.log.i
vincbeck commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563144429
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.lo
dabla commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563139049
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.log.i
potiuk commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563133064
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.log.
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 5f6f4a5f46 Fix calendar view with no DAG Run. (#38964)
add 61501796ca Fix `sql_alchemy_engine_args` config example
phi-friday commented on code in PR #38942:
URL: https://github.com/apache/airflow/pull/38942#discussion_r1563128664
##
airflow/api_connexion/endpoints/xcom_endpoint.py:
##
@@ -74,8 +74,8 @@ def get_xcom_entries(
# Match idx_xcom_task_instance + idx_xcom_key for performance.
potiuk merged PR #38971:
URL: https://github.com/apache/airflow/pull/38971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
FFCMSouza commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2052409632
Yes, I saw that. So there is no intention to change this behavior?
To me this doesn't make sense, marking a task as failed should trigger the
failure callback.
If that's the
paramjeet01 commented on issue #38968:
URL: https://github.com/apache/airflow/issues/38968#issuecomment-2052400361
I have updated the config map with `max_tis_per_query = 512` and redeployed
the scheduler. Will monitor for some time and let you know , thanks for quick
response.
--
This i
o-nikolas commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1563072454
##
tests/system/conftest.py:
##
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config,
items: list[pytest.Item
rootdir = config.rootpath
ephraimbuddy commented on issue #38935:
URL: https://github.com/apache/airflow/issues/38935#issuecomment-2052393366
This behaviour is documented in the code
https://github.com/apache/airflow/blob/5f6f4a5f4654d64efb4c0cabb6e0e054d13a2e0f/airflow/models/taskinstance.py#L2594-L2597.
So i
vincbeck commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563046987
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.lo
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 8fad98d34d (external_task.py): changed the background color of
external task in graph (#38969)
add 5f6f4a5f46 Fi
eladkal merged PR #38964:
URL: https://github.com/apache/airflow/pull/38964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
eladkal closed issue #38875: Calendar view is broken for dags with no dagrun
URL: https://github.com/apache/airflow/issues/38875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
paramjeet01 commented on issue #38968:
URL: https://github.com/apache/airflow/issues/38968#issuecomment-2052336139
Apologies, I'm relatively new to Airflow. We've checked the scheduler logs
thoroughly, and everything seems to be functioning correctly without any
errors. Additionally, the sc
uranusjr commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563041853
##
airflow/providers/common/sql/hooks/sql.py:
##
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.lo
This is an automated email from the ASF dual-hosted git repository.
jscheffl pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 8fad98d34d (external_task.py): changed the backgr
jscheffl merged PR #38969:
URL: https://github.com/apache/airflow/pull/38969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
jscheffl closed issue #38845: Change the UI color for ExternalSensor tasks
URL: https://github.com/apache/airflow/issues/38845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jscheffl commented on issue #38968:
URL: https://github.com/apache/airflow/issues/38968#issuecomment-2052303193
Without any logs, errors, metrics or details it is impossible to (1)
understand your problem and (2) fix anything.
Can you please describe more details?
--
This is an aut
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch improve-warning-system
in repository https://gitbox.apache.org/repos/asf/airflow.git
from df4a571173 Update example in docs
add 5c6240c690 Revert some accidental changes
No new revis
potiuk closed pull request #38973: Fix dataset events endpoint
URL: https://github.com/apache/airflow/pull/38973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
potiuk opened a new pull request, #38973:
URL: https://github.com/apache/airflow/pull/38973
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch improve-warning-system
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 0877981523 Add warnings summarizer
add df4a571173 Update example in docs
No new revisions we
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch improve-warning-system
in repository https://gitbox.apache.org/repos/asf/airflow.git
discard bf985375da Add warnings summarizer
add 0877981523 Add warnings summarizer
This update added
This is an automated email from the ASF dual-hosted git repository.
taragolis pushed a change to branch improve-warning-system
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 8113d2262b Make plugin works withing xdists workers
add bf985375da Add warnings summarizer
N
eladkal commented on PR #38960:
URL: https://github.com/apache/airflow/pull/38960#issuecomment-2052228799
can you add unit test to cover this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vincbeck commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1562964822
##
tests/system/conftest.py:
##
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config,
items: list[pytest.Item
rootdir = config.rootpath
vincbeck commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1562964822
##
tests/system/conftest.py:
##
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config,
items: list[pytest.Item
rootdir = config.rootpath
vincbeck commented on PR #38972:
URL: https://github.com/apache/airflow/pull/38972#issuecomment-2052224846
> Have you run the system test locally to ensure it passes with this new
code change?
Yes sir!
--
This is an automated message from the Apache Git Service.
To respond to the m
vincbeck commented on PR #38715:
URL: https://github.com/apache/airflow/pull/38715#issuecomment-2052217490
Hi @dabla,
This PR made one of our system test fails because the parameter `rows` of
`insert_rows` can also be a generator. See fix here: #38972
--
This is an automated messag
vincbeck opened a new pull request, #38972:
URL: https://github.com/apache/airflow/pull/38972
#38715 introduced a bug when the parameter `rows` is a generator. In that
case, the method raises this error:
```
ERROR [airflow.task] Task failed with exception
Traceback (most recent
o-nikolas commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1562955354
##
tests/system/conftest.py:
##
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config,
items: list[pytest.Item
rootdir = config.rootpath
vincbeck closed pull request #38967: Add a generic system test in
`tests/system/` and run it in the CI
URL: https://github.com/apache/airflow/pull/38967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jedcunningham opened a new pull request, #38971:
URL: https://github.com/apache/airflow/pull/38971
It's json, not python, so we need lowercase bools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch summit
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
at 66723d2950 Add temporary banner for 2024 Airflow Summit
This branch includes the following new commits:
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch summit
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
commit 66723d2950aa5295fe05482237c6eebacf901663
Author: Elad Kalif <45845474+elad...@users.noreply.github.com>
AuthorDate
eladkal opened a new pull request, #1004:
URL: https://github.com/apache/airflow-site/pull/1004
redo https://github.com/apache/airflow-site/pull/762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jedcunningham commented on code in PR #38549:
URL: https://github.com/apache/airflow/pull/38549#discussion_r1562800108
##
helm_tests/webserver/test_rpc_server.py:
##
@@ -0,0 +1,923 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
rawwar commented on issue #37158:
URL: https://github.com/apache/airflow/issues/37158#issuecomment-2052099050
I am picking this back up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
e-galan commented on code in PR #37693:
URL: https://github.com/apache/airflow/pull/37693#discussion_r1562813483
##
airflow/providers/google/cloud/sensors/dataflow.py:
##
@@ -357,4 +500,45 @@ def poke(self, context: Context) -> bool:
location=self.location,
This is an automated email from the ASF dual-hosted git repository.
dstandish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new d39367bcbf Fix try_number handling when db isola
dstandish merged PR #38943:
URL: https://github.com/apache/airflow/pull/38943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflo
idantepper opened a new pull request, #38969:
URL: https://github.com/apache/airflow/pull/38969
closes #38845
Changed the color of the extra task in the Graph from this:
