Re: [PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
potiuk commented on PR #40766: URL: https://github.com/apache/airflow/pull/40766#issuecomment-2227212177 Let's try to merge it to see if it solves the issue in main too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

(airflow) branch main updated: Do not trigger provider tests on core changes (#40776)

2024-07-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ee97d7b6f5 Do not trigger provider tests on core ch

Re: [PR] Do not trigger provider tests on core changes [airflow]

2024-07-13 Thread via GitHub
potiuk merged PR #40776: URL: https://github.com/apache/airflow/pull/40776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Do not trigger provider tests on core changes [airflow]

2024-07-13 Thread via GitHub
potiuk opened a new pull request, #40776: URL: https://github.com/apache/airflow/pull/40776 Provider tests have been triggered when core airflow changed. This has been done in order to avoid some core changes that would break providers, however running provider tests - especially including

Re: [PR] Add kerberos related connection fields(principal, keytab) on SparkSubmitHook [airflow]

2024-07-13 Thread via GitHub
seyoon-lim commented on PR #40757: URL: https://github.com/apache/airflow/pull/40757#issuecomment-2227182665 Sorry, the changes to the www directory that I was working on locally were pushed by my mistake. sorry for the reviewers (@ryanahamilton @ashb @bbovenzi @pierrejeambrun) --

Re: [PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
potiuk commented on code in PR #40766: URL: https://github.com/apache/airflow/pull/40766#discussion_r1677004959 ## tests/sensors/test_time_delta.py: ## @@ -57,7 +58,8 @@ def setup_method(self): @pytest.mark.parametrize( "data_interval_end, delta, should_deffer",

Re: [I] XCom unable to parse tuple response from DatabricksSQLOperator on SQL query execution [airflow]

2024-07-13 Thread via GitHub
jroachgolf84 commented on issue #39448: URL: https://github.com/apache/airflow/issues/39448#issuecomment-2227171654 If this isn't assigned, I'd love to have it assigned to myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] RedshiftDataOperator fails when `return_sql_result` is true, and SQL statements are provided [airflow]

2024-07-13 Thread via GitHub
jroachgolf84 commented on issue #40427: URL: https://github.com/apache/airflow/issues/40427#issuecomment-2227171396 Was this issue resolved? If not, I'd love to have it assigned to myself. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Add kerberos related connection fields(principal, keytab) on SparkSubmitHook [airflow]

2024-07-13 Thread via GitHub
seyoon-lim commented on code in PR #40757: URL: https://github.com/apache/airflow/pull/40757#discussion_r1676984823 ## airflow/providers/apache/spark/hooks/spark_submit.py: ## @@ -268,6 +291,12 @@ def _resolve_connection(self) -> dict[str, Any]: ) c

Re: [I] Performance Issues on Initial Page Load [airflow]

2024-07-13 Thread via GitHub
github-actions[bot] commented on issue #38776: URL: https://github.com/apache/airflow/issues/38776#issuecomment-2227145679 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Performance Issues on Initial Page Load [airflow]

2024-07-13 Thread via GitHub
github-actions[bot] closed issue #38776: Performance Issues on Initial Page Load URL: https://github.com/apache/airflow/issues/38776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] adding callback hook for on/off state of dag [airflow]

2024-07-13 Thread via GitHub
github-actions[bot] commented on PR #38683: URL: https://github.com/apache/airflow/pull/38683#issuecomment-2227145683 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Enhance Secret Name Selection Based on gitSync Image Version [airflow]

2024-07-13 Thread via GitHub
github-actions[bot] closed pull request #38841: Enhance Secret Name Selection Based on gitSync Image Version URL: https://github.com/apache/airflow/pull/38841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Feature/pass airflow confi as job param [airflow]

2024-07-13 Thread via GitHub
github-actions[bot] closed pull request #39007: Feature/pass airflow confi as job param URL: https://github.com/apache/airflow/pull/39007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Experimental: Support custom weight_rule implementation to calculate the TI priority_weight [airflow]

2024-07-13 Thread via GitHub
waleedsamy commented on PR #38222: URL: https://github.com/apache/airflow/pull/38222#issuecomment-2227144681 @hussein-awala Does this PR set the task_instance priority_weight only when it is in running state / up_for_retry? I notice the priority_weight is set to 1 (default) when task_

[PR] Support `PythonVirtualEnvHook` [airflow]

2024-07-13 Thread via GitHub
softyoungha opened a new pull request, #40775: URL: https://github.com/apache/airflow/pull/40775 Hello, I have made some modifications to the existing `PythonVirtualenvOperator` to upgrade a few areas. I am currently working on deploying Airflow on a k8

Re: [PR] provide session to PriorityWeightStrategy get_weight method [airflow]

2024-07-13 Thread via GitHub
hussein-awala commented on PR #40774: URL: https://github.com/apache/airflow/pull/40774#issuecomment-2227116136 I will add an integration test, but first I'm trying to find a simpler solution. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] provide session to PriorityWeightStrategy get_weight method [airflow]

2024-07-13 Thread via GitHub
hussein-awala opened a new pull request, #40774: URL: https://github.com/apache/airflow/pull/40774 closes: #40773 There is a session created in `DagRun.verify_integrity` method, these statements will be called: https://github.com/apache/airflow/blob/8de5e7a679e256ac194153d

[I] Exception when using session object in CustomPriorityWeightPlugin [airflow]

2024-07-13 Thread via GitHub
hussein-awala opened a new issue, #40773: URL: https://github.com/apache/airflow/issues/40773 ### Apache Airflow version 2.9.2 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? Created from https://stackoverflow.com/ques

Re: [I] Allow localization of UI [airflow]

2024-07-13 Thread via GitHub
mahdi-mirz commented on issue #9864: URL: https://github.com/apache/airflow/issues/9864#issuecomment-2227111597 I wanna translate UI of airflow to Persian, anyone have suggestion ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
hussein-awala commented on code in PR #40766: URL: https://github.com/apache/airflow/pull/40766#discussion_r1676936134 ## tests/sensors/test_time_delta.py: ## @@ -57,7 +58,8 @@ def setup_method(self): @pytest.mark.parametrize( "data_interval_end, delta, should_deff

Re: [PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
potiuk commented on PR #40766: URL: https://github.com/apache/airflow/pull/40766#issuecomment-2227046971 Seems it's better now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Move lowest-dependencies test to separate workflow [airflow]

2024-07-13 Thread via GitHub
potiuk merged PR #40768: URL: https://github.com/apache/airflow/pull/40768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (89baaa23b2 -> f399c4acec)

2024-07-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 89baaa23b2 Revert "Rotate fernet key optimisation (#40758)" (#40769) add f399c4acec Move lowest-dependencies test

(airflow) branch main updated (e6d382244e -> 89baaa23b2)

2024-07-13 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from e6d382244e Bump minimum version for azure containerinstance. (#40767) add 89baaa23b2 Revert "Rotate fernet key op

Re: [PR] Revert "Rotate fernet key optimisation (#40758)" [airflow]

2024-07-13 Thread via GitHub
eladkal merged PR #40769: URL: https://github.com/apache/airflow/pull/40769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Rotate fernet key optimisation [airflow]

2024-07-13 Thread via GitHub
potiuk commented on PR #40758: URL: https://github.com/apache/airflow/pull/40758#issuecomment-2227032887 Hey @bjankie1 -> we need to revert that one. Our canary builds detected that `yield_per` is sqlalchemy 2-only feature and we still support sqlalchemy 1 because a number of our users migh

Re: [PR] Move lowest-dependencies test to separate workflow [airflow]

2024-07-13 Thread via GitHub
potiuk commented on PR #40768: URL: https://github.com/apache/airflow/pull/40768#issuecomment-2227029738 We also have another issue with "yield_per" - but that one is kinda tricky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] Revert "Rotate fernet key optimisation (#40758)" [airflow]

2024-07-13 Thread via GitHub
potiuk opened a new pull request, #40769: URL: https://github.com/apache/airflow/pull/40769 This reverts commit 6e604f64b68bd5ee1b9f8f6f331035665b650b01. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.co

(airflow) branch main updated (f09b2201fa -> e6d382244e)

2024-07-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f09b2201fa Fix Custom Training Job operators to accept results without managed model (#40685) add e6d382244e Bump

Re: [PR] Bump minimum version for azure containerinstance. [airflow]

2024-07-13 Thread via GitHub
potiuk merged PR #40767: URL: https://github.com/apache/airflow/pull/40767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Bump minimum version for azure containerinstance. [airflow]

2024-07-13 Thread via GitHub
potiuk commented on PR #40767: URL: https://github.com/apache/airflow/pull/40767#issuecomment-2227008147 Yep #40768 should fix it - I was afraid we will hit the workflow limit when I separate it out, but seems that we are not, so it's good to go. -- This is an automated message from the A

Re: [PR] Bump minimum version for azure containerinstance. [airflow]

2024-07-13 Thread via GitHub
potiuk commented on PR #40767: URL: https://github.com/apache/airflow/pull/40767#issuecomment-2227006630 > interesting. I thought we are checking also against min versions of the depended libs? Generally speaking if we would know this during review of the PR I would be favor in adding a

Re: [PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
potiuk commented on code in PR #40766: URL: https://github.com/apache/airflow/pull/40766#discussion_r1676866411 ## tests/sensors/test_time_delta.py: ## @@ -57,7 +58,8 @@ def setup_method(self): @pytest.mark.parametrize( "data_interval_end, delta, should_deffer",

[PR] Move lowest-dependencies test to separate workflow [airflow]

2024-07-13 Thread via GitHub
potiuk opened a new pull request, #40768: URL: https://github.com/apache/airflow/pull/40768 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

Re: [PR] Bump minimum version for azure containerinstance. [airflow]

2024-07-13 Thread via GitHub
potiuk commented on PR #40767: URL: https://github.com/apache/airflow/pull/40767#issuecomment-2226999612 Detected by canary builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] Bump minimum version for azure containerinstance. [airflow]

2024-07-13 Thread via GitHub
potiuk opened a new pull request, #40767: URL: https://github.com/apache/airflow/pull/40767 The #40616 used priority for ContainerGroup and it has only been added in 10.1.0 version of azure-containerinstance library See https://pypi.org/project/azure-mgmt-containerinstance/10.1.0/

Re: [PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
hussein-awala commented on code in PR #40766: URL: https://github.com/apache/airflow/pull/40766#discussion_r1676860513 ## tests/sensors/test_time_delta.py: ## @@ -57,7 +58,8 @@ def setup_method(self): @pytest.mark.parametrize( "data_interval_end, delta, should_deff

Re: [PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
potiuk commented on PR #40766: URL: https://github.com/apache/airflow/pull/40766#issuecomment-2226995901 Not sure if that's the issue @hussein-awala -> but I am trying to run this with self-hosted runners - currently the tests in main fail 1/5 tests. -- This is an automated message from

Re: [PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
potiuk closed pull request #40766: Attempt to fix async sensor test flakiness URL: https://github.com/apache/airflow/pull/40766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Attempt to fix async sensor test flakiness [airflow]

2024-07-13 Thread via GitHub
potiuk opened a new pull request, #40766: URL: https://github.com/apache/airflow/pull/40766 The #40719 introduce flakiness that only shows with self-hosted runners - likely because the reference_time is modified in-place by ".add" and that introduces a subtle timing issue even if the tests

(airflow) branch main updated: Fix Custom Training Job operators to accept results without managed model (#40685)

2024-07-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f09b2201fa Fix Custom Training Job operators to acc

Re: [I] Vertex AI job operators in deferrable mode assume job uses Managed Model [airflow]

2024-07-13 Thread via GitHub
potiuk closed issue #40476: Vertex AI job operators in deferrable mode assume job uses Managed Model URL: https://github.com/apache/airflow/issues/40476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix Custom Training Job operators to accept results without a model in def mode [airflow]

2024-07-13 Thread via GitHub
potiuk merged PR #40685: URL: https://github.com/apache/airflow/pull/40685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Fix Custom Training Job operators to accept results without a model in def mode [airflow]

2024-07-13 Thread via GitHub
potiuk commented on code in PR #40685: URL: https://github.com/apache/airflow/pull/40685#discussion_r1676854500 ## airflow/providers/google/cloud/operators/vertex_ai/custom_job.py: ## @@ -180,6 +180,40 @@ def execute(self, context: Context) -> None: stacklevel=2,

Re: [PR] feat: support rendering ObjectStoragePath value [airflow]

2024-07-13 Thread via GitHub
gyli commented on PR #40638: URL: https://github.com/apache/airflow/pull/40638#issuecomment-2226989836 @potiuk Test added. Please review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] DynamoDBToS3Operator using native export functionality. [airflow]

2024-07-13 Thread via GitHub
gyli commented on issue #40737: URL: https://github.com/apache/airflow/issues/40737#issuecomment-2226989533 I agree with @jayceslesar that ExportTableToPointInTime is the only API provided in boto to export DynamoDB data to S3, based on AWS's [blog](https://aws.amazon.com/blogs/aws/new-expo

(airflow) branch constraints-main updated: Updating constraints. Github run id:9920808559

2024-07-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new cd10042e81 Updating con

(airflow) branch main updated: Fix and adjust URL generation for UI grid and older runs (#40764)

2024-07-13 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9c13c0939a Fix and adjust URL generation for

Re: [PR] Fix and adjust URL generation for UI grid and older runs [airflow]

2024-07-13 Thread via GitHub
hussein-awala merged PR #40764: URL: https://github.com/apache/airflow/pull/40764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [I] Status of testing Providers that were prepared on July 12, 2024 [airflow]

2024-07-13 Thread via GitHub
eldar-elne commented on issue #40752: URL: https://github.com/apache/airflow/issues/40752#issuecomment-2226912520 @eladkal From my side (#40659 + #40637 )- everything works as expected with RC2, LMK if u need anything else. -- This is an automated message from the Apache Git Service. To r

Re: [PR] Added optional locale parameter to the ds_format method in macros [airflow]

2024-07-13 Thread via GitHub
dabla commented on PR #40746: URL: https://github.com/apache/airflow/pull/40746#issuecomment-2226905879 > Also maybe worth to add a compat version to `providers/common/compat` What do I have to put there, as the macros is part of Airflow itself and is not in the providers? Docstring

Re: [I] Status of testing of Apache Airflow 2.9.3rc1 [airflow]

2024-07-13 Thread via GitHub
phi-friday commented on issue #40756: URL: https://github.com/apache/airflow/issues/40756#issuecomment-2226894235 #40208 it works fine (test operators: `_PythonVirtualenvDecoratedOperator`, `_DockerDecoratedOperator`) -- This is an automated message from the Apache Git Service. To resp

Re: [I] Add a new ExternalAPITaskSensor to monitor external DAGs via Airflow REST API [airflow]

2024-07-13 Thread via GitHub
cherrera20 commented on issue #39463: URL: https://github.com/apache/airflow/issues/39463#issuecomment-2226892939 Ok, I could work on it. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Add cached property for connection_extra in DbApiHook to improve performance [airflow]

2024-07-13 Thread via GitHub
dabla commented on PR #40751: URL: https://github.com/apache/airflow/pull/40751#issuecomment-2226892724 I'm just wondering if I have to bump to version of the common sql provider? As there will be a change there, it should become like 1.15.0 as @potiuk suggested in the other PR [40665](ht

[PR] [DRAFT] Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) [airflow]

2024-07-13 Thread via GitHub
gopidesupavan opened a new pull request, #40765: URL: https://github.com/apache/airflow/pull/40765 Draft --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_p

Re: [I] Executor reports task instance (...) finished (failed) although the task says it's queued [airflow]

2024-07-13 Thread via GitHub
trlopes1974 commented on issue #39717: URL: https://github.com/apache/airflow/issues/39717#issuecomment-2226843279 > y looks like for some reason something is killing your tasks. and this will happen for example when you have not enough memory (or other resources that your tasks need

(airflow) branch constraints-main updated: Updating constraints. Github run id:9918744805

2024-07-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 267295f5b0 Updating con

[PR] Fix and adjust URL generation for UI grid and older runs [airflow]

2024-07-13 Thread via GitHub
jscheffl opened a new pull request, #40764: URL: https://github.com/apache/airflow/pull/40764 Even though there was a PR #39642 and linked several others there is a serious regression to have valid and working links for older DAG runs pointing to grid. I got a report for such a bug durin

(airflow) branch main updated: Rotate fernet key optimisation (#40758)

2024-07-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6e604f64b6 Rotate fernet key optimisation (#40758)

Re: [PR] Rotate fernet key optimisation [airflow]

2024-07-13 Thread via GitHub
potiuk merged PR #40758: URL: https://github.com/apache/airflow/pull/40758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] ExternalTaskSensor doesn't check existence in deferrable model [airflow]

2024-07-13 Thread via GitHub
potiuk commented on issue #40745: URL: https://github.com/apache/airflow/issues/40745#issuecomment-2226824779 Assigned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] ExternalTaskSensor doesn't check existence in deferrable model [airflow]

2024-07-13 Thread via GitHub
Prab-27 commented on issue #40745: URL: https://github.com/apache/airflow/issues/40745#issuecomment-2226816867 hi @potiuk , Would you please assign this issue .I want to contribute as my first contribution. And I assure you I will complete as soon as possible. -- This is an automated mes

Re: [I] The "Set state to success" in the Task Instances view behaves differently than "Mark state as.. (success)" in Dag's detail view. [airflow]

2024-07-13 Thread via GitHub
shahar1 commented on issue #39362: URL: https://github.com/apache/airflow/issues/39362#issuecomment-2226811810 I've managed to reproduce the issue and I think that we should treat it as a bug - inconsistent behavior for the same action done in different places. -- This is an automated me

Re: [I] Support different plugins_folder setting in helm chart when airflow version > 2.0.0 [airflow]

2024-07-13 Thread via GitHub
shahar1 commented on issue #39562: URL: https://github.com/apache/airflow/issues/39562#issuecomment-2226809579 @tankim Would you still like to work on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Bug in Extras in Add Connection , while writing few words are hidden due to margin and padding [airflow]

2024-07-13 Thread via GitHub
shahar1 commented on issue #37583: URL: https://github.com/apache/airflow/issues/37583#issuecomment-2226801047 @Ram-tripath would you still like to work on this issue? It would be helpful if you could provide additional screenshots so it could be resolved. -- This is an automated messa