bolkedebruin commented on issue #40974:
URL: https://github.com/apache/airflow/issues/40974#issuecomment-2254016349
Sounds good. Although I don't understand your point 1 fully. Yes to
consolidation, but "making airflow modules select serialization engines" I do
not understand. Care the clar
pankajkoti merged PR #41050:
URL: https://github.com/apache/airflow/pull/41050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airfl
This is an automated email from the ASF dual-hosted git repository.
pankajkoti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 4535e08b86 [Databricks Provider] Revert PRs #40
utkarsharma2 commented on issue #41055:
URL: https://github.com/apache/airflow/issues/41055#issuecomment-2254177871
my 2c: I think there is a valid case for the infinite/unknown parallelism
for KE. For example, if we have a cluster with some capacity X Gi of memory,
now how do we decide the
HuanjieGuo opened a new pull request, #41064:
URL: https://github.com/apache/airflow/pull/41064
You can see the detail in https://github.com/apache/airflow/discussions/40880
* Currently, we do not have any worker log disk isolation, and a bug in a
dag can write a 10Gb + file, which ca
boring-cyborg[bot] commented on PR #41064:
URL: https://github.com/apache/airflow/pull/41064#issuecomment-2254182260
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
shahar1 commented on code in PR #41031:
URL: https://github.com/apache/airflow/pull/41031#discussion_r1693979122
##
docs/apache-airflow/core-concepts/params.rst:
##
@@ -220,7 +220,7 @@ The following features are supported in the Trigger UI Form:
If no ``title`` is defined t
This is an automated email from the ASF dual-hosted git repository.
husseinawala pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 4535e08b86 [Databricks Provider] Revert PRs #40864 and #40471 (#41050)
add 4e5ad66656 fix: add argument incl
hussein-awala merged PR #41062:
URL: https://github.com/apache/airflow/pull/41062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ai
potiuk opened a new pull request, #41065:
URL: https://github.com/apache/airflow/pull/41065
The incremental library 24.7.0 and 24.7.1 have been broken (the 24.7.0 has
been yanked already but 24.7.1 has still a breaking change - it plugs in
setuptools/distutils in the way that when virtualen
potiuk commented on PR #41065:
URL: https://github.com/apache/airflow/pull/41065#issuecomment-2254204883
Should fix our broken `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
potiuk merged PR #41065:
URL: https://github.com/apache/airflow/pull/41065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new fad5e5e9d4 Limit incremental library (dependency of
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 509b442100 Updating con
jscheffl commented on code in PR #41037:
URL: https://github.com/apache/airflow/pull/41037#discussion_r1693999003
##
airflow/example_dags/example_dataset_alias.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
jscheffl commented on code in PR #41037:
URL: https://github.com/apache/airflow/pull/41037#discussion_r1693999003
##
airflow/example_dags/example_dataset_alias.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
jscheffl commented on code in PR #41037:
URL: https://github.com/apache/airflow/pull/41037#discussion_r1693999132
##
airflow/example_dags/example_dataset_alias.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
jscheffl commented on code in PR #41037:
URL: https://github.com/apache/airflow/pull/41037#discussion_r1693999291
##
airflow/example_dags/example_dataset_alias.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
jscheffl commented on code in PR #41037:
URL: https://github.com/apache/airflow/pull/41037#discussion_r1693999227
##
airflow/example_dags/example_dataset_alias.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
patpanda94 opened a new pull request, #41066:
URL: https://github.com/apache/airflow/pull/41066
This PR adds a simple tests for RedisKeySensor and RedisPublishOperator.
Part of https://github.com/apache/airflow/issues/35442
---
**^ Add meaningful description above**
Re
boring-cyborg[bot] commented on PR #41066:
URL: https://github.com/apache/airflow/pull/41066#issuecomment-2254219220
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
potiuk opened a new pull request, #41067:
URL: https://github.com/apache/airflow/pull/41067
This PR removes AIP-44 feature flag and replaces "in-progress-disabled" test
with dedicated "DatabaseIsolation" one.
The DatabaseIsolation test will run all "db-tests" with enabled DB isolation
potiuk commented on PR #41067:
URL: https://github.com/apache/airflow/pull/41067#issuecomment-2254221364
This PR will have quite a number of failing tests still - some of them
because they should just be disabled - on a module level in most cases (with
adding `pytest.mark.skuip-if-database
aritra24 commented on PR #41067:
URL: https://github.com/apache/airflow/pull/41067#issuecomment-2254222666
I'll try taking a look at some failures tomorrow my time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
potiuk closed issue #41068: AIP-44 Test setup
URL: https://github.com/apache/airflow/issues/41068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
potiuk closed issue #29308: AIP-44 Migrate
TaskInstance.schedule_downstream_tasks to Internal API
URL: https://github.com/apache/airflow/issues/29308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk commented on issue #29308:
URL: https://github.com/apache/airflow/issues/29308#issuecomment-2254225215
This it too complex to be completed in the "experimental" phase. For now
AIP-44 will have "mini-scheduler" disabled.
--
This is an automated message from the Apache Git Service.
T
potiuk commented on issue #30241:
URL: https://github.com/apache/airflow/issues/30241#issuecomment-2254225486
This is something we might want to do for Airflow 2.11 - if we decide to use
AIP-44 as a "test-bed" for AIP-72
--
This is an automated message from the Apache Git Service.
To resp
potiuk closed issue #18116: Methods
`TaskInstance.get_previous_execution_date()` & `TaskInstance.get_previous_ti()`
are lying !
URL: https://github.com/apache/airflow/issues/18116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
potiuk commented on issue #31213:
URL: https://github.com/apache/airflow/issues/31213#issuecomment-2254225750
Might still be a good idea actually. It should not be that hard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
potiuk commented on issue #31213:
URL: https://github.com/apache/airflow/issues/31213#issuecomment-2254226729
This is one of the remainin points for AIP-44, and I think we might consider
using the "serde" serializer instead the "DAG" serializer still. The code to
wire it up should be just m
potiuk opened a new issue, #41069:
URL: https://github.com/apache/airflow/issues/41069
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gyli commented on issue #40974:
URL: https://github.com/apache/airflow/issues/40974#issuecomment-2254227102
I've edited my language in my comment above. I was thinking about supporting
the old DAG serializer and the consolidated version at the same time for
smoother migration, while I also
shahar1 commented on code in PR #41031:
URL: https://github.com/apache/airflow/pull/41031#discussion_r1694004153
##
airflow/example_dags/example_params_trigger_ui.py:
##
@@ -100,3 +101,4 @@ def print_greetings(greetings1, greetings2, greetings3) ->
None:
french_greetings =
potiuk commented on issue #40974:
URL: https://github.com/apache/airflow/issues/40974#issuecomment-2254229231
Also as mentioned in https://github.com/apache/airflow/issues/31213 -> it
might be a good exercise to migrate AIP-44 for Airflow 2.10 to use `serde`
eventually. While AIP-44 will be
jscheffl opened a new pull request, #41070:
URL: https://github.com/apache/airflow/pull/41070
While rebasing I realized that one mapped method in internal API was renamed
and broke the internal API.
This PR fixes back to the correct name.
@potiuk How could this happen if internal A
potiuk commented on PR #41070:
URL: https://github.com/apache/airflow/pull/41070#issuecomment-2254238500
Yeah. I also found it and fixed in
https://github.com/apache/airflow/pull/41067 - so yeah. That's exactly what
will not happen when we run the tests :D
--
This is an automated messag
potiuk commented on PR #41070:
URL: https://github.com/apache/airflow/pull/41070#issuecomment-2254238793
And yeah. By implementing the test you already implemented
[the](https://github.com/apache/airflow/issues/28695)
--
This is an automated message from the Apache Git Service.
To respon
jscheffl commented on PR #41070:
URL: https://github.com/apache/airflow/pull/41070#issuecomment-2254239334
> And yeah. By implementing the test you already implemented [This
one](https://github.com/apache/airflow/issues/28695)
I would say the pytest is 50% of it. Still you could add t
jscheffl merged PR #41070:
URL: https://github.com/apache/airflow/pull/41070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
This is an automated email from the ASF dual-hosted git repository.
jscheffl pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new bf01953138 Fix broken/renamed internal API method
potiuk commented on PR #41070:
URL: https://github.com/apache/airflow/pull/41070#issuecomment-2254240106
Agreed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
jscheffl closed issue #28695: Create pre-commit check for all @internal_api
methods to be present in METHODS_MAP
URL: https://github.com/apache/airflow/issues/28695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jscheffl commented on issue #28695:
URL: https://github.com/apache/airflow/issues/28695#issuecomment-2254240372
I would re-open here as I assume the bugfix/pytest was only covering 50% of
the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
jscheffl commented on PR #41067:
URL: https://github.com/apache/airflow/pull/41067#issuecomment-2254241760
I LOVE pull-requests which delete more lines than adding. But as being
DRAFT, looking forward for review (if family time permits tomorrow)
--
This is an automated message from the Ap
potiuk commented on issue #28695:
URL: https://github.com/apache/airflow/issues/28695#issuecomment-2254242139
Yep. Not closed yet :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
potiuk opened a new pull request, #41071:
URL: https://github.com/apache/airflow/pull/41071
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul
potiuk closed issue #40811: Add links to example dags in use params section
URL: https://github.com/apache/airflow/issues/40811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk merged PR #41031:
URL: https://github.com/apache/airflow/pull/41031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
boring-cyborg[bot] commented on PR #41031:
URL: https://github.com/apache/airflow/pull/41031#issuecomment-2254243909
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from bf01953138 Fix broken/renamed internal API method (#41070)
add e7a2a9d865 Add links to example dags in use params
potiuk commented on PR #41064:
URL: https://github.com/apache/airflow/pull/41064#issuecomment-2254244541
Are you sure this change is going to be backwards compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
potiuk opened a new pull request, #41072:
URL: https://github.com/apache/airflow/pull/41072
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul
boring-cyborg[bot] commented on PR #41073:
URL: https://github.com/apache/airflow/pull/41073#issuecomment-2254268651
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
github-actions[bot] closed pull request #30115: Re-enable note ordering in
DagRunModelView
URL: https://github.com/apache/airflow/pull/30115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
github-actions[bot] closed issue #29988: Mapped Task details view "success"
counts are off
URL: https://github.com/apache/airflow/issues/29988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
github-actions[bot] commented on issue #29988:
URL: https://github.com/apache/airflow/issues/29988#issuecomment-2254290456
This issue has been closed because it has not received response from the
issue author.
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on issue #28865:
URL: https://github.com/apache/airflow/issues/28865#issuecomment-2254290465
This issue has been automatically marked as stale because it has been open
for 14 days with no response from the author. It will be closed in next 7 days
if no further
Lee-W commented on code in PR #41037:
URL: https://github.com/apache/airflow/pull/41037#discussion_r1694044354
##
airflow/example_dags/example_dataset_alias.py:
##
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agre
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new e37de42b47 Updating con
gyli commented on issue #31213:
URL: https://github.com/apache/airflow/issues/31213#issuecomment-2254328335
Yeah I can try that, and hopefully I can co-own this issue with someone
who's familiar with internal_api_call and rpc server. Still trying to figure
out how I can test it other than u
HuanjieGuo commented on PR #41064:
URL: https://github.com/apache/airflow/pull/41064#issuecomment-2254328669
> Are you sure this change is going to be backwards compatible?
@potiuk
the new added parameters all have default value, should not break the
existed init process for *
eladkal merged PR #41071:
URL: https://github.com/apache/airflow/pull/41071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new a482d0f851 Update UV to latest version 0.2.30 (#41
potiuk commented on issue #31213:
URL: https://github.com/apache/airflow/issues/31213#issuecomment-2254350184
Sure. It's all rather well defined. Let me describe the options of testing.
Might be also useful for others:
1) Testing it locallu with airflow:
```
breeze start-ai
eladkal merged PR #40996:
URL: https://github.com/apache/airflow/pull/40996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 4ab0183cfa Add AirflowRun on COMPLETE/FAIL events
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch ol-add-runfacet-complete-fail
in repository https://gitbox.apache.org/repos/asf/airflow.git
was f3ad57ba82 openlineage: add AirflowRun on COMPLETE/FAIL events
The revisions that were on th
eladkal merged PR #40538:
URL: https://github.com/apache/airflow/pull/40538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 681b884525 Refactor Compute Engine system tests (#
eladkal opened a new pull request, #41074:
URL: https://github.com/apache/airflow/pull/41074
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
potiuk opened a new pull request, #41075:
URL: https://github.com/apache/airflow/pull/41075
The https://github.com/twisted/incremental/issues/106 issue has been
addressed in 24.7.2 so we are removing the limit - just in case we also exclude
the buggy versions, even if they are yanked.
SledgeHammer01 commented on PR #41073:
URL: https://github.com/apache/airflow/pull/41073#issuecomment-2254358267
@potiuk can you take a look? For some reason, I'm unable to add reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
potiuk commented on PR #41073:
URL: https://github.com/apache/airflow/pull/41073#issuecomment-2254360836
> @potiuk can you take a look? For some reason, I'm unable to add reviewers.
Yes. Reviewers will take a look when they have time and interest generally,
not when they are called.
74 matches
Mail list logo
