Re: [I] Inclusive or exclusive range filters in API [airflow]

2024-07-30 Thread via GitHub
uranusjr commented on issue #9237: URL: https://github.com/apache/airflow/issues/9237#issuecomment-2259784765 This shouldn’t be too difficult. Just add GT and LT variants of the GTE/LTE filters listed above, and add them as parameters that make sense in the API spec (`openapi/v1.yaml`). Fee

Re: [I] Allow user to supply croniter object, multiple cron strings or generator object to DAG [airflow]

2024-07-30 Thread via GitHub
uranusjr closed issue #8835: Allow user to supply croniter object, multiple cron strings or generator object to DAG URL: https://github.com/apache/airflow/issues/8835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Replaced bootstrap-typeahead with jquery-ui [airflow]

2024-07-30 Thread via GitHub
sai-ganesh-03 commented on code in PR #40744: URL: https://github.com/apache/airflow/pull/40744#discussion_r1697933246 ## airflow/www/static/css/main.css: ## @@ -288,10 +288,20 @@ label[for="timezone-other"], font-weight: normal; } +#timezone-menu { + overflow-x: hidden;

Re: [PR] Replaced bootstrap-typeahead with jquery-ui [airflow]

2024-07-30 Thread via GitHub
sai-ganesh-03 commented on code in PR #40744: URL: https://github.com/apache/airflow/pull/40744#discussion_r1697932163 ## airflow/www/static/css/main.css: ## @@ -288,10 +288,20 @@ label[for="timezone-other"], font-weight: normal; } +#timezone-menu { + overflow-x: hidden;

Re: [I] When multiple filters selected in arg_tags_filter, each filter works as 'or' instead of 'and'. [airflow]

2024-07-30 Thread via GitHub
ryuichi-zd commented on issue #10724: URL: https://github.com/apache/airflow/issues/10724#issuecomment-2259690357 Found a more recent issue raised: https://github.com/apache/airflow/issues/39363 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Add option to hide Datasets in Graph View [airflow]

2024-07-30 Thread via GitHub
uranusjr commented on issue #41003: URL: https://github.com/apache/airflow/issues/41003#issuecomment-2259641168 I think we should also have an option to hide the DAGs too (the other way around). cc @bbovenzi sicne I think there’s some planned improvements on the view for 3.0. -- This is

Re: [I] Backfilling ignores task-level start_date and end_date [airflow]

2024-07-30 Thread via GitHub
uranusjr commented on issue #17734: URL: https://github.com/apache/airflow/issues/17734#issuecomment-2259638430 @dstandish one thing to note when reimplementing backfilling with the scheduler. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] Inconsistent data_interval_start/data_interval_end behavior between manual and scheduled DAG runs [airflow]

2024-07-30 Thread via GitHub
uranusjr commented on issue #41014: URL: https://github.com/apache/airflow/issues/41014#issuecomment-2259633808 The behaviour is expected and (unfortunately) intended. When a run is scheduled, it is identified by its data interval, but a manually triggered run does not have a pre-defined in

Re: [I] Consider supporting .jinja2 extensions across the project [airflow]

2024-07-30 Thread via GitHub
uranusjr commented on issue #8603: URL: https://github.com/apache/airflow/issues/8603#issuecomment-2259620366 This would be irrelevant if [AIP-80](https://cwiki.apache.org/confluence/x/2grOEg) is accepted. Instead of inferring from the extension, you’d need to pass in a FileTemplate class

Re: [PR] Render Dataset Conditions in DAG Graph view [airflow]

2024-07-30 Thread via GitHub
Lee-W commented on PR #41137: URL: https://github.com/apache/airflow/pull/41137#issuecomment-2259600345 The UI looks great! I tested it with the following dag but couldn't see the graph. Is there anything I missed? Thanks! ```python from __future__ import annotations import

Re: [PR] Send context using in venv operator [airflow]

2024-07-30 Thread via GitHub
gyli commented on PR #41039: URL: https://github.com/apache/airflow/pull/41039#issuecomment-2259562632 This PR looks good to me, at least for Airflow 2. While the down side is it creates another version of serialized context. I think ideally in Airflow 3, it can utilize serde to seri

Re: [I] Import error of new dags cannot be shown on web UI for common users [airflow]

2024-07-30 Thread via GitHub
wolfier commented on issue #29897: URL: https://github.com/apache/airflow/issues/29897#issuecomment-2259556807 I am unable to replicate the behaviour in Airflow 2.5.1 or 2.6.3. In the original scenario, the custom role does not have the respective read on DAG permission. The role mus

[I] Using `MappedOperator` creates `TriggerDagRunLink` incorrectly [airflow]

2024-07-30 Thread via GitHub
phi-friday opened a new issue, #41145: URL: https://github.com/apache/airflow/issues/41145 ### Apache Airflow version 2.9.3 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When I create a `TriggerDagRunOperator` with `p

Re: [PR] added a new condition before launching the self._scan_stale_dags() fu… [airflow]

2024-07-30 Thread via GitHub
github-actions[bot] commented on PR #39159: URL: https://github.com/apache/airflow/pull/39159#issuecomment-2259398995 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [I] webserver - acces task log | TypeError: '<' not supported between instances of 'Interval' and 'DateTime' [airflow]

2024-07-30 Thread via GitHub
github-actions[bot] commented on issue #39306: URL: https://github.com/apache/airflow/issues/39306#issuecomment-2259398977 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [PR] Add instruction: where to put image pull secret for private registry [airflow]

2024-07-30 Thread via GitHub
github-actions[bot] commented on PR #39687: URL: https://github.com/apache/airflow/pull/39687#issuecomment-2259398957 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Updated kuberentes pod operator to find pods only in running state [airflow]

2024-07-30 Thread via GitHub
github-actions[bot] commented on PR #39702: URL: https://github.com/apache/airflow/pull/39702#issuecomment-2259398931 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] CI: Introduce cross-provider backwards-compatiblity tests. [airflow]

2024-07-30 Thread via GitHub
github-actions[bot] commented on PR #40053: URL: https://github.com/apache/airflow/pull/40053#issuecomment-2259398912 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Add multiple task instance selection in Grid View (#33448) [airflow]

2024-07-30 Thread via GitHub
github-actions[bot] commented on PR #40147: URL: https://github.com/apache/airflow/pull/40147#issuecomment-2259398893 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[PR] Field Deletion Warning when editing Connections [airflow]

2024-07-30 Thread via GitHub
lh5844 opened a new pull request, #41144: URL: https://github.com/apache/airflow/pull/41144 The issue mentions that fields backed by the BS3TextFieldWidget cannot be deleted once populated. To delete those fields, the user must delete the connection and create a new one. The

[PR] Fix Manager Tests for Dataset Isolation Mode [airflow]

2024-07-30 Thread via GitHub
jscheffl opened a new pull request, #41143: URL: https://github.com/apache/airflow/pull/41143 Relates https://github.com/apache/airflow/pull/41067 Fixed Datasets Manager for DB Isolation. Needed to add skip for two tests - in my view they are not called via API and are just int

Re: [PR] Add capability to export log messages into XCOM [airflow]

2024-07-30 Thread via GitHub
boring-cyborg[bot] commented on PR #41142: URL: https://github.com/apache/airflow/pull/41142#issuecomment-2259336139 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Add capability to export log messages into XCOM [airflow]

2024-07-30 Thread via GitHub
perry2of5 opened a new pull request, #41142: URL: https://github.com/apache/airflow/pull/41142 This commit adds the capability to export log messages into XCOM on an optional basis. The existing behavior (no logs) is retained as the default making this an opt-in feature. Users of the operat

Re: [I] Add “Resources” section in the Airflow website [airflow-site]

2024-07-30 Thread via GitHub
divyaguduru commented on issue #233: URL: https://github.com/apache/airflow-site/issues/233#issuecomment-2259332619 hi @aijamalnk , i have gone through the description and would like to pick this issue .. pls assign it to me -- This is an automated message from the Apache Git Service. To

Re: [I] Version dropdown doesn't work on Module pages [airflow-site]

2024-07-30 Thread via GitHub
kaxil commented on issue #254: URL: https://github.com/apache/airflow-site/issues/254#issuecomment-2259327230 Thanks @divyaguduru -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [I] Version dropdown doesn't work on Module pages [airflow-site]

2024-07-30 Thread via GitHub
kaxil closed issue #254: Version dropdown doesn't work on Module pages URL: https://github.com/apache/airflow-site/issues/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Version dropdown doesn't work on Module pages [airflow-site]

2024-07-30 Thread via GitHub
divyaguduru commented on issue #254: URL: https://github.com/apache/airflow-site/issues/254#issuecomment-2259324030 unable to reproduce this issue in UI .. looks like it's already addressed @kaxil @mik-laj -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-07-30 Thread via GitHub
jscheffl commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2259305747 FYI I attempted to fix tests/datasets/test_manager.py but failed as the "task_instance mock is "wrongly" serialized and therefore the internal API failing in the backend. To fix thi

(airflow) branch main updated: Fix Utils Tests for Dataset Isolation Mode (#41138)

2024-07-30 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c1772d090f Fix Utils Tests for Dataset Isolation

Re: [PR] Fix Utils Tests for Dataset Isolation Mode [airflow]

2024-07-30 Thread via GitHub
jscheffl merged PR #41138: URL: https://github.com/apache/airflow/pull/41138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] `ExternalTaskSensor` deferrable doesn't fail with `failed_states` [airflow]

2024-07-30 Thread via GitHub
mjohansenwork commented on issue #41140: URL: https://github.com/apache/airflow/issues/41140#issuecomment-2259297473 Initial stab at PR https://github.com/apache/airflow/pull/41141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Update external_task.py to forward `failed_states` [airflow]

2024-07-30 Thread via GitHub
mjohansenwork commented on PR #41141: URL: https://github.com/apache/airflow/pull/41141#issuecomment-2259297306 I'm not sure if this will actually fix the issue or not. If somebody wants to help me figure out how to test this, I'm happy to do so. I'm using the Astronomer runtime `11.7.0` do

[PR] Update external_task.py to forward `failed_states` [airflow]

2024-07-30 Thread via GitHub
mjohansenwork opened a new pull request, #41141: URL: https://github.com/apache/airflow/pull/41141 It seems there is a bug with `ExternalTaskSensor` when using deferrable mode. It continuously loops and pokes the upstream task/DAG even if it's `failed`. I would expect the deferrable sensor

Re: [PR] Update external_task.py to forward `failed_states` [airflow]

2024-07-30 Thread via GitHub
boring-cyborg[bot] commented on PR #41141: URL: https://github.com/apache/airflow/pull/41141#issuecomment-2259296461 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

Re: [I] Improve CSS of https://airflow.apache.org/announcements/ [airflow-site]

2024-07-30 Thread via GitHub
divyaguduru commented on issue #300: URL: https://github.com/apache/airflow-site/issues/300#issuecomment-2259293631 hi @mik-laj , i would like to work on this issue. pls assign it to my name. -- This is an automated message from the Apache Git Service. To respond to the message, please log

(airflow) branch main updated: Fix Base Job Tests for Dataset Isolation Mode (#41136)

2024-07-30 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f970b4dabc Fix Base Job Tests for Dataset Isolati

Re: [I] `ExternalTaskSensor` deferrable doesn't fail with `failed_states` [airflow]

2024-07-30 Thread via GitHub
boring-cyborg[bot] commented on issue #41140: URL: https://github.com/apache/airflow/issues/41140#issuecomment-2259292831 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] Fix Base Job Tests for Dataset Isolation Mode [airflow]

2024-07-30 Thread via GitHub
jscheffl merged PR #41136: URL: https://github.com/apache/airflow/pull/41136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

[I] `ExternalTaskSensor` deferrable doesn't fail with `failed_states` [airflow]

2024-07-30 Thread via GitHub
mjohansenwork opened a new issue, #41140: URL: https://github.com/apache/airflow/issues/41140 ### Apache Airflow version 2.9.3 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? For `ExternalTaskSensor`, when I specify `de

Re: [PR] Only disable tests when not starting airflow [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41139: URL: https://github.com/apache/airflow/pull/41139#issuecomment-2259281794 Follow up after #41135 - that one did not allow tests to run in interactive mode with isolation. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Only disable tests when not starting airflow [airflow]

2024-07-30 Thread via GitHub
potiuk opened a new pull request, #41139: URL: https://github.com/apache/airflow/pull/41139 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

Re: [PR] Bugfix/41067 fix tests core test core.py 2 [airflow]

2024-07-30 Thread via GitHub
jscheffl commented on PR #41134: URL: https://github.com/apache/airflow/pull/41134#issuecomment-2259275109 > Hmm. I think the "run" method of the operator is only used for backfill, cli commands and tests. That's why we have not seen it failing in "regular runs" - there `task_run` is used t

[PR] Fix Utils Tests for Dataset Isolation Mode [airflow]

2024-07-30 Thread via GitHub
jscheffl opened a new pull request, #41138: URL: https://github.com/apache/airflow/pull/41138 Realted https://github.com/apache/airflow/pull/41067 The failed utils tests are all legacy or WWW related. We can safely skip them in isolation mode. -- This is an automated message from t

Re: [PR] Bugfix/41067 fix tests core test core.py 2 [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41134: URL: https://github.com/apache/airflow/pull/41134#issuecomment-2259270329 Hmm. I think the "run" method of the operator is only used for backfill, cli commands and tests. That's why we have not seen it failing in "regular runs" - there `task_run` is used that

[PR] Render Dataset Conditions in DAG Graph view [airflow]

2024-07-30 Thread via GitHub
bbovenzi opened a new pull request, #41137: URL: https://github.com/apache/airflow/pull/41137 Before we were just rendering a json object of the any/all conditions of dataset events for a dag to run. Now, we interpret that and render it in the graph view with logical gates. Also, add

Re: [PR] Remove datatables.net [airflow]

2024-07-30 Thread via GitHub
bbovenzi merged PR #41133: URL: https://github.com/apache/airflow/pull/41133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

(airflow) branch main updated: Remove datatables.net (#41133)

2024-07-30 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 940c2851df Remove datatables.net (#41133) 940c285

[PR] Fix Base Job Tests for Dataset Isolation Mode [airflow]

2024-07-30 Thread via GitHub
jscheffl opened a new pull request, #41136: URL: https://github.com/apache/airflow/pull/41136 Realted https://github.com/apache/airflow/pull/41067 Fix (and skip one) tests for Base Job... Again mostly because of different sessions running over more than one DB connection. On

(airflow) branch main updated: Only set "running db isolation tests" mode in Breeze for tests (#41135)

2024-07-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0433d75594 Only set "running db isolation tests" mo

Re: [PR] Only set "running db isolation tests" mode in Breeze for tests [airflow]

2024-07-30 Thread via GitHub
potiuk merged PR #41135: URL: https://github.com/apache/airflow/pull/41135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Bugfix/41067 fix tests core test core.py 2 [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41134: URL: https://github.com/apache/airflow/pull/41134#issuecomment-2259245362 https://github.com/apache/airflow/pull/41135 - brings the "start-airflow" experience back. And yes - it still works, so we miss something for sure. -- This is an automated message from

Re: [PR] Remove Dataset Alias Condition Tests from Dataset Isolation Mode [airflow]

2024-07-30 Thread via GitHub
potiuk merged PR #41132: URL: https://github.com/apache/airflow/pull/41132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Remove Dataset Alias Condition Tests from Dataset Isolation Mode! (#41132)

2024-07-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new db8ce428b2 Remove Dataset Alias Condition Tests fro

[PR] Only set "running db isolation tests" mode in Breeze for tests [airflow]

2024-07-30 Thread via GitHub
potiuk opened a new pull request, #41135: URL: https://github.com/apache/airflow/pull/41135 The recent change caused it to be set also for regular "start-airflow" --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://

Re: [PR] Bugfix/41067 fix tests core test core.py 2 [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41134: URL: https://github.com/apache/airflow/pull/41134#issuecomment-2259206893 > I was also thinking a moment... but I saw the worker (in remote executer case) already running with successful execution... and this is sooo basic. I was sure and am still puzzled... h

Re: [PR] Bugfix/41067 fix tests core test core.py 2 [airflow]

2024-07-30 Thread via GitHub
jscheffl closed pull request #41134: Bugfix/41067 fix tests core test core.py 2 URL: https://github.com/apache/airflow/pull/41134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bugfix/41067 fix tests core test core.py 2 [airflow]

2024-07-30 Thread via GitHub
jscheffl commented on PR #41134: URL: https://github.com/apache/airflow/pull/41134#issuecomment-2259198941 > I am afraid - those are the tests and functioality that **should** be fixed - those tests are calling `run` method of the task - and it seems that starting from `dag_run = session.sc

Re: [PR] Bugfix/41067 fix tests core test core.py 2 [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41134: URL: https://github.com/apache/airflow/pull/41134#issuecomment-2259198707 I think this is the toughest part to fix and it will unblock / fix many other tests -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Bugfix/41067 fix tests core test core.py 2 [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41134: URL: https://github.com/apache/airflow/pull/41134#issuecomment-2259195308 I am afraid - those are the tests and functioality that **should** be fixed - those tests are calling `run` method of the task - and it seems that starting from `dag_run = session.scalar

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2259177640 > Would it make sense to skip the failing tests and get this to main and follow-up replacing skips incrementally later? I'd say there are still some **real** issues there - and I t

(airflow) branch main updated: Pass mapIndex to LogLink component for external log systems (#41125)

2024-07-30 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f1a32a4072 Pass mapIndex to LogLink component for

Re: [I] Bad map_index in the log view of a mapped task [airflow]

2024-07-30 Thread via GitHub
bbovenzi closed issue #40655: Bad map_index in the log view of a mapped task URL: https://github.com/apache/airflow/issues/40655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Pass mapIndex to LogLink component for external log systems [airflow]

2024-07-30 Thread via GitHub
boring-cyborg[bot] commented on PR #41125: URL: https://github.com/apache/airflow/pull/41125#issuecomment-2259175651 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Pass mapIndex to LogLink component for external log systems [airflow]

2024-07-30 Thread via GitHub
bbovenzi merged PR #41125: URL: https://github.com/apache/airflow/pull/41125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Skip www tests for db isolation mode [airflow]

2024-07-30 Thread via GitHub
potiuk merged PR #41131: URL: https://github.com/apache/airflow/pull/41131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (58b06724ca -> 63e7c6354a)

2024-07-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 58b06724ca Disable db isolation tests for api_connexion tests (#41130) add 63e7c6354a Skip www tests for db isolat

[PR] Remove datatables.net [airflow]

2024-07-30 Thread via GitHub
bbovenzi opened a new pull request, #41133: URL: https://github.com/apache/airflow/pull/41133 We don't appear to use these libraries anymore. Let's get rid of them. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/

(airflow) branch main updated: Disable db isolation tests for api_connexion tests (#41130)

2024-07-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 58b06724ca Disable db isolation tests for api_conne

Re: [PR] Disable db isolation tests for api_connexion tests [airflow]

2024-07-30 Thread via GitHub
potiuk merged PR #41130: URL: https://github.com/apache/airflow/pull/41130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Skip www tests for db isolation mode [airflow]

2024-07-30 Thread via GitHub
potiuk opened a new pull request, #41131: URL: https://github.com/apache/airflow/pull/41131 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

Re: [PR] Remove incremental upper-bind limit [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41075: URL: https://github.com/apache/airflow/pull/41075#issuecomment-2259108847 Would love to merge it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] Disable db isolation tests for api_connexion tests [airflow]

2024-07-30 Thread via GitHub
potiuk opened a new pull request, #41130: URL: https://github.com/apache/airflow/pull/41130 Those tests should not be run for db isolation tests at all Related: #41067 --- **^ Add meaningful description above** Read the **[Pull Request Guidelin

(airflow) branch main updated: Make traceback for DB isolation mode way smaller and useful (#41129)

2024-07-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7233ffe644 Make traceback for DB isolation mode way

Re: [PR] Make traceback for DB isolation mode way smaller and useful [airflow]

2024-07-30 Thread via GitHub
potiuk merged PR #41129: URL: https://github.com/apache/airflow/pull/41129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-07-30 Thread via GitHub
jscheffl commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2259101512 > We are racing with time :( Agree. There are a hell-lot of fixes open. Good thing that I saw is that the function is general working, all I saw are environment or test issues in

Re: [PR] Make traceback for DB isolation mode way smaller and useful [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41129: URL: https://github.com/apache/airflow/pull/41129#issuecomment-2259078715 Only that remains: ![image](https://github.com/user-attachments/assets/957990b8-fdaa-46b8-a865-394eb6925822) -- This is an automated message from the Apache Git Service. To

[PR] Make traceback for DB isolation mode way smaller and useful [airflow]

2024-07-30 Thread via GitHub
potiuk opened a new pull request, #41129: URL: https://github.com/apache/airflow/pull/41129 Removes a lot of useless frames from the traceback: * pytest and pluggy * last two "create_session" tracebacks This way it is immediately visible where we should look for problems

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2259057773 We are racing with time :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-07-30 Thread via GitHub
potiuk commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2259057153 > Weird, tests/datasets/test_dataset.py is succeeding on my side. Maybe it is failing when running with others and, somehow, they are conflicting each other? But when I run pytest tests/

Re: [I] Move "devel_only" extras for providers to "[devel]" extras of providers [airflow]

2024-07-30 Thread via GitHub
potiuk closed issue #33908: Move "devel_only" extras for providers to "[devel]" extras of providers URL: https://github.com/apache/airflow/issues/33908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] mypy errors - Argument 1 has incompatible type "XComArg" [airflow]

2024-07-30 Thread via GitHub
potiuk commented on issue #39514: URL: https://github.com/apache/airflow/issues/39514#issuecomment-2259009056 Yeah. Duplicate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Run all tests with minimum versions of our dependencies [airflow]

2024-07-30 Thread via GitHub
potiuk closed issue #34296: Run all tests with minimum versions of our dependencies URL: https://github.com/apache/airflow/issues/34296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Add legend to grid view [airflow]

2024-07-30 Thread via GitHub
bbovenzi commented on issue #28737: URL: https://github.com/apache/airflow/issues/28737#issuecomment-2258985345 No, definitely not in every single dag run tooltip. Once a user learns the icons, they don't need to be reminded every single time. But maybe we should add those icons to th

Re: [PR] Show dataset aliases in dependency graphs [airflow]

2024-07-30 Thread via GitHub
bbovenzi commented on PR #41128: URL: https://github.com/apache/airflow/pull/41128#issuecomment-2258980033 cc: @uranusjr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Show dataset aliases in dependency graphs [airflow]

2024-07-30 Thread via GitHub
bbovenzi opened a new pull request, #41128: URL: https://github.com/apache/airflow/pull/41128 Add Dataset Alias to the legend of each cross-dag dependency graph with a corresponded icon/color. https://github.com/user-attachments/assets/80386304-40bb-4e0d-88e0-3ad7188d4f81";> https:

(airflow) branch main updated: Improve detection of the airflow code vs. test code in db isolation (#41127)

2024-07-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4e70337baa Improve detection of the airflow code vs

Re: [PR] Improve detection of the airflow code vs. test code in db isolation [airflow]

2024-07-30 Thread via GitHub
potiuk merged PR #41127: URL: https://github.com/apache/airflow/pull/41127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] Downstream sensors button [airflow]

2024-07-30 Thread via GitHub
bbovenzi commented on issue #39939: URL: https://github.com/apache/airflow/issues/39939#issuecomment-2258956878 We did a bit to show datasets connected upstream and downstream of a DAG on the DAG page. It's not a bad idea to include all types of dependencies like sensors and triggers. --

Re: [I] allow setting a default view for the run [airflow]

2024-07-30 Thread via GitHub
bbovenzi commented on issue #39125: URL: https://github.com/apache/airflow/issues/39125#issuecomment-2258940684 We could create a task_instance_default_view or just make logs the default for all users. I've wanted to refactor how the tabs work anyway since it changes a lot depending on if a

Re: [I] The graph should show the median task duration [airflow]

2024-07-30 Thread via GitHub
bbovenzi commented on issue #39937: URL: https://github.com/apache/airflow/issues/39937#issuecomment-2258935808 We show this in the Task Duration tab. And we just expanded the taks duration tab to see across all runs/tasks. What's the use case here? To see how far off the task durati

Re: [I] Display TaskGroup types in Graph view legends [airflow]

2024-07-30 Thread via GitHub
bbovenzi closed issue #21870: Display TaskGroup types in Graph view legends URL: https://github.com/apache/airflow/issues/21870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Display TaskGroup types in Graph view legends [airflow]

2024-07-30 Thread via GitHub
bbovenzi commented on issue #21870: URL: https://github.com/apache/airflow/issues/21870#issuecomment-2258929187 We've changed the graph view quite a lot since this was opened. TaskGroups now have a lot more visual separation from regular tasks -- This is an automated message from the Apac

Re: [PR] Implement AND logic checkbox for filtering DAGs [airflow]

2024-07-30 Thread via GitHub
bbovenzi commented on PR #39564: URL: https://github.com/apache/airflow/pull/39564#issuecomment-2258923747 UX-wise. I think it would be best to add the AND/OR toggle as a sticky div inside of the tag selection dropdown. Tagged onto the top or the bottom. Sort of like how we keep some timezo

Re: [PR] Added Feature: search dags by task id with suggestions [airflow]

2024-07-30 Thread via GitHub
bbovenzi commented on PR #37436: URL: https://github.com/apache/airflow/pull/37436#issuecomment-2258917527 Looking better! I think we should add an info tooltip telling users the new keywords search. -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] Improve detection of the airflow code vs. test code in db isolation [airflow]

2024-07-30 Thread via GitHub
potiuk opened a new pull request, #41127: URL: https://github.com/apache/airflow/pull/41127 The current code has been only checking when the session is created in tests - to see if the aiflow code is not using the session, However, Sometimes when session is created in the tests and passed t

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-07-30 Thread via GitHub
vincbeck commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2258893652 > OK. The tests are not hanging any more - and I added semi-automated way of retrieving the list of remaining test and will keep on refreshing it. Weird, `tests/datasets/test_dat

(airflow) branch main updated: Do not attempt to refresh task instance in session for DB isolation (#41117)

2024-07-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 24426f38b9 Do not attempt to refresh task instance

Re: [PR] Do not attempt to refresh task instance in session for DB isolation [airflow]

2024-07-30 Thread via GitHub
potiuk merged PR #41117: URL: https://github.com/apache/airflow/pull/41117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Build documentation in canary runs using ASF self-hosted AMD runners (#41057)

2024-07-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a3d3479bb9 Build documentation in canary runs using

Re: [PR] Build documentation in canary runs using ASF self-hosted AMD runners [airflow]

2024-07-30 Thread via GitHub
potiuk merged PR #41057: URL: https://github.com/apache/airflow/pull/41057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

  1   2   >