Re: [PR] Change default DAG schedule to None [airflow]

2024-08-11 Thread via GitHub
uranusjr commented on PR #41321: URL: https://github.com/apache/airflow/pull/41321#issuecomment-2283227079 Alternative PR posted https://github.com/apache/airflow/pull/41397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix dep status check, add condition to check if last dagrun is still running [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #40963: URL: https://github.com/apache/airflow/pull/40963#issuecomment-2283227035 As a general advice - adding a unit test that fails befofe and works after the change is a good way to explain what the change is about and make it easier to review. -- This is an au

(airflow) branch constraints-2-10 updated: Updating constraints. Github run id:10343459586

2024-08-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-10 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-10 by this push: new 115fff7c20 Updating con

(airflow) branch main updated: Simpler task retrieval for taskinstance test (#41389)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f25adf14ad Simpler task retrieval for taskinstance

Re: [PR] Simpler task retrieval for taskinstance test [airflow]

2024-08-11 Thread via GitHub
potiuk merged PR #41389: URL: https://github.com/apache/airflow/pull/41389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Deprecate implicit DAG schedule [airflow]

2024-08-11 Thread via GitHub
uranusjr commented on PR #41321: URL: https://github.com/apache/airflow/pull/41321#issuecomment-2283178774 I’m going to do this another way to not break the tests for now. We still need to eventually fix all the tests when we migrate to 3.0, but it’ll buy us some time. -- This is an auto

Re: [I] Add a CoalesceOperator to Airflow Providers [airflow]

2024-08-11 Thread via GitHub
eladkal commented on issue #41339: URL: https://github.com/apache/airflow/issues/41339#issuecomment-2283168079 First step is to start a discussion in the mailing list with your proposal. If this is not clear from the guide then please feel free to improve it -- This is an automated messag

Re: [PR] Replaced bootstrap-typeahead with jquery-ui [airflow]

2024-08-11 Thread via GitHub
sai-ganesh-03 commented on code in PR #40744: URL: https://github.com/apache/airflow/pull/40744#discussion_r1713198275 ## airflow/www/static/css/main.css: ## @@ -288,10 +288,20 @@ label[for="timezone-other"], font-weight: normal; } +#timezone-menu { + overflow-x: hidden;

[PR] Bump minimum Airflow version in providers to Airflow 2.8.0 [airflow]

2024-08-11 Thread via GitHub
eladkal opened a new pull request, #41396: URL: https://github.com/apache/airflow/pull/41396 Note: the changelog entry about version bump will be updated during release time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(airflow) branch main updated: reorder docstring of `SparkKubernetesOperator` (#41372)

2024-08-11 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2b1ae5f811 reorder docstring of `SparkKubernetesOp

Re: [PR] spark kubernetes operator arguments description reordering [airflow]

2024-08-11 Thread via GitHub
eladkal merged PR #41372: URL: https://github.com/apache/airflow/pull/41372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] [WIP] Add blog post for 2.10.0 [airflow-site]

2024-08-11 Thread via GitHub
vatsrahul1001 commented on PR #1052: URL: https://github.com/apache/airflow-site/pull/1052#issuecomment-2283134514 Missing DAG parsing button in UI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] Improve Airflow's debugging story [airflow]

2024-08-11 Thread via GitHub
Dev-iL commented on issue #40975: URL: https://github.com/apache/airflow/issues/40975#issuecomment-2283110227 @omkar-foss don't suggest - decide. I, too, think questions should be mostly optional. As for the contents of the survey - I don't believe it's ready. It currently has questions ask

Re: [I] Improve Airflow's debugging story [airflow]

2024-08-11 Thread via GitHub
omkar-foss commented on issue #40975: URL: https://github.com/apache/airflow/issues/40975#issuecomment-2283026141 >I've made a [google doc](https://docs.google.com/document/d/1QcQaejbBgpHzAjLHyx9KNG1d1JKdYkWjhrR6XzZ_0tE/edit?usp=sharing) so we can start hashing out this survey collaborative

(airflow) branch main updated: Remove deprecated ``TaskMixin`` class (#41394)

2024-08-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 61a181fd59 Remove deprecated ``TaskMixin`` class

Re: [PR] Remove deprecated ``TaskMixin`` class [airflow]

2024-08-11 Thread via GitHub
kaxil merged PR #41394: URL: https://github.com/apache/airflow/pull/41394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

Re: [PR] Fix dep status check, add condition to check if last dagrun is still running [airflow]

2024-08-11 Thread via GitHub
omkar-foss commented on PR #40963: URL: https://github.com/apache/airflow/pull/40963#issuecomment-2283007496 > I suggest you do not call maintiners by name - that limits your options of getting others to review it My apologies, I'll keep this in mind going forward. I had tagged you he

Re: [PR] Remove deprecated ``TaskMixin`` class [airflow]

2024-08-11 Thread via GitHub
kaxil commented on PR #41394: URL: https://github.com/apache/airflow/pull/41394#issuecomment-2282993695 > If TaskMixin is removed, should we update the comments in > > https://github.com/apache/airflow/blob/aa047d7b46c2a466b7c981f34e690347e5aa3ff1/airflow/models/xcom_arg.py#L138 >

Re: [PR] Retain the function "resource_name_for_dag" for backwards compatibility [airflow]

2024-08-11 Thread via GitHub
joaopamaral commented on PR #41382: URL: https://github.com/apache/airflow/pull/41382#issuecomment-2282990623 Thanks @ephraimbuddy!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Remove deprecated `ExternalTaskSensorLink` [airflow]

2024-08-11 Thread via GitHub
kaxil merged PR #41391: URL: https://github.com/apache/airflow/pull/41391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

(airflow) branch main updated: Remove deprecated `ExternalTaskSensorLink` (#41391)

2024-08-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 61928bc454 Remove deprecated `ExternalTaskSensor

Re: [PR] Remove deprecated param in `DayOfWeekSensor` [airflow]

2024-08-11 Thread via GitHub
kaxil merged PR #41393: URL: https://github.com/apache/airflow/pull/41393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

(airflow) branch main updated (b809ee1e8c -> aa047d7b46)

2024-08-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b809ee1e8c Remove deprecated ``ImportError`` from ``airflow.models`` (#41367) add aa047d7b46 Remove deprecated

[PR] Remove deprecations from `airflow.executors` & `airflow.utils` [airflow]

2024-08-11 Thread via GitHub
kaxil opened a new pull request, #41395: URL: https://github.com/apache/airflow/pull/41395 Remove deprecated features in preparation for Airflow 3.0 - Removed `UNPICKLEABLE_EXECUTORS` from `airflow.executors.executor_loader`. - Removed `test_cycle` function from `airflow.utils.dag_c

Re: [PR] bump ruff to 0.5.5 [airflow]

2024-08-11 Thread via GitHub
Lee-W commented on PR #41032: URL: https://github.com/apache/airflow/pull/41032#issuecomment-2282973641 If there's no major change we disagree, I think we would definitely want to upgrade to 0.5.7 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Remove deprecated ``ImportError`` from ``airflow.models`` [airflow]

2024-08-11 Thread via GitHub
kaxil merged PR #41367: URL: https://github.com/apache/airflow/pull/41367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

(airflow) branch main updated: Remove deprecated ``ImportError`` from ``airflow.models`` (#41367)

2024-08-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b809ee1e8c Remove deprecated ``ImportError`` fro

Re: [PR] Aip-59 Performance testing framework [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #41315: URL: https://github.com/apache/airflow/pull/41315#issuecomment-2282954955 Agree. Would be nice to separate out piece by piece and review them in smaller increments. Generally review time is at least n^2 -- This is an automated message from the Apache Git Se

Re: [PR] Fix dep status check, add condition to check if last dagrun is still running [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #40963: URL: https://github.com/apache/airflow/pull/40963#issuecomment-2282953872 I suggest you do not call maintiners by name - that limits your options of getting others to review it - I don't feel I have time to look at it, and I am not sure I know all consequences

[PR] Remove deprecated ``TaskMixin`` class [airflow]

2024-08-11 Thread via GitHub
kaxil opened a new pull request, #41394: URL: https://github.com/apache/airflow/pull/41394 The ``airflow.models.taskMixin.TaskMixin`` class has been removed. It was previously deprecated in favor of the ``airflow.models.taskMixin.DependencyMixin`` class. -

Re: [I] Hash Virtual Environment Cache Based on Actual Package Versions in `PythonVirtualEnvOperator` [airflow]

2024-08-11 Thread via GitHub
potiuk commented on issue #41328: URL: https://github.com/apache/airflow/issues/41328#issuecomment-2282951794 You can't do it. You do not know what versions will be installed before you install it, at which point calculating hash is already too late - because you already installed the venv.

Re: [I] Hash Virtual Environment Cache Based on Actual Package Versions in `PythonVirtualEnvOperator` [airflow]

2024-08-11 Thread via GitHub
potiuk closed issue #41328: Hash Virtual Environment Cache Based on Actual Package Versions in `PythonVirtualEnvOperator` URL: https://github.com/apache/airflow/issues/41328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(airflow) branch main updated: Add methodtools as dependency to mssql provider (#41392)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4fd77ecfd9 Add methodtools as dependency to mssql p

Re: [I] Missing dependency `methodtools` when using `microsoft-mssql==3.8.0` with `airflow==2.7.3` [airflow]

2024-08-11 Thread via GitHub
potiuk closed issue #41330: Missing dependency `methodtools` when using `microsoft-mssql==3.8.0` with `airflow==2.7.3` URL: https://github.com/apache/airflow/issues/41330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Add methodtools as dependency to mssql provider [airflow]

2024-08-11 Thread via GitHub
potiuk merged PR #41392: URL: https://github.com/apache/airflow/pull/41392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] Missing dependency `methodtools` when using `microsoft-mssql==3.8.0` with `airflow==2.7.3` [airflow]

2024-08-11 Thread via GitHub
potiuk closed issue #41330: Missing dependency `methodtools` when using `microsoft-mssql==3.8.0` with `airflow==2.7.3` URL: https://github.com/apache/airflow/issues/41330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] Remove deprecated param in `DayOfWeekSensor` [airflow]

2024-08-11 Thread via GitHub
kaxil opened a new pull request, #41393: URL: https://github.com/apache/airflow/pull/41393 The `use_task_execution_day` param is deprecated --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airfl

(airflow) branch main updated: Limit parallelism for constraints generation in CI (#41383)

2024-08-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fffd41e9d9 Limit parallelism for constraints gen

Re: [PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
kaxil merged PR #41383: URL: https://github.com/apache/airflow/pull/41383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

[PR] Add methodtools as dependency to mssql provider [airflow]

2024-08-11 Thread via GitHub
potiuk opened a new pull request, #41392: URL: https://github.com/apache/airflow/pull/41392 Fixes: #41330 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_

Re: [I] Missing dependency `methodtools` when using `microsoft-mssql==3.8.0` with `airflow==2.7.3` [airflow]

2024-08-11 Thread via GitHub
potiuk commented on issue #41330: URL: https://github.com/apache/airflow/issues/41330#issuecomment-2282939001 Indeed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Remove deprecated `ExternalTaskSensorLink` [airflow]

2024-08-11 Thread via GitHub
kaxil commented on PR #41391: URL: https://github.com/apache/airflow/pull/41391#issuecomment-2282938360 @uranusjr / @Lee-W -- These are the kind of things I think we can easily automate for users since those are just import changes -- This is an automated message from the Apache Git Serv

[PR] Remove deprecated `ExternalTaskSensorLink` [airflow]

2024-08-11 Thread via GitHub
kaxil opened a new pull request, #41391: URL: https://github.com/apache/airflow/pull/41391 It is replaced by `airflow.sensors.external_task.ExternalDagLink` --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github

Re: [PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #41383: URL: https://github.com/apache/airflow/pull/41383#issuecomment-2282930542 Looks like it works and should bring back main to be `green` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Remove deprecated SubDags [airflow]

2024-08-11 Thread via GitHub
kaxil commented on code in PR #41390: URL: https://github.com/apache/airflow/pull/41390#discussion_r1713082551 ## airflow/providers/fab/auth_manager/security_manager/override.py: ## @@ -1073,15 +1073,15 @@ def create_dag_specific_permissions(self) -> None: dags = dagbag

Re: [PR] Remove deprecated SubDags [airflow]

2024-08-11 Thread via GitHub
kaxil commented on code in PR #41390: URL: https://github.com/apache/airflow/pull/41390#discussion_r1713082430 ## airflow/providers/google/cloud/hooks/dataplex.py: ## @@ -279,14 +279,7 @@ def get_task( """ name = f"projects/{project_id}/locations/{region}/lake

[PR] Remove deprecated SubDags [airflow]

2024-08-11 Thread via GitHub
kaxil opened a new pull request, #41390: URL: https://github.com/apache/airflow/pull/41390 This PR removes SubDags in favor of TaskGroups fro Airflow 3.0 Subdags have been removed from the following locations: - CLI - API - ``SubDagOperator`` This removal marks the

(airflow) branch v2-10-test updated (6c6797c5d9 -> 8ea4eb1ce0)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git from 6c6797c5d9 Fix mypy checks for new azure libraries (#41386) add 8ea4eb1ce0 Fix tests/decorators/test_python

(airflow) branch main updated: Fix tests/decorators/test_python.py for database isolation tests (#41387)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 278f3c4b6e Fix tests/decorators/test_python.py for

Re: [PR] Fix tests/decorators/test_python.py for database isolation tests [airflow]

2024-08-11 Thread via GitHub
potiuk merged PR #41387: URL: https://github.com/apache/airflow/pull/41387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Simpler task retrieval for taskinstance test [airflow]

2024-08-11 Thread via GitHub
potiuk opened a new pull request, #41389: URL: https://github.com/apache/airflow/pull/41389 The test has been updated for DB isolation but the retrieval of task was not intuitive and it could lead to flaky tests possibly --- **^ Add meaningful descriptio

Re: [I] Airflow task takes success status if driver was deleted [airflow]

2024-08-11 Thread via GitHub
bugraoz93 commented on issue #41212: URL: https://github.com/apache/airflow/issues/41212#issuecomment-2282913006 I haven't had the chance to check this yet, but I plan to do so in the next few days. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Fix tests/decorators/test_python.py for database isolation tests [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #41387: URL: https://github.com/apache/airflow/pull/41387#issuecomment-2282907095 Some tests are failing - same as in the #41067 PR :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

(airflow) 01/02: Skip docs publishing on non-main brnaches (#41385)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 09567dcc61d89c4247610ec63d0414dfade5d368 Author: Jarek Potiuk AuthorDate: Sun Aug 11 23:20:39 2024 +0200 Skip

(airflow) 02/02: Fix mypy checks for new azure libraries (#41386)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 6c6797c5d9ab173d2860cf628543b866fa5873a5 Author: Jarek Potiuk AuthorDate: Sun Aug 11 23:36:18 2024 +0200 Fix m

(airflow) branch v2-10-test updated (34e2c9c694 -> 6c6797c5d9)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git from 34e2c9c694 bump uv version to 0.2.34 (#41334) new 09567dcc61 Skip docs publishing on non-main brnaches (#413

[I] Setup Github Runners via Kubernetes Controller on our AWS instance [airflow]

2024-08-11 Thread via GitHub
potiuk opened a new issue, #41388: URL: https://github.com/apache/airflow/issues/41388 ### Body We should set-up the https://github.com/actions/actions-runner-controller on Airflow AWS instance - so that it can speed up our builds and allow for ARM builds to be prepared. Curre

[PR] Fix tests/decorators/test_python.py for database isolation tests [airflow]

2024-08-11 Thread via GitHub
bugraoz93 opened a new pull request, #41387: URL: https://github.com/apache/airflow/pull/41387 Related: https://github.com/apache/airflow/pull/41067 Fixes `tests/decorators/test_python.py` for database isolation. Passing `serialized` parameter to dag_maker ---

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-08-11 Thread via GitHub
bugraoz93 commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2282899130 `tests/decorators/test_python.py` seems like an easy one. Creating the PR shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
potiuk closed pull request #41383: Limit parallelism for constraints generation in CI URL: https://github.com/apache/airflow/pull/41383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Fix mypy checks for new azure libraries [airflow]

2024-08-11 Thread via GitHub
potiuk merged PR #41386: URL: https://github.com/apache/airflow/pull/41386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Fix mypy checks for new azure libraries (#41386)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 68a6a0583b Fix mypy checks for new azure libraries

(airflow) branch main updated: Skip docs publishing on non-main brnaches (#41385)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 54c165cee0 Skip docs publishing on non-main brnache

Re: [PR] Skip docs publishing on non-main branches [airflow]

2024-08-11 Thread via GitHub
potiuk merged PR #41385: URL: https://github.com/apache/airflow/pull/41385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Fix mypy checks for new azure libraries [airflow]

2024-08-11 Thread via GitHub
potiuk opened a new pull request, #41386: URL: https://github.com/apache/airflow/pull/41386 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

[PR] Skip docs publishing on non-main brnaches [airflow]

2024-08-11 Thread via GitHub
potiuk opened a new pull request, #41385: URL: https://github.com/apache/airflow/pull/41385 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

Re: [PR] Skip docs publishing on non-main brnaches [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #41385: URL: https://github.com/apache/airflow/pull/41385#issuecomment-2282891135 Better fix for the temporary one added to v2-10-test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
potiuk commented on code in PR #41383: URL: https://github.com/apache/airflow/pull/41383#discussion_r1713058801 ## airflow/providers/microsoft/azure/hooks/wasb.py: ## @@ -213,7 +213,7 @@ def get_conn(self) -> BlobServiceClient: **extra, ) -def _get_co

Re: [PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
potiuk commented on code in PR #41383: URL: https://github.com/apache/airflow/pull/41383#discussion_r1713058801 ## airflow/providers/microsoft/azure/hooks/wasb.py: ## @@ -213,7 +213,7 @@ def get_conn(self) -> BlobServiceClient: **extra, ) -def _get_co

(airflow) branch v2-10-test updated (4fce874b95 -> 34e2c9c694)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git from 4fce874b95 Update RELEASE_NOTES.rst add a7d48cb850 Fix tests/models/test_taskinstance.py for Database Isola

Re: [PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
potiuk commented on code in PR #41383: URL: https://github.com/apache/airflow/pull/41383#discussion_r1713053729 ## airflow/providers/microsoft/azure/hooks/wasb.py: ## @@ -213,7 +213,7 @@ def get_conn(self) -> BlobServiceClient: **extra, ) -def _get_co

Re: [PR] Fix k8s test: Try building base airflow image [airflow]

2024-08-11 Thread via GitHub
utkarsharma2 closed pull request #41376: Fix k8s test: Try building base airflow image URL: https://github.com/apache/airflow/pull/41376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix k8s test: Try building base airflow image [airflow]

2024-08-11 Thread via GitHub
utkarsharma2 commented on PR #41376: URL: https://github.com/apache/airflow/pull/41376#issuecomment-2282880055 > Any reason why ? The base images are pulled in one of the previous steps and tagged as latest images, so rebuilding them should be unnecesary. Is there any problem it was going t

(airflow) branch v2-10-test updated (51988844bc -> 4fce874b95)

2024-08-11 Thread utkarsharma
This is an automated email from the ASF dual-hosted git repository. utkarsharma pushed a change to branch v2-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit 51988844bc Update RELEASE_NOTES.rst add 4fce874b95 Update RELEASE_NOTES.rst This update added new revi

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-08-11 Thread via GitHub
jscheffl commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2282878751 I fix the follow-up of test_variable.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Generalize caching of connection in DbApiHook to improve performance [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #40751: URL: https://github.com/apache/airflow/pull/40751#issuecomment-2282874511 But compatibiliity tests are "real" - i.e. when the "main" provider tests are run against "2.7, 2.8, 2.9" - they fail because of the change in connection ids available. I suggest to chec

Re: [PR] Generalize caching of connection in DbApiHook to improve performance [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #40751: URL: https://github.com/apache/airflow/pull/40751#issuecomment-2282873923 > @eladkal Don't understand the error as we didn't modify that code: This is because your PR modifies dependencies (which is rare) - and apparently new dependencies are breaking M

Re: [I] `DbApiHook.insert_rows` unnecessarily restarting connections [airflow]

2024-08-11 Thread via GitHub
potiuk commented on issue #40609: URL: https://github.com/apache/airflow/issues/40609#issuecomment-2282872747 They look like real compatibility issues with Airflow 2.7 - 2.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
potiuk commented on code in PR #41383: URL: https://github.com/apache/airflow/pull/41383#discussion_r1713048621 ## airflow/providers/microsoft/azure/hooks/wasb.py: ## @@ -213,7 +213,7 @@ def get_conn(self) -> BlobServiceClient: **extra, ) -def _get_co

[PR] Better map_index and downstream/upstream tasks handling [airflow]

2024-08-11 Thread via GitHub
harjeevanmaan opened a new pull request, #41384: URL: https://github.com/apache/airflow/pull/41384 - Fixes "Clearing a Mapped Task (with Downstream included) clears all Downstream tasks instead of mapped downstream tasks #41278" - Fixes "control state of individual taskflow in mapped task

Re: [PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #41383: URL: https://github.com/apache/airflow/pull/41383#issuecomment-2282866994 Example error here (in main - likely will affect v2-10-test/stble as well): https://github.com/apache/airflow/actions/runs/10340160246/job/28620494570#step:10:5663 ```

[PR] Limit parallelism for constraints generation in CI [airflow]

2024-08-11 Thread via GitHub
potiuk opened a new pull request, #41383: URL: https://github.com/apache/airflow/pull/41383 Apparently constraints generation in 4 parallel docker containers causes "no space left on device" error for public runners. This one limits parallelism to 3 to limit disk usage

Re: [PR] Send context using in venv operator [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #41363: URL: https://github.com/apache/airflow/pull/41363#issuecomment-2282859662 Ah yes. This is because serialization uses Pydantic currently to serialize DB models that are part of the context and that requires Pydantic v2 to be installed. I'd say we should make th

Re: [PR] Microsoft Power BI operator to refresh the dataset [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #40356: URL: https://github.com/apache/airflow/pull/40356#issuecomment-2282857453 > Yea, I'm able to pass all the tests locally. But didn't understand why they are failing on CI. Are tests getting failed locally as well on your end? Might be those are side effec

Re: [PR] bump uv version to 0.2.34 [airflow]

2024-08-11 Thread via GitHub
potiuk merged PR #41334: URL: https://github.com/apache/airflow/pull/41334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2282855527 Rebased with latest changes to see where we are in main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

(airflow) branch main updated (60cbea5097 -> b4a92f802e)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 60cbea5097 Fix pytests for Core except Variable for DB Isolation Mode (#41375) add b4a92f802e bump uv version to

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-08-11 Thread via GitHub
potiuk closed pull request #41067: Remove Database Isolation feature flag and run DB isolation tests URL: https://github.com/apache/airflow/pull/41067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Deprecate implicit DAG schedule [airflow]

2024-08-11 Thread via GitHub
kaxil commented on PR #41321: URL: https://github.com/apache/airflow/pull/41321#issuecomment-2282852128 @uranusjr @ephraimbuddy - Do we need to get this for 2.10.0rc1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Fix k8s test: Try building base airflow image [airflow]

2024-08-11 Thread via GitHub
potiuk commented on PR #41376: URL: https://github.com/apache/airflow/pull/41376#issuecomment-2282841814 Any reason why ? The base images are pulled in one of the previous steps and tagged as latest images, so rebuilding them should be unnecesary. Is there any problem it was going to solve

(airflow) branch main updated: Fix pytests for Core except Variable for DB Isolation Mode (#41375)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 60cbea5097 Fix pytests for Core except Variable for

Re: [PR] Fix pytests for Core except Variable for DB Isolation Mode [airflow]

2024-08-11 Thread via GitHub
potiuk merged PR #41375: URL: https://github.com/apache/airflow/pull/41375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Fix Variable and KubernetesJobOperator Tests for Database Isolation Tests [airflow]

2024-08-11 Thread via GitHub
potiuk merged PR #41370: URL: https://github.com/apache/airflow/pull/41370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Fix Variable and KubernetesJobOperator Tests for Database Isolation Tests (#41370)

2024-08-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c98d1a177b Fix Variable and KubernetesJobOperator T

Re: [I] Provide access privilege required for `cncf.kubernetes` operators/executors [airflow]

2024-08-11 Thread via GitHub
topherinternational commented on issue #40210: URL: https://github.com/apache/airflow/issues/40210#issuecomment-2282802475 @pykenny A good start might be the k8s permissions in the Helm chart, e.g. https://github.com/apache/airflow/blob/providers-cncf-kubernetes/8.3.4/chart/templates/rbac/po

Re: [PR] Draft: Fix Models Trigger Tests for Database Isolation Tests [airflow]

2024-08-11 Thread via GitHub
bugraoz93 closed pull request #41338: Draft: Fix Models Trigger Tests for Database Isolation Tests URL: https://github.com/apache/airflow/pull/41338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

(airflow) branch v2-10-test updated (1951051369 -> 51988844bc)

2024-08-11 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit 1951051369 Just test omit 527bcaf432 Update RELEASE_NOTES.rst omit 50889faa2c Update version to

Re: [PR] Revert "Feature: Allow set Dag Run resource into Dag Level permission (#40703)" [airflow]

2024-08-11 Thread via GitHub
ephraimbuddy closed pull request #41379: Revert "Feature: Allow set Dag Run resource into Dag Level permission (#40703)" URL: https://github.com/apache/airflow/pull/41379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

(airflow) branch main updated (ed13bd6543 -> 0576f557f1)

2024-08-11 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ed13bd6543 Remove `contrib` (#41366) add 0576f557f1 Retain the function "resource_name_for_dag" for backw

Re: [PR] Retain the function "resource_name_for_dag" for backwards compatibility [airflow]

2024-08-11 Thread via GitHub
ephraimbuddy merged PR #41382: URL: https://github.com/apache/airflow/pull/41382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

  1   2   >