Re: [PR] Deprecate implicit default DAG schedule [airflow]

2024-08-13 Thread via GitHub
eladkal commented on PR #41321: URL: https://github.com/apache/airflow/pull/41321#issuecomment-2287957990 > > A backport to the 2.10 branch is needed. > > According to the new rules it's on the committer who merges it to backport it and create a new PR if I read them right. I r

[PR] Add Airflow 3 development readme [airflow]

2024-08-13 Thread via GitHub
eladkal opened a new pull request, #41457: URL: https://github.com/apache/airflow/pull/41457 Lets have a doc that list the protocols we accepted for development of Airflow 3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fetch history dataset events based on DDRQ instead of the previous Dag Run [airflow]

2024-08-13 Thread via GitHub
Lee-W commented on PR #41427: URL: https://github.com/apache/airflow/pull/41427#issuecomment-2287944972 > > I thought of it but I would > > Is this sentence unfinished? I've reworded it and didn't remove this sentence. Just updated it. Thanks! -- This is an automated message

Re: [PR] Introduce DAG SLA [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on PR #36639: URL: https://github.com/apache/airflow/pull/36639#issuecomment-2287944474 The `run_after` value in `DagRunInfo` is probably the best for this purpose, but I’m not sure if it is available in this context. -- This is an automated message from the Apache Git

Re: [PR] 📧 Add email decorator [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on PR #41076: URL: https://github.com/apache/airflow/pull/41076#issuecomment-2287938368 Can you add an example DAG for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(airflow) branch main updated: Rephrase max_tis_per_query config docs (#41448)

2024-08-13 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fcc9f3dc0e Rephrase max_tis_per_query config docs

Re: [PR] rephrase max_tis_per_query config docs [airflow]

2024-08-13 Thread via GitHub
uranusjr merged PR #41448: URL: https://github.com/apache/airflow/pull/41448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] fix: The remote task tracked by the trigger failed due to the reassignment of the trigger task [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41232: URL: https://github.com/apache/airflow/pull/41232#discussion_r1716332040 ## airflow/jobs/triggerer_job_runner.py: ## @@ -751,3 +757,28 @@ def get_trigger_by_classpath(self, classpath: str) -> type[BaseTrigger]: if classpath not

Re: [PR] fix: The remote task tracked by the trigger failed due to the reassignment of the trigger task [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41232: URL: https://github.com/apache/airflow/pull/41232#discussion_r1716331102 ## airflow/jobs/triggerer_job_runner.py: ## @@ -643,7 +647,9 @@ async def run_trigger(self, trigger_id, trigger): # allow triggers a chance to cleanup,

Re: [PR] fix: The remote task tracked by the trigger failed due to the reassignment of the trigger task [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41232: URL: https://github.com/apache/airflow/pull/41232#discussion_r1716328637 ## airflow/jobs/triggerer_job_runner.py: ## @@ -538,10 +539,13 @@ async def cancel_triggers(self): This allows the cleanup job to delete them. """

Re: [PR] fix: The remote task tracked by the trigger failed due to the reassignment of the trigger task [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41232: URL: https://github.com/apache/airflow/pull/41232#discussion_r1716328140 ## airflow/jobs/triggerer_job_runner.py: ## @@ -538,10 +539,13 @@ async def cancel_triggers(self): This allows the cleanup job to delete them. """

Re: [PR] Fetch history dataset events based on DDRQ instead of the previous Dag Run [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on PR #41427: URL: https://github.com/apache/airflow/pull/41427#issuecomment-2287881763 > I thought of it but I would Is this sentence unfinished? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] Update Airflow version to `3.0.0.dev0` [airflow]

2024-08-13 Thread via GitHub
jedcunningham opened a new pull request, #41456: URL: https://github.com/apache/airflow/pull/41456 Main is now Airflow 3! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Is it possible to avoid a running dag run that would be affected if the dag file is changed? [airflow]

2024-08-13 Thread via GitHub
shawn-ann commented on issue #41452: URL: https://github.com/apache/airflow/issues/41452#issuecomment-2287867778 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Microsoft Power BI operator to refresh the dataset [airflow]

2024-08-13 Thread via GitHub
ambika-garg commented on PR #40356: URL: https://github.com/apache/airflow/pull/40356#issuecomment-2287824542 Hey @potiuk & @dabla, I've reviewed and updated the code to the best of my ability. It looks good to me now, and I believe there are no remaining issues. -- This is an automate

Re: [PR] [WIP] Add blog post for 2.10.0 [airflow-site]

2024-08-13 Thread via GitHub
howardyoo commented on PR #1052: URL: https://github.com/apache/airflow-site/pull/1052#issuecomment-2287756616 Hi Jarek, yes we should!! Howard On Tue, Aug 13, 2024 at 6:25 PM Jarek Potiuk ***@***.***> wrote: > ***@***. commented on this pull request. > -

[I] Airflow DAG Pod stuck in NotReady state [airflow]

2024-08-13 Thread via GitHub
Ajit-mycom opened a new issue, #41455: URL: https://github.com/apache/airflow/issues/41455 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.8.1 ### What happened? When I trigger

Re: [I] Airflow Clusterrole and ClusterroleBinding for Sparkapplications [airflow]

2024-08-13 Thread via GitHub
boring-cyborg[bot] commented on issue #41454: URL: https://github.com/apache/airflow/issues/41454#issuecomment-2287728764 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Airflow Clusterrole and ClusterroleBinding for Sparkapplications [airflow]

2024-08-13 Thread via GitHub
Ajit-mycom opened a new issue, #41454: URL: https://github.com/apache/airflow/issues/41454 ### Official Helm Chart version 1.13.1 ### Apache Airflow version 2.8.1 ### Kubernetes Version 1.29 ### Helm Chart configuration _No response_ ###

Re: [PR] Fetch history dataset events based on DDRQ instead of the previous Dag Run [airflow]

2024-08-13 Thread via GitHub
Lee-W commented on PR #41427: URL: https://github.com/apache/airflow/pull/41427#issuecomment-2287711473 > The timestamp-based filtering is hard to reason about and, sorta imprecise. Maybe we should take this opportunity to explore using parent-child relationships that don't rely on timestam

Re: [PR] feat(assets): rename airflow.datasets as airflow.assets [airflow]

2024-08-13 Thread via GitHub
Lee-W commented on code in PR #41348: URL: https://github.com/apache/airflow/pull/41348#discussion_r1716203926 ## airflow/providers/amazon/aws/datasets/s3.py: ## Review Comment: Yes, it's indeed something missed. Thanks for reminding me. Will do it today -- This is an a

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on PR #41443: URL: https://github.com/apache/airflow/pull/41443#issuecomment-2287674120 I’m going to have this in main first and worry about improvements (might not be that much needed anyway) later. -- This is an automated message from the Apache Git Service. To respon

(airflow) branch main updated: Check breaking changes have a news fragment (#41443)

2024-08-13 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 509f15eab1 Check breaking changes have a news fra

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr merged PR #41443: URL: https://github.com/apache/airflow/pull/41443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1716201942 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Export Azure Container Instance log messages to XCOM [airflow]

2024-08-13 Thread via GitHub
perry2of5 commented on PR #41142: URL: https://github.com/apache/airflow/pull/41142#issuecomment-2287669521 I believe I have fixed the issues from my code (currently re-running breeze static-checks), but when I run "breeze static-checks --all-files" it complains about a file I didn't change

[PR] Remove schedule_interval and timetable DAG args [airflow]

2024-08-13 Thread via GitHub
uranusjr opened a new pull request, #41453: URL: https://github.com/apache/airflow/pull/41453 The 'timetable' attribute still exists on DAG, and is now the only value that reflects the DAG's schedule. The 'schedule_interval' attribute is removed from DAG. The 'schedule_interval' on D

Re: [PR] KubernetesHook kube_config extra can take dict [airflow]

2024-08-13 Thread via GitHub
jedcunningham commented on code in PR #41413: URL: https://github.com/apache/airflow/pull/41413#discussion_r1716186556 ## tests/providers/cncf/kubernetes/hooks/test_kubernetes.py: ## @@ -53,7 +53,8 @@ POLL_INTERVAL = 100 -class DeprecationRemovalRequired(AirflowException):

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-08-13 Thread via GitHub
potiuk commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2287653130 I think this one is likely to have only two remaining issues - I fixed the "regular" failures - by excluding serialization for the tests that failed with it in "decorator/test_python"

Re: [PR] Support template hostname in NOTES.txt [airflow]

2024-08-13 Thread via GitHub
jedcunningham merged PR #41423: URL: https://github.com/apache/airflow/pull/41423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

(airflow) branch main updated (6edeba7391 -> 8653988012)

2024-08-13 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 6edeba7391 Remove support for deprecated imports like operators/hooks/sensors (#41368) add 8653988012 Supp

Re: [I] Is it possible to avoid a running dag run that would be affected if the dag file is changed? [airflow]

2024-08-13 Thread via GitHub
potiuk closed issue #41452: Is it possible to avoid a running dag run that would be affected if the dag file is changed? URL: https://github.com/apache/airflow/issues/41452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Is it possible to avoid a running dag run that would be affected if the dag file is changed? [airflow]

2024-08-13 Thread via GitHub
potiuk commented on issue #41452: URL: https://github.com/apache/airflow/issues/41452#issuecomment-2287619005 Patiently wait until someone will respond there (and for sure few hours for respeons is not patient - taking into account this forum where volunteers are helping others in their fre

Re: [I] Is it possible to avoid a running dag run that would be affected if the dag file is changed? [airflow]

2024-08-13 Thread via GitHub
potiuk commented on issue #41452: URL: https://github.com/apache/airflow/issues/41452#issuecomment-2287611369 Please do not open issues for discussions - especially if you already opened one -- This is an automated message from the Apache Git Service. To respond to the message, please

(airflow) branch main updated (1fcbde2e32 -> 6edeba7391)

2024-08-13 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 1fcbde2e32 Remove deprecated and unused methods / properties on DAG (#41440) add 6edeba7391 Remove support

Re: [PR] Remove support for deprecated imports like operators/hooks/sensors [airflow]

2024-08-13 Thread via GitHub
jedcunningham merged PR #41368: URL: https://github.com/apache/airflow/pull/41368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [I] Is it possible to avoid a running dag run that would be affected if the dag file is changed? [airflow]

2024-08-13 Thread via GitHub
boring-cyborg[bot] commented on issue #41452: URL: https://github.com/apache/airflow/issues/41452#issuecomment-2287592593 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Is it possible to avoid a running dag run that would be affected if the dag file is changed? [airflow]

2024-08-13 Thread via GitHub
shawn-ann opened a new issue, #41452: URL: https://github.com/apache/airflow/issues/41452 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.2.3 ### What happened? For running dag

(airflow) branch main updated: Remove deprecated and unused methods / properties on DAG (#41440)

2024-08-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1fcbde2e32 Remove deprecated and unused methods / p

Re: [PR] Remove deprecated and unused methods / properties on DAG [airflow]

2024-08-13 Thread via GitHub
potiuk merged PR #41440: URL: https://github.com/apache/airflow/pull/41440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
eakmanrq commented on PR #41374: URL: https://github.com/apache/airflow/pull/41374#issuecomment-2287568507 > Thanks @eakmanrq! Congrats on your first commit 🎉 > > So close to being the 3,000th contributor, but alas you are the 2,999th (still kinda cool imo). Wow congrats to you

(airflow) branch dependabot/npm_and_yarn/airflow/www/axios-1.7.4 created (now d4624e0c11)

2024-08-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/airflow/www/axios-1.7.4 in repository https://gitbox.apache.org/repos/asf/airflow.git at d4624e0c11 Bump axios from 1.6.1 to 1.7.4 in /airflow/www No new revis

Re: [PR] Temporarily disable doc publishing waiting for ASF self-hosted runners [airflow]

2024-08-13 Thread via GitHub
jedcunningham commented on code in PR #41449: URL: https://github.com/apache/airflow/pull/41449#discussion_r1716163541 ## .github/workflows/static-checks-mypy-docs.yml: ## @@ -243,7 +243,9 @@ jobs: INCLUDE_SUCCESS_OUTPUTS: "${{ inputs.include-success-outputs }}" PY

[PR] Bump axios from 1.6.1 to 1.7.4 in /airflow/www [airflow]

2024-08-13 Thread via GitHub
dependabot[bot] opened a new pull request, #41451: URL: https://github.com/apache/airflow/pull/41451 Bumps [axios](https://github.com/axios/axios) from 1.6.1 to 1.7.4. Release notes Sourced from https://github.com/axios/axios/releases";>axios's releases. Release v1.7.4 Rel

Re: [PR] Temporarily disable doc publishing waiting for ASF self-hosted runners [airflow]

2024-08-13 Thread via GitHub
potiuk merged PR #41449: URL: https://github.com/apache/airflow/pull/41449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Temporarily disable doc publishing waiting for ASF self-hosted runners [airflow]

2024-08-13 Thread via GitHub
potiuk commented on code in PR #41449: URL: https://github.com/apache/airflow/pull/41449#discussion_r1716162898 ## .github/workflows/static-checks-mypy-docs.yml: ## @@ -243,7 +243,9 @@ jobs: INCLUDE_SUCCESS_OUTPUTS: "${{ inputs.include-success-outputs }}" PYTHON_MA

(airflow) branch main updated: Temporarily disable doc publishing waiting for ASF self-hosted runners (#41449)

2024-08-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9221bb5559 Temporarily disable doc publishing waiti

Re: [PR] Temporarily disable doc publishing waiting for ASF self-hosted runners [airflow]

2024-08-13 Thread via GitHub
potiuk commented on code in PR #41449: URL: https://github.com/apache/airflow/pull/41449#discussion_r1716162573 ## .github/workflows/static-checks-mypy-docs.yml: ## @@ -243,7 +243,9 @@ jobs: INCLUDE_SUCCESS_OUTPUTS: "${{ inputs.include-success-outputs }}" PYTHON_MA

Re: [PR] Temporarily disable doc publishing waiting for ASF self-hosted runners [airflow]

2024-08-13 Thread via GitHub
jedcunningham commented on code in PR #41449: URL: https://github.com/apache/airflow/pull/41449#discussion_r1716160995 ## .github/workflows/static-checks-mypy-docs.yml: ## @@ -243,7 +243,9 @@ jobs: INCLUDE_SUCCESS_OUTPUTS: "${{ inputs.include-success-outputs }}" PY

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
potiuk commented on PR #41374: URL: https://github.com/apache/airflow/pull/41374#issuecomment-2287553411 > So close to being the 3,000th contributor, but alas you are the 2,999th (still kinda cool imo). 👀👀👀 -- This is an automated message from the Apache Git Service. To re

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
jedcunningham commented on PR #41374: URL: https://github.com/apache/airflow/pull/41374#issuecomment-2287548124 Thanks @eakmanrq! Congrats on your first commit 🎉 So close to being the 3,000th contributor, but alas you are the 2,999th (still kinda cool imo). -- This is an automated

(airflow) branch main updated: Properly implement termination grace period seconds (#41374)

2024-08-13 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dbc068c7f9 Properly implement termination gr

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
jedcunningham merged PR #41374: URL: https://github.com/apache/airflow/pull/41374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
boring-cyborg[bot] commented on PR #41374: URL: https://github.com/apache/airflow/pull/41374#issuecomment-2287545418 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Field Deletion Warning when editing Connections [airflow]

2024-08-13 Thread via GitHub
lh5844 commented on PR #41144: URL: https://github.com/apache/airflow/pull/41144#issuecomment-2287529830 Thank you for your suggestion! It definitely made it more concise. With that, it should be ready to be merged! -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Export Azure Container Instance log messages to XCOM [airflow]

2024-08-13 Thread via GitHub
perry2of5 commented on PR #41142: URL: https://github.com/apache/airflow/pull/41142#issuecomment-2287479001 Thanks. I’ll look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

(airflow) branch main updated: Send context using in venv operator (#41363)

2024-08-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 645c3cddf9 Send context using in venv operator (#41

Re: [PR] Send context using in venv operator [airflow]

2024-08-13 Thread via GitHub
potiuk merged PR #41363: URL: https://github.com/apache/airflow/pull/41363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: ydb provider: add database to table name in bulk upsert, use bulk upsert in system test (#41303)

2024-08-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6e22364278 ydb provider: add database to table name

Re: [PR] ydb provider: add database to table name in bulk upsert, use bulk upsert in system test [airflow]

2024-08-13 Thread via GitHub
potiuk merged PR #41303: URL: https://github.com/apache/airflow/pull/41303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] update git-sync to 4.2.4 [airflow]

2024-08-13 Thread via GitHub
potiuk commented on PR #41411: URL: https://github.com/apache/airflow/pull/41411#issuecomment-2287459936 Needs to fix pre-commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Microsoft Power BI operator to refresh the dataset [airflow]

2024-08-13 Thread via GitHub
potiuk commented on PR #40356: URL: https://github.com/apache/airflow/pull/40356#issuecomment-2287456254 @dabla @ambika-garg -> any other remaining points? It looks good to me but maybe I missed someething -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Export Azure Container Instance log messages to XCOM [airflow]

2024-08-13 Thread via GitHub
potiuk commented on PR #41142: URL: https://github.com/apache/airflow/pull/41142#issuecomment-2287445773 static checks failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Add incremental export and cross account export functionality in `DynamoDBToS3Operator` [airflow]

2024-08-13 Thread via GitHub
Ghoul-SSZ commented on PR #41304: URL: https://github.com/apache/airflow/pull/41304#issuecomment-2287411949 I have ran and update the import so that the Static checks should pass. However, I have noticed that documentation build and spell checks have failed in the GitHub Action for c

Re: [PR] Issue-41243 Unpin the moto dependency [airflow]

2024-08-13 Thread via GitHub
boring-cyborg[bot] commented on PR #41256: URL: https://github.com/apache/airflow/pull/41256#issuecomment-2287410940 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [I] Moto 5.0.12 breaks amazon provider's RDS tests [airflow]

2024-08-13 Thread via GitHub
potiuk closed issue #41243: Moto 5.0.12 breaks amazon provider's RDS tests URL: https://github.com/apache/airflow/issues/41243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Issue-41243 Unpin the moto dependency [airflow]

2024-08-13 Thread via GitHub
potiuk merged PR #41256: URL: https://github.com/apache/airflow/pull/41256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (e94b508b94 -> fb378bdf2e)

2024-08-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from e94b508b94 Skipping tests for db isolation because similar tests were skipped (#41450) add fb378bdf2e Issue-41243

(airflow) branch main updated: Skipping tests for db isolation because similar tests were skipped (#41450)

2024-08-13 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e94b508b94 Skipping tests for db isolation because

Re: [PR] Fix tests/sensors/test_external_task_sensor.py for database isolation tests [airflow]

2024-08-13 Thread via GitHub
potiuk merged PR #41450: URL: https://github.com/apache/airflow/pull/41450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] ModuleNotFoundError: No module named 'methodtools' due to breaking changes made in a new release 3.8.0 of apache-airflow-providers-microsoft-mssql library [airflow]

2024-08-13 Thread via GitHub
potiuk closed issue #41446: ModuleNotFoundError: No module named 'methodtools' due to breaking changes made in a new release 3.8.0 of apache-airflow-providers-microsoft-mssql library URL: https://github.com/apache/airflow/issues/41446 -- This is an automated message from the Apache Git Servi

Re: [I] ModuleNotFoundError: No module named 'methodtools' due to breaking changes made in a new release 3.8.0 of apache-airflow-providers-microsoft-mssql library [airflow]

2024-08-13 Thread via GitHub
potiuk commented on issue #41446: URL: https://github.com/apache/airflow/issues/41446#issuecomment-2287400406 Already addressed in #41392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] full refacto sensors error management [airflow]

2024-08-13 Thread via GitHub
potiuk commented on PR #41047: URL: https://github.com/apache/airflow/pull/41047#issuecomment-2287396502 > @potiuk what should we do ? thanks Rebase/ review - potentually simplify and merge it as breaking change to main (which is already Airflow 3). We likely won't backport it to 2.10

Re: [PR] Change default DAG schedule to None [airflow]

2024-08-13 Thread via GitHub
potiuk commented on PR #41321: URL: https://github.com/apache/airflow/pull/41321#issuecomment-2287385800 > A backport to the 2.10 branch is needed. According to the new rule it's on the committer who merges it to backport it and create a new PR if I read them right. -- This is an a

Re: [PR] Add config to default schedule to None [airflow]

2024-08-13 Thread via GitHub
uranusjr closed pull request #41397: Add config to default schedule to None URL: https://github.com/apache/airflow/pull/41397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Change default DAG schedule to None [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on PR #41321: URL: https://github.com/apache/airflow/pull/41321#issuecomment-2287382099 This should be ready if CI passes. **A backport to the 2.10 branch is needed.** -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [WIP] Add blog post for 2.10.0 [airflow-site]

2024-08-13 Thread via GitHub
potiuk commented on code in PR #1052: URL: https://github.com/apache/airflow-site/pull/1052#discussion_r1716090675 ## landing-pages/site/content/en/blog/airflow-2.10.0/index.md: ## @@ -0,0 +1,182 @@ +--- +title: "Apache Airflow 2.10.0 is here" +linkTitle: "Apache Airflow 2.10.0

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
eakmanrq commented on code in PR #41374: URL: https://github.com/apache/airflow/pull/41374#discussion_r1716087963 ## airflow/providers/fab/auth_manager/cli_commands/user_command.py: ## @@ -212,10 +212,10 @@ def users_import(args): users_created, users_updated = _import_us

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
eakmanrq commented on code in PR #41374: URL: https://github.com/apache/airflow/pull/41374#discussion_r1716085172 ## airflow/providers/fab/auth_manager/cli_commands/user_command.py: ## @@ -212,10 +212,10 @@ def users_import(args): users_created, users_updated = _import_us

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
eakmanrq commented on code in PR #41374: URL: https://github.com/apache/airflow/pull/41374#discussion_r1716083991 ## airflow/providers/fab/auth_manager/cli_commands/user_command.py: ## @@ -212,10 +212,10 @@ def users_import(args): users_created, users_updated = _import_us

Re: [PR] Properly implement termination grace period seconds [airflow]

2024-08-13 Thread via GitHub
jedcunningham commented on code in PR #41374: URL: https://github.com/apache/airflow/pull/41374#discussion_r1716082314 ## airflow/providers/fab/auth_manager/cli_commands/user_command.py: ## @@ -212,10 +212,10 @@ def users_import(args): users_created, users_updated = _impo

Re: [I] Improve Airflow's debugging story [airflow]

2024-08-13 Thread via GitHub
potiuk commented on issue #40975: URL: https://github.com/apache/airflow/issues/40975#issuecomment-2287370561 I think none of the maintainers know "power users" well. Almost by definition, we are not running, nor maining airlfow and we do not have teams of people working together on DAGs. w

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
potiuk commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1716068492 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
potiuk commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1716074427 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
potiuk commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1716068492 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
potiuk commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1716067577 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1716051596 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Delete experimental API [airflow]

2024-08-13 Thread via GitHub
jedcunningham commented on PR #41434: URL: https://github.com/apache/airflow/pull/41434#issuecomment-2287306443 > > > I am unsure what to do with `airflow/api/client/local_client.py` and `airflow/api/client/json_client.py`. They both use the experimental APIs. Does someone have context on t

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1716023740 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[PR] Fix tests/sensors/test_external_task_sensor.py for database isolation tests [airflow]

2024-08-13 Thread via GitHub
bugraoz93 opened a new pull request, #41450: URL: https://github.com/apache/airflow/pull/41450 Related: #41067 Similar tests were skipped so I skipped these two. **TLDR** The problem seems like the `dag` is not attached to any session and the `dag` method is called

[PR] Temporarily disable doc publishing waiting for ASF self-hosted runners [airflow]

2024-08-13 Thread via GitHub
potiuk opened a new pull request, #41449: URL: https://github.com/apache/airflow/pull/41449 The self hosted runners from ASF behave strangely: https://issues.apache.org/jira/projects/INFRA/issues/INFRA-25990 So we need to disable publishing docs.

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
potiuk commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1715986674 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

(airflow) branch main updated: Rename @span decorator to @add_span to avoid collisions (#41444)

2024-08-13 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ea515e6022 Rename @span decorator to @add_span t

Re: [PR] Rename @span decorator to @add_span to avoid collisions [airflow]

2024-08-13 Thread via GitHub
dstandish merged PR #41444: URL: https://github.com/apache/airflow/pull/41444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1715969051 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add incremental export and cross account export functionality in `DynamoDBToS3Operator` [airflow]

2024-08-13 Thread via GitHub
vincbeck commented on PR #41304: URL: https://github.com/apache/airflow/pull/41304#issuecomment-2287195266 Static checks are failing. Could you please [run them](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst) -- This is an automated message from t

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1715957560 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1715957560 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Check breaking changes have a news fragment [airflow]

2024-08-13 Thread via GitHub
uranusjr commented on code in PR #41443: URL: https://github.com/apache/airflow/pull/41443#discussion_r1715957560 ## .github/workflows/news-fragment.yml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Added logging device and logging device options [airflow]

2024-08-13 Thread via GitHub
geraj1010 commented on code in PR #41416: URL: https://github.com/apache/airflow/pull/41416#discussion_r1715955116 ## airflow/providers/docker/operators/docker_swarm.py: ## @@ -128,12 +140,25 @@ def __init__( self.networks = networks self.placement = placement

  1   2   3   >