Re: [PR] K8s Executor: failing the task in case the watcher receives an event with the reason ProviderFailed [airflow]

2024-08-18 Thread via GitHub
dirrao commented on code in PR #41186: URL: https://github.com/apache/airflow/pull/41186#discussion_r1721286663 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py: ## @@ -220,6 +220,16 @@ def process_status( # However, need to free the execu

Re: [PR] log handler deprecated filename_template argument removal [airflow]

2024-08-18 Thread via GitHub
dirrao commented on code in PR #41552: URL: https://github.com/apache/airflow/pull/41552#discussion_r1721283096 ## airflow/providers/microsoft/azure/log/wasb_task_handler.py: ## @@ -46,14 +46,13 @@ class WasbTaskHandler(FileTaskHandler, LoggingMixin): def __init__(

svn commit: r70984 [3/4] - /dev/airflow/providers/

2024-08-18 Thread eladkal
Propchange: dev/airflow/providers/apache_airflow_providers_google-10.22.0.tar.gz -- svn:mime-type = application/octet-stream Added: dev/airflow/providers/apache_airflow_providers_google-10.22.0.tar.gz.asc =

svn commit: r70984 [4/4] - /dev/airflow/providers/

2024-08-18 Thread eladkal
Added: dev/airflow/providers/apache_airflow_providers_qdrant-1.2.0-py3-none-any.whl.sha512 == --- dev/airflow/providers/apache_airflow_providers_qdrant-1.2.0-py3-none-any.whl.sha512 (added) +++ dev/airflow/providers/apa

svn commit: r70984 [1/4] - /dev/airflow/providers/

2024-08-18 Thread eladkal
Author: eladkal Date: Mon Aug 19 06:22:21 2024 New Revision: 70984 Log: Add artifacts for Airflow Providers 2024-08-19 Added: dev/airflow/providers/apache_airflow_providers_airbyte-3.9.0-py3-none-any.whl (with props) dev/airflow/providers/apache_airflow_providers_airbyte-3.9.0-py3-no

svn commit: r70984 [2/4] - /dev/airflow/providers/

2024-08-18 Thread eladkal
Added: dev/airflow/providers/apache_airflow_providers_apache_kafka-1.6.0.tar.gz.sha512 == --- dev/airflow/providers/apache_airflow_providers_apache_kafka-1.6.0.tar.gz.sha512 (added) +++ dev/airflow/providers/apache_airf

Re: [PR] Switch cloudant provider from cloudant library to ibmcloudant library [airflow]

2024-08-18 Thread via GitHub
topherinternational commented on PR #41555: URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295750150 Ok @potiuk I've added the exclusion and an explanatory comment, so I think this is complete. Please review at your convenience, thanks. -- This is an automated message fro

Re: [PR] Remove deprecated SubDags [airflow]

2024-08-18 Thread via GitHub
eladkal commented on code in PR #41390: URL: https://github.com/apache/airflow/pull/41390#discussion_r1721259282 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -495,8 +495,9 @@ def _get_ti_pod_labels(context: Context | None = None, include_try_number: bool

Re: [PR] Prepare docs for Aug 2nd wave of providers [airflow]

2024-08-18 Thread via GitHub
eladkal merged PR #41559: URL: https://github.com/apache/airflow/pull/41559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Prepare docs for Aug 2nd wave of providers [airflow]

2024-08-18 Thread via GitHub
eladkal commented on PR #41559: URL: https://github.com/apache/airflow/pull/41559#issuecomment-2295743160 merging, no need to refresh the changelog generation as no new commits for providers -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Small refactoring of Dataplex system tests [airflow]

2024-08-18 Thread via GitHub
VladaZakharova opened a new pull request, #41573: URL: https://github.com/apache/airflow/pull/41573 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests

[PR] fix: InletEventsAccessors stubs [airflow]

2024-08-18 Thread via GitHub
phi-friday opened a new pull request, #41572: URL: https://github.com/apache/airflow/pull/41572 `InletEventsAccessors` allowed `DatasetAlias`. But `context.pyi` does not allowed it. --- **^ Add meaningful description above** Read the **[Pull Request Guidel

[I] Gets a `DatasetEvent` that was created later than `logical_date`. [airflow]

2024-08-18 Thread via GitHub
phi-friday opened a new issue, #41571: URL: https://github.com/apache/airflow/issues/41571 ### Apache Airflow version 2.10.0rc1 ### If "Other Airflow 2 version" selected, which one? 2.10.0(not rc) ### What happened? I was expecting to be able to access the `

(airflow) branch constraints-main updated: Updating constraints. Github run id:10445737077

2024-08-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e9ad8dab84 Updating con

Re: [PR] New provider for Magento open source [airflow]

2024-08-18 Thread via GitHub
kodurusivakumar34 commented on PR #41556: URL: https://github.com/apache/airflow/pull/41556#issuecomment-2295543149 @potiuk Thank you for your feedback on the pull request for the Magento provider. I understand the concerns raised and would like to address them with two proposed solu

Re: [PR] Switch cloudant provider from cloudant library to ibmcloudant library [airflow]

2024-08-18 Thread via GitHub
topherinternational commented on PR #41555: URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295512197 Great explanation, thank you @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Specify an image pull secret [airflow]

2024-08-18 Thread via GitHub
adinamarca commented on issue #24303: URL: https://github.com/apache/airflow/issues/24303#issuecomment-2295448409 > I met the problem as well, after reading the helm chart. I figured out a solution. First, create a secret in you kubernetes cluster, detailed info can be found her

(airflow) branch main updated: Airflow 3: processor_poll_interval deprecated parameter usage removal (#41096)

2024-08-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8f8565fac0 Airflow 3: processor_poll_interval depre

Re: [PR] Airflow 3: processor_poll_interval deprecated parameter usage removal [airflow]

2024-08-18 Thread via GitHub
potiuk merged PR #41096: URL: https://github.com/apache/airflow/pull/41096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Upgrade build and chart dependencies [airflow]

2024-08-18 Thread via GitHub
potiuk opened a new pull request, #41570: URL: https://github.com/apache/airflow/pull/41570 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

Re: [I] Email on failure stuck indefinitely (not timing out) [airflow]

2024-08-18 Thread via GitHub
sunank200 commented on issue #41490: URL: https://github.com/apache/airflow/issues/41490#issuecomment-2295424864 @pedro-cf Thank you for submitting the issue. Have you verified the smtp_timeout value in your airflow.cfg or environment variables? Also, please check if other settings like smt

Re: [I] Error when you pass string arguments with white spaces on kubernetes pod operator [airflow]

2024-08-18 Thread via GitHub
sunank200 commented on issue #41419: URL: https://github.com/apache/airflow/issues/41419#issuecomment-2295423563 @abmramirez you might want to ensure that the arguments are properly escaped or quoted. Does the following work for you? ``` task = KubernetesPodOperator( task_id='ex

Re: [I] Ability to delete a Dataset from the UI and/or supported by the Airflow REST API [airflow]

2024-08-18 Thread via GitHub
sunank200 commented on issue #41431: URL: https://github.com/apache/airflow/issues/41431#issuecomment-2295422523 This PR seems related: https://github.com/apache/airflow/pull/36781 Also it seems duplicate of issue of https://github.com/apache/airflow/issues/36308 -- This is an aut

Re: [I] Use `set` instead of `list` for dag's tags [airflow]

2024-08-18 Thread via GitHub
sunank200 commented on issue #41420: URL: https://github.com/apache/airflow/issues/41420#issuecomment-2295421335 @Avihais12344 Thanks for raising the issue. I had follow-up questions: - Will this change to `set` break any existing DAGs or workflows expecting a list? I think it would. Woul

Re: [PR] Make all test pass in Database Isolation mode [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41567: URL: https://github.com/apache/airflow/pull/41567#issuecomment-2295419331 CC: @jscheffl -> the only problem with that one is that provider's tests are not run in v2-10-test branch (by definition). Which I **think** is not a problem - we already gone thr

Re: [I] SparkSubmitHook requires yarn binary [airflow]

2024-08-18 Thread via GitHub
sunank200 commented on issue #41324: URL: https://github.com/apache/airflow/issues/41324#issuecomment-2295417146 @EugeneMSOff Is the YARN binary available in the PATH of your Airflow instance? It seems that the YARN binary may not be available in your current environment, which could be the

Re: [PR] Remove debian bullseye support (#41568) [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41569: URL: https://github.com/apache/airflow/pull/41569#issuecomment-2295414256 (it's long overdue - should be removed in 2.9.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Remove debian bullseye support (#41568) [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41569: URL: https://github.com/apache/airflow/pull/41569#issuecomment-2295414202 Backport to v2-10-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Cleanup installed packages when running provider compatibility tests [airflow]

2024-08-18 Thread via GitHub
potiuk merged PR #41488: URL: https://github.com/apache/airflow/pull/41488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Cleanup installed packages when running provider compatibility tests [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41488: URL: https://github.com/apache/airflow/pull/41488#issuecomment-2295414045 I had to add a bit more stuff to make the "unwanted" packages removal - and the "--clean" installation takes quite a bit more time, so I only enabled it in canary runs. -- This is an

[PR] Remove debian bullseye support (#41568) [airflow]

2024-08-18 Thread via GitHub
potiuk opened a new pull request, #41569: URL: https://github.com/apache/airflow/pull/41569 (cherry picked from commit 5c323a9c562c6e886dbba460fc733a6f8590bf8b) --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://gi

Re: [PR] Remove debian bullseye support [airflow]

2024-08-18 Thread via GitHub
potiuk merged PR #41568: URL: https://github.com/apache/airflow/pull/41568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] fixing emr-operator-deferral-logic [airflow]

2024-08-18 Thread via GitHub
laksh-krishna-sharma commented on PR #41561: URL: https://github.com/apache/airflow/pull/41561#issuecomment-2295406553 @shahar1 sir please review the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] DatasetOrTimeSchedule causes deadlock [airflow]

2024-08-18 Thread via GitHub
sunank200 commented on issue #41305: URL: https://github.com/apache/airflow/issues/41305#issuecomment-2295405814 I have following DAG: ``` with DAG( dag_id="dataset_produces_1", catchup=False, start_date=pendulum.datetime(2021, 1, 1, tz="UTC"), schedule="

(airflow) branch main updated: base excutor deprecated unused validate_command function removal (#41551)

2024-08-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 55e60992ad base excutor deprecated unused validate_

Re: [PR] base executor unused validate_command function removal [airflow]

2024-08-18 Thread via GitHub
potiuk merged PR #41551: URL: https://github.com/apache/airflow/pull/41551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Feature/ Get upstream task ids by state [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41506: URL: https://github.com/apache/airflow/pull/41506#issuecomment-2295402432 I am not sure if we want to add this -> generally speaking, I **think** we want to get rid of the TaskInstance as model being available and used in Airflow 3 and use Airflow-sdk (with AI

Re: [PR] fixing emr-operator-deferral-logic [airflow]

2024-08-18 Thread via GitHub
laksh-krishna-sharma commented on PR #41561: URL: https://github.com/apache/airflow/pull/41561#issuecomment-2295401096 Thank you for letting me know, @shahar1. I will make the changes and add comments again . I'll update you once the problem is resolved." -- This is an automated message f

(airflow) branch main updated: smtp email user and password deprecated config removal (#41539)

2024-08-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 865220965f smtp email user and password deprecated

Re: [PR] smtp email user and password deprecated config removal [airflow]

2024-08-18 Thread via GitHub
potiuk merged PR #41539: URL: https://github.com/apache/airflow/pull/41539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: airflow deprecated settings session_lifetime_days, force_log_out_after and policy removal (#41550)

2024-08-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f2e92eb6a2 airflow deprecated settings session_life

Re: [PR] airflow deprecated settings session_lifetime_days, force_log_out_after and policy removal [airflow]

2024-08-18 Thread via GitHub
potiuk merged PR #41550: URL: https://github.com/apache/airflow/pull/41550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Remove debian bullseye support [airflow]

2024-08-18 Thread via GitHub
potiuk opened a new pull request, #41568: URL: https://github.com/apache/airflow/pull/41568 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

Re: [PR] Add Airflow 3 development readme [airflow]

2024-08-18 Thread via GitHub
eladkal commented on code in PR #41457: URL: https://github.com/apache/airflow/pull/41457#discussion_r1721055214 ## dev/README_AIRFLOW3_DEV.md: ## @@ -0,0 +1,114 @@ + + + +**Table of contents** + +- [Main branch is Airflow 3](#main-branch-is-airflow-3) +- [Contributors](#contrib

Re: [PR] Airflow 2.10.0 has been released [airflow]

2024-08-18 Thread via GitHub
potiuk commented on code in PR #41528: URL: https://github.com/apache/airflow/pull/41528#discussion_r1721053068 ## README.md: ## @@ -124,7 +124,7 @@ as this is the only environment that is supported. The only distro that is used is used in the [Community managed DockerHub ima

Re: [PR] Switch cloudant provider from cloudant library to ibmcloudant library [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41555: URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295384199 I've added "all-versions" tag to the PR of yours - to make sure it's tested on all versions - so once you exclude python versions you should be able to see both CI images and tests to ru

Re: [PR] Switch cloudant provider from cloudant library to ibmcloudant library [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41555: URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295383824 See https://github.com/apache/airflow/pull/41548 - where we just removed such exclusion for Papermill for Python 3.12 -- This is an automated message from the Apache Git Service. To re

Re: [PR] Switch cloudant provider from cloudant library to ibmcloudant library [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41555: URL: https://github.com/apache/airflow/pull/41555#issuecomment-2295383399 > Rats, looks like the joke is on me and this PR is blocked on another third-party...`ibmcloudant` has a dependency conflict with the Snowflake Python library that nerfs the Airflow buil

Re: [PR] Add Airflow 3 development readme [airflow]

2024-08-18 Thread via GitHub
potiuk commented on code in PR #41457: URL: https://github.com/apache/airflow/pull/41457#discussion_r1721051735 ## dev/README_AIRFLOW3_DEV.md: ## @@ -0,0 +1,114 @@ + + + +**Table of contents** + +- [Main branch is Airflow 3](#main-branch-is-airflow-3) +- [Contributors](#contribu

Re: [PR] Aip-59 Performance testing framework [airflow]

2024-08-18 Thread via GitHub
bjankie1 commented on PR #41315: URL: https://github.com/apache/airflow/pull/41315#issuecomment-2295382245 I will make an attempt to divide the code into several PRs. 1. Framework for building performance DAGs 1. Framework for collecting instance metrics in kubernetes. 1. Framewor

Re: [PR] Remove deprecated SubDags [airflow]

2024-08-18 Thread via GitHub
potiuk commented on code in PR #41390: URL: https://github.com/apache/airflow/pull/41390#discussion_r1721050765 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -495,8 +495,9 @@ def _get_ti_pod_labels(context: Context | None = None, include_try_number: bool

Re: [PR] New provider for Magento open source [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41556: URL: https://github.com/apache/airflow/pull/41556#issuecomment-2295379965 And to add to what @hussein-awala wrote - it's not very likely we will accept magento as managed by the community - we need to be able to support providers in the community and I guess m

Re: [PR] Support pre-versions in version handling in Breeze [airflow]

2024-08-18 Thread via GitHub
potiuk merged PR #41565: URL: https://github.com/apache/airflow/pull/41565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (a083dcde40 -> c0c92d37f3)

2024-08-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a083dcde40 Fix changelog template for new providers w/o relevant commits (#41566) add c0c92d37f3 Support pre-vers

[PR] Make all test pass in Database Isolation mode [airflow]

2024-08-18 Thread via GitHub
potiuk opened a new pull request, #41567: URL: https://github.com/apache/airflow/pull/41567 This adds dedicated "DatabaseIsolation" test to airflow v2-10-test branch.. The DatabaseIsolation test will run all "db-tests" with enabled DB isolation mode and running `internal-api` componen

Re: [PR] fix: unwrap Param objects when used as DagParam defaults [airflow]

2024-08-18 Thread via GitHub
jscheffl commented on PR #41513: URL: https://github.com/apache/airflow/pull/41513#issuecomment-2295364126 @nickmyatt I do not get the full point behind the adjustment. Description and change do not match or I just don't get it. Can you please post an example problematic DAG that I understa

Re: [PR] Remove Database Isolation feature flag and run DB isolation tests [airflow]

2024-08-18 Thread via GitHub
potiuk commented on PR #41067: URL: https://github.com/apache/airflow/pull/41067#issuecomment-2295363572 > How about... we split the PR into: > * Feature flag --> Airflow 2.11 to be cherry-picked - this will probably not have risk to degrade > * Internal API Tests --> Merge to v2-1

(airflow) branch main updated: Fix changelog template for new providers w/o relevant commits (#41566)

2024-08-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a083dcde40 Fix changelog template for new providers

Re: [PR] Fix changelog template for new providers w/o relevant commits [airflow]

2024-08-18 Thread via GitHub
potiuk merged PR #41566: URL: https://github.com/apache/airflow/pull/41566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Revamp Contributor's quick start [airflow]

2024-08-18 Thread via GitHub
RNHTTR commented on PR #39837: URL: https://github.com/apache/airflow/pull/39837#issuecomment-2295357075 still working on this ahead of airflow summit's contributor's workshop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] Fix changelog template for new providers w/o relevant commits [airflow]

2024-08-18 Thread via GitHub
jscheffl opened a new pull request, #41566: URL: https://github.com/apache/airflow/pull/41566 During the implementation of AIP-69 I realized that the CI fails during the check of preparation of changelog. Reason is that the `classified_changes` prepared is None and the Jinja templating fail

[PR] Support pre-versions in version handling in Breeze [airflow]

2024-08-18 Thread via GitHub
jscheffl opened a new pull request, #41565: URL: https://github.com/apache/airflow/pull/41565 During the implementation of AIP-69 for which we agreed to make a pre-release as provider only I noticed that breeze fails in non-numeric versions, e.g. I used `0.1.0pre0` as the code attempts to r

Re: [PR] fixing emr-operator-deferral-logic [airflow]

2024-08-18 Thread via GitHub
shahar1 commented on code in PR #41561: URL: https://github.com/apache/airflow/pull/41561#discussion_r1721020824 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -833,11 +833,9 @@ def execute(self, context: Context) -> str | None: waiter_max_attempts=

[PR] Airflow Core Provider [airflow]

2024-08-18 Thread via GitHub
romsharon98 opened a new pull request, #41564: URL: https://github.com/apache/airflow/pull/41564 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rs

[I] callback without __name__ are not allowed when taskinstance executing [airflow]

2024-08-18 Thread via GitHub
obarisk opened a new issue, #41563: URL: https://github.com/apache/airflow/issues/41563 ### Apache Airflow version 2.10.0rc1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? _run_finished_callback now logs ```

Re: [PR] Enable EksPodOperator deferrable [airflow]

2024-08-18 Thread via GitHub
jx2lee commented on code in PR #41380: URL: https://github.com/apache/airflow/pull/41380#discussion_r1720987537 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -1100,4 +1108,22 @@ def execute(self, context: Context): with eks_hook.generate_config_file(

Re: [PR] Separate FAB migration from Core Airflow migration [airflow]

2024-08-18 Thread via GitHub
ephraimbuddy commented on PR #41437: URL: https://github.com/apache/airflow/pull/41437#issuecomment-2295262925 > Likely side-effect of other tests that have been somewhat masked or avoided before the change - where some setup/teardown removed the side-effect. > > > > You can r

Re: [I] Values in SparkKubernetesOperator YAML needs to be defined [airflow]

2024-08-18 Thread via GitHub
boring-cyborg[bot] commented on issue #41562: URL: https://github.com/apache/airflow/issues/41562#issuecomment-2295257736 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Values in SparkKubernetesOperator YAML needs to be defined [airflow]

2024-08-18 Thread via GitHub
amirshabanics opened a new issue, #41562: URL: https://github.com/apache/airflow/issues/41562 ### Apache Airflow Provider(s) cncf-kubernetes ### Versions of Apache Airflow Providers apache-airflow-providers-cncf-kubernetes==8.3.1 ### Apache Airflow version 2

Re: [PR] fixing emr-operator-deferral-logic [airflow]

2024-08-18 Thread via GitHub
boring-cyborg[bot] commented on PR #41561: URL: https://github.com/apache/airflow/pull/41561#issuecomment-2295245962 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] fixing emr-operator-deferral-logic [airflow]

2024-08-18 Thread via GitHub
laksh-krishna-sharma opened a new pull request, #41561: URL: https://github.com/apache/airflow/pull/41561 --- ### Summary of Changes This PR addresses issue #40966 by modifying the logic in the `EmrCreateJobFlowOperator` to ensure that the `deferrabl

[PR] Adding config max_active_tasks_include_deferred [airflow]

2024-08-18 Thread via GitHub
gopidesupavan opened a new pull request, #41560: URL: https://github.com/apache/airflow/pull/41560 Adding max_active_tasks_include_deferred. max_active_tasks should take in account the deferred task when max_active_tasks_include_deferred=true closes: #40528

[PR] Prepare docs for Aug 2nd wave of providers [airflow]

2024-08-18 Thread via GitHub
eladkal opened a new pull request, #41559: URL: https://github.com/apache/airflow/pull/41559 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Remove deprecated SubDags [airflow]

2024-08-18 Thread via GitHub
eladkal commented on code in PR #41390: URL: https://github.com/apache/airflow/pull/41390#discussion_r1720922955 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -495,8 +495,9 @@ def _get_ti_pod_labels(context: Context | None = None, include_try_number: bool

Re: [PR] Remove deprecated SubDags [airflow]

2024-08-18 Thread via GitHub
eladkal commented on code in PR #41390: URL: https://github.com/apache/airflow/pull/41390#discussion_r1720922955 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -495,8 +495,9 @@ def _get_ti_pod_labels(context: Context | None = None, include_try_number: bool

Re: [PR] Add Airflow 3 development readme [airflow]

2024-08-18 Thread via GitHub
eladkal commented on code in PR #41457: URL: https://github.com/apache/airflow/pull/41457#discussion_r1720920063 ## dev/README_AIRFLOW3_DEV.md: ## @@ -0,0 +1,76 @@ + + + +**Table of contents** + +- [Main branch is Airflow 3](#main-branch-is-airflow-3) +- [Developing for provider

(airflow) branch constraints-main updated: Updating constraints. Github run id:10438817225

2024-08-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new a14b95788c Updating con