Re: [PR] Backcompat for non inheriting executors [airflow]

2024-08-31 Thread via GitHub
utkarsharma2 commented on PR #41906: URL: https://github.com/apache/airflow/pull/41906#issuecomment-2323191430 > Would be great to get that one for 2.10.1 @ephraimbuddy @utkarsharma2 Sure @potiuk I'll include this for 2.10.1 -- This is an automated message from the Apache Git Servic

Re: [PR] Feature/add pgbouncer and statsd ingress [airflow]

2024-08-31 Thread via GitHub
romsharon98 commented on PR #41759: URL: https://github.com/apache/airflow/pull/41759#issuecomment-2323183912 > @romsharon98 overall the changes look good. Could you add test cases for default values? Most of the default values are set to `""`,making it difficult to test effectively.

Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]

2024-08-31 Thread via GitHub
divyaguduru commented on PR #1062: URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2323160929 @potiuk i will work on the feedback .. could you please review sticky sidebar implementation for "Community" page as well. It is requested on the same issue #233 - Added

Re: [PR] Protect against None components of universal pathlib xcom backend [airflow]

2024-08-31 Thread via GitHub
potiuk commented on code in PR #41921: URL: https://github.com/apache/airflow/pull/41921#discussion_r1739968045 ## airflow/io/path.py: ## @@ -198,7 +198,7 @@ def replace(self, target) -> ObjectStoragePath: Returns the new Path instance pointing to the target path.

Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]

2024-08-31 Thread via GitHub
potiuk commented on PR #1062: URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2323128441 I am not sure if adding the book to resources is a good idea. Generally whatever we publish (except Ecosystem page) should be PMC "owned" and "controlled" and the book is something wr

Re: [I] Universal-pathlib 0.2.3 seems to break compatibility with 0.2.2 (at least breaks mypy checks). [airflow]

2024-08-31 Thread via GitHub
potiuk commented on issue #41723: URL: https://github.com/apache/airflow/issues/41723#issuecomment-2323126687 > Ping me once you fix the `Optional[str]` issue on your side. I can then release a new intermediate version of `universal-pathlib` with the #257 fix. I don't think it was "se

[PR] Protect against None components of universal pathlib xcom backend [airflow]

2024-08-31 Thread via GitHub
potiuk opened a new pull request, #41921: URL: https://github.com/apache/airflow/pull/41921 fixes: #41723 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_

Re: [PR] Add CountTokensOperator for Google Generative AI CountTokensAPI [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41908: URL: https://github.com/apache/airflow/pull/41908#issuecomment-2323104715 Needs rebase. Also cc: @VladaZakharova -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Removed deprecation warning catching in test_db_cleanup [airflow]

2024-08-31 Thread via GitHub
potiuk merged PR #41909: URL: https://github.com/apache/airflow/pull/41909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Removed deprecation warning catching in test_db_cleanup (#41909)

2024-08-31 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2b03469e9e Removed deprecation warning catching in

Re: [PR] Add RunEvaluationOperator for Google Generative AI Rapid Evaluation API [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41919: URL: https://github.com/apache/airflow/pull/41919#issuecomment-2323104367 cc: @VladaZakharova ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Add RunEvaluationOperator for Google Generative AI Rapid Evaluation API [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41919: URL: https://github.com/apache/airflow/pull/41919#issuecomment-2323104337 Needs rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] AIP-69: Adding Edge Provider Package for Edge Executor / Worker [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41729: URL: https://github.com/apache/airflow/pull/41729#issuecomment-2323104051 Maybe we can further split that one? It's a **huge** one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] AIP-69: Adding Edge Provider Package for Edge Executor / Worker [airflow]

2024-08-31 Thread via GitHub
potiuk commented on code in PR #41729: URL: https://github.com/apache/airflow/pull/41729#discussion_r1739945847 ## airflow/providers/edge/provider.yaml: ## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] AIP-69: Airflow Core adjustments for introduction of Edge Executor [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41730: URL: https://github.com/apache/airflow/pull/41730#issuecomment-2323103017 (and tests are failing too) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] AIP-69: Breeze adjustments for introduction of Edge Executor [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41731: URL: https://github.com/apache/airflow/pull/41731#issuecomment-2323102752 Needs to be cherry-picked to v2-10-test I guess -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] AIP-69: Airflow Core adjustments for introduction of Edge Executor [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41730: URL: https://github.com/apache/airflow/pull/41730#issuecomment-2323102647 Needs to be cherry-picked to `v2-10-test` I guess -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Airflow 3: python operators deprecations removal [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41493: URL: https://github.com/apache/airflow/pull/41493#issuecomment-2323101716 I think we need to wait for next dev call where we discuss "standard" provider's scope -- This is an automated message from the Apache Git Service. To respond to the message, please lo

(airflow) branch main updated: update pattern for dataflow job id extraction (#41794)

2024-08-31 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9a66882ed5 update pattern for dataflow job id extra

Re: [PR] update pattern for dataflow job id extraction [airflow]

2024-08-31 Thread via GitHub
boring-cyborg[bot] commented on PR #41794: URL: https://github.com/apache/airflow/pull/41794#issuecomment-2323101309 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] update pattern for dataflow job id extraction [airflow]

2024-08-31 Thread via GitHub
potiuk merged PR #41794: URL: https://github.com/apache/airflow/pull/41794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (b1e4f37505 -> 86e3d2919c)

2024-08-31 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b1e4f37505 Fix ElasticSearch SQLClient deprecation warning (#41871) add 86e3d2919c Enforce deprecation message for

Re: [PR] Enforce deprecation message format with EOL for google provider package [airflow]

2024-08-31 Thread via GitHub
potiuk merged PR #41637: URL: https://github.com/apache/airflow/pull/41637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Fix ElasticSearch SQLClient deprecation warning (#41871)

2024-08-31 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b1e4f37505 Fix ElasticSearch SQLClient deprecation

Re: [PR] Fix ElasticSearch SQLClient deprecation warning [airflow]

2024-08-31 Thread via GitHub
potiuk merged PR #41871: URL: https://github.com/apache/airflow/pull/41871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Remove state sync during celery task processing [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2323093079 Also another question: https://airflow.apache.org/docs/apache-airflow-providers-celery/stable/configurations-ref.html#result-backend-sqlalchemy-engine-options -> there is also a

Re: [PR] Remove state sync during celery task processing [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2323080871 It's an interesting one. And yeah - nice analysis @Kytha ! Looks like the original code was supposed to handle "quick" tasks - but It did not take into account that - apparently -

Re: [PR] Switch cloudant provider from cloudant library to ibmcloudant library [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41555: URL: https://github.com/apache/airflow/pull/41555#issuecomment-2323075534 I added a fixup that is supposed to skip cloundant tests for 3.8, 3.9, 3.12 @topherinternational -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Backcompat for non inheriting executors [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41906: URL: https://github.com/apache/airflow/pull/41906#issuecomment-2323073018 (Still - this one needs main + backport as discussed before). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Backcompat for non inheriting executors [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41906: URL: https://github.com/apache/airflow/pull/41906#issuecomment-2323071677 Would be great to get that one for 2.10.1 @ephraimbuddy @utkarsharma2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] airflow.models.xcom deprecations removed [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41803: URL: https://github.com/apache/airflow/pull/41803#issuecomment-2323069602 Looks like 'mock_context` in conftest.py should be modified to accept xcom_push with `execution_date` when Airflow < 3.0. Likely could be done by adding `**kwargs` to the xcom_push metho

(airflow) branch main updated: Removed deprecated method requires_access from module airflow.api_connexion.security (#41910)

2024-08-31 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3b76ec9a89 Removed deprecated method requires_acces

Re: [PR] Removed deprecated method requires_access from module airflow.api_connexion.security [airflow]

2024-08-31 Thread via GitHub
potiuk merged PR #41910: URL: https://github.com/apache/airflow/pull/41910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Add generating recommended actions for projects and dependency depth (#41920)

2024-08-31 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fe15f590e0 Add generating recommended actions for p

Re: [PR] Add generating recommended actions for projects and dependency depth [airflow]

2024-08-31 Thread via GitHub
potiuk merged PR #41920: URL: https://github.com/apache/airflow/pull/41920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Add generating recommended actions for projects and dependency depth [airflow]

2024-08-31 Thread via GitHub
potiuk opened a new pull request, #41920: URL: https://github.com/apache/airflow/pull/41920 The SBON export dependencies command now supports generating recommended actions and dependency depth information. recommended actions and dependency depth information.

Re: [PR] UI API CLI and Breeze integration [airflow]

2024-08-31 Thread via GitHub
potiuk commented on PR #41896: URL: https://github.com/apache/airflow/pull/41896#issuecomment-2323057885 I'd say - migrating existing REST APIs to the new "ui-api" command is the way to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] After user admin recreation: AttributeError: 'NoneType' object has no attribute 'is_active': unable to connect [airflow]

2024-08-31 Thread via GitHub
jscheffl commented on issue #41901: URL: https://github.com/apache/airflow/issues/41901#issuecomment-2323050148 Note: I tested the steps below "How to Reproduce" and can not see a problem in Airflow 2.10.0 and latest main (both). As you reported the problem with 2.9.3... can you test on 2.1

(airflow) branch constraints-main updated: Updating constraints. Github run id:10645656618

2024-08-31 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 1d052f3d82 Updating con

Re: [I] After user admin recreation: AttributeError: 'NoneType' object has no attribute 'is_active': unable to connect [airflow]

2024-08-31 Thread via GitHub
jscheffl commented on issue #41901: URL: https://github.com/apache/airflow/issues/41901#issuecomment-2323045378 I assume the "right" way to reset a user (admin or normal) password is: ``` root@fb30c3a3f4ce:/opt/airflow# airflow users reset-password --help Usage: airflow users reset-p

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-08-31 Thread via GitHub
jscheffl commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2323044478 Some static checks fail. Though I like the implementation a lot more than before... actually as project team we have decided (1) that Airflow 2.10 will only get new features in excepti

Re: [I] Rerunning a dag in Airflow 2.7.3 causes a missing table issue [airflow]

2024-08-31 Thread via GitHub
jscheffl commented on issue #41894: URL: https://github.com/apache/airflow/issues/41894#issuecomment-2323043882 Thanks for reporting the bug. Whereas retrospective version 2.7 is pretty old and very probably we will not release patches. Do I understand it right that mainly you have pr

[PR] Add RunEvaluationOperator for Google Generative AI Rapid Evaluation API [airflow]

2024-08-31 Thread via GitHub
CYarros10 opened a new pull request, #41919: URL: https://github.com/apache/airflow/pull/41919 The Gen AI Evaluation Service lets you evaluate your large language models (LLMs), both pointwise and pairwise, across several metrics, with your own criteria. You can provide inference-time input

[I] StepFunctionStartExecutionOperator in MWAA does not throw error if IAM Role does not DescribeExecution permission [airflow]

2024-08-31 Thread via GitHub
sarkch opened a new issue, #41918: URL: https://github.com/apache/airflow/issues/41918 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.8.1 ### What happened? I am using StepFun

Re: [I] Amazon S3 for logging using IAM role for service accounts(IRSA) [airflow]

2024-08-31 Thread via GitHub
Thamban777 commented on issue #25322: URL: https://github.com/apache/airflow/issues/25322#issuecomment-2322927522 ``` Hi Team, Am getting Permission denied: '/.aws' on InitContainer. I have followed the Documentation mentioned above. EKS Version: 1.30 Chart version: 1.13.1

Re: [I] Amazon S3 for logging using IAM role for service accounts(IRSA) [airflow]

2024-08-31 Thread via GitHub
Thamban777 commented on issue #25322: URL: https://github.com/apache/airflow/issues/25322#issuecomment-2322925622 Hi Team, Am getting Permission denied: '/.aws' on InitContainer. I have followed the Documentation mentioned above. EKS Version: 1.30 Chart version: 1.13.1 m

Re: [I] Inconsistent XCom message format when using PubSubPullSensor with deferrable=True [airflow]

2024-08-31 Thread via GitHub
gopidesupavan commented on issue #41877: URL: https://github.com/apache/airflow/issues/41877#issuecomment-2322917853 Looking into this one, seems received message to JSON-serializable dicts conversion not there when deferrable = True. Let me check and update. -- This is an automated messa

Re: [PR] feat: notify about potential serialization failures when sending DagRun, don't serialize unnecessary params, guard listener for exceptions [airflow]

2024-08-31 Thread via GitHub
mobuchowski commented on code in PR #41690: URL: https://github.com/apache/airflow/pull/41690#discussion_r1739733449 ## airflow/providers/openlineage/plugins/adapter.py: ## @@ -336,33 +335,36 @@ def fail_task( def dag_started( self, -dag_run: DagRun, -

Re: [I] Error loop when using Airflow's docker compose file [airflow]

2024-08-31 Thread via GitHub
Nakeuh closed issue #41915: Error loop when using Airflow's docker compose file URL: https://github.com/apache/airflow/issues/41915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Add support for semicolon stripping to DbApiHook, PrestoHook, and TrinoHook [airflow]

2024-08-31 Thread via GitHub
boring-cyborg[bot] commented on PR #41916: URL: https://github.com/apache/airflow/pull/41916#issuecomment-2322885953 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Add support for semicolon stripping to DbApiHook, PrestoHook, and TrinoHook [airflow]

2024-08-31 Thread via GitHub
Illumaria opened a new pull request, #41916: URL: https://github.com/apache/airflow/pull/41916 Closes #34828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] Error loop when using Airflow's docker compose file [airflow]

2024-08-31 Thread via GitHub
Nakeuh commented on issue #41915: URL: https://github.com/apache/airflow/issues/41915#issuecomment-2322885708 Finally found a fix. Using apache/airflow:2.10.0 instead of apache/airflow:slim-latest solved the issue -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Error loop when using Airflow's docker compose file [airflow]

2024-08-31 Thread via GitHub
boring-cyborg[bot] commented on issue #41915: URL: https://github.com/apache/airflow/issues/41915#issuecomment-2322876453 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Error loop when using Airflow's docker compose file [airflow]

2024-08-31 Thread via GitHub
Nakeuh opened a new issue, #41915: URL: https://github.com/apache/airflow/issues/41915 ### Apache Airflow version 2.10.0 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? I am trying to run a docker compose file from [off

Re: [I] น [airflow]

2024-08-31 Thread via GitHub
potiuk closed issue #41913: น URL: https://github.com/apache/airflow/issues/41913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [I] timeout on Dynamic Task mapping : skipped inner task , task status is still success [airflow]

2024-08-31 Thread via GitHub
raphaelauv commented on issue #37332: URL: https://github.com/apache/airflow/issues/37332#issuecomment-2322832278 no stale -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] BugFix(Operators.rst): Update operators.rst on adding SQLExecuteQueryOperator [airflow]

2024-08-31 Thread via GitHub
boring-cyborg[bot] commented on PR #41914: URL: https://github.com/apache/airflow/pull/41914#issuecomment-2322832033 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] BugFix(Operators.rst): Update operators.rst on adding SQLExecuteQueryOperator [airflow]

2024-08-31 Thread via GitHub
DilanJT opened a new pull request, #41914: URL: https://github.com/apache/airflow/pull/41914 Added SQLExecuteQueryOperator to the list of Operators as the PostgresOperator is deprecated. --- **^ Add meaningful description above** Read the **[Pull Requ

Re: [PR] airflow.models.xcom deprecations removed [airflow]

2024-08-31 Thread via GitHub
dirrao commented on PR #41803: URL: https://github.com/apache/airflow/pull/41803#issuecomment-2322808109 @potiuk / @uranusjr Provider backward compatibility test is failing. Ideally, it should pass. Something nontrivial to me. Can someone help me with this? -- This is an automated me

[PR] Removed deprecated method requires_access from module airflow.api_connexion.security [airflow]

2024-08-31 Thread via GitHub
dirrao opened a new pull request, #41910: URL: https://github.com/apache/airflow/pull/41910 Removed deprecated method requires_access from module airflow.api_connexion.security -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Broken url for the source code pointing to example_dags under providers [airflow]

2024-08-31 Thread via GitHub
github-actions[bot] commented on issue #32295: URL: https://github.com/apache/airflow/issues/32295#issuecomment-2322805138 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Broken url for the source code pointing to example_dags under providers [airflow]

2024-08-31 Thread via GitHub
github-actions[bot] closed issue #32295: Broken url for the source code pointing to example_dags under providers URL: https://github.com/apache/airflow/issues/32295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] sqlalchemy.exc.ResourceClosedError when updating a task instance's executor_config from a task_instance_mutation_hook [airflow]

2024-08-31 Thread via GitHub
github-actions[bot] commented on issue #32375: URL: https://github.com/apache/airflow/issues/32375#issuecomment-2322805092 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activit