[I] Grouping Dataset Events to Trigger DAGs [airflow]

2024-09-04 Thread via GitHub
dirrao opened a new issue, #42015: URL: https://github.com/apache/airflow/issues/42015 ### Description _No response_ ### Use case/motivation To handle multiple dataset updates efficiently and avoid triggering a DAG for every small dataset update (like a tiny partition),

Re: [PR] Metrics basic deprecated validators removed in favor of pattern matching [airflow]

2024-09-04 Thread via GitHub
dirrao commented on code in PR #41975: URL: https://github.com/apache/airflow/pull/41975#discussion_r1744879895 ## airflow/metrics/validators.py: ## @@ -118,7 +107,7 @@ def get_validator() -> ListValidator: else: list_type = DEFAULT_VALIDATOR_TYPE -return val

Re: [I] Remove StatsD and replace it with Open Telemetry as first-class citizen [airflow]

2024-09-04 Thread via GitHub
raphaelauv commented on issue #40800: URL: https://github.com/apache/airflow/issues/40800#issuecomment-2330664590 Yes otel is better ,but why keep stated ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] How to use .md file in doc_md for DAG documentation [airflow]

2024-09-04 Thread via GitHub
jscheffl closed issue #41886: How to use .md file in doc_md for DAG documentation URL: https://github.com/apache/airflow/issues/41886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [I] How to use .md file in doc_md for DAG documentation [airflow]

2024-09-04 Thread via GitHub
jscheffl commented on issue #41886: URL: https://github.com/apache/airflow/issues/41886#issuecomment-2330595950 Okay, you hit a special situation as the logic was adjusted between 2.8.3 and 2.9.3 because of a security hardening. Templating support was removed in 2.9.3. So I propose t

Re: [PR] kubernetes executor cleanup_stuck_queued_tasks optimization [airflow]

2024-09-04 Thread via GitHub
dirrao commented on code in PR #41220: URL: https://github.com/apache/airflow/pull/41220#discussion_r1744708190 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str | datetime) -> str:

Re: [PR] kubernetes executor cleanup_stuck_queued_tasks optimization [airflow]

2024-09-04 Thread via GitHub
dirrao commented on code in PR #41220: URL: https://github.com/apache/airflow/pull/41220#discussion_r1744708550 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str | datetime) -> str:

Re: [PR] kubernetes executor cleanup_stuck_queued_tasks optimization [airflow]

2024-09-04 Thread via GitHub
dirrao commented on code in PR #41220: URL: https://github.com/apache/airflow/pull/41220#discussion_r1744708190 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -177,6 +177,37 @@ def _make_safe_label_value(self, input_value: str | datetime) -> str:

Re: [PR] WIP: feat: dynamic dag creation with partial errors - initial sketch of desired behavior [airflow]

2024-09-04 Thread via GitHub
github-actions[bot] closed pull request #40822: WIP: feat: dynamic dag creation with partial errors - initial sketch of desired behavior URL: https://github.com/apache/airflow/pull/40822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] ISSUE-40525: Fix backfilling CLI command where DAG files are missing [airflow]

2024-09-04 Thread via GitHub
github-actions[bot] commented on PR #40911: URL: https://github.com/apache/airflow/pull/40911#issuecomment-2330357447 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [I] DatasetOrTimeSchedule causes deadlock [airflow]

2024-09-04 Thread via GitHub
github-actions[bot] commented on issue #41305: URL: https://github.com/apache/airflow/issues/41305#issuecomment-2330357385 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [I] Remove StatsD and replace it with Open Telemetry as first-class citizen [airflow]

2024-09-04 Thread via GitHub
howardyoo commented on issue #40800: URL: https://github.com/apache/airflow/issues/40800#issuecomment-2330330962 > > > Will StatsD support be dropped with AF 3 or will OTEL become primary for AF 3 with StatsD as an alternative/backup for N versions to ensure there is a smooth and safe migra

Re: [PR] Use set instead of list for dags' tags [airflow]

2024-09-04 Thread via GitHub
jscheffl commented on code in PR #41695: URL: https://github.com/apache/airflow/pull/41695#discussion_r1744611759 ## airflow/models/dag.py: ## @@ -3603,7 +3603,7 @@ def dag( is_paused_upon_creation: bool | None = None, jinja_environment_kwargs: dict | None = None,

Re: [PR] Improve docs on markdown docs in DAGs (#42012) [airflow]

2024-09-04 Thread via GitHub
jscheffl merged PR #42013: URL: https://github.com/apache/airflow/pull/42013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Implement `SimpleAuthManager` [airflow]

2024-09-04 Thread via GitHub
jedcunningham commented on code in PR #42004: URL: https://github.com/apache/airflow/pull/42004#discussion_r1744603133 ## airflow/auth/managers/simple/views/auth.py: ## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

(airflow) branch main updated (85ad5c374d -> 48ea66c2d7)

2024-09-04 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 85ad5c374d Add callback to process Azure Service Bus message contents (#41601) add 48ea66c2d7 Improve docs on

Re: [PR] Improve docs on markdown docs in DAGs [airflow]

2024-09-04 Thread via GitHub
jscheffl merged PR #42012: URL: https://github.com/apache/airflow/pull/42012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Add callback to process Azure Service Bus message contents [airflow]

2024-09-04 Thread via GitHub
perry2of5 commented on PR #41601: URL: https://github.com/apache/airflow/pull/41601#issuecomment-2330269872 Thank you @potiuk and @Lee-W. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Add callback to process Azure Service Bus message contents [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41601: URL: https://github.com/apache/airflow/pull/41601#discussion_r1744585720 ## airflow/providers/microsoft/azure/hooks/asb.py: ## @@ -326,5 +342,32 @@ def receive_subscription_message( max_message_count=max_message_count, max

[PR] Improve docs on markdown docs in DAGs [airflow]

2024-09-04 Thread via GitHub
jscheffl opened a new pull request, #42012: URL: https://github.com/apache/airflow/pull/42012 Improve documentation to current code, no template files anymore and some more precision how MD files are used. related: #41886 -- This is an automated message from the Apache Git Ser

Re: [PR] Add callback to process Azure Service Bus message contents [airflow]

2024-09-04 Thread via GitHub
perry2of5 commented on code in PR #41601: URL: https://github.com/apache/airflow/pull/41601#discussion_r1744584448 ## airflow/providers/microsoft/azure/hooks/asb.py: ## @@ -326,5 +342,32 @@ def receive_subscription_message( max_message_count=max_message_count,

Re: [PR] Refactor new UI Nav [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on PR #42009: URL: https://github.com/apache/airflow/pull/42009#issuecomment-2330259584 > Very nice! > > I see you decided to drop the tags and owner from the default view but choose to have description. I think tags and owner are better to display first and descri

Re: [PR] Add callback to process Azure Service Bus message contents [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41601: URL: https://github.com/apache/airflow/pull/41601#discussion_r1744565440 ## airflow/providers/microsoft/azure/hooks/asb.py: ## @@ -326,5 +342,32 @@ def receive_subscription_message( max_message_count=max_message_count, max

Re: [PR] Exclude google-cloud-spanner 3.49.0 [airflow]

2024-09-04 Thread via GitHub
potiuk merged PR #42011: URL: https://github.com/apache/airflow/pull/42011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (995eea8222 -> c5aeeff412)

2024-09-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 995eea8222 Add codeowners for new UI (#42010) add c5aeeff412 bugfix/livy-set-base-url (#41658) No new revisions w

Re: [PR] bugfix/livy-set-base-url [airflow]

2024-09-04 Thread via GitHub
boring-cyborg[bot] commented on PR #41658: URL: https://github.com/apache/airflow/pull/41658#issuecomment-2330208208 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

(airflow) branch main updated: Add codeowners for new UI (#42010)

2024-09-04 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 995eea8222 Add codeowners for new UI (#42010) 995

Re: [PR] Add codeowners for new UI [airflow]

2024-09-04 Thread via GitHub
bbovenzi merged PR #42010: URL: https://github.com/apache/airflow/pull/42010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Remove state sync during celery task processing [airflow]

2024-09-04 Thread via GitHub
Kytha commented on PR #41870: URL: https://github.com/apache/airflow/pull/41870#issuecomment-2330190525 >here is also a possible pool configuration, so celery backend can use pooling. As you mentioned NullPool is used only when process is not forked. But what does it mean that process i

Re: [PR] bugfix/livy-set-base-url [airflow]

2024-09-04 Thread via GitHub
harryshi10 commented on PR #41658: URL: https://github.com/apache/airflow/pull/41658#issuecomment-2330185586 UT added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] add argument to python operator, test code of it [airflow]

2024-09-04 Thread via GitHub
Prab-27 commented on code in PR #42007: URL: https://github.com/apache/airflow/pull/42007#discussion_r1744450342 ## tests/operators/test_python.py: ## @@ -374,6 +374,17 @@ def test_custom_logger_name_can_be_empty_string(self): python_operator = PythonOperator(task_id="t

Re: [PR] add argument to python operator, test code of it [airflow]

2024-09-04 Thread via GitHub
Prab-27 commented on code in PR #42007: URL: https://github.com/apache/airflow/pull/42007#discussion_r1744427556 ## tests/operators/test_python.py: ## @@ -374,6 +374,17 @@ def test_custom_logger_name_can_be_empty_string(self): python_operator = PythonOperator(task_id="t

Re: [PR] add argument to python operator, test code of it [airflow]

2024-09-04 Thread via GitHub
Prab-27 commented on code in PR #42007: URL: https://github.com/apache/airflow/pull/42007#discussion_r1744410915 ## tests/operators/test_python.py: ## @@ -374,6 +374,17 @@ def test_custom_logger_name_can_be_empty_string(self): python_operator = PythonOperator(task_id="t

Re: [PR] add argument to python operator, test code of it [airflow]

2024-09-04 Thread via GitHub
Prab-27 commented on code in PR #42007: URL: https://github.com/apache/airflow/pull/42007#discussion_r1744410915 ## tests/operators/test_python.py: ## @@ -374,6 +374,17 @@ def test_custom_logger_name_can_be_empty_string(self): python_operator = PythonOperator(task_id="t

Re: [PR] Automate exclusion of providers in lowest-dependency tests [airflow]

2024-09-04 Thread via GitHub
potiuk merged PR #41991: URL: https://github.com/apache/airflow/pull/41991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] Add `execute_tasks_new_python_interpreter` argument to `PythonOperator` [airflow]

2024-09-04 Thread via GitHub
Prab-27 commented on issue #41093: URL: https://github.com/apache/airflow/issues/41093#issuecomment-2329917357 @potiuk I have updated description I think it would solve your query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Add callback to process Azure Service Bus message contents [airflow]

2024-09-04 Thread via GitHub
perry2of5 commented on PR #41601: URL: https://github.com/apache/airflow/pull/41601#issuecomment-2329917131 This is ready to be reviewed again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Metrics basic deprecated validators removed in favor of pattern matching [airflow]

2024-09-04 Thread via GitHub
ferruzzi commented on code in PR #41975: URL: https://github.com/apache/airflow/pull/41975#discussion_r1744336098 ## airflow/metrics/validators.py: ## @@ -118,7 +107,7 @@ def get_validator() -> ListValidator: else: list_type = DEFAULT_VALIDATOR_TYPE -return v

Re: [PR] add argument to python operator, test code of it [airflow]

2024-09-04 Thread via GitHub
potiuk commented on PR #42007: URL: https://github.com/apache/airflow/pull/42007#issuecomment-2329713631 Closing it actually - unless I am entirely wrong and someone will show how it can work. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Metrics basic deprecated validators removed in favor of pattern matching [airflow]

2024-09-04 Thread via GitHub
ferruzzi commented on code in PR #41975: URL: https://github.com/apache/airflow/pull/41975#discussion_r1744224602 ## airflow/metrics/validators.py: ## @@ -118,7 +107,7 @@ def get_validator() -> ListValidator: else: list_type = DEFAULT_VALIDATOR_TYPE -return v

Re: [PR] Kubernetes Pod Operator: check pod completion reason if completed during deffered logging interval [airflow]

2024-09-04 Thread via GitHub
johnhoran commented on code in PR #41868: URL: https://github.com/apache/airflow/pull/41868#discussion_r1744217262 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -745,6 +746,7 @@ def trigger_reentry(self, context: Context, event: dict[str, Any]) -> Any: g

[PR] add argument to python operator, test code of it [airflow]

2024-09-04 Thread via GitHub
Prab-27 opened a new pull request, #42007: URL: https://github.com/apache/airflow/pull/42007 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pu

Re: [I] can't see run config on dag_run [airflow]

2024-09-04 Thread via GitHub
jscheffl commented on issue #41787: URL: https://github.com/apache/airflow/issues/41787#issuecomment-2329567950 @raphaelauv Agree with Brent. As developers we'd like to focus on the next level UI and fixing the scroll pane issues might be very effort-consuming. In most cases it depends also

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-09-04 Thread via GitHub
jscheffl commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2329570708 > > Some static checks fail. Though I like the implementation a lot more than before... actually as project team we have decided (1) that Airflow 2.10 will only get new features in exc

Re: [I] StaleDataError when running DAG with dynamic task mapping [airflow]

2024-09-04 Thread via GitHub
boring-cyborg[bot] commented on issue #42006: URL: https://github.com/apache/airflow/issues/42006#issuecomment-2329562898 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

(airflow) branch main updated (d5467d6818 -> 7650f09d56)

2024-09-04 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from d5467d6818 Fix issue generation failing after deleting a PR (#42001) add 7650f09d56 Implement pagination for the

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744115305 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -const ur

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
utkarsharma2 commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744093827 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -co

Re: [PR] Kubernetes Pod Operator: check pod completion reason if completed during deffered logging interval [airflow]

2024-09-04 Thread via GitHub
dstandish commented on code in PR #41868: URL: https://github.com/apache/airflow/pull/41868#discussion_r1744085339 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -745,6 +746,7 @@ def trigger_reentry(self, context: Context, event: dict[str, Any]) -> Any: g

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744074896 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -const ur

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
utkarsharma2 commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744075302 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -co

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744074896 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -const ur

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744050012 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -const

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744045430 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -const ur

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744040814 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -const ur

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744040814 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,15 @@ const ExtraLinks = ({ if (!url) { return true; } -const ur

Re: [PR] Implement on_killed support for tasks during DAG run timeout [airflow]

2024-09-04 Thread via GitHub
MRLab12 closed pull request #42002: Implement on_killed support for tasks during DAG run timeout URL: https://github.com/apache/airflow/pull/42002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Implement on_killed support for tasks during DAG run timeout [airflow]

2024-09-04 Thread via GitHub
MRLab12 opened a new pull request, #42002: URL: https://github.com/apache/airflow/pull/42002 --- *This is a new PR to fix an issue with the Tests workflow (old [PR](https://github.com/apache/airflow/pull/41627)) This PR addresses issue #41036 by addi

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
utkarsharma2 commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1744019178 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,27 @@ const ExtraLinks = ({ if (!url) { return true; } -co

(airflow) branch main updated (bfbff66a20 -> d5467d6818)

2024-09-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from bfbff66a20 validate aws service exceptions in waiters (#41941) add d5467d6818 Fix issue generation failing after d

Re: [PR] Fix issue generation failing after deleting a PR [airflow]

2024-09-04 Thread via GitHub
potiuk merged PR #42001: URL: https://github.com/apache/airflow/pull/42001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Kubernetes Pod Operator: check pod completion reason if completed during deffered logging interval [airflow]

2024-09-04 Thread via GitHub
johnhoran commented on code in PR #41868: URL: https://github.com/apache/airflow/pull/41868#discussion_r1744005392 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -787,9 +774,27 @@ def trigger_reentry(self, context: Context, event: dict[str, Any]) -> Any:

Re: [PR] Support multiline input for Params of type string in trigger UI form [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on PR #40414: URL: https://github.com/apache/airflow/pull/40414#issuecomment-2329358130 > Some static checks fail. Though I like the implementation a lot more than before... actually as project team we have decided (1) that Airflow 2.10 will only get new features in excep

Re: [PR] Kubernetes Pod Operator: check pod completion reason if completed during deffered logging interval [airflow]

2024-09-04 Thread via GitHub
johnhoran commented on code in PR #41868: URL: https://github.com/apache/airflow/pull/41868#discussion_r1743998709 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -391,9 +391,7 @@ def __init__( self.skip_on_exit_code = ( skip_on_exit_code

Re: [I] StepFunctionStartExecutionOperator in MWAA does not throw error if IAM Role does not DescribeExecution permission [airflow]

2024-09-04 Thread via GitHub
vincbeck closed issue #41918: StepFunctionStartExecutionOperator in MWAA does not throw error if IAM Role does not DescribeExecution permission URL: https://github.com/apache/airflow/issues/41918 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] Remove StatsD and replace it with Open Telemetry as first-class citizen [airflow]

2024-09-04 Thread via GitHub
howardyoo commented on issue #40800: URL: https://github.com/apache/airflow/issues/40800#issuecomment-2329349065 > Will StatsD support be dropped with AF 3 or will OTEL become primary for AF 3 with StatsD as an alternative/backup for N versions to ensure there is a smooth and safe migration

Re: [PR] Validate aws service exceptions in waiters [airflow]

2024-09-04 Thread via GitHub
vincbeck merged PR #41941: URL: https://github.com/apache/airflow/pull/41941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] ONNX Model Inference Operator [airflow]

2024-09-04 Thread via GitHub
Rohanberiwal commented on issue #41702: URL: https://github.com/apache/airflow/issues/41702#issuecomment-2329350066 Sir I would like to know more about the official process of gertting accpeted and work for the airflow , I have made the solution and read the protocal but where shoudl I hav

Re: [I] Remove StatsD and replace it with Open Telemetry as first-class citizen [airflow]

2024-09-04 Thread via GitHub
chomipi88 commented on issue #40800: URL: https://github.com/apache/airflow/issues/40800#issuecomment-2329344880 Will StatsD support be dropped with AF 3 or will OTEL become primary for AF 3 with StatsD as an alternative/backup for N versions to ensure there is a smooth and safe migration p

Re: [I] ONNX Model Inference Operator [airflow]

2024-09-04 Thread via GitHub
Rohanberiwal commented on issue #41702: URL: https://github.com/apache/airflow/issues/41702#issuecomment-2329345801 # ONNX Inference Operator for Apache Airflow ## Description The `ONNXInferenceOperator` is a custom operator designed for running inference using ONNX models with

Re: [PR] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on code in PR #41905: URL: https://github.com/apache/airflow/pull/41905#discussion_r1743972851 ## airflow/ui/src/dagsList.tsx: ## @@ -84,23 +89,100 @@ const columns: ColumnDef[] = [ type TableProps = { data: TData[]; + total: number | undefined; colu

Re: [PR] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
tirkarthi commented on code in PR #41905: URL: https://github.com/apache/airflow/pull/41905#discussion_r1743970885 ## airflow/ui/src/dagsList.tsx: ## @@ -84,23 +89,100 @@ const columns: ColumnDef[] = [ type TableProps = { data: TData[]; + total: number | undefined; col

Re: [PR] Fix issue generation failing after deleting a PR [airflow]

2024-09-04 Thread via GitHub
potiuk commented on PR #42001: URL: https://github.com/apache/airflow/pull/42001#issuecomment-2329310462 Nothing suspicious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on code in PR #41905: URL: https://github.com/apache/airflow/pull/41905#discussion_r1743965474 ## airflow/ui/src/dagsList.tsx: ## @@ -84,23 +89,100 @@ const columns: ColumnDef[] = [ type TableProps = { data: TData[]; + total: number | undefined; colu

Re: [PR] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on code in PR #41905: URL: https://github.com/apache/airflow/pull/41905#discussion_r1743964581 ## airflow/ui/src/dagsList.tsx: ## @@ -84,23 +89,100 @@ const columns: ColumnDef[] = [ type TableProps = { data: TData[]; + total: number | undefined; colu

Re: [PR] Fix issue generation failing after deleting a PR [airflow]

2024-09-04 Thread via GitHub
potiuk commented on PR #42001: URL: https://github.com/apache/airflow/pull/42001#issuecomment-2329302919 > Thanks @potiuk . This seems to block the ci for a while Yeah - see slack. Looks like the PR in question is `gone` - same as the contributor who created it. I will take a close lo

Re: [PR] Fix issue generation failing after deleting a PR [airflow]

2024-09-04 Thread via GitHub
Lee-W commented on PR #42001: URL: https://github.com/apache/airflow/pull/42001#issuecomment-2329296732 Thanks @potiuk . This seems to block the ci for a while -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

(airflow) branch main updated: Update UI contributing docs (#41903)

2024-09-04 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5fbfe4cfd1 Update UI contributing docs (#41903) 5

Re: [PR] Update UI contributing docs [airflow]

2024-09-04 Thread via GitHub
bbovenzi merged PR #41903: URL: https://github.com/apache/airflow/pull/41903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] Status of testing of Apache Airflow 2.10.1rc1 [airflow]

2024-09-04 Thread via GitHub
tirkarthi commented on issue #41956: URL: https://github.com/apache/airflow/issues/41956#issuecomment-2329272955 Thanks @Lee-W for the backport, it's working fine as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Move `register_views` to auth manager interface [airflow]

2024-09-04 Thread via GitHub
vincbeck merged PR #41777: URL: https://github.com/apache/airflow/pull/41777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
potiuk commented on PR #41995: URL: https://github.com/apache/airflow/pull/41995#issuecomment-2329221409 Not sure if we have some tests for this one ? @pierrejeambrun @bbovenzi ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Handle relative paths when sanitizing URLs [airflow]

2024-09-04 Thread via GitHub
potiuk commented on code in PR #41995: URL: https://github.com/apache/airflow/pull/41995#discussion_r1743910036 ## airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx: ## @@ -57,8 +57,27 @@ const ExtraLinks = ({ if (!url) { return true; } -const ur

Re: [PR] fix: dag_run_dag_id_execution_date_key [airflow]

2024-09-04 Thread via GitHub
raphaelauv commented on PR #38179: URL: https://github.com/apache/airflow/pull/38179#issuecomment-2329163069 https://github.com/apache/airflow/pull/41818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP] Implement pagination for the new home page. [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on PR #41905: URL: https://github.com/apache/airflow/pull/41905#issuecomment-2329167039 > > We should use the new ui_api to pass config values through the user object or a /config endpoint. > > I made a simple grep in the repo and couldn't find something related to

Re: [I] constraint "dag_run_dag_id_execution_date_key" not using run_id [airflow]

2024-09-04 Thread via GitHub
raphaelauv commented on issue #38176: URL: https://github.com/apache/airflow/issues/38176#issuecomment-2329162110 https://github.com/apache/airflow/pull/41818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] UI API Add views tests [airflow]

2024-09-04 Thread via GitHub
bbovenzi commented on PR #41957: URL: https://github.com/apache/airflow/pull/41957#issuecomment-2329124923 @bugraoz93 I just started a thread in the dev list too. Trying to get the old UI to use the new rest API will create a lot of work for us that we will just have to delete soon, especia

Re: [PR] Automate exclusion of providers in lowest-dependency tests [airflow]

2024-09-04 Thread via GitHub
topherinternational commented on PR #41991: URL: https://github.com/apache/airflow/pull/41991#issuecomment-2329089473 > > I think the followup to #41967 I am writing will also address this problem. > > We can compare and choose better one :) Or we can have defense in depth :D

Re: [PR] Drop execution_date unique constraint on DagRun [airflow]

2024-09-04 Thread via GitHub
uranusjr merged PR #41818: URL: https://github.com/apache/airflow/pull/41818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] Triggered DAG button looks like disabled with TriggerDagRunOperator [airflow]

2024-09-04 Thread via GitHub
utkarsharma2 commented on issue #41977: URL: https://github.com/apache/airflow/issues/41977#issuecomment-2329052999 > Just to add I am still able to use the button and it works. It just looks like disabled. Doesn't look like a blocker. @potiuk @amoghrajesh Kinda defeats the purpose o

Re: [PR] Automate exclusion of providers in lowest-dependency tests [airflow]

2024-09-04 Thread via GitHub
potiuk commented on PR #41991: URL: https://github.com/apache/airflow/pull/41991#issuecomment-2328972185 Actually this one also solves "main" failures of Python 3.12 "Lowest dependencies" tests that I've seen recently! -- This is an automated message from the Apache Git Service. To respon

Re: [PR] fix: rm `skip_if` and `run_if` in python source [airflow]

2024-09-04 Thread via GitHub
phi-friday commented on code in PR #41832: URL: https://github.com/apache/airflow/pull/41832#discussion_r1743671153 ## tests/utils/test_decorators.py: ## @@ -0,0 +1,156 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

Re: [PR] Revert "Adding url sanitisation for extra links" [airflow]

2024-09-04 Thread via GitHub
potiuk commented on PR #41993: URL: https://github.com/apache/airflow/pull/41993#issuecomment-2328804370 > > I think we should fix it, not revert > > Also, I think we shouldn't have rc2 because of this. WDYT? Agreed, -- This is an automated message from the Apache Git Service

Re: [PR] Revert "Adding url sanitisation for extra links" [airflow]

2024-09-04 Thread via GitHub
ephraimbuddy commented on PR #41993: URL: https://github.com/apache/airflow/pull/41993#issuecomment-2328769213 > I think we should fix it, not revert Also, I think we shouldn't have rc2 because of this. WDYT? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Automate exclusion of providers in lowest-dependency tests [airflow]

2024-09-04 Thread via GitHub
topherinternational commented on PR #41991: URL: https://github.com/apache/airflow/pull/41991#issuecomment-2328761652 I think the followup to #41967 I am writing will also address this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] Triggered DAG button looks like disabled with TriggerDagRunOperator [airflow]

2024-09-04 Thread via GitHub
vatsrahul1001 commented on issue #41977: URL: https://github.com/apache/airflow/issues/41977#issuecomment-2328755939 Just to add I am still able to use the button and it works. It just looks like disabled. Doesn't look like a blocker. -- This is an automated message from the Apache Git Se

[I] airflow-scheduler deadlock and crash [airflow]

2024-09-04 Thread via GitHub
zchunhai opened a new issue, #41992: URL: https://github.com/apache/airflow/issues/41992 ### Apache Airflow version 2.10.0 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? [2024-09-04T16:08:33.735+0800] {kubernetes_execu

Re: [I] airflow-scheduler deadlock and crash [airflow]

2024-09-04 Thread via GitHub
boring-cyborg[bot] commented on issue #41992: URL: https://github.com/apache/airflow/issues/41992#issuecomment-2328665126 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[PR] Automate exclusion of providers in lowest-dependency tests [airflow]

2024-09-04 Thread via GitHub
potiuk opened a new pull request, #41991: URL: https://github.com/apache/airflow/pull/41991 The "lowest" dependency tests had "hard-coded" exclusion for those providers that were excluded in specific python versions. This change automates it: * selective checks produce dictiona

Re: [PR] Switch cloudant provider from cloudant library to ibmcloudant library [airflow]

2024-09-04 Thread via GitHub
potiuk commented on PR #41555: URL: https://github.com/apache/airflow/pull/41555#issuecomment-2328558624 This one should fix it https://github.com/apache/airflow/pull/41991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

  1   2   >