GuidoTournois opened a new issue #18771:
URL: https://github.com/apache/airflow/issues/18771


   ### Apache Airflow Provider(s)
   
   pagerduty
   
   ### Versions of Apache Airflow Providers
   
   apache-airflow-providers-pagerduty==2.0.1
   
   ### Apache Airflow version
   
   2.1.4 (latest released)
   
   ### Operating System
   
   macOS catalina
   
   ### Deployment
   
   Virtualenv installation
   
   ### Deployment details
   
   _No response_
   
   ### What happened
   
   Currently, the PagerdutyHook has two attributes referring to the same 
integration key: `routing_key` and `token`.
   
   - `routing_key`: This attribute is retrieved from the `Extra` field and is 
used to perform the actual post request to the Pagerduty Endpoint. In the 
`create_event` the value is asserted to be not `None`.
   - `token`:  This attribute is retrieved from the `Password` field or can be 
set at initialization of a class instance by passing it into the init method of 
the class.  In the __Init__ method, its value is asserted to be not `None`. The 
token is **not used** for sending alerts to Pagerduty.
   
   As a result, the Integration key needs to set in both password and the extra 
field. This to me makes no sense at all. I would expect that I need to set the 
token only once in the Add connection form.
   
   Also, it makes the code unnecessarily complex.
   
   ### What you expected to happen
   
   _No response_
   
   ### How to reproduce
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to