JavierLopezT opened a new pull request #17448:
URL: https://github.com/apache/airflow/pull/17448


   One of the main advantages of using AWS Secrets Manager is its ability to 
automatically create secrets of RDS databases and Redshift databases. Those 
secrets consist of several keys with their values, i.e user, pass, etc. Also, 
it is normal to store API Keys, sftp, or whatever using different values, as 
shown in the picture below:
   ![Captura de pantalla 2020-05-22 a las 10 41 
07](https://user-images.githubusercontent.com/11339132/82648933-c23ac100-9c18-11ea-9f7c-6a36d0333bbe.png)
   
   With the current code, all the keys and values obtained from a secret are 
stored in the schema attribute of the conn object, unless you have just one key 
with the conn_uri in the value. Thus, the current situation is forcing to use 
Secrets Manager in a way it is not intended to.
   
   With this proposed modification, you can use AWS Secrets Manager using keys 
and values and have some kind of freedom to choose different words for each key 
to make the get_conn work.
   
   Third attempt. Coming from here: https://github.com/apache/airflow/pull/15104
   @xinbinhuang I have tried to implement all your suggestions (thanks!) but 
regarding https://github.com/apache/airflow/pull/15104#discussion_r606090823 I 
received an error that Connection could not be imported. Maybe it is because I 
am using the secrets backend replacing the original file with a COPY in the 
Dockerfile, I dunno
   @ dstandish Regarding 
https://github.com/apache/airflow/pull/15104#issuecomment-812596462, I like 
your suggestion but I would rather keep the code as it is now. It's been a 
while since my first pull request for this (more than a year 
https://github.com/apache/airflow/pull/9008) and I want to have it merge ASAP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to