[GitHub] [airflow] Jorricks commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-01 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-890525699 Rebased on latest main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] Jorricks commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-901830794 > I feel we should not make this change but dig more to reliably reproduce the linked issue. > On my first try, I was able to see `Scheduler marked as failed` but on sever

[GitHub] [airflow] Jorricks commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-20 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-903019652 @ephraimbuddy please make sure you are using a form of a Celery Executor, as this ticket is only for celery setups. -- This is an automated message from the Apache Git Serv

[GitHub] [airflow] Jorricks commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-23 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-904077786 I tried to add some tests on the CLI task part. That is pretty much done. However, I had quite some trouble wrapping my head around a decent test approach on the `celery_ex

[GitHub] [airflow] Jorricks commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-07-25 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-886190622 The other idea: > After every manually triggered task, we read the event_buffer and store that in the task instances. Would look something like adding this to the `d