[GitHub] [airflow] Owen-CH-Leung commented on a diff in pull request #32781: Override base log folder by using task handler's base_log_folder

2023-07-24 Thread via GitHub
Owen-CH-Leung commented on code in PR #32781: URL: https://github.com/apache/airflow/pull/32781#discussion_r1272198290 ## tests/utils/test_serve_logs.py: ## @@ -22,7 +22,9 @@ import jwt import pytest import time_machine +from py import path Review Comment: Thanks. I've us

[GitHub] [airflow] Owen-CH-Leung commented on a diff in pull request #32781: Override base log folder by using task handler's base_log_folder

2023-07-23 Thread via GitHub
Owen-CH-Leung commented on code in PR #32781: URL: https://github.com/apache/airflow/pull/32781#discussion_r1271766095 ## airflow/utils/serve_logs.py: ## @@ -44,28 +45,28 @@ def create_app(): flask_app = Flask(__name__, static_folder=None) expiration_time_in_seconds =

[GitHub] [airflow] Owen-CH-Leung commented on a diff in pull request #32781: Override base log folder by using task handler's base_log_folder

2023-07-23 Thread via GitHub
Owen-CH-Leung commented on code in PR #32781: URL: https://github.com/apache/airflow/pull/32781#discussion_r1271697052 ## airflow/utils/serve_logs.py: ## @@ -44,7 +44,31 @@ def create_app(): flask_app = Flask(__name__, static_folder=None) expiration_time_in_seconds = c