[GitHub] [airflow] SamWheating commented on pull request #12822: Removing redundant calls to session.commit()

2021-04-16 Thread GitBox
SamWheating commented on pull request #12822: URL: https://github.com/apache/airflow/pull/12822#issuecomment-821091046 I'm on it - sorry for taking so long, this one keeps falling of my radar somehow. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] SamWheating commented on pull request #12822: Removing redundant calls to session.commit()

2021-03-01 Thread GitBox
SamWheating commented on pull request #12822: URL: https://github.com/apache/airflow/pull/12822#issuecomment-787978445 My bad - I forgot about this PR over the holidays. I can rebase and fix this up in the next few days as the issue is still open.

[GitHub] [airflow] SamWheating commented on pull request #12822: Removing redundant calls to session.commit()

2020-12-09 Thread GitBox
SamWheating commented on pull request #12822: URL: https://github.com/apache/airflow/pull/12822#issuecomment-742099715 > We might need session.flush() at few places. This is because the wrapper does not commit if the session is passed to the function. Having re-read `airflow/utils/se