SamWheating edited a comment on pull request #18924:
URL: https://github.com/apache/airflow/pull/18924#issuecomment-945999217


   I agree that `dag_id_ilike` isn't great because it results in using database 
syntax in an API request, which means users may expect this endpoint to support 
other SQL terms like `order_by` etc.
   
   I think that `dag_id_contains` isn't quite accurate because it doesn't say 
anything about using wildcards within the string.
   
   Therefore I think that `dag_id_pattern` is a good choice for now, and we can 
using a similar parameter name if we ever need to add primary key filters onto 
other API endpoints.
   
   Updated + rebased, so this should be ready for review. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to