[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-898763140 > @Sonins, congrats on your first commit! Thanks for the fix Thanks for your help. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-898034985 Thanks for your suggest, @jedcunningham. Static-check failure is because of formatting problem. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-896918356 I think CI has an issue right now. All `Build image` phases are now pending, including other PRs. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-896394743 I added simple username and password. Here's test result.

[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-895740341 > Yeah, we should change it to 9200. Cool. I think new issue for that will be necessary later. Or is there any necessary change for this? -- This is an automated

[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 OK. I wrote new test coverage. Here's my local test result. with original template ``` ``` -- This is an automated message from the Apache Git

[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894733668 OK. I misunderstood badly. I will commit new test function as soon as i finished. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function

Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-893932430 Thank you for your review @jedcunningham . I did the unit test using pytest in breeze environment, but I don't know how to attach the result to this PR in fancy style.