[GitHub] [airflow] Taragolis commented on pull request #27947: refactored Amazon Redshift-data functionality into the hook

2023-01-25 Thread via GitHub
Taragolis commented on PR #27947: URL: https://github.com/apache/airflow/pull/27947#issuecomment-1404455178 Thin `boto3` client wrapper it is a Hook based on AwsBaseHook without extending positional and key-word arguments created. IMHO and personal thought: "The last think that we wa

[GitHub] [airflow] Taragolis commented on pull request #27947: refactored Amazon Redshift-data functionality into the hook

2023-01-25 Thread via GitHub
Taragolis commented on PR #27947: URL: https://github.com/apache/airflow/pull/27947#issuecomment-1404065857 > Also, a downside of this is that a single hook instance can only be used for a single redshift destination. Not a problem at all, it is how it intends to use, Single Operator

[GitHub] [airflow] Taragolis commented on pull request #27947: refactored Amazon Redshift-data functionality into the hook

2022-11-30 Thread GitBox
Taragolis commented on PR #27947: URL: https://github.com/apache/airflow/pull/27947#issuecomment-1332727578 For avoid any further regression error I would suggest move tests this methods from operator `tests/providers/amazon/aws/operators/test_redshift_data.py` to hook `tests/providers/ama