[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests

2023-01-09 Thread GitBox
Taragolis commented on PR #28767: URL: https://github.com/apache/airflow/pull/28767#issuecomment-1376037991 Yeah, let me revert quarantined mark for this test. I just think about what we tried to test here: 1. Is on_retry_callback actually called or 2. Is task retried, e.g. ch

[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests

2023-01-09 Thread GitBox
Taragolis commented on PR #28767: URL: https://github.com/apache/airflow/pull/28767#issuecomment-1375630674 And ... this test failed again 😞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests

2023-01-08 Thread GitBox
Taragolis commented on PR #28767: URL: https://github.com/apache/airflow/pull/28767#issuecomment-1374830419 I can't reproduce this error locally but I have an idea what could possible wrong Potentially callback might acquire lock https://github.com/apache/airflow/blob/ce677862be4a

[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests

2023-01-08 Thread GitBox
Taragolis commented on PR #28767: URL: https://github.com/apache/airflow/pull/28767#issuecomment-1374756956 @potiuk I hope it just flaky test and not something wrong with callback mechanism. Let keep it for a while and have a look how often it failed - just for some statistic, I will exc