[GitHub] [airflow] Taragolis commented on pull request #29142: Decrypt SecureString value obtained by SsmHook

2023-02-02 Thread via GitHub
Taragolis commented on PR #29142: URL: https://github.com/apache/airflow/pull/29142#issuecomment-1413363531 @o-nikolas if you have a time could you also have a look (you have a binding approval power) and maybe we could merge it -- This is an automated message from the Apache Git

[GitHub] [airflow] Taragolis commented on pull request #29142: Decrypt SecureString value obtained by SsmHook

2023-01-24 Thread via GitHub
Taragolis commented on PR #29142: URL: https://github.com/apache/airflow/pull/29142#issuecomment-1402786587 Since we cant be sure where it password and where it is not than better mask all. I will ad it tomorrow. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] Taragolis commented on pull request #29142: Decrypt SecureString value obtained by SsmHook

2023-01-24 Thread via GitHub
Taragolis commented on PR #29142: URL: https://github.com/apache/airflow/pull/29142#issuecomment-1402747883 > Nice catch! IMHO, if we are decoding by default then masking sounds like the right answer to me. I'm not really up to date on best practices when using SecureString though, so I'm