[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r510106178 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -496,17 +517,15 @@ def start_java_dataflow( variables['jobName'] = name

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r509343344 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -93,15 +94,30 @@ def inner_wrapper(self: "DataflowHook", *args, **kwargs) -> RT: cla

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r508460182 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -496,17 +517,15 @@ def start_java_dataflow( variables['jobName'] = name

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r508321399 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -783,6 +794,77 @@ def cancel_job( name=job_name, job_id=job_

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r508282889 ## File path: airflow/providers/google/cloud/operators/dataflow.py ## @@ -406,6 +406,88 @@ def on_kill(self) -> None: self.hook.cancel_job(job

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r508222533 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -694,29 +710,23 @@ def _build_dataflow_job_name(job_name: str, append_job_name: bool

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r508222123 ## File path: airflow/providers/google/cloud/operators/dataflow.py ## @@ -406,6 +406,88 @@ def on_kill(self) -> None: self.hook.cancel_job(job

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r508221739 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -496,17 +517,15 @@ def start_java_dataflow( variables['jobName'] = name

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r504574733 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -783,6 +794,77 @@ def cancel_job( name=job_name, job_id=job_

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r504573298 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -431,13 +448,17 @@ def _start_dataflow( variables: Dict, name: str,

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r501799152 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -783,6 +794,77 @@ def cancel_job( name=job_name, job_id=job_

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r501799152 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -783,6 +794,77 @@ def cancel_job( name=job_name, job_id=job_

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r501046939 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -783,6 +794,77 @@ def cancel_job( name=job_name, job_id=job_

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r501044662 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -783,6 +794,77 @@ def cancel_job( name=job_name, job_id=job_

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r497550417 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -93,15 +94,30 @@ def inner_wrapper(self: "DataflowHook", *args, **kwargs) -> RT: cla

[GitHub] [airflow] TobKed commented on a change in pull request #8553: Add DataflowStartSQLQuery operator

TobKed commented on a change in pull request #8553: URL: https://github.com/apache/airflow/pull/8553#discussion_r496513620 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -93,15 +94,30 @@ def inner_wrapper(self: "DataflowHook", *args, **kwargs) -> RT: cla