YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-689162322
> If anyone has any more suggestions or want to request changes, let's do it
in a follow-up PR.
>
> Thanks alot @YingboWang and apologies for the long wait.
Than
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-682195574
@kaxil I have rebased this PR. There are some pylint errors not related to
my change (on Module airflow.providers.google.cloud.hooks.cloud_sql)
-
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-681165680
> Static checks were failing, I have pushed
[ad5ada1](https://github.com/apache/airflow/commit/ad5ada1e2d116865c39374fd5f79f31005012a1b)
to fix it. Hope you don't mind
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-676715187
@kaxil I have made changes based on your comments. Please let me know if
there is still any other problem. Thanks again for reviewing this PR.
--
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-663673386
> @YingboWang would you mind adding documentation for this new feature?
@turbaszek Thank you for reviewing this PR. I just added a smart-sensor.rst
in docs. Please let
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-659618394
@ashb Thank you for your comments in AIP-17. I agree that it's a good idea
to leverage the smart sensor for more operators. I'm just wondering if you can
help take a look int
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-659587164
@BasPH Thank you for giving us feedback in an early stage. We have done a
lot of work on this smart sensor project since then. Would you like to take a
look at this PR again?
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-657890487
> > Would probly be helpful to include an architecture diagram for it. Since
a couple other folks are intereseted, maybe you can share a high level number
on the impact this
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-657839775
> @YingboWang is this PR ready to be reviewed/merged?
Thanks @ryw . This PR is ready to be reviewed.
YingboWang commented on pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#issuecomment-634854013
Thanks @KevinYang21 for the comment. This PR description was updated with a
high level architecture diagram and some charts for smart sensor impact after
being deployed.
10 matches
Mail list logo
