[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-04-01 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-607216008 @feluelle I have just marked the comments resolved again which I have solved, there are two things which I haven't done and have

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-603233128 @grjones I have almost resolved all change request,conflicts etc on this. Dont know if it can be merged now or not? @kaxil

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-03-24 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-603187906 Hello All, Except for the last changes pointed out by @feluelle I have resolved all problems. I am bit busy and not sure if I

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-27 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-591959953 @feluelle deleted 'tests/sensors/test_aws_glue_job_sensor.py' Not sure about how to exclude integration change, you asked to

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-27 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-591954863 @feluelle I have made all changes and have rebased, does it look okay now?

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-26 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-591699396 @feluelle I moved and deleted all files as per your comnet EXCEPT fo 'docs/integration.rst' as it is still in airflow [master

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-25 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-590883802 @feluelle I am not sure bout the old files in the contrib and docs, can you please elaborate more on which files needs to be

[GitHub] [airflow] abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration

2020-02-24 Thread GitBox
abdulbasitds commented on issue #6007: [AIRFLOW-2310] Enable AWS Glue Job Integration URL: https://github.com/apache/airflow/pull/6007#issuecomment-590549904 @feluelle I have done point 1 and 3, can you please verify if it was the change you asked? For point 2, I am not able to