aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r598725144
##
File path: tests/models/test_renderedtifields.py
##
@@ -172,7 +172,10 @@ def test_delete_old_records(self, rtif_num, num_to_keep,
remaining_rtif
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r598749733
##
File path: airflow/models/dagcode.py
##
@@ -147,7 +148,7 @@ def has_dag(cls, fileloc: str, session=None) -> bool:
:param session: ORM Se
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r598750010
##
File path:
airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py
##
@@ -43,9 +100,14 @@ def upgrade():
with op.batch_alter
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r598725144
##
File path: tests/models/test_renderedtifields.py
##
@@ -172,7 +172,10 @@ def test_delete_old_records(self, rtif_num, num_to_keep,
remaining_rtif
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r598923981
##
File path: airflow/jobs/scheduler_job.py
##
@@ -1585,15 +1586,16 @@ def _create_dag_runs(self, dag_models:
Iterable[DagModel], session: Session)
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r598750010
##
File path:
airflow/migrations/versions/bbf4a7ad0465_remove_id_column_from_xcom.py
##
@@ -43,9 +100,14 @@ def upgrade():
with op.batch_alter
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r599194680
##
File path: airflow/models/dagcode.py
##
@@ -147,7 +148,7 @@ def has_dag(cls, fileloc: str, session=None) -> bool:
:param session: ORM Se
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r611186097
##
File path:
airflow/migrations/versions/5ccc55a461b1_make_mssql_tables_in_sync_with_sqla_.py
##
@@ -0,0 +1,111 @@
+#
+# Licensed to the Apache So
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r611188371
##
File path:
airflow/migrations/versions/83f031fd9f1c_change_ts_columns_to_datetime_on_mssql.py
##
@@ -0,0 +1,185 @@
+#
+# Licensed to the Apache
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r611188583
##
File path:
airflow/migrations/versions/83f031fd9f1c_change_ts_columns_to_datetime_on_mssql.py
##
@@ -0,0 +1,185 @@
+#
+# Licensed to the Apache
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614315995
##
File path: airflow/models/serialized_dag.py
##
@@ -114,14 +114,17 @@ def write_dag(cls, dag: DAG, min_update_interval:
Optional[int] = None, ses
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614338049
##
File path: tests/models/test_taskinstance.py
##
@@ -2109,8 +2116,12 @@ def test_execute_queries_count_store_serialized(self):
ru
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614337946
##
File path: tests/models/test_renderedtifields.py
##
@@ -172,7 +172,11 @@ def test_delete_old_records(self, rtif_num, num_to_keep,
remaining_rtif
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614338163
##
File path: tests/models/test_taskinstance.py
##
@@ -2091,8 +2091,15 @@ def test_execute_queries_count(self,
expected_query_count, mark_success):
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614367500
##
File path: airflow/www/security.py
##
@@ -347,19 +347,23 @@ def can_read_dag(self, dag_id, user=None) -> bool:
if not user:
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614367500
##
File path: airflow/www/security.py
##
@@ -347,19 +347,23 @@ def can_read_dag(self, dag_id, user=None) -> bool:
if not user:
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614367500
##
File path: airflow/www/security.py
##
@@ -347,19 +347,23 @@ def can_read_dag(self, dag_id, user=None) -> bool:
if not user:
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614906460
##
File path: airflow/www/security.py
##
@@ -347,19 +347,23 @@ def can_read_dag(self, dag_id, user=None) -> bool:
if not user:
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r628834270
##
File path:
airflow/migrations/versions/83f031fd9f1c_change_ts_columns_to_datetime_on_mssql.py
##
@@ -0,0 +1,181 @@
+#
+# Licensed to the Apache
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r628834279
##
File path:
airflow/migrations/versions/98271e7606e2_add_scheduling_decision_to_dagrun_and_.py
##
@@ -35,12 +35,32 @@
depends_on = None
+def
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r628834339
##
File path:
airflow/migrations/versions/e9304a3141f0_make_xcom_pkey_columns_non_nullable.py
##
@@ -0,0 +1,76 @@
+#
+# Licensed to the Apache Soft
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r628834607
##
File path: airflow/models/dagcode.py
##
@@ -147,7 +148,7 @@ def has_dag(cls, fileloc: str, session=None) -> bool:
:param session: ORM Se
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r628835005
##
File path: airflow/models/dagcode.py
##
@@ -147,7 +148,7 @@ def has_dag(cls, fileloc: str, session=None) -> bool:
:param session: ORM Se
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r628835005
##
File path: airflow/models/dagcode.py
##
@@ -147,7 +148,7 @@ def has_dag(cls, fileloc: str, session=None) -> bool:
:param session: ORM Se
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r628912980
##
File path: scripts/ci/selective_ci_checks.sh
##
@@ -117,6 +127,7 @@ function output_all_basic_variables() {
if [[ ${FULL_TESTS_NEEDED_LABEL}
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r629380571
##
File path: airflow/www/security.py
##
@@ -348,19 +348,21 @@ def can_read_dag(self, dag_id, user=None) -> bool:
if not user:
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r629415571
##
File path: airflow/sensors/smart_sensor.py
##
@@ -391,13 +391,21 @@ def _update_ti_hostname(self, sensor_works, session=None):
:param se
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r629416272
##
File path:
airflow/migrations/versions/83f031fd9f1c_improve_mssql_compatibility.py
##
@@ -0,0 +1,262 @@
+#
+# Licensed to the Apache Software Fo
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r629543337
##
File path: airflow/www/security.py
##
@@ -347,19 +347,23 @@ def can_read_dag(self, dag_id, user=None) -> bool:
if not user:
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r630008838
##
File path: airflow/models/serialized_dag.py
##
@@ -114,14 +114,17 @@ def write_dag(cls, dag: DAG, min_update_interval:
Optional[int] = None, ses
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r469986489
##
File path:
airflow/migrations/versions/83f031fd9f1c_change_ts_columns_to_datetime_on_mssql.py
##
@@ -0,0 +1,200 @@
+#
+# Licensed to the Apache
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r460056076
##
File path: Dockerfile.ci
##
@@ -309,6 +322,8 @@ RUN if [[ -n "${ADDITIONAL_PYTHON_DEPS}" ]]; then \
pip install ${ADDITIONAL_PYTHON_DEPS
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r460068470
##
File path: Dockerfile.ci
##
@@ -309,6 +322,8 @@ RUN if [[ -n "${ADDITIONAL_PYTHON_DEPS}" ]]; then \
pip install ${ADDITIONAL_PYTHON_DEPS
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r460056076
##
File path: Dockerfile.ci
##
@@ -309,6 +322,8 @@ RUN if [[ -n "${ADDITIONAL_PYTHON_DEPS}" ]]; then \
pip install ${ADDITIONAL_PYTHON_DEPS
aneesh-joseph commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r460196799
##
File path: Dockerfile.ci
##
@@ -309,6 +322,8 @@ RUN if [[ -n "${ADDITIONAL_PYTHON_DEPS}" ]]; then \
pip install ${ADDITIONAL_PYTHON_DEPS
35 matches
Mail list logo