[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533733027 ## File path: .dockerignore ## @@ -60,8 +60,9 @@ !.github !empty -# This folder is for you if you want to add any files to the docker context when you

[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533733644 ## File path: .github/workflows/build-images-workflow-run.yml ## @@ -336,7 +336,8 @@ jobs: if: steps.defaults.outputs.proceed == 'true' - n

[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533735419 ## File path: breeze ## @@ -2211,6 +2259,12 @@ function breeze::flag_local_file_mounting() { -l, --skip-mounting-local-sources Skips mounting loc

[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533737690 ## File path: scripts/in_container/entrypoint_ci.sh ## @@ -98,13 +101,51 @@ if [[ -z ${INSTALL_AIRFLOW_VERSION=} ]]; then mkdir -p "${AIRFLOW_SOURCES}

[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533774397 ## File path: scripts/in_container/entrypoint_ci.sh ## @@ -98,13 +101,51 @@ if [[ -z ${INSTALL_AIRFLOW_VERSION=} ]]; then mkdir -p "${AIRFLOW_SOURCES}

[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-01 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r533774989 ## File path: breeze ## @@ -2211,6 +2259,12 @@ function breeze::flag_local_file_mounting() { -l, --skip-mounting-local-sources Skips mounting loc

[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-06 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r537054053 ## File path: Dockerfile.ci ## @@ -330,8 +330,8 @@ RUN if [[ ${INSTALL_AIRFLOW_VIA_PIP} == "true" ]]; then \ # they are also installed additionally to wha

[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-06 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r537054443 ## File path: LOCAL_VIRTUALENV.rst ## @@ -163,6 +163,31 @@ Activate your virtualenv, e.g. by using ``workon``, and once you are in it, run: cd airflo

[GitHub] [airflow] ashb commented on a change in pull request #12685: Production images on CI are now built from packages

2020-12-06 Thread GitBox
ashb commented on a change in pull request #12685: URL: https://github.com/apache/airflow/pull/12685#discussion_r537055160 ## File path: breeze ## @@ -1473,6 +1477,10 @@ function breeze::prepare_formatted_versions() { tr ',' ' ' | fold -w "${indented_screen_width}" -s