[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847420061 ## airflow/models/dagrun.py: ## @@ -838,14 +838,24 @@ def verify_integrity(self, session: Session = NEW_SESSION): ti.state = State.REMOVED

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847446426 ## airflow/models/dagrun.py: ## @@ -838,14 +838,24 @@ def verify_integrity(self, session: Session = NEW_SESSION): ti.state = State.REMOVED

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847645333 ## airflow/serialization/serialized_objects.py: ## @@ -1081,12 +1081,12 @@ def deserialize_dag(cls, encoded_dag: Dict[str, Any]) -> 'SerializedDAG': set

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847653426 ## airflow/serialization/serialized_objects.py: ## @@ -1081,12 +1081,12 @@ def deserialize_dag(cls, encoded_dag: Dict[str, Any]) -> 'SerializedDAG': set

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847687365 ## airflow/decorators/base.py: ## @@ -406,6 +406,9 @@ class DecoratedMappedOperator(MappedOperator): # in partial_kwargs, and MappedOperator prevents duplication.

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847700088 ## airflow/models/mappedoperator.py: ## @@ -559,7 +562,12 @@ def _get_map_lengths(self, run_id: str, *, session: Session) -> Dict[str, int]: for task_id, length

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847715879 ## tests/models/test_dagrun.py: ## @@ -1036,14 +1036,17 @@ def test_mapped_mixed__literal_not_expanded_at_create(dag_maker, session): mapped = MockOperator.part

[GitHub] [airflow] ashb commented on a diff in pull request #22909: Fix bug where dynamically mapped tasks got set to REMOVED

2022-04-11 Thread GitBox
ashb commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847719456 ## tests/models/test_dagrun.py: ## @@ -1036,14 +1036,17 @@ def test_mapped_mixed__literal_not_expanded_at_create(dag_maker, session): mapped = MockOperator.part