[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module

2020-02-25 Thread GitBox
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591098934 https://github.com/apache/airflow/pull/7538 will I think solve my issue/brain fart.

[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module

2020-02-25 Thread GitBox
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591096260 It's probably fine as it is. Def not worth changing all the files again anyway.

[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module

2020-02-25 Thread GitBox
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591091381 :man_facepalming: oh yeah. Sorry, long day. This is an

[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module

2020-02-25 Thread GitBox
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591084955 (excuse the grump, but this change, and the pre commit rule we put in place meant I had to work around it have code live

[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module

2020-02-25 Thread GitBox
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591081255 Why did we make this change? Neither the PR nor the linked Jira give _any_ justification for the change. It doesn't