[GitHub] [airflow] ashb commented on pull request #14878: Make app creation session- or class-wide when possible to make tests faster

2021-04-01 Thread GitBox
ashb commented on pull request #14878: URL: https://github.com/apache/airflow/pull/14878#issuecomment-811996652 > Edit: Actually I think those are already included in this one? Whoops, so they are! -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [airflow] ashb commented on pull request #14878: Make app creation session- or class-wide when possible to make tests faster

2021-04-01 Thread GitBox
ashb commented on pull request #14878: URL: https://github.com/apache/airflow/pull/14878#issuecomment-811968760 Ran some tests, this PR as it stands made tests/cli/commands go from 4m30 down to 2m12. Nice! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ashb commented on pull request #14878: Make app creation session- or class-wide when possible to make tests faster

2021-04-01 Thread GitBox
ashb commented on pull request #14878: URL: https://github.com/apache/airflow/pull/14878#issuecomment-811968184 Don't know if we want to do it in this PR, but tests.cli.commands.test_role_command and test_user_command are slow and wuold likely benefit massively from fixtures too. -- Thi

[GitHub] [airflow] ashb commented on pull request #14878: Make app creation session- or class-wide when possible to make tests faster

2021-04-01 Thread GitBox
ashb commented on pull request #14878: URL: https://github.com/apache/airflow/pull/14878#issuecomment-811962565 @uranusjr Changes look okay -- do you have before and after numbers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [airflow] ashb commented on pull request #14878: Make app creation session- or class-wide when possible to make tests faster

2021-03-19 Thread GitBox
ashb commented on pull request #14878: URL: https://github.com/apache/airflow/pull/14878#issuecomment-803148129 Closing and re-opening to trigger full CI rebuild. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR