[GitHub] [airflow] ashb commented on pull request #28773: pre-commit check for xfail in unit tests

2023-01-11 Thread GitBox
ashb commented on PR #28773: URL: https://github.com/apache/airflow/pull/28773#issuecomment-1378603645 Oh yeah I'm cool with "don't use XFail for flaky tests" etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [airflow] ashb commented on pull request #28773: pre-commit check for xfail in unit tests

2023-01-10 Thread GitBox
ashb commented on PR #28773: URL: https://github.com/apache/airflow/pull/28773#issuecomment-133398 This is a -0.99 from me. XFail exists for a reason, we can discourage it's use without needing to remove it. -- This is an automated message from the Apache Git Service. To respond to th