ashb opened a new pull request #11732:
URL: https://github.com/apache/airflow/pull/11732


   It was possible to "block" the scheduler such that it would not schedule or 
queue tasks for a dag if you triggered a DAG run when the DAG was already at 
the max active runs.
   
   This approach works around the problem for now, but a better longer term fix 
for this would be to introduce a "queued" state for DagRuns, and then when 
manually creating dag runs (or clearing) set it to queued, and only have the 
scheduler set DagRuns to running, nothing else -- this would mean we wouldn't 
need to examine active runs in the TI part of the scheduler loop, only in 
DagRun creation part.
   
   Fixes #11582.
   
   (Depends on/will conflict with #11730, so already based on that commit. 
Please ignore first commit when reviewing)
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to