astahlman opened a new pull request #4973: [AIRFLOW-4155] Allow Public role 
access to /home
URL: https://github.com/apache/airflow/pull/4973
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ X ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4155
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ X ] Here are some details about my PR, including screenshots of any UI 
changes:
   
       Problem: After a user registers in the PUBLIC_AUTH_ROLE they are
       redirected to /home. But a user in the Public role still doesn't have
       view privileges on /home, so they are immediately
       redirected *back* to the /login page, which creates an endless redirect
       cycle.
   
       This PR change grants the Public role view access to the index page.
       Because the Public user doesn't have any other read permission, they
       won't see any DAGs.
   
       If the user is not logged in, we add a banner at the top of the page
       with a link to the login page. If the user is logged in but belongs only
       to the Public role, then the banner displays a message warning the user
       that they don't have sufficient privileges to view the DAGs.
   
   #### Before logging in 
   ![Screen Shot 2019-03-25 at 9 38 05 
AM](https://user-images.githubusercontent.com/1173394/54939277-675aec00-4ee5-11e9-8dda-0526e5fe0d18.png)
   
   #### After logging in as user in Public role
   ![Screen Shot 2019-03-25 at 9 38 30 
AM](https://user-images.githubusercontent.com/1173394/54939275-64f89200-4ee5-11e9-9e6c-347814b33ac6.png)
   
   
   ### Tests
   
   - [ X ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ X ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to