[GitHub] [airflow] davidavdav commented on a change in pull request #19683: In DAG dependency detector, use class type instead of class name, related #19582

Thu, 18 Nov 2021 10:52:19 -0800 


davidavdav commented on a change in pull request #19683:
URL: https://github.com/apache/airflow/pull/19683#discussion_r752533080



##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -444,14 +446,14 @@ class DependencyDetector:
     @staticmethod
     def detect_task_dependencies(task: BaseOperator) -> 
Optional['DagDependency']:
         """Detects dependencies caused by tasks"""
-        if task.task_type == "TriggerDagRunOperator":
+        if isinstance(task, TriggerDagRunOperator):

Review comment:
       Sure I'll look into how tests work in airflow, and add one, I suppose, 
for testing that both `TriggerDagRunOperator` and inherited classes give the 
expected result. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to