[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-21 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-974851460 > @dstandish anything else I need to do to shepherd this guy through? I will make sure to review monday. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-21 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-974851460 > @dstandish anything else I need to do to shepherd this guy through? I will make sure to review monday. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-11 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-966544379 > I have rebased. I am sure someone somewhere out there wants that use case; however, the deprecation is going to be ugly no matter how or when you do it since this attribut

[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-08 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-963563477 also @fredthomsen looks like this needs a rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-08 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-963563214 thanks @fredthomsen yeah the reason i ask is because deprecations seem kindof ugly in helm and i figure, if we think we'll ultimately need `path` to be part of the `host`

[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-03 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-960239070 Hi @fredthomsen Can you help me understand the use case for configuring multiple hosts? I noticed that we apply the same path to all hosts. But from looking at

[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-03 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-960239070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-03 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-960239070 Hi @fredthomsen Can you help me understand the use case for configuring multiple hosts? I noticed that we apply the same path to all hosts. But from looking at