[GitHub] [airflow] dstandish commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-15 Thread GitBox
dstandish commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-969428515 this is not airflow code. i can repro the exception of course, when i try to access a secret that i don't have access to. but my point is, airflow does not search

[GitHub] [airflow] dstandish commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-15 Thread GitBox
dstandish commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-969387824 > Maybe so, but even without the above export, when secrets manager backend is set, and a condition or resource constraint is applied, Airflow will fail to start with

[GitHub] [airflow] dstandish commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-15 Thread GitBox
dstandish commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-969377230 > The fundamental way that a secrets backend works is to try all connections, variables, and configurations there first and, if it returns None, try the OS environment

[GitHub] [airflow] dstandish commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-14 Thread GitBox
dstandish commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-968316195 > The boto3 secrets manager library will fail with ResourceNotFoundException if there are no restrictions in the IAM role, i.e. it has full access to secrets manager. That

[GitHub] [airflow] dstandish commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-12 Thread GitBox
dstandish commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-967546660 > this is already implemented in the gcp secret_manager -> > >

[GitHub] [airflow] dstandish commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-10-29 Thread GitBox
dstandish commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-955146602 > Today, this causes a failure with the Scheduler as an uncaught exception What do you mean with the scheduler? Most commonly one retrieves a connection from a