ecerulm commented on PR #29016:
URL: https://github.com/apache/airflow/pull/29016#issuecomment-1416010163
Is there anything else that I can do? I just wonder if I need to do anything
else before you merge it?
--
This is an automated message from the Apache Git Service.
To respond to the m
ecerulm commented on PR #29016:
URL: https://github.com/apache/airflow/pull/29016#issuecomment-1415206145
I had to fix some formatting issues and some stuff from the rebase from main
but now "all checks have passed".
--
This is an automated message from the Apache Git Service.
To respond
ecerulm commented on PR #29016:
URL: https://github.com/apache/airflow/pull/29016#issuecomment-1413772510
Nevermind, I realized now that the `ConvertableToDict` approach does not
work on Python 3.7 (as `typing.Protocol` was introduced in 3.8). So I guess
I'll try your try-import approach
ecerulm commented on PR #29016:
URL: https://github.com/apache/airflow/pull/29016#issuecomment-1387133006
I had to introduce a `ConvertableToDict` abstract base class , in order to
keep the `mypy` happy since `k8s.V1EnvVar` is not a dict. Initially I used
`hasattr(item, "to_dict") but mypy
