epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1146479644
@josh-fell cool I went with option one & it's passing now 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1142979885
@josh-fell I was able to resolve the unit test failures locally by updating
the value of `dbt_cloud_conn_id` to `dbt_cloud` (the name of my connection
locally). Should I push those c
epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1135339271
@josh-fell okay changes pushed 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1133584143
@josh-fell Yep, totally follow. I removed the arg from the Operator. Do you
have an opinion whether the tenant should be stored in the connection as the
schema or as an extra?
--
T
epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1126275702
@josh-fell It is not possible that a single API key could access a single
tenant instance + a multi-tenant instance. Each instance will require its own
API key
--
This is an automa
epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1124489662
@josh-fell Added tenant as an option to the Airflow connection. Let me know
what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1121446279
@josh-fell one API key for one single tenant instance. A large customer may
have multiple single tenant instances. Considering that, do you think it would
be best to have the single t
epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1120075557
@sungchun12 Added to the PR. Please let me know if you'd like any others :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epapineau commented on PR #22938:
URL: https://github.com/apache/airflow/pull/22938#issuecomment-1118752737
Hello~ Following up to see if this needs anything else for review? 🥲
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
