[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1092263564 ## docs/apache-airflow/howto/usage-cli.rst: ## @@ -217,6 +217,17 @@ You can use the ``--dry-run`` option to print the row counts in the primary tabl By defau

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1092132580 ## airflow/utils/db_cleanup.py: ## @@ -123,6 +127,15 @@ def _check_for_rows(*, query: Query, print_rows=False): return num_entities +def _dump_table_to_

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-31 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1092120446 ## docs/apache-airflow/howto/usage-cli.rst: ## @@ -217,6 +217,17 @@ You can use the ``--dry-run`` option to print the row counts in the primary tabl By defau

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-30 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1091027961 ## airflow/utils/db_cleanup.py: ## @@ -370,3 +383,19 @@ def run_cleanup( session=session, ) session.commit() + + +@pro

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-30 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1090342753 ## airflow/cli/commands/db_command.py: ## @@ -207,3 +207,14 @@ def cleanup_tables(args): confirm=not args.yes, skip_archive=args.skip_archive,

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-30 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1090338640 ## airflow/utils/db_cleanup.py: ## @@ -123,6 +126,15 @@ def _check_for_rows(*, query: Query, print_rows=False): return num_entities +def _dump_db(*, tar

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-29 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1089948584 ## airflow/utils/db_cleanup.py: ## @@ -370,3 +382,19 @@ def run_cleanup( session=session, ) session.commit() + + +@pro

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-27 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1089067018 ## airflow/cli/cli_parser.py: ## @@ -468,7 +468,17 @@ def string_lower_type(val): help="Don't preserve purged records in an archive table.", action="st

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Add command to export purged records to CSV files

2023-01-27 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1088928444 ## airflow/utils/db_cleanup.py: ## @@ -159,6 +170,14 @@ def _do_delete(*, query, orm_model, skip_archive, session): logger.debug("delete statement:\n%s", de