ephraimbuddy commented on code in PR #29248:
URL: https://github.com/apache/airflow/pull/29248#discussion_r1092200171


##########
chart/RELEASE_NOTES.rst:
##########
@@ -23,15 +23,116 @@ Run ``helm repo update`` before upgrading the chart to the 
latest version.
 
 .. towncrier release notes start
 
+Airflow Helm Chart 1.8.0 (2023-02-02)
+-------------------------------------
+
+Significant Changes
+^^^^^^^^^^^^^^^^^^^
+
+``bitnami/postgresql`` subchart updated to ``12.1.9`` (#29071)
+""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+The version of postgresql installed is still version 11.
+
+If you are upgrading an existing helm release with the built-in postgres 
database, you will either need to delete your release and reinstall fresh, or 
manually delete these 2 objects:
+
+```
+kubectl delete secret {RELEASE_NAME}-postgresql
+kubectl delete statefulset {RELEASE_NAME}-postgresql
+```
+
+As a reminder, it is recommended to `set up an external database 
<https://airflow.apache.org/docs/helm-chart/stable/production-guide.html#database>`_
 in production.
+
+This version of the chart uses different variable names for setting usernames 
and passwords in the postgres database.
+
+- ``postgresql.auth.enablePostgresUser`` is used to determine if the 
"postgres" admin account will be created.
+- ``postgresql.auth.postgresPassword`` sets the password for the "postgres" 
user.
+- ``postgresql.auth.username`` and ``postrgesql.auth.password`` are used to 
set credentials for a non-admin account if desired.
+- ``postgresql.postgresqlUsername`` and ``postgresql.postresqlPassword``, 
which were used in the previous version of the chart, are no longer used.
+
+Users will need to make those changes in their values files if they are 
changing the Postgres configuration.
+
+Previously the subchart version was ``10.5.3``.
+
+Default ``dags.gitSync.wait`` reduced to ``5`` seconds (#27625)
+"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+The default for ``dags.gitSync.wait`` has been reduced from ``60`` seconds to 
``5`` seconds to reduce the likelihood of DAGs
+becoming inconsistent between Airflow components. This will, however, increase 
traffic to the remote git repository.
+
+Default Airflow image is updated to ``2.5.1`` (#29074)
+""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+The default Airflow image that is used with the Chart is now ``2.5.1``, 
previously it was ``2.4.1``.
+
+Default git-sync image is updated to ``3.6.3`` (#27848)
+"""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+The default git-sync image that is used with the Chart is now ``3.6.3``, 
previously it was ``3.4.0``.
+
+Default redis image is updated to ``7-bullseye`` (#27443)
+"""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+The default redis image that is used with the Chart is now ``7-bullseye``, 
previously it was ``6-bullseye``.
+
+New Features
+^^^^^^^^^^^^
+
+- Add annotations on deployments (#28688)
+- Add global volume & volumeMounts to the chart (#27781)
+
+Improvements
+^^^^^^^^^^^^
+
+- Add support for ``webserverConfigConfigMapName`` (#27419)
+- Enhance chart to allow over-riding command-line args to statsd exporter 
(#28041)

Review Comment:
   ```suggestion
   - Enhance chart to allow overriding command-line args to statsd exporter 
(#28041)
   ```



##########
chart/Chart.yaml:
##########
@@ -67,187 +67,143 @@ annotations:
     - title: Task Instance Context Menu
       url: 
https://airflow.apache.org/docs/apache-airflow/2.5.1/_images/context.png
   artifacthub.io/changes: |
-    - description: Make cleanup job history configurable
+    - description: Add annotations on deployments
       kind: added
       links:
-      - name: '#26838'
-        url: https://github.com/apache/airflow/pull/26838
-    - description: Added labels to specific Airflow components
+      - name: '#28688'
+        url: https://github.com/apache/airflow/pull/28688
+    - description: Add global volume & volumeMounts to the chart
       kind: added
       links:
-      - name: '#25031'
-        url: https://github.com/apache/airflow/pull/25031
-    - description: Add StatsD ``overrideMappings`` in Helm chart values
-      kind: added
-      links:
-      - name: '#26598'
-        url: https://github.com/apache/airflow/pull/26598
-    - description: Adding ``podAnnotations`` to StatsD deployment template
-      kind: added
-      links:
-      - name: '#25732'
-        url: https://github.com/apache/airflow/pull/25732
-    - description: Container specific extra environment variables
-      kind: added
-      links:
-      - name: '#24784'
-        url: https://github.com/apache/airflow/pull/24784
-    - description: Custom labels for extrasecrets/configmaps
-      kind: added
-      links:
-      - name: '#25283'
-        url: https://github.com/apache/airflow/pull/25283
-    - description: Add ``revisionHistoryLimit`` to all deployments
-      kind: added
-      links:
-      - name: '#25059'
-        url: https://github.com/apache/airflow/pull/25059
-    - description: Adding ``podAnnotations`` to Redis StatefulSet
-      kind: added
-      links:
-      - name: '#23708'
-        url: https://github.com/apache/airflow/pull/23708
-    - description: Provision Standalone Dag Processor
-      kind: added
-      links:
-      - name: '#23711'
-        url: https://github.com/apache/airflow/pull/23711
-    - description: Add configurable scheme for webserver probes
-      kind: added
+      - name: '#27781'
+        url: https://github.com/apache/airflow/pull/27781
+    - description: Add support for ``webserverConfigConfigMapName``
+      kind: changed
       links:
-      - name: '#22815'
-        url: https://github.com/apache/airflow/pull/22815
-    - description: Add support for KEDA HPA config to Helm chart
-      kind: added
+      - name: '#27419'
+        url: https://github.com/apache/airflow/pull/27419
+    - description: Enhance chart to allow over-riding command-line args to 
statsd exporter

Review Comment:
   ```suggestion
       - description: Enhance chart to allow overriding command-line args to 
statsd exporter
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to