ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400675244
> Feel free to merge if you think it's GOOD and useful :).
Been thinking about the useful side of it :) let @jedcunningham decide
--
This is an automated message from the
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400284160
Previously, some of the commands used to check out branches were being
executed in the CI. However, because this change was not in the checked-out
branch, the codes could not be fo
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1399875924
> I think you might wan to re-install breeze (via the composite action we
use elsewhere) just before "Fix ownership" job. This should fix the last
problem @ephraimbuddy
Re-i
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1386921743
> Please fix those - and if it still does not help - I might take a closer
look.
On it. Thanks
--
This is an automated message from the Apache Git Service.
To respond to t
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1386750234
Hi @potiuk, It seems like there's something wrong with the breeze build on
this PR. For example, here:
https://github.com/apache/airflow/actions/runs/3947115412/jobs/6755756155#ste
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1346094951
> Which pre-commit ? This does not seem like it is run in image (it would be
/opt/airflow path then). Each pre-commit has their own dependencies and you
need to make sure they are
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1345934132
> cc: @ephraimbuddy
Thanks. Have updated it. It seems like `inputimeout` is not installed in the
image because it errors out during pre-commit run:
```
File
"/Users/ep
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1338728668
> I think you need to rebase @ephraimbuddy :)
Seems there's something I did wrong because the build info has always failed
recently after each rebase. Any ideas?
--
This i
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1327111335
I added a new function `user_confirm_bools` that returns a bool using
`user_confirm` under the hood. This helped me reduce a lot of `if else`
statements.
Also added `console_pr
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1323934130
Nice. Thanks once more!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1323886749
@potiuk, Concerning running this on the CI with `dry_option` and `--answer
yes`, I think we should not. It looks risky and doesn't seem to give us
information on whether the comman
ephraimbuddy commented on PR #27829:
URL: https://github.com/apache/airflow/pull/27829#issuecomment-1323635269
> @ephraimbuddy - the "prepare-provider-documenation" step is added here
#27832 - let's see if it works fine. `ANSWER="yes"` is passed from the job
environments (see the top of the
12 matches
Mail list logo
